@wordpress/block-library 9.26.0 → 9.27.0

package/src/navigation-link/update-attributes.js

@@ -2,7 +2,89 @@
  * WordPress dependencies
  */
 import { escapeHTML } from '@wordpress/escape-html';
-import { safeDecodeURI } from '@wordpress/url';
+import { safeDecodeURI, getPath } from '@wordpress/url';
+
+/**
+ * Determines if an entity link should be severed based on URL changes.
+ *
+ * @param {string} originalUrl - The original URL
+ * @param {string} newUrl      - The new URL
+ * @return {boolean} True if the entity link should be severed
+ */
+const shouldSeverEntityLink = ( originalUrl, newUrl ) => {
+	if ( ! originalUrl || ! newUrl ) {
+		return false;
+	}
+
+	const normalizePath = ( path ) => {
+		if ( ! path ) {
+			return '';
+		}
+		return path.replace( /\/+$/, '' ); // Remove trailing slashes
+	};
+
+	// Helper function to create URL objects with proper base handling
+	const createUrlObject = ( url, baseUrl = null ) => {
+		try {
+			// Always provide a base URL - it will be ignored for absolute URLs
+			// Use window.location.origin in browser, fallback for Node/tests
+			const base =
+				baseUrl ||
+				( typeof window !== 'undefined'
+					? window.location.origin
+					: 'https://wordpress.org' );
+			return new URL( url, base );
+		} catch ( error ) {
+			// If URL construction still fails, it's likely an invalid URL
+			// and we should sever the entity link
+			return null;
+		}
+	};
+
+	const originalUrlObj = createUrlObject( originalUrl );
+	if ( ! originalUrlObj ) {
+		return true;
+	}
+
+	const newUrlObj = createUrlObject( newUrl, originalUrl );
+	if ( ! newUrlObj ) {
+		return true;
+	}
+
+	// Move these declarations here, after the null checks
+	const originalHostname = originalUrlObj.hostname;
+	const newHostname = newUrlObj.hostname;
+	const originalPath = normalizePath( getPath( originalUrlObj.toString() ) );
+	const newPath = normalizePath( getPath( newUrlObj.toString() ) );
+
+	// If hostname or path changed, sever the entity link
+	if ( originalHostname !== newHostname || originalPath !== newPath ) {
+		return true;
+	}
+
+	// Special handling for plain permalinks (query string post IDs)
+	const originalP = originalUrlObj.searchParams.get( 'p' );
+	const newP = newUrlObj.searchParams.get( 'p' );
+
+	// If both are plain permalinks (with ?p= or ?page_id=), compare the IDs
+	if ( originalP && newP && originalP !== newP ) {
+		return true;
+	}
+
+	const originalPageId = originalUrlObj.searchParams.get( 'page_id' );
+	const newPageId = newUrlObj.searchParams.get( 'page_id' );
+
+	if ( originalPageId && newPageId && originalPageId !== newPageId ) {
+		return true;
+	}
+	// If switching between ?p= and ?page_id=, or one is missing, sever
+	if ( ( originalP && newPageId ) || ( originalPageId && newP ) ) {
+		return true;
+	}
+
+	// If only query string or fragment changed, preserve the entity link
+	return false;
+};
 
 /**
  * @typedef {'post-type'|'custom'|'taxonomy'|'post-type-archive'} WPNavigationLinkKind
@@ -42,19 +124,23 @@ export const updateAttributes = (
 
 	const {
 		title: newLabel = '', // the title of any provided Post.
-		url: newUrl = '',
+		label: newLabelFromLabel = '', // alternative to title
+		url: newUrl,
 		opensInNewTab,
-		id,
+		id: newID,
 		kind: newKind = originalKind,
 		type: newType = originalType,
 	} = updatedValue;
 
-	const newLabelWithoutHttp = newLabel.replace( /http(s?):\/\//gi, '' );
-	const newUrlWithoutHttp = newUrl.replace( /http(s?):\/\//gi, '' );
+	// Use title if provided, otherwise fall back to label
+	const finalNewLabel = newLabel || newLabelFromLabel;
+
+	const newLabelWithoutHttp = finalNewLabel.replace( /http(s?):\/\//gi, '' );
+	const newUrlWithoutHttp = newUrl?.replace( /http(s?):\/\//gi, '' ) ?? '';
 
 	const useNewLabel =
-		newLabel &&
-		newLabel !== originalLabel &&
+		finalNewLabel &&
+		finalNewLabel !== originalLabel &&
 		// LinkControl without the title field relies
 		// on the check below. Specifically, it assumes that
 		// the URL is the same as a title.
@@ -73,7 +159,7 @@ export const updateAttributes = (
 	// - https://github.com/WordPress/gutenberg/pull/41063
 	// - https://github.com/WordPress/gutenberg/pull/18617.
 	const label = useNewLabel
-		? escapeHTML( newLabel )
+		? escapeHTML( finalNewLabel )
 		: originalLabel || escapeHTML( newUrlWithoutHttp );
 
 	// In https://github.com/WordPress/gutenberg/pull/24670 we decided to use "tag" in favor of "post_tag"
@@ -86,13 +172,40 @@ export const updateAttributes = (
 		( ! newKind && ! isBuiltInType ) || newKind === 'custom';
 	const kind = isCustomLink ? 'custom' : newKind;
 
-	setAttributes( {
+	const attributes = {
 		// Passed `url` may already be encoded. To prevent double encoding, decodeURI is executed to revert to the original string.
-		...( newUrl && { url: encodeURI( safeDecodeURI( newUrl ) ) } ),
+		...( newUrl !== undefined
+			? { url: newUrl ? encodeURI( safeDecodeURI( newUrl ) ) : newUrl }
+			: {} ),
 		...( label && { label } ),
 		...( undefined !== opensInNewTab && { opensInNewTab } ),
-		...( id && Number.isInteger( id ) && { id } ),
 		...( kind && { kind } ),
 		...( type && type !== 'URL' && { type } ),
-	} );
+	};
+
+	// If the block's id is set then the menu item is linking to an entity.
+	// Therefore, if the URL is set but a new ID is not provided, check if
+	// the entity link should be severed based on URL changes.
+	if ( newUrl && ! newID && blockAttributes.id ) {
+		const shouldSever = shouldSeverEntityLink(
+			blockAttributes.url,
+			newUrl
+		);
+
+		if ( shouldSever ) {
+			attributes.id = undefined; // explicitly "unset" the ID.
+			// When URL is manually changed in a way that severs the entity link,
+			// update kind and type to "custom" to indicate this is now a custom link.
+			attributes.kind = 'custom';
+			attributes.type = 'custom';
+		}
+	} else if ( newID && Number.isInteger( newID ) ) {
+		attributes.id = newID;
+	} else if ( blockAttributes.id ) {
+		// If we have an existing ID and no URL change, ensure kind and type are preserved
+		attributes.kind = kind;
+		attributes.type = type;
+	}
+
+	setAttributes( attributes );
 };

package/src/navigation-submenu/edit.js

@@ -8,6 +8,7 @@ import clsx from 'clsx';
  */
 import { useSelect, useDispatch } from '@wordpress/data';
 import {
+	CheckboxControl,
 	TextControl,
 	TextareaControl,
 	ToolbarButton,
@@ -134,7 +135,7 @@ export default function NavigationSubmenuEdit( {
 	context,
 	clientId,
 } ) {
-	const { label, url, description, rel } = attributes;
+	const { label, url, description, rel, opensInNewTab } = attributes;
 
 	const { showSubmenuIcon, maxNestingLevel, openSubmenusOnClick } = context;
 
@@ -392,6 +393,7 @@ export default function NavigationSubmenuEdit( {
 							url: '',
 							description: '',
 							rel: '',
+							opensInNewTab: false,
 						} );
 					} }
 					dropdownMenuProps={ dropdownMenuProps }
@@ -433,6 +435,24 @@ export default function NavigationSubmenuEdit( {
 						/>
 					</ToolsPanelItem>
 
+					<ToolsPanelItem
+						hasValue={ () => !! opensInNewTab }
+						label={ __( 'Open in new tab' ) }
+						onDeselect={ () =>
+							setAttributes( { opensInNewTab: false } )
+						}
+						isShownByDefault
+					>
+						<CheckboxControl
+							__nextHasNoMarginBottom
+							label={ __( 'Open in new tab' ) }
+							checked={ opensInNewTab }
+							onChange={ ( value ) =>
+								setAttributes( { opensInNewTab: value } )
+							}
+						/>
+					</ToolsPanelItem>
+
 					<ToolsPanelItem
 						label={ __( 'Description' ) }
 						isShownByDefault

package/src/post-author/edit.js

@@ -20,8 +20,11 @@ import {
 	__experimentalToolsPanel as ToolsPanel,
 	__experimentalToolsPanelItem as ToolsPanelItem,
 } from '@wordpress/components';
+import { debounce } from '@wordpress/compose';
+import { useMemo, useState } from '@wordpress/element';
 import { useSelect, useDispatch } from '@wordpress/data';
 import { __, sprintf } from '@wordpress/i18n';
+import { decodeEntities } from '@wordpress/html-entities';
 import { store as coreStore } from '@wordpress/core-data';
 
 /**
@@ -29,13 +32,81 @@ import { store as coreStore } from '@wordpress/core-data';
  */
 import { useToolsPanelDropdownMenuProps } from '../utils/hooks';
 
-const minimumUsersForCombobox = 25;
-
 const AUTHORS_QUERY = {
 	who: 'authors',
 	per_page: 100,
+	_fields: 'id,name',
+	context: 'view',
 };
 
+function AuthorCombobox( { value, onChange } ) {
+	const [ filterValue, setFilterValue ] = useState( '' );
+	const { authors, isLoading } = useSelect(
+		( select ) => {
+			const { getUsers, isResolving } = select( coreStore );
+
+			const query = { ...AUTHORS_QUERY };
+			if ( filterValue ) {
+				query.search = filterValue;
+				query.search_columns = [ 'name' ];
+			}
+
+			return {
+				authors: getUsers( query ),
+				isLoading: isResolving( 'getUsers', [ query ] ),
+			};
+		},
+		[ filterValue ]
+	);
+
+	const authorOptions = useMemo( () => {
+		const fetchedAuthors = ( authors ?? [] ).map( ( author ) => {
+			return {
+				value: author.id,
+				label: decodeEntities( author.name ),
+			};
+		} );
+
+		// Ensure the current author is included in the list.
+		const foundAuthor = fetchedAuthors.findIndex(
+			( fetchedAuthor ) => value?.id === fetchedAuthor.value
+		);
+
+		let currentAuthor = [];
+		if ( foundAuthor < 0 && value ) {
+			currentAuthor = [
+				{
+					value: value.id,
+					label: decodeEntities( value.name ),
+				},
+			];
+		} else if ( foundAuthor < 0 && ! value ) {
+			currentAuthor = [
+				{
+					value: 0,
+					label: __( '(No author)' ),
+				},
+			];
+		}
+
+		return [ ...currentAuthor, ...fetchedAuthors ];
+	}, [ authors, value ] );
+
+	return (
+		<ComboboxControl
+			__next40pxDefaultSize
+			__nextHasNoMarginBottom
+			label={ __( 'Author' ) }
+			options={ authorOptions }
+			value={ value?.id }
+			onFilterValueChange={ debounce( setFilterValue, 300 ) }
+			onChange={ onChange }
+			allowReset={ false }
+			isLoading={ isLoading }
+		/>
+	);
+}
+
 function PostAuthorEdit( {
 	isSelected,
 	context: { postType, postId, queryId },
@@ -45,22 +116,28 @@ function PostAuthorEdit( {
 	const isDescendentOfQueryLoop = Number.isFinite( queryId );
 	const dropdownMenuProps = useToolsPanelDropdownMenuProps();
 
-	const { authorId, authorDetails, authors, supportsAuthor } = useSelect(
+	const { authorDetails, canAssignAuthor, supportsAuthor } = useSelect(
 		( select ) => {
-			const { getEditedEntityRecord, getUser, getUsers, getPostType } =
+			const { getEditedEntityRecord, getUser, getPostType } =
 				select( coreStore );
-			const _authorId = getEditedEntityRecord(
+			const currentPost = getEditedEntityRecord(
 				'postType',
 				postType,
 				postId
-			)?.author;
+			);
+			const authorId = currentPost?.author;
 
 			return {
-				authorId: _authorId,
-				authorDetails: _authorId ? getUser( _authorId ) : null,
-				authors: getUsers( AUTHORS_QUERY ),
+				authorDetails: authorId
+					? getUser( authorId, { context: 'view' } )
+					: null,
 				supportsAuthor:
 					getPostType( postType )?.supports?.author ?? false,
+				canAssignAuthor: currentPost?._links?.[
+					'wp:action-assign-author'
+				]
+					? true
+					: false,
 			};
 		},
 		[ postType, postId ]
@@ -94,24 +171,14 @@ function PostAuthorEdit( {
 		} ),
 	} );
 
-	const authorOptions = authors?.length
-		? authors.map( ( { id, name } ) => {
-				return {
-					value: id,
-					label: name,
-				};
-		  } )
-		: [];
-
 	const handleSelect = ( nextAuthorId ) => {
 		editEntityRecord( 'postType', postType, postId, {
 			author: nextAuthorId,
 		} );
 	};
 
-	const showCombobox = authorOptions.length >= minimumUsersForCombobox;
 	const showAuthorControl =
-		!! postId && ! isDescendentOfQueryLoop && authorOptions.length > 0;
+		!! postId && ! isDescendentOfQueryLoop && canAssignAuthor;
 
 	if ( ! supportsAuthor && postType !== undefined ) {
 		return (
@@ -142,26 +209,10 @@ function PostAuthorEdit( {
 				>
 					{ showAuthorControl && (
 						<div style={ { gridColumn: '1 / -1' } }>
-							{ ( showCombobox && (
-								<ComboboxControl
-									__next40pxDefaultSize
-									__nextHasNoMarginBottom
-									label={ __( 'Author' ) }
-									options={ authorOptions }
-									value={ authorId }
-									onChange={ handleSelect }
-									allowReset={ false }
-								/>
-							) ) || (
-								<SelectControl
-									__next40pxDefaultSize
-									__nextHasNoMarginBottom
-									label={ __( 'Author' ) }
-									value={ authorId }
-									options={ authorOptions }
-									onChange={ handleSelect }
-								/>
-							) }
+							<AuthorCombobox
+								value={ authorDetails }
+								onChange={ handleSelect }
+							/>
 						</div>
 					) }
 					<ToolsPanelItem

package/src/post-comments-form/form.js

@@ -106,7 +106,7 @@ const CommentsForm = ( { postId, postType } ) => {
 			return (
 				<Warning>
 					{ sprintf(
-						/* translators: 1: Post type (i.e. "post", "page") */
+						/* translators: %s: Post type (i.e. "post", "page") */
 						__(
 							'Post Comments Form block: Comments are not enabled for this post type (%s).'
 						),

package/src/post-content/block.json

@@ -7,6 +7,12 @@
 	"description": "Displays the contents of a post or page.",
 	"textdomain": "default",
 	"usesContext": [ "postId", "postType", "queryId" ],
+	"attributes": {
+		"tagName": {
+			"type": "string",
+			"default": "div"
+		}
+	},
 	"example": {
 		"viewportWidth": 350
 	},

package/src/post-content/edit.js

@@ -3,11 +3,13 @@
  */
 import { __ } from '@wordpress/i18n';
 import {
+	InspectorControls,
 	useBlockProps,
 	useInnerBlocksProps,
 	RecursionProvider,
 	useHasRecursion,
 	Warning,
+	privateApis as blockEditorPrivateApis,
 	__experimentalUseBlockPreview as useBlockPreview,
 } from '@wordpress/block-editor';
 import { parse } from '@wordpress/blocks';
@@ -23,6 +25,9 @@ import { useMemo } from '@wordpress/element';
  * Internal dependencies
  */
 import { useCanEditEntity } from '../utils/hooks';
+import { unlock } from '../lock-unlock';
+
+const { HTMLElementControl } = unlock( blockEditorPrivateApis );
 
 function ReadOnlyContent( {
 	parentLayout,
@@ -30,6 +35,7 @@ function ReadOnlyContent( {
 	userCanEdit,
 	postType,
 	postId,
+	tagName: TagName = 'div',
 } ) {
 	const [ , , content ] = useEntityProp(
 		'postType',
@@ -60,18 +66,18 @@ function ReadOnlyContent( {
 	}
 
 	return content?.protected ? (
-		<div { ...blockProps }>
+		<TagName { ...blockProps }>
 			<Warning>{ __( 'This content is password protected.' ) }</Warning>
-		</div>
+		</TagName>
 	) : (
-		<div
+		<TagName
 			{ ...blockProps }
 			dangerouslySetInnerHTML={ { __html: content?.rendered } }
-		></div>
+		></TagName>
 	);
 }
 
-function EditableContent( { context = {} } ) {
+function EditableContent( { context = {}, tagName: TagName = 'div' } ) {
 	const { postType, postId } = context;
 
 	const [ blocks, onInput, onChange ] = useEntityBlockEditor(
@@ -104,12 +110,15 @@ function EditableContent( { context = {} } ) {
 			template: ! hasInnerBlocks ? initialInnerBlocks : undefined,
 		}
 	);
-	return <div { ...props } />;
+	return <TagName { ...props } />;
 }
 
 function Content( props ) {
-	const { context: { queryId, postType, postId } = {}, layoutClassNames } =
-		props;
+	const {
+		context: { queryId, postType, postId } = {},
+		layoutClassNames,
+		tagName,
+	} = props;
 	const userCanEdit = useCanEditEntity( 'postType', postType, postId );
 	if ( userCanEdit === undefined ) {
 		return null;
@@ -127,6 +136,7 @@ function Content( props ) {
 			userCanEdit={ userCanEdit }
 			postType={ postType }
 			postId={ postId }
+			tagName={ tagName }
 		/>
 	);
 }
@@ -165,8 +175,39 @@ function RecursionError() {
 	);
 }
 
+/**
+ * Render inspector controls for the PostContent block.
+ *
+ * @param {Object}   props                 Component props.
+ * @param {string}   props.tagName         The HTML tag name.
+ * @param {Function} props.onSelectTagName onChange function for the SelectControl.
+ * @param {string}   props.clientId        The client ID of the current block.
+ *
+ * @return {JSX.Element}                The control group.
+ */
+function PostContentEditControls( { tagName, onSelectTagName, clientId } ) {
+	return (
+		<InspectorControls group="advanced">
+			<HTMLElementControl
+				tagName={ tagName }
+				onChange={ onSelectTagName }
+				clientId={ clientId }
+				options={ [
+					{ label: __( 'Default (<div>)' ), value: 'div' },
+					{ label: '<main>', value: 'main' },
+					{ label: '<section>', value: 'section' },
+					{ label: '<article>', value: 'article' },
+				] }
+			/>
+		</InspectorControls>
+	);
+}
+
 export default function PostContentEdit( {
 	context,
+	attributes: { tagName = 'div' },
+	setAttributes,
+	clientId,
 	__unstableLayoutClassNames: layoutClassNames,
 	__unstableParentLayout: parentLayout,
 } ) {
@@ -177,17 +218,28 @@ export default function PostContentEdit( {
 		return <RecursionError />;
 	}
 
+	const handleSelectTagName = ( value ) => {
+		setAttributes( { tagName: value } );
+	};
+
 	return (
-		<RecursionProvider uniqueId={ contextPostId }>
-			{ contextPostId && contextPostType ? (
-				<Content
-					context={ context }
-					parentLayout={ parentLayout }
-					layoutClassNames={ layoutClassNames }
-				/>
-			) : (
-				<Placeholder layoutClassNames={ layoutClassNames } />
-			) }
-		</RecursionProvider>
+		<>
+			<PostContentEditControls
+				tagName={ tagName }
+				onSelectTagName={ handleSelectTagName }
+				clientId={ clientId }
+			/>
+			<RecursionProvider uniqueId={ contextPostId }>
+				{ contextPostId && contextPostType ? (
+					<Content
+						context={ context }
+						parentLayout={ parentLayout }
+						layoutClassNames={ layoutClassNames }
+					/>
+				) : (
+					<Placeholder layoutClassNames={ layoutClassNames } />
+				) }
+			</RecursionProvider>
+		</>
 	);
 }

package/src/post-content/index.php

@@ -54,12 +54,19 @@ function render_block_core_post_content( $attributes, $content, $block ) {
 		return '';
 	}
 
+	$tag_name = 'div';
+
+	if ( ! empty( $attributes['tagName'] ) && tag_escape( $attributes['tagName'] ) === $attributes['tagName'] ) {
+		$tag_name = $attributes['tagName'];
+	}
+
 	$wrapper_attributes = get_block_wrapper_attributes( array( 'class' => 'entry-content' ) );
 
-	return (
-		'<div ' . $wrapper_attributes . '>' .
-			$content .
-		'</div>'
+	return sprintf(
+		'<%1$s %2$s>%3$s</%1$s>',
+		$tag_name,
+		$wrapper_attributes,
+		$content
 	);
 }
 

package/src/post-featured-image/edit.js

@@ -248,6 +248,7 @@ export default function PostFeaturedImageEdit( {
 								isLink: false,
 								linkTarget: '_self',
 								rel: '',
+								sizeSlug: DEFAULT_MEDIA_SIZE_SLUG,
 							} );
 						} }
 						dropdownMenuProps={ dropdownMenuProps }

package/src/post-featured-image/index.php

@@ -27,8 +27,9 @@ function render_block_core_post_featured_image( $attributes, $content, $block )
 	$overlay_markup = get_block_core_post_featured_image_overlay_element_markup( $attributes );
 
 	if ( $is_link ) {
-		if ( get_the_title( $post_ID ) ) {
-			$attr['alt'] = trim( strip_tags( get_the_title( $post_ID ) ) );
+		$title = get_the_title( $post_ID );
+		if ( $title ) {
+			$attr['alt'] = trim( strip_tags( $title ) );
 		} else {
 			$attr['alt'] = sprintf(
 				// translators: %d is the post ID.

package/src/rss/index.php

@@ -46,7 +46,8 @@ function render_block_core_rss( $attributes ) {
 	}
 
 	foreach ( $rss_items as $item ) {
-		$title = esc_html( trim( strip_tags( $item->get_title() ) ) );
+		$title = esc_html( trim( strip_tags( html_entity_decode( $item->get_title() ) ) ) );
+
 		if ( empty( $title ) ) {
 			$title = __( '(no title)' );
 		}

package/src/search/edit.js

@@ -480,7 +480,7 @@ export default function SearchEdit( {
 											key={ widthValue }
 											value={ widthValue }
 											label={ sprintf(
-												/* translators: Percentage value. */
+												/* translators: %d: Percentage value. */
 												__( '%d%%' ),
 												widthValue
 											) }