@wordpress/block-library 8.31.0 → 8.33.0

package/build-style/theme.css

@@ -95,7 +95,7 @@
   color: rgba(255, 255, 255, 0.65);
 }
 
-.wp-block-audio {
+:where(.wp-block-audio) {
   margin: 0 0 1em 0;
 }
 
@@ -115,7 +115,7 @@
   color: rgba(255, 255, 255, 0.65);
 }
 
-.wp-block-embed {
+:where(.wp-block-embed) {
   margin: 0 0 1em 0;
 }
 
@@ -137,16 +137,17 @@
   color: rgba(255, 255, 255, 0.65);
 }
 
-.wp-block-image {
+:where(.wp-block-image) {
   margin: 0 0 1em 0;
 }
 
-.wp-block-pullquote {
+:where(.wp-block-pullquote) {
   border-top: 4px solid currentColor;
   border-bottom: 4px solid currentColor;
   margin-bottom: 1.75em;
   color: currentColor;
 }
+
 .wp-block-pullquote cite,
 .wp-block-pullquote footer, .wp-block-pullquote__citation {
   color: currentColor;
@@ -155,29 +156,29 @@
   font-style: normal;
 }
 
-.wp-block-quote {
+:where(.wp-block-quote) {
   border-left: 0.25em solid currentColor;
   margin: 0 0 1.75em 0;
   padding-left: 1em;
 }
-.wp-block-quote cite,
-.wp-block-quote footer {
+:where(.wp-block-quote) cite,
+:where(.wp-block-quote) footer {
   color: currentColor;
   font-size: 0.8125em;
   position: relative;
   font-style: normal;
 }
-.wp-block-quote.has-text-align-right {
+:where(.wp-block-quote).has-text-align-right {
   border-left: none;
   border-right: 0.25em solid currentColor;
   padding-left: 0;
   padding-right: 1em;
 }
-.wp-block-quote.has-text-align-center {
+:where(.wp-block-quote).has-text-align-center {
   border: none;
   padding-left: 0;
 }
-.wp-block-quote.is-style-plain, .wp-block-quote.is-style-large, .wp-block-quote.is-large {
+:where(.wp-block-quote).is-style-plain, :where(.wp-block-quote).is-style-large, :where(.wp-block-quote).is-large {
   border: none;
 }
 
@@ -218,9 +219,6 @@
   height: 2px;
 }
 
-.wp-block-table {
-  margin: 0 0 1em 0;
-}
 .wp-block-table td,
 .wp-block-table th {
   word-break: normal;
@@ -234,6 +232,10 @@
   color: rgba(255, 255, 255, 0.65);
 }
 
+:where(.wp-block-table) {
+  margin: 0 0 1em 0;
+}
+
 .wp-block-video figcaption {
   color: #555;
   font-size: 13px;
@@ -243,11 +245,11 @@
   color: rgba(255, 255, 255, 0.65);
 }
 
-.wp-block-video {
+:where(.wp-block-video) {
   margin: 0 0 1em 0;
 }
 
-.wp-block-template-part.has-background {
+:where(.wp-block-template-part).has-background {
   padding: 1.25em 2.375em;
   margin-top: 0;
   margin-bottom: 0;

package/build-style/video/theme-rtl.css

@@ -95,6 +95,6 @@
   color: rgba(255, 255, 255, 0.65);
 }
 
-.wp-block-video {
+:where(.wp-block-video) {
   margin: 0 0 1em 0;
 }

package/build-style/video/theme.css

@@ -95,6 +95,6 @@
   color: rgba(255, 255, 255, 0.65);
 }
 
-.wp-block-video {
+:where(.wp-block-video) {
   margin: 0 0 1em 0;
 }

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@wordpress/block-library",
-	"version": "8.31.0",
+	"version": "8.33.0",
 	"description": "Block library for the WordPress editor.",
 	"author": "The WordPress Contributors",
 	"license": "GPL-2.0-or-later",
@@ -31,38 +31,38 @@
 	],
 	"dependencies": {
 		"@babel/runtime": "^7.16.0",
-		"@wordpress/a11y": "^3.54.0",
-		"@wordpress/api-fetch": "^6.51.0",
-		"@wordpress/autop": "^3.54.0",
-		"@wordpress/blob": "^3.54.0",
-		"@wordpress/block-editor": "^12.22.0",
-		"@wordpress/blocks": "^12.31.0",
-		"@wordpress/components": "^27.2.0",
-		"@wordpress/compose": "^6.31.0",
-		"@wordpress/core-data": "^6.31.0",
-		"@wordpress/data": "^9.24.0",
-		"@wordpress/date": "^4.54.0",
-		"@wordpress/deprecated": "^3.54.0",
-		"@wordpress/dom": "^3.54.0",
-		"@wordpress/element": "^5.31.0",
-		"@wordpress/escape-html": "^2.54.0",
-		"@wordpress/hooks": "^3.54.0",
-		"@wordpress/html-entities": "^3.54.0",
-		"@wordpress/i18n": "^4.54.0",
-		"@wordpress/icons": "^9.45.0",
-		"@wordpress/interactivity": "^5.3.0",
-		"@wordpress/interactivity-router": "^1.4.0",
-		"@wordpress/keycodes": "^3.54.0",
-		"@wordpress/notices": "^4.22.0",
-		"@wordpress/patterns": "^1.15.0",
-		"@wordpress/primitives": "^3.52.0",
-		"@wordpress/private-apis": "^0.36.0",
-		"@wordpress/reusable-blocks": "^4.31.0",
-		"@wordpress/rich-text": "^6.31.0",
-		"@wordpress/server-side-render": "^4.31.0",
-		"@wordpress/url": "^3.55.0",
-		"@wordpress/viewport": "^5.31.0",
-		"@wordpress/wordcount": "^3.54.0",
+		"@wordpress/a11y": "^3.56.0",
+		"@wordpress/api-fetch": "^6.53.0",
+		"@wordpress/autop": "^3.56.0",
+		"@wordpress/blob": "^3.56.0",
+		"@wordpress/block-editor": "^12.24.0",
+		"@wordpress/blocks": "^12.33.0",
+		"@wordpress/components": "^27.4.0",
+		"@wordpress/compose": "^6.33.0",
+		"@wordpress/core-data": "^6.33.0",
+		"@wordpress/data": "^9.26.0",
+		"@wordpress/date": "^4.56.0",
+		"@wordpress/deprecated": "^3.56.0",
+		"@wordpress/dom": "^3.56.0",
+		"@wordpress/element": "^5.33.0",
+		"@wordpress/escape-html": "^2.56.0",
+		"@wordpress/hooks": "^3.56.0",
+		"@wordpress/html-entities": "^3.56.0",
+		"@wordpress/i18n": "^4.56.0",
+		"@wordpress/icons": "^9.47.0",
+		"@wordpress/interactivity": "^5.5.0",
+		"@wordpress/interactivity-router": "^1.6.0",
+		"@wordpress/keycodes": "^3.56.0",
+		"@wordpress/notices": "^4.24.0",
+		"@wordpress/patterns": "^1.17.0",
+		"@wordpress/primitives": "^3.54.0",
+		"@wordpress/private-apis": "^0.38.0",
+		"@wordpress/reusable-blocks": "^4.33.0",
+		"@wordpress/rich-text": "^6.33.0",
+		"@wordpress/server-side-render": "^4.33.0",
+		"@wordpress/url": "^3.57.0",
+		"@wordpress/viewport": "^5.33.0",
+		"@wordpress/wordcount": "^3.56.0",
 		"change-case": "^4.1.2",
 		"classnames": "^2.3.1",
 		"colord": "^2.7.0",
@@ -80,5 +80,5 @@
 	"publishConfig": {
 		"access": "public"
 	},
-	"gitHead": "ffc07735d0abfb3f69e91d48f25b7fe8d1ef92d2"
+	"gitHead": "280403b4c1cf6cc2c55a6c4d56f9ef91145e4191"
 }

package/src/audio/theme.scss

@@ -2,6 +2,6 @@
 	@include caption-style-theme();
 }
 
-.wp-block-audio {
+:where(.wp-block-audio) {
 	margin: 0 0 1em 0;
 }

package/src/avatar/index.php

@@ -62,7 +62,7 @@ function render_block_core_avatar( $attributes, $content, $block ) {
 			$label = '';
 			if ( '_blank' === $attributes['linkTarget'] ) {
 				// translators: %s is the Author name.
-				$label = 'aria-label="' . sprintf( esc_attr__( '(%s author archive, opens in a new tab)' ), $author_name ) . '"';
+				$label = 'aria-label="' . esc_attr( sprintf( __( '(%s author archive, opens in a new tab)' ), $author_name ) ) . '"';
 			}
 			// translators: %1$s: Author archive link. %2$s: Link target. %3$s Aria label. %4$s Avatar image.
 			$avatar_block = sprintf( '<a href="%1$s" target="%2$s" %3$s class="wp-block-avatar__link">%4$s</a>', esc_url( get_author_posts_url( $author_id ) ), esc_attr( $attributes['linkTarget'] ), $label, $avatar_block );
@@ -89,7 +89,7 @@ function render_block_core_avatar( $attributes, $content, $block ) {
 		$label = '';
 		if ( '_blank' === $attributes['linkTarget'] ) {
 			// translators: %s is the Comment Author name.
-			$label = 'aria-label="' . sprintf( esc_attr__( '(%s website link, opens in a new tab)' ), $comment->comment_author ) . '"';
+			$label = 'aria-label="' . esc_attr( sprintf( __( '(%s website link, opens in a new tab)' ), $comment->comment_author ) ) . '"';
 		}
 		// translators: %1$s: Comment Author website link. %2$s: Link target. %3$s Aria label. %4$s Avatar image.
 		$avatar_block = sprintf( '<a href="%1$s" target="%2$s" %3$s class="wp-block-avatar__link">%4$s</a>', esc_url( $comment->comment_author_url ), esc_attr( $attributes['linkTarget'] ), $label, $avatar_block );

package/src/block/edit.js

@@ -38,7 +38,7 @@ import { name as patternBlockName } from './index';
 import { unlock } from '../lock-unlock';
 
 const { useLayoutClasses } = unlock( blockEditorPrivateApis );
-const { PARTIAL_SYNCING_SUPPORTED_BLOCKS } = unlock( patternsPrivateApis );
+const { isOverridableBlock } = unlock( patternsPrivateApis );
 
 const fullAlignments = [ 'full', 'wide', 'left', 'right' ];
 
@@ -90,21 +90,9 @@ const useInferredLayout = ( blocks, parentLayout ) => {
 	}, [ blocks, parentLayout ] );
 };
 
-function hasOverridableAttributes( block ) {
-	return (
-		Object.keys( PARTIAL_SYNCING_SUPPORTED_BLOCKS ).includes(
-			block.name
-		) &&
-		!! block.attributes.metadata?.bindings &&
-		Object.values( block.attributes.metadata.bindings ).some(
-			( binding ) => binding.source === 'core/pattern-overrides'
-		)
-	);
-}
-
 function hasOverridableBlocks( blocks ) {
 	return blocks.some( ( block ) => {
-		if ( hasOverridableAttributes( block ) ) return true;
+		if ( isOverridableBlock( block ) ) return true;
 		return hasOverridableBlocks( block.innerBlocks );
 	} );
 }
@@ -133,7 +121,7 @@ function applyInitialContentValuesToInnerBlocks(
 		const metadataName =
 			legacyIdMap?.[ block.clientId ] ?? block.attributes.metadata?.name;
 
-		if ( ! metadataName || ! hasOverridableAttributes( block ) ) {
+		if ( ! metadataName || ! isOverridableBlock( block ) ) {
 			return { ...block, innerBlocks };
 		}
 
@@ -184,7 +172,7 @@ function getContentValuesFromInnerBlocks( blocks, defaultValues, legacyIdMap ) {
 		}
 		const metadataName =
 			legacyIdMap?.[ block.clientId ] ?? block.attributes.metadata?.name;
-		if ( ! metadataName || ! hasOverridableAttributes( block ) ) {
+		if ( ! metadataName || ! isOverridableBlock( block ) ) {
 			continue;
 		}
 
@@ -217,7 +205,7 @@ function setBlockEditMode( setEditMode, blocks, mode ) {
 	blocks.forEach( ( block ) => {
 		const editMode =
 			mode ||
-			( hasOverridableAttributes( block ) ? 'contentOnly' : 'disabled' );
+			( isOverridableBlock( block ) ? 'contentOnly' : 'disabled' );
 		setEditMode( block.clientId, editMode );
 
 		setBlockEditMode(
@@ -229,7 +217,36 @@ function setBlockEditMode( setEditMode, blocks, mode ) {
 	} );
 }
 
-export default function ReusableBlockEdit( {
+function RecursionWarning() {
+	const blockProps = useBlockProps();
+	return (
+		<div { ...blockProps }>
+			<Warning>
+				{ __( 'Block cannot be rendered inside itself.' ) }
+			</Warning>
+		</div>
+	);
+}
+
+// Wrap the main Edit function for the pattern block with a recursion wrapper
+// that allows short-circuiting rendering as early as possible, before any
+// of the other effects in the block edit have run.
+export default function ReusableBlockEditRecursionWrapper( props ) {
+	const { ref } = props.attributes;
+	const hasAlreadyRendered = useHasRecursion( ref );
+
+	if ( hasAlreadyRendered ) {
+		return <RecursionWarning />;
+	}
+
+	return (
+		<RecursionProvider uniqueId={ ref }>
+			<ReusableBlockEdit { ...props } />
+		</RecursionProvider>
+	);
+}
+
+function ReusableBlockEdit( {
 	name,
 	attributes: { ref, content },
 	__unstableParentLayout: parentLayout,
@@ -237,7 +254,6 @@ export default function ReusableBlockEdit( {
 	setAttributes,
 } ) {
 	const registry = useRegistry();
-	const hasAlreadyRendered = useHasRecursion( ref );
 	const { record, editedRecord, hasResolved } = useEntityRecord(
 		'postType',
 		'wp_block',
@@ -434,14 +450,6 @@ export default function ReusableBlockEdit( {
 
 	let children = null;
 
-	if ( hasAlreadyRendered ) {
-		children = (
-			<Warning>
-				{ __( 'Block cannot be rendered inside itself.' ) }
-			</Warning>
-		);
-	}
-
 	if ( isMissing ) {
 		children = (
 			<Warning>
@@ -459,7 +467,7 @@ export default function ReusableBlockEdit( {
 	}
 
 	return (
-		<RecursionProvider uniqueId={ ref }>
+		<>
 			{ userCanEdit && onNavigateToEntityRecord && (
 				<BlockControls>
 					<ToolbarGroup>
@@ -489,6 +497,6 @@ export default function ReusableBlockEdit( {
 			) : (
 				<div { ...blockProps }>{ children }</div>
 			) }
-		</RecursionProvider>
+		</>
 	);
 }

package/src/block/test/edit.native.js

@@ -45,6 +45,7 @@ const getMockedReusableBlock = ( id ) => ( {
 	title: { raw: `Reusable block - ${ id }` },
 	type: 'wp_block',
 	meta: { footnotes: '' },
+	wp_pattern_category: [],
 } );
 
 beforeAll( () => {

package/src/button/edit.native.js

@@ -494,7 +494,7 @@ function ButtonEdit( props ) {
 					<View pointerEvents="none" style={ outLineStyles } />
 				) }
 				<RichText
-					setRef={ onSetRef }
+					ref={ onSetRef }
 					placeholder={ placeholderText }
 					value={ text }
 					onChange={ onChangeText }

package/src/cover/edit.native.js

@@ -248,6 +248,12 @@ const Cover = ( {
 		closeSettingsBottomSheet();
 	}, [ closeSettingsBottomSheet ] );
 
+	const onAddMediaButtonPress = useCallback( () => {
+		if ( openMediaOptionsRef?.current ) {
+			openMediaOptionsRef.current();
+		}
+	}, [] );
+
 	function setColor( color ) {
 		const colorValue = getColorObjectByColorValue( colorsDefault, color );
 
@@ -352,7 +358,7 @@ const Cover = ( {
 			accessibilityHint={ accessibilityHint }
 			accessibilityLabel={ __( 'Add image or video' ) }
 			accessibilityRole="button"
-			onPress={ openMediaOptionsRef.current }
+			onPress={ onAddMediaButtonPress }
 		>
 			<View style={ styles.selectImageContainer }>
 				<View style={ styles.selectImage }>

package/src/cover/editor.scss

@@ -30,9 +30,18 @@
 	}
 
 	// Applied while media is being uploaded
-	&.is-transient::before {
-		background-color: #fff;
-		opacity: 0.3;
+	&.is-transient {
+		position: relative;
+
+		&::before {
+			background-color: #fff;
+			content: "";
+			height: 100%;
+			opacity: 0.3;
+			position: absolute;
+			width: 100%;
+			z-index: 1;
+		}
 	}
 
 	// Shown while media is being uploaded

package/src/cover/style.scss

@@ -1,12 +1,16 @@
+// Lowest specificity styles are used to ensure that the default styles for the cover block can be overridden by global styles.
+:where(.wp-block-cover-image, .wp-block-cover) {
+	min-height: 430px;
+	padding: 1em;
+}
+
 .wp-block-cover-image,
 .wp-block-cover {
 	position: relative;
 	background-position: center center;
-	min-height: 430px;
 	display: flex;
 	justify-content: center;
 	align-items: center;
-	padding: 1em;
 	// Prevent the `wp-block-cover__background` span from overflowing the container when border-radius is applied.
 	// `overflow: hidden` is provided as a fallback for browsers that don't support `overflow: clip`.
 	overflow: hidden;

package/src/details/style.scss

@@ -1,6 +1,5 @@
 .wp-block-details {
 	box-sizing: border-box;
-	overflow: hidden;
 }
 
 .wp-block-details summary {

package/src/editor.scss

@@ -55,7 +55,6 @@
 @import "./post-featured-image/editor.scss";
 @import "./post-comments-form/editor.scss";
 @import "./post-content/editor.scss";
-
 @import "./editor-elements.scss";
 
 :root .editor-styles-wrapper {
@@ -64,13 +63,6 @@
 	@include gradient-colors-deprecated();
 }
 
-// This CSS Custom Properties aren't used anymore as defaults,
-// but we still need to keep them for backward compatibility.
-:where(.editor-styles-wrapper) {
-	--wp--preset--font-size--normal: 16px;
-	--wp--preset--font-size--huge: 42px;
-}
-
 // Font sizes (not used now, kept because of backward compatibility).
 //
 // The reason we add the editor class wrapper here is
@@ -83,14 +75,6 @@
 	font-size: 42px;
 }
 
-:where(.editor-styles-wrapper) .has-normal-font-size {
-	font-size: var(--wp--preset--font-size--normal);
-}
-
-:where(.editor-styles-wrapper) .has-huge-font-size {
-	font-size: var(--wp--preset--font-size--huge);
-}
-
 /**
  * Editor Normalization Styles
  *

package/src/embed/edit.js

@@ -58,45 +58,51 @@ const EmbedEdit = ( props ) => {
 	const [ isEditingURL, setIsEditingURL ] = useState( false );
 	const { invalidateResolution } = useDispatch( coreStore );
 
-	const { preview, fetching, themeSupportsResponsive, cannotEmbed } =
-		useSelect(
-			( select ) => {
-				const {
-					getEmbedPreview,
-					isPreviewEmbedFallback,
-					isRequestingEmbedPreview,
-					getThemeSupports,
-				} = select( coreStore );
-				if ( ! attributesUrl ) {
-					return { fetching: false, cannotEmbed: false };
-				}
+	const {
+		preview,
+		fetching,
+		themeSupportsResponsive,
+		cannotEmbed,
+		hasResolved,
+	} = useSelect(
+		( select ) => {
+			const {
+				getEmbedPreview,
+				isPreviewEmbedFallback,
+				isRequestingEmbedPreview,
+				getThemeSupports,
+				hasFinishedResolution,
+			} = select( coreStore );
+			if ( ! attributesUrl ) {
+				return { fetching: false, cannotEmbed: false };
+			}
 
-				const embedPreview = getEmbedPreview( attributesUrl );
-				const previewIsFallback =
-					isPreviewEmbedFallback( attributesUrl );
+			const embedPreview = getEmbedPreview( attributesUrl );
+			const previewIsFallback = isPreviewEmbedFallback( attributesUrl );
 
-				// The external oEmbed provider does not exist. We got no type info and no html.
-				const badEmbedProvider =
-					embedPreview?.html === false &&
-					embedPreview?.type === undefined;
-				// Some WordPress URLs that can't be embedded will cause the API to return
-				// a valid JSON response with no HTML and `data.status` set to 404, rather
-				// than generating a fallback response as other embeds do.
-				const wordpressCantEmbed = embedPreview?.data?.status === 404;
-				const validPreview =
-					!! embedPreview &&
-					! badEmbedProvider &&
-					! wordpressCantEmbed;
-				return {
-					preview: validPreview ? embedPreview : undefined,
-					fetching: isRequestingEmbedPreview( attributesUrl ),
-					themeSupportsResponsive:
-						getThemeSupports()[ 'responsive-embeds' ],
-					cannotEmbed: ! validPreview || previewIsFallback,
-				};
-			},
-			[ attributesUrl ]
-		);
+			// The external oEmbed provider does not exist. We got no type info and no html.
+			const badEmbedProvider =
+				embedPreview?.html === false &&
+				embedPreview?.type === undefined;
+			// Some WordPress URLs that can't be embedded will cause the API to return
+			// a valid JSON response with no HTML and `data.status` set to 404, rather
+			// than generating a fallback response as other embeds do.
+			const wordpressCantEmbed = embedPreview?.data?.status === 404;
+			const validPreview =
+				!! embedPreview && ! badEmbedProvider && ! wordpressCantEmbed;
+			return {
+				preview: validPreview ? embedPreview : undefined,
+				fetching: isRequestingEmbedPreview( attributesUrl ),
+				themeSupportsResponsive:
+					getThemeSupports()[ 'responsive-embeds' ],
+				cannotEmbed: ! validPreview || previewIsFallback,
+				hasResolved: hasFinishedResolution( 'getEmbedPreview', [
+					attributesUrl,
+				] ),
+			};
+		},
+		[ attributesUrl ]
+	);
 
 	/**
 	 * Returns the attributes derived from the preview, merged with the current attributes.
@@ -127,7 +133,7 @@ const EmbedEdit = ( props ) => {
 	};
 
 	useEffect( () => {
-		if ( preview?.html || ! cannotEmbed || fetching ) {
+		if ( preview?.html || ! cannotEmbed || ! hasResolved ) {
 			return;
 		}
 
@@ -137,7 +143,13 @@ const EmbedEdit = ( props ) => {
 		setURL( newURL );
 		setIsEditingURL( false );
 		setAttributes( { url: newURL } );
-	}, [ preview?.html, attributesUrl, cannotEmbed, fetching, setAttributes ] );
+	}, [
+		preview?.html,
+		attributesUrl,
+		cannotEmbed,
+		hasResolved,
+		setAttributes,
+	] );
 
 	// Try a different provider in case the embed url is not supported.
 	useEffect( () => {

package/src/embed/theme.scss

@@ -2,6 +2,6 @@
 	@include caption-style-theme();
 }
 
-.wp-block-embed {
+:where(.wp-block-embed) {
 	margin: 0 0 1em 0;
 }

package/src/file/edit.js

@@ -84,7 +84,8 @@ function FileEdit( { attributes, isSelected, setAttributes, clientId } ) {
 	);
 
 	const { createErrorNotice } = useDispatch( noticesStore );
-	const { toggleSelection } = useDispatch( blockEditorStore );
+	const { toggleSelection, __unstableMarkNextChangeAsNotPersistent } =
+		useDispatch( blockEditorStore );
 
 	useUploadMediaFromBlobURL( {
 		url: href,
@@ -92,12 +93,17 @@ function FileEdit( { attributes, isSelected, setAttributes, clientId } ) {
 		onError: onUploadError,
 	} );
 
+	// Note: Handle setting a default value for `downloadButtonText` via HTML API
+	// when it supports replacing text content for HTML tags.
 	useEffect( () => {
 		if ( RichText.isEmpty( downloadButtonText ) ) {
+			__unstableMarkNextChangeAsNotPersistent();
 			setAttributes( {
 				downloadButtonText: _x( 'Download', 'button label' ),
 			} );
 		}
+		// Reason: This effect should only run on mount.
+		// eslint-disable-next-line react-hooks/exhaustive-deps
 	}, [] );
 
 	function onSelectFile( newMedia ) {