@wordpress/block-library 7.10.0 → 7.11.0

package/src/navigation-link/edit.js

@@ -312,7 +312,7 @@ const useIsInvalidLink = ( kind, type, id ) => {
 	return [ isInvalid, isDraft ];
 };
 
-const useMissingText = ( type ) => {
+function getMissingText( type ) {
 	let missingText = '';
 
 	switch ( type ) {
@@ -338,7 +338,7 @@ const useMissingText = ( type ) => {
 	}
 
 	return missingText;
-};
+}
 
 /**
  * Removes HTML from a given string.
@@ -682,7 +682,7 @@ export default function NavigationLinkEdit( {
 		'wp-block-navigation-link__placeholder': ! url || isInvalid || isDraft,
 	} );
 
-	const missingText = useMissingText( type, isInvalid, isDraft );
+	const missingText = getMissingText( type );
 	/* translators: Whether the navigation link is Invalid or a Draft. */
 	const placeholderText = `(${
 		isInvalid ? __( 'Invalid' ) : __( 'Draft' )
@@ -849,6 +849,7 @@ export default function NavigationLinkEdit( {
 							position="bottom center"
 							onClose={ () => setIsLinkOpen( false ) }
 							anchorRef={ listItemRef.current }
+							__unstableShift
 						>
 							<LinkControl
 								hasTextControl

package/src/navigation-submenu/edit.js

@@ -634,6 +634,7 @@ export default function NavigationSubmenuEdit( {
 							position="bottom center"
 							onClose={ () => setIsLinkOpen( false ) }
 							anchorRef={ listItemRef.current }
+							__unstableShift
 						>
 							<LinkControl
 								className="wp-block-navigation-link__inline-link-input"

package/src/page-list/edit.js

@@ -103,6 +103,14 @@ export default function PageListEdit( { context, clientId } ) {
 
 function useFrontPageId() {
 	return useSelect( ( select ) => {
+		const canReadSettings = select( coreStore ).canUser(
+			'read',
+			'settings'
+		);
+		if ( ! canReadSettings ) {
+			return undefined;
+		}
+
 		const site = select( coreStore ).getEntityRecord( 'root', 'site' );
 		return site?.show_on_front === 'page' && site?.page_on_front;
 	}, [] );
@@ -117,6 +125,7 @@ function usePageData() {
 			order: 'asc',
 			_fields: [ 'id', 'link', 'parent', 'title', 'menu_order' ],
 			per_page: -1,
+			context: 'view',
 		}
 	);
 

package/src/paragraph/edit.js

@@ -8,7 +8,7 @@ import classnames from 'classnames';
  */
 import { __, _x, isRTL } from '@wordpress/i18n';
 import {
-	ToolbarDropdownMenu,
+	ToolbarButton,
 	ToggleControl,
 	__experimentalToolsPanelItem as ToolsPanelItem,
 } from '@wordpress/components';
@@ -33,19 +33,13 @@ const name = 'core/paragraph';
 function ParagraphRTLControl( { direction, setDirection } ) {
 	return (
 		isRTL() && (
-			<ToolbarDropdownMenu
-				controls={ [
-					{
-						icon: formatLtr,
-						title: _x( 'Left to right', 'editor button' ),
-						isActive: direction === 'ltr',
-						onClick() {
-							setDirection(
-								direction === 'ltr' ? undefined : 'ltr'
-							);
-						},
-					},
-				] }
+			<ToolbarButton
+				icon={ formatLtr }
+				title={ _x( 'Left to right', 'editor button' ) }
+				isActive={ direction === 'ltr' }
+				onClick={ () => {
+					setDirection( direction === 'ltr' ? undefined : 'ltr' );
+				} }
 			/>
 		)
 	);

package/src/post-comments-form/edit.js

@@ -9,14 +9,8 @@ import classnames from 'classnames';
 import {
 	AlignmentControl,
 	BlockControls,
-	Warning,
 	useBlockProps,
-	store as blockEditorStore,
 } from '@wordpress/block-editor';
-import { Button } from '@wordpress/components';
-import { useEntityProp, store as coreStore } from '@wordpress/core-data';
-import { __, _x, sprintf } from '@wordpress/i18n';
-import { useSelect } from '@wordpress/data';
 
 /**
  * Internal dependencies
@@ -30,72 +24,13 @@ export default function PostCommentsFormEdit( {
 } ) {
 	const { textAlign } = attributes;
 	const { postId, postType } = context;
-	const [ commentStatus, setCommentStatus ] = useEntityProp(
-		'postType',
-		postType,
-		'comment_status',
-		postId
-	);
+
 	const blockProps = useBlockProps( {
 		className: classnames( {
 			[ `has-text-align-${ textAlign }` ]: textAlign,
 		} ),
 	} );
 
-	const isSiteEditor = postType === undefined || postId === undefined;
-
-	const { defaultCommentStatus } = useSelect(
-		( select ) =>
-			select( blockEditorStore ).getSettings()
-				.__experimentalDiscussionSettings
-	);
-
-	const postTypeSupportsComments = useSelect( ( select ) =>
-		postType
-			? !! select( coreStore ).getPostType( postType )?.supports.comments
-			: false
-	);
-
-	let warning = false;
-	let actions;
-	let showPlaceholder = true;
-
-	if ( ! isSiteEditor && 'open' !== commentStatus ) {
-		if ( 'closed' === commentStatus ) {
-			warning = __(
-				'Post Comments Form block: Comments are not enabled for this item.'
-			);
-
-			actions = [
-				<Button
-					key="enableComments"
-					onClick={ () => setCommentStatus( 'open' ) }
-					variant="primary"
-				>
-					{ _x(
-						'Enable comments',
-						'action that affects the current post'
-					) }
-				</Button>,
-			];
-			showPlaceholder = false;
-		} else if ( ! postTypeSupportsComments ) {
-			warning = sprintf(
-				/* translators: 1: Post type (i.e. "post", "page") */
-				__(
-					'Post Comments Form block: Comments are not enabled for this post type (%s).'
-				),
-				postType
-			);
-			showPlaceholder = false;
-		} else if ( 'open' !== defaultCommentStatus ) {
-			warning = __(
-				'Post Comments Form block: Comments are not enabled.'
-			);
-			showPlaceholder = false;
-		}
-	}
-
 	return (
 		<>
 			<BlockControls group="block">
@@ -107,11 +42,7 @@ export default function PostCommentsFormEdit( {
 				/>
 			</BlockControls>
 			<div { ...blockProps }>
-				{ warning && (
-					<Warning actions={ actions }>{ warning }</Warning>
-				) }
-
-				{ showPlaceholder ? <CommentsForm /> : null }
+				<CommentsForm postId={ postId } postType={ postType } />
 			</div>
 		</>
 	);

package/src/post-comments-form/form.js

@@ -6,13 +6,20 @@ import classnames from 'classnames';
 /**
  * WordPress dependencies
  */
-import { __ } from '@wordpress/i18n';
-import { __experimentalGetElementClassName } from '@wordpress/block-editor';
+import { __, _x, sprintf } from '@wordpress/i18n';
+import {
+	Warning,
+	store as blockEditorStore,
+	__experimentalGetElementClassName,
+} from '@wordpress/block-editor';
+import { Button } from '@wordpress/components';
 import { useDisabled, useInstanceId } from '@wordpress/compose';
+import { useEntityProp, store as coreStore } from '@wordpress/core-data';
+import { useSelect } from '@wordpress/data';
 
-const CommentsForm = () => {
+const CommentsFormPlaceholder = () => {
 	const disabledFormRef = useDisabled();
-	const instanceId = useInstanceId( CommentsForm );
+	const instanceId = useInstanceId( CommentsFormPlaceholder );
 
 	return (
 		<div className="comment-respond">
@@ -34,7 +41,6 @@ const CommentsForm = () => {
 						name="submit"
 						type="submit"
 						className={ classnames(
-							'submit',
 							'wp-block-button__link',
 							__experimentalGetElementClassName( 'button' )
 						) }
@@ -47,4 +53,73 @@ const CommentsForm = () => {
 	);
 };
 
+const CommentsForm = ( { postId, postType } ) => {
+	const [ commentStatus, setCommentStatus ] = useEntityProp(
+		'postType',
+		postType,
+		'comment_status',
+		postId
+	);
+
+	const isSiteEditor = postType === undefined || postId === undefined;
+
+	const { defaultCommentStatus } = useSelect(
+		( select ) =>
+			select( blockEditorStore ).getSettings()
+				.__experimentalDiscussionSettings
+	);
+
+	const postTypeSupportsComments = useSelect( ( select ) =>
+		postType
+			? !! select( coreStore ).getPostType( postType )?.supports.comments
+			: false
+	);
+
+	if ( ! isSiteEditor && 'open' !== commentStatus ) {
+		if ( 'closed' === commentStatus ) {
+			const actions = [
+				<Button
+					key="enableComments"
+					onClick={ () => setCommentStatus( 'open' ) }
+					variant="primary"
+				>
+					{ _x(
+						'Enable comments',
+						'action that affects the current post'
+					) }
+				</Button>,
+			];
+			return (
+				<Warning actions={ actions }>
+					{ __(
+						'Post Comments Form block: Comments are not enabled for this item.'
+					) }
+				</Warning>
+			);
+		} else if ( ! postTypeSupportsComments ) {
+			return (
+				<Warning>
+					{ sprintf(
+						/* translators: 1: Post type (i.e. "post", "page") */
+						__(
+							'Post Comments Form block: Comments are not enabled for this post type (%s).'
+						),
+						postType
+					) }
+				</Warning>
+			);
+		} else if ( 'open' !== defaultCommentStatus ) {
+			return (
+				<Warning>
+					{ __(
+						'Post Comments Form block: Comments are not enabled.'
+					) }
+				</Warning>
+			);
+		}
+	}
+
+	return <CommentsFormPlaceholder />;
+};
+
 export default CommentsForm;

package/src/post-comments-form/index.php

@@ -72,7 +72,7 @@ add_action( 'init', 'register_block_core_post_comments_form' );
  */
 function post_comments_form_block_form_defaults( $fields ) {
 	if ( wp_is_block_theme() ) {
-		$fields['submit_button'] = '<input name="%1$s" type="submit" id="%2$s" class="%3$s wp-block-button__link ' . WP_Theme_JSON_Gutenberg::get_element_class_name( 'button' ) . '" value="%4$s" />';
+		$fields['submit_button'] = '<input name="%1$s" type="submit" id="%2$s" class="wp-block-button__link ' . WP_Theme_JSON_Gutenberg::get_element_class_name( 'button' ) . '" value="%4$s" />';
 		$fields['submit_field']  = '<p class="form-submit wp-block-button">%1$s %2$s</p>';
 	}
 

package/src/post-comments-form/style.scss

@@ -21,7 +21,6 @@
 
 	// Styles copied from button block styles.
 	input[type="submit"] {
-		border: none;
 		box-shadow: none;
 		cursor: pointer;
 		display: inline-block;

package/src/post-terms/edit.js

@@ -40,6 +40,7 @@ export default function PostTermsEdit( {
 	attributes,
 	clientId,
 	context,
+	isSelected,
 	setAttributes,
 	insertBlocksAfter,
 } ) {
@@ -96,7 +97,7 @@ export default function PostTermsEdit( {
 			</InspectorControls>
 			<div { ...blockProps }>
 				{ isLoading && <Spinner /> }
-				{ ! isLoading && hasPostTerms && (
+				{ ! isLoading && hasPostTerms && ( isSelected || prefix ) && (
 					<RichText
 						allowedFormats={ ALLOWED_FORMATS }
 						className="wp-block-post-terms__prefix"
@@ -135,7 +136,7 @@ export default function PostTermsEdit( {
 					! hasPostTerms &&
 					( selectedTerm?.labels?.no_terms ||
 						__( 'Term items not found.' ) ) }
-				{ ! isLoading && hasPostTerms && (
+				{ ! isLoading && hasPostTerms && ( isSelected || suffix ) && (
 					<RichText
 						allowedFormats={ ALLOWED_FORMATS }
 						className="wp-block-post-terms__suffix"

package/src/query-no-results/edit.js

@@ -20,9 +20,6 @@ export default function QueryNoResultsEdit() {
 	const innerBlocksProps = useInnerBlocksProps( blockProps, {
 		template: TEMPLATE,
 	} );
-	return (
-		<>
-			<div { ...innerBlocksProps } />
-		</>
-	);
+
+	return <div { ...innerBlocksProps } />;
 }

package/src/query-pagination-next/edit.js

@@ -35,6 +35,7 @@ export default function QueryPaginationNextEdit( {
 			{ displayArrow && (
 				<span
 					className={ `wp-block-query-pagination-next-arrow is-arrow-${ paginationArrow }` }
+					aria-hidden={ true }
 				>
 					{ displayArrow }
 				</span>

package/src/query-pagination-previous/edit.js

@@ -25,6 +25,7 @@ export default function QueryPaginationPreviousEdit( {
 			{ displayArrow && (
 				<span
 					className={ `wp-block-query-pagination-previous-arrow is-arrow-${ paginationArrow }` }
+					aria-hidden={ true }
 				>
 					{ displayArrow }
 				</span>