@wordpress/block-editor 15.6.0 → 15.6.1

package/src/hooks/block-bindings.js

@@ -15,11 +15,10 @@ import {
 	__experimentalToolsPanel as ToolsPanel,
 	__experimentalToolsPanelItem as ToolsPanelItem,
 	__experimentalVStack as VStack,
-	Modal,
 	privateApis as componentsPrivateApis,
 } from '@wordpress/components';
 import { useSelect } from '@wordpress/data';
-import { useContext, useState } from '@wordpress/element';
+import { useContext } from '@wordpress/element';
 import { useViewportMatch } from '@wordpress/compose';
 
 /**
@@ -63,12 +62,7 @@ const useToolsPanelDropdownMenuProps = () => {
 		: {};
 };
 
-function BlockBindingsPanelMenuContent( {
-	attribute,
-	binding,
-	sources,
-	onOpenModal,
-} ) {
+function BlockBindingsPanelMenuContent( { attribute, binding, sources } ) {
 	const { clientId } = useBlockEditContext();
 	const { updateBlockBindings } = useBlockBindingsUtils();
 	const isMobile = useViewportMatch( 'medium', '<' );
@@ -99,105 +93,85 @@ function BlockBindingsPanelMenuContent( {
 					return null;
 				}
 
-				if ( source.mode === 'dropdown' ) {
-					return (
-						<Menu
-							key={ sourceKey }
-							placement={
-								isMobile ? 'bottom-start' : 'left-start'
-							}
-						>
-							<Menu.SubmenuTriggerItem>
-								<Menu.ItemLabel>
-									{ source.label }
-								</Menu.ItemLabel>
-							</Menu.SubmenuTriggerItem>
-							<Menu.Popover gutter={ 8 }>
-								<Menu.Group>
-									{ sourceDataItems.map( ( item ) => {
-										const itemBindings = {
-											source: sourceKey,
-											args: item?.args || {
-												key: item.key,
-											},
-										};
-										const values = source.getValues( {
-											select,
-											context: blockContext,
-											bindings: {
-												[ attribute ]: itemBindings,
-											},
-										} );
-										return (
-											<Menu.CheckboxItem
-												key={
-													sourceKey +
-														JSON.stringify(
-															item.args
-														) || item.key
-												}
-												onChange={ () => {
-													const isCurrentlySelected =
-														fastDeepEqual(
-															binding?.args,
-															item.args
-														) ??
-														// Deprecate key dependency in 7.0.
-														item.key ===
-															binding?.args?.key;
-
-													if ( isCurrentlySelected ) {
-														// Unset if the same item is selected again.
-														updateBlockBindings( {
-															[ attribute ]:
-																undefined,
-														} );
-													} else {
-														updateBlockBindings( {
-															[ attribute ]:
-																itemBindings,
-														} );
-													}
-												} }
-												name={ attribute + '-binding' }
-												value={ values[ attribute ] }
-												checked={
+				return (
+					<Menu
+						key={ sourceKey }
+						placement={ isMobile ? 'bottom-start' : 'left-start' }
+					>
+						<Menu.SubmenuTriggerItem>
+							<Menu.ItemLabel>{ source.label }</Menu.ItemLabel>
+						</Menu.SubmenuTriggerItem>
+						<Menu.Popover gutter={ 8 }>
+							<Menu.Group>
+								{ sourceDataItems.map( ( item ) => {
+									const itemBindings = {
+										source: sourceKey,
+										args: item?.args || {
+											key: item.key,
+										},
+									};
+									const values = source.getValues( {
+										select,
+										context: blockContext,
+										bindings: {
+											[ attribute ]: itemBindings,
+										},
+									} );
+									return (
+										<Menu.CheckboxItem
+											key={
+												sourceKey +
+													JSON.stringify(
+														item.args
+													) || item.key
+											}
+											onChange={ () => {
+												const isCurrentlySelected =
 													fastDeepEqual(
 														binding?.args,
 														item.args
 													) ??
 													// Deprecate key dependency in 7.0.
 													item.key ===
-														binding?.args?.key
+														binding?.args?.key;
+
+												if ( isCurrentlySelected ) {
+													// Unset if the same item is selected again.
+													updateBlockBindings( {
+														[ attribute ]:
+															undefined,
+													} );
+												} else {
+													updateBlockBindings( {
+														[ attribute ]:
+															itemBindings,
+													} );
 												}
-											>
-												<Menu.ItemLabel>
-													{ item?.label }
-												</Menu.ItemLabel>
-												<Menu.ItemHelpText>
-													{ values[ attribute ] }
-												</Menu.ItemHelpText>
-											</Menu.CheckboxItem>
-										);
-									} ) }
-								</Menu.Group>
-							</Menu.Popover>
-						</Menu>
-					);
-				}
-
-				if ( source.mode === 'modal' ) {
-					return (
-						<Menu.Item
-							key={ sourceKey }
-							onClick={ () => onOpenModal( { sourceKey } ) }
-						>
-							<Menu.ItemLabel>{ source.label }</Menu.ItemLabel>
-						</Menu.Item>
-					);
-				}
-
-				return null;
+											} }
+											name={ attribute + '-binding' }
+											value={ values[ attribute ] }
+											checked={
+												fastDeepEqual(
+													binding?.args,
+													item.args
+												) ??
+												// Deprecate key dependency in 7.0.
+												item.key === binding?.args?.key
+											}
+										>
+											<Menu.ItemLabel>
+												{ item?.label }
+											</Menu.ItemLabel>
+											<Menu.ItemHelpText>
+												{ values[ attribute ] }
+											</Menu.ItemHelpText>
+										</Menu.CheckboxItem>
+									);
+								} ) }
+							</Menu.Group>
+						</Menu.Popover>
+					</Menu>
+				);
 			} ) }
 		</Menu>
 	);
@@ -282,16 +256,11 @@ function EditableBlockBindingsPanelItem( {
 	attribute,
 	binding,
 	sources,
-	setModalState,
 	blockName,
 } ) {
 	const { updateBlockBindings } = useBlockBindingsUtils();
 	const isMobile = useViewportMatch( 'medium', '<' );
 
-	const handleOpenModal = ( { sourceKey } ) => {
-		setModalState( { attribute, sourceKey } );
-	};
-
 	return (
 		<ToolsPanelItem
 			hasValue={ () => !! binding }
@@ -316,7 +285,6 @@ function EditableBlockBindingsPanelItem( {
 						attribute={ attribute }
 						binding={ binding }
 						sources={ sources }
-						onOpenModal={ handleOpenModal }
 					/>
 				</Menu.Popover>
 			</Menu>
@@ -328,11 +296,6 @@ export const BlockBindingsPanel = ( { name: blockName, metadata } ) => {
 	const blockContext = useContext( BlockContext );
 	const { removeAllBlockBindings } = useBlockBindingsUtils();
 	const dropdownMenuProps = useToolsPanelDropdownMenuProps();
-	const [ modalState, setModalState ] = useState( null );
-
-	const handleCloseModal = () => {
-		setModalState( null );
-	};
 
 	// Use useSelect to ensure sources are updated whenever there are updates in block context
 	// or when underlying data changes.
@@ -352,7 +315,7 @@ export const BlockBindingsPanel = ( { name: blockName, metadata } ) => {
 			Object.entries( registeredSources ).forEach(
 				( [
 					sourceName,
-					{ editorUI, getFieldsList, usesContext, label, getValues },
+					{ getFieldsList, usesContext, label, getValues },
 				] ) => {
 					// Populate context.
 					const context = {};
@@ -361,44 +324,19 @@ export const BlockBindingsPanel = ( { name: blockName, metadata } ) => {
 							context[ key ] = blockContext[ key ];
 						}
 					}
-
-					if ( editorUI ) {
-						const editorUIResult = editorUI( {
+					if ( getFieldsList ) {
+						const fieldsListResult = getFieldsList( {
 							select,
 							context,
 						} );
-
 						_sources[ sourceName ] = {
-							...editorUIResult,
+							data: fieldsListResult || [],
 							label,
 							getValues,
 						};
-					} else if ( getFieldsList ) {
-						// Backward compatibility: Convert getFieldsList to editorUI format.
-						const fieldsListResult = getFieldsList( {
-							select,
-							context,
-						} );
-
-						if ( fieldsListResult ) {
-							const data = Object.entries( fieldsListResult ).map(
-								( [ key, field ] ) => ( {
-									label: field.label || key,
-									type: field.type || 'string',
-									args: { key },
-								} )
-							);
-
-							_sources[ sourceName ] = {
-								mode: 'dropdown', // Default mode for backward compatibility.
-								data,
-								label,
-								getValues,
-							};
-						}
 					} else {
 						/*
-						 * Include sources without editorUI if they are already used in a binding.
+						 * Include sources without getFieldsList if they are already used in a binding.
 						 * This allows them to be displayed in read-only mode.
 						 */
 						_sources[ sourceName ] = {
@@ -438,9 +376,6 @@ export const BlockBindingsPanel = ( { name: blockName, metadata } ) => {
 	// Lock the UI when the user can't update bindings or there are no fields to connect to.
 	const readOnly = ! canUpdateBlockBindings || ! hasCompatibleData;
 
-	const RenderModalContent =
-		sources[ modalState?.sourceKey ]?.renderModalContent;
-
 	if ( bindings === undefined && ! hasCompatibleData ) {
 		return null;
 	}
@@ -490,7 +425,6 @@ export const BlockBindingsPanel = ( { name: blockName, metadata } ) => {
 								attribute={ attribute }
 								binding={ binding }
 								sources={ sources }
-								setModalState={ setModalState }
 								blockName={ blockName }
 							/>
 						);
@@ -508,14 +442,6 @@ export const BlockBindingsPanel = ( { name: blockName, metadata } ) => {
 					</p>
 				</Text>
 			</ToolsPanel>
-			{ RenderModalContent && (
-				<Modal onRequestClose={ handleCloseModal }>
-					<RenderModalContent
-						attribute={ modalState.attribute }
-						closeModal={ handleCloseModal }
-					/>
-				</Modal>
-			) }
 		</InspectorControls>
 	);
 };

package/src/hooks/custom-class-name.js

@@ -145,6 +145,6 @@ addFilter(
 
 addFilter(
 	'blocks.switchToBlockType.transformedBlock',
-	'core/color/addTransforms',
+	'core/customClassName/addTransforms',
 	addTransforms
 );

package/src/hooks/fit-text.js

@@ -3,7 +3,7 @@
  */
 import { addFilter } from '@wordpress/hooks';
 import { hasBlockSupport } from '@wordpress/blocks';
-import { useEffect, useCallback, useRef } from '@wordpress/element';
+import { useEffect, useCallback } from '@wordpress/element';
 import { useSelect } from '@wordpress/data';
 import { __ } from '@wordpress/i18n';
 import {
@@ -62,28 +62,18 @@ function useFitText( { fitText, name, clientId } ) {
 	const hasFitTextSupport = hasBlockSupport( name, FIT_TEXT_SUPPORT_KEY );
 	const blockElement = useBlockElement( clientId );
 
-	// Monitor block attribute changes and selection state
+	// Monitor block attribute changes
 	// Any attribute may change the available space.
-	const { blockAttributes, isSelected } = useSelect(
+	const blockAttributes = useSelect(
 		( select ) => {
 			if ( ! clientId ) {
-				return { blockAttributes: undefined, isSelected: false };
+				return;
 			}
-			return {
-				blockAttributes:
-					select( blockEditorStore ).getBlockAttributes( clientId ),
-				isSelected:
-					select( blockEditorStore ).isBlockSelected( clientId ),
-			};
+			return select( blockEditorStore ).getBlockAttributes( clientId );
 		},
 		[ clientId ]
 	);
 
-	const isSelectedRef = useRef();
-	useEffect( () => {
-		isSelectedRef.current = isSelected;
-	}, [ isSelected ] );
-
 	const applyFitText = useCallback( () => {
 		if ( ! blockElement || ! hasFitTextSupport || ! fitText ) {
 			return;
@@ -104,13 +94,8 @@ function useFitText( { fitText, name, clientId } ) {
 			styleElement.textContent = css;
 		};
 
-		// Avoid very jarring resizes when a user is actively editing the
-		// block. Placing a ceiling on how much the block can grow curbs the
-		// effect of the first few keypresses.
-		const maxSize = isSelectedRef.current ? 200 : undefined;
-
-		optimizeFitText( blockElement, blockSelector, applyStylesFn, maxSize );
-	}, [ blockElement, clientId, hasFitTextSupport, fitText, isSelectedRef ] );
+		optimizeFitText( blockElement, blockSelector, applyStylesFn );
+	}, [ blockElement, clientId, hasFitTextSupport, fitText ] );
 
 	useEffect( () => {
 		if (
@@ -164,7 +149,6 @@ function useFitText( { fitText, name, clientId } ) {
 		}
 	}, [
 		blockAttributes,
-		isSelected,
 		fitText,
 		applyFitText,
 		blockElement,
@@ -180,12 +164,16 @@ function useFitText( { fitText, name, clientId } ) {
  * @param {Function} props.setAttributes Function to set block attributes.
  * @param {string}   props.name          Block name.
  * @param {boolean}  props.fitText       Whether fit text is enabled.
+ * @param {string}   props.fontSize      Font size slug.
+ * @param {Object}   props.style         Block style object.
  */
 export function FitTextControl( {
 	clientId,
 	fitText = false,
 	setAttributes,
 	name,
+	fontSize,
+	style,
 } ) {
 	if ( ! hasBlockSupport( name, FIT_TEXT_SUPPORT_KEY ) ) {
 		return null;
@@ -203,13 +191,34 @@ export function FitTextControl( {
 					__nextHasNoMarginBottom
 					label={ __( 'Fit text' ) }
 					checked={ fitText }
-					onChange={ () =>
-						setAttributes( { fitText: ! fitText || undefined } )
-					}
+					onChange={ () => {
+						const newFitText = ! fitText || undefined;
+						const updates = { fitText: newFitText };
+
+						// When enabling fit text, clear font size if it has a value
+						if ( newFitText ) {
+							if ( fontSize ) {
+								updates.fontSize = undefined;
+							}
+							if ( style?.typography?.fontSize ) {
+								updates.style = {
+									...style,
+									typography: {
+										...style?.typography,
+										fontSize: undefined,
+									},
+								};
+							}
+						}
+
+						setAttributes( updates );
+					} }
 					help={
 						fitText
 							? __( 'Text will resize to fit its container.' )
-							: __( 'Resize text to fit its container.' )
+							: __(
+									'The text will resize to fit its container, resetting other font size settings.'
+							  )
 					}
 				/>
 			</ToolsPanelItem>
@@ -278,7 +287,7 @@ const hasFitTextSupport = ( blockNameOrType ) => {
 export default {
 	useBlockProps,
 	addSaveProps,
-	attributeKeys: [ 'fitText' ],
+	attributeKeys: [ 'fitText', 'fontSize', 'style' ],
 	hasSupport: hasFitTextSupport,
 	edit: FitTextControl,
 };

package/src/hooks/font-size.js

@@ -97,8 +97,11 @@ export function FontSizeEdit( props ) {
 	} = props;
 	const [ fontSizes ] = useSettings( 'typography.fontSizes' );
 
-	const onChange = ( value ) => {
-		const fontSizeSlug = getFontSizeObjectByValue( fontSizes, value ).slug;
+	const onChange = ( value, selectedItem ) => {
+		// Use the selectedItem's slug if available, otherwise fall back to finding by value
+		const fontSizeSlug =
+			selectedItem?.slug ||
+			getFontSizeObjectByValue( fontSizes, value ).slug;
 
 		setAttributes( {
 			style: cleanEmptyObject( {
@@ -124,7 +127,8 @@ export function FontSizeEdit( props ) {
 	return (
 		<FontSizePicker
 			onChange={ onChange }
-			value={ fontSizeValue }
+			value={ fontSize || fontSizeValue }
+			valueMode={ fontSize ? 'slug' : 'literal' }
 			withReset={ false }
 			withSlider
 			size="__unstable-large"

package/src/hooks/metadata.js

@@ -2,6 +2,8 @@
  * WordPress dependencies
  */
 import { addFilter } from '@wordpress/hooks';
+import { hasBlockSupport } from '@wordpress/blocks';
+
 const META_ATTRIBUTE_NAME = 'metadata';
 
 /**
@@ -28,8 +30,95 @@ export function addMetaAttribute( blockTypeSettings ) {
 	return blockTypeSettings;
 }
 
+/**
+ * Add metadata transforms.
+ *
+ * @param {Object} result  The transformed block.
+ * @param {Array}  source  Original blocks transformed.
+ * @param {number} index   Index of the transformed block.
+ * @param {Array}  results All blocks that resulted from the transformation.
+ * @return {Object} Modified transformed block.
+ */
+export function addTransforms( result, source, index, results ) {
+	// If the condition verifies we are probably in the presence of a wrapping transform
+	// e.g: nesting paragraphs in a group or columns and in that case the metadata should not be kept.
+	if ( results.length === 1 && result.innerBlocks.length === source.length ) {
+		return result;
+	}
+
+	// If we are transforming one block to multiple blocks or multiple blocks to one block,
+	// we ignore the metadata during the transform.
+	if (
+		( results.length === 1 && source.length > 1 ) ||
+		( results.length > 1 && source.length === 1 )
+	) {
+		return result;
+	}
+
+	// If we are transforming multiple blocks to multiple blocks with different counts,
+	// we ignore the metadata during the transform.
+	if (
+		results.length > 1 &&
+		source.length > 1 &&
+		results.length !== source.length
+	) {
+		return result;
+	}
+
+	const sourceMetadata = source[ index ]?.attributes?.metadata;
+
+	if ( ! sourceMetadata ) {
+		return result;
+	}
+
+	const preservedMetadata = {};
+
+	// Notes
+	if ( sourceMetadata.noteId && ! result.attributes?.metadata?.noteId ) {
+		preservedMetadata.noteId = sourceMetadata.noteId;
+	}
+
+	// Custom name
+	if (
+		sourceMetadata.name &&
+		! result.attributes?.metadata?.name &&
+		hasBlockSupport( result.name, 'renaming', true )
+	) {
+		preservedMetadata.name = sourceMetadata.name;
+	}
+
+	// Block visibility
+	if (
+		sourceMetadata.blockVisibility !== undefined &&
+		! result.attributes?.metadata?.blockVisibility &&
+		hasBlockSupport( result.name, 'blockVisibility', true )
+	) {
+		preservedMetadata.blockVisibility = sourceMetadata.blockVisibility;
+	}
+
+	if ( Object.keys( preservedMetadata ).length > 0 ) {
+		return {
+			...result,
+			attributes: {
+				...result.attributes,
+				metadata: {
+					...result.attributes.metadata,
+					...preservedMetadata,
+				},
+			},
+		};
+	}
+	return result;
+}
+
 addFilter(
 	'blocks.registerBlockType',
 	'core/metadata/addMetaAttribute',
 	addMetaAttribute
 );
+
+addFilter(
+	'blocks.switchToBlockType.transformedBlock',
+	'core/metadata/addTransforms',
+	addTransforms
+);