@wordbricks/cva 0.1.1 → 0.1.2

package/lib/install.js

@@ -16,7 +16,7 @@ async function downloadFile(url, destination) {
     const request = https.get(url, (response) => {
       if (response.statusCode >= 300 && response.statusCode < 400 && response.headers.location) {
         response.resume();
-        downloadFile(response.headers.location, destination).then(resolve).catch(reject);
+        resolve(downloadFile(response.headers.location, destination));
         return;
       }
       if (response.statusCode !== 200) {
@@ -27,13 +27,14 @@ async function downloadFile(url, destination) {
 
       const output = fs.createWriteStream(tempFile, { mode: 0o755 });
       pipeline(response, output)
-        .then(resolve)
+        .then(() => {
+          fs.renameSync(tempFile, destination);
+          resolve();
+        })
         .catch(reject);
     });
     request.on("error", reject);
   });
-
-  fs.renameSync(tempFile, destination);
 }
 
 async function ensureBinary(options = {}) {
@@ -74,5 +75,6 @@ if (require.main === module) {
 }
 
 module.exports = {
+  downloadFile,
   ensureBinary
 };

package/lib/install.test.js

@@ -0,0 +1,54 @@
+const test = require("node:test");
+const assert = require("node:assert/strict");
+const fs = require("node:fs");
+const os = require("node:os");
+const path = require("node:path");
+const { PassThrough } = require("node:stream");
+const https = require("node:https");
+
+const { downloadFile } = require("./install");
+
+test("downloadFile follows redirects without double-renaming the temp file", async () => {
+  const originalGet = https.get;
+  const calls = [];
+
+  https.get = (url, callback) => {
+    calls.push(url);
+    const response = new PassThrough();
+    if (calls.length === 1) {
+      response.statusCode = 302;
+      response.headers = { location: "https://example.com/final" };
+      process.nextTick(() => {
+        callback(response);
+        response.end();
+      });
+    } else {
+      response.statusCode = 200;
+      response.headers = {};
+      process.nextTick(() => {
+        callback(response);
+        response.end("binary-data");
+      });
+    }
+    return {
+      on() {
+        return this;
+      }
+    };
+  };
+
+  const tempDir = fs.mkdtempSync(path.join(os.tmpdir(), "cva-install-test-"));
+  const destination = path.join(tempDir, "cva");
+
+  try {
+    await downloadFile("https://example.com/redirect", destination);
+    assert.equal(fs.readFileSync(destination, "utf8"), "binary-data");
+    assert.deepEqual(calls, [
+      "https://example.com/redirect",
+      "https://example.com/final"
+    ]);
+  } finally {
+    https.get = originalGet;
+    fs.rmSync(tempDir, { recursive: true, force: true });
+  }
+});

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@wordbricks/cva",
-  "version": "0.1.1",
+  "version": "0.1.2",
   "description": "Codex Virtual Assistant CLI wrapper that installs the native cva binary.",
   "homepage": "https://github.com/wordbricks/codex-virtual-assistant",
   "bugs": {