@woosh/meep-engine 3.13.0 → 3.14.0

package/src/shade/device/PASS_ENCODER_PROPOSAL_2026_08_31.md

@@ -12,6 +12,10 @@
 > **Revision 3** records what shipped. The §9 decisions were taken (§9), the error-carrying
 > `workgroup_size_error` of revision 2 was rejected in favour of throwing at construction (§3.5),
 > and the code landed in three commits (§10).
+>
+> **Revision 4** rewrites §3.2, which was wrong and shipped a renderer that could not draw. Revision
+> 2 identified `setBindGroup` as the one forward that could be actively wrong and then guarded the
+> wrong end of it. §8.9 is the post-mortem; §3.2 is now the rule that replaced it.
 
 ---
 
@@ -228,9 +232,7 @@ export class ShadeGPUComputePassEncoder {
 
     setBindGroupRange(index, bind_group, data, data_start, data_length) { /* §3.2 */ }
 
-    setImmediates(range_offset, data, data_offset, data_size) {
-        this.#pass.setImmediates(range_offset, data, data_offset, data_size);
-    }
+    setImmediates(...args) { /* §3.2, shape 1 */ }
 
     // --- GPUDebugCommandsMixin ------------------------------------------------
 
@@ -662,6 +664,16 @@ call it out. This is the single most likely place for this change to introduce a
 - **"Both classes ~120 lines."** Now ~130 with the `label` setter and the split `setBindGroup`.
   Immaterial, but the earlier number was a guess presented as a measurement.
 
+### 8.8 Residual risks, accepted
+
+- **A WebGPU method Chrome ships that Shade has not modelled** is now a hard failure rather than a
+  silent forward. That is the intended trade (§8.2), but it means the browser check is load-bearing
+  and needs to actually run in CI or a pre-release checklist, not just exist.
+- **`executeBundles` work is uncounted** (§3.3). Pre-existing, documented, nothing uses bundles.
+- **99 call sites change type.** No reflection over pass objects exists anywhere in the tree
+  (`typeof pass.x`, `Object.keys(pass)`, spread, `instanceof` — all checked, all absent), so the
+  surface is method calls only. If one is missed it throws at that call; it cannot silently misbehave.
+
 ### 8.9 It shipped broken anyway — the arity bug *(found in a browser, after landing)*
 
 `setBindGroup(0, bind_group)` forwarded `setBindGroup(0, bind_group, undefined)`, and the renderer
@@ -702,16 +714,6 @@ rather than claiming a mechanism it cannot demonstrate.
 three tiers in §6 are blind to the mock/browser boundary by construction, and this change has now
 been wrong at that boundary twice.
 
-### 8.8 Residual risks, accepted
-
-- **A WebGPU method Chrome ships that Shade has not modelled** is now a hard failure rather than a
-  silent forward. That is the intended trade (§8.2), but it means the browser check is load-bearing
-  and needs to actually run in CI or a pre-release checklist, not just exist.
-- **`executeBundles` work is uncounted** (§3.3). Pre-existing, documented, nothing uses bundles.
-- **99 call sites change type.** No reflection over pass objects exists anywhere in the tree
-  (`typeof pass.x`, `Object.keys(pass)`, spread, `instanceof` — all checked, all absent), so the
-  surface is method calls only. If one is missed it throws at that call; it cannot silently misbehave.
-
 ---
 
 ## 9. Decisions taken
@@ -745,6 +747,9 @@ Still open, and deliberately not done here:
 2. `refactor(shade): pass encoders become explicit decorator classes` — §§3.1–3.4 and 3.6, plus the
    BVH verification tool moved onto a `GPUFrameRecorder`.
 3. `refactor(shade): remove the debug-timer path, the profiler is the only one` — §4.
+4. `fix(shade): pass encoders forward the arity they received` — §3.2, after the renderer failed on
+   its first bind group in a browser. §8.9.
 
 Revision 2 ordered these decorators-first; that was wrong (§8.4) and the workgroup size went first
-instead. Full suite green after each: 15,012 tests.
+instead. Full suite green after each: 15,014 tests — which, per §8.9, was never going to be enough
+on its own.

package/src/shade/renderer/postprocess/eye/GPUCameraExposureManager.js

@@ -48,7 +48,7 @@ export class GPUCameraExposureManager {
      * -1 = half as bright
      * @type {number}
      */
-    exposure_compensation = 1.0;
+    exposure_compensation = 0.0;
 
     /**
      *

package/src/shade/renderer/scene/Mesh.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"Mesh.d.ts","sourceRoot":"","sources":["../../../../../src/shade/renderer/scene/Mesh.js"],"names":[],"mappings":"AAYA;IA2HI;;;;;;OAMG;IACH,mFAFY,IAAI,CAoBf;IAnJD;;OAEG;IACH,0BAAS;IAET;;OAEG;IACH,wBAAS;IAET;;;OAGG;IACH,cAFU,YAAY,CAEa;IAEnC;;;OAGG;IACH,iBAFU,YAAY,CAEgB;IAEtC;;;OAGG;IACH,SAFa,IAAI,CAQhB;IAED;;;OAGG;IACH,YAFW,IAAI,QAiBd;IAED;;;;OAIG;IACH,cAHW,IAAI,GACF,OAAO,CAQnB;IAQD,0BAOC;IAED,0BAqCC;IA+BL,gBAAqB;CAHpB;uBAvJsB,aAAa"}
+{"version":3,"file":"Mesh.d.ts","sourceRoot":"","sources":["../../../../../src/shade/renderer/scene/Mesh.js"],"names":[],"mappings":"AAUA;IA2HI;;;;;;OAMG;IACH,mFAFY,IAAI,CAoBf;IAnJD;;OAEG;IACH,0BAAS;IAET;;OAEG;IACH,wBAAS;IAET;;;OAGG;IACH,cAFU,YAAY,CAEa;IAEnC;;;OAGG;IACH,iBAFU,YAAY,CAEgB;IAEtC;;;OAGG;IACH,SAFa,IAAI,CAQhB;IAED;;;OAGG;IACH,YAFW,IAAI,QAiBd;IAED;;;;OAIG;IACH,cAHW,IAAI,GACF,OAAO,CAQnB;IAQD,0BAOC;IAED,0BAqCC;IA+BL,gBAAqB;CAHpB;uBAvJsB,aAAa"}

package/src/shade/renderer/scene/Mesh.js

@@ -1,10 +1,8 @@
 import { assert } from "../../../core/assert.js";
 import { AABB3 } from "../../../core/geom/3d/aabb/AABB3.js";
-import {
-    aabb3_from_v3_array_transformed
-} from "../../../core/geom/3d/aabb/aabb3_from_v3_array_transformed.js";
+import { aabb3_from_v3_array_transformed } from "../../../core/geom/3d/aabb/aabb3_from_v3_array_transformed.js";
 import { aabb3_matrix4_project } from "../../../core/geom/3d/aabb/aabb3_matrix4_project.js";
-import { sphere_matrix4_project } from "../../../core/geom/3d/sphere/sphere_matrix4_transform.js";
+import { sphere_matrix4_transform } from "../../../core/geom/3d/sphere/sphere_matrix4_transform.js";
 import { epsilonEquals } from "../../../core/math/epsilonEquals.js";
 import { optional_equality } from "../../descriptor/util/optional_equality.js";
 import { StandardAttributes } from "../geometry/StandardAttributes.js";
@@ -91,7 +89,7 @@ export class Mesh extends Node3D {
         const m = this.transform_global;
 
         aabb3_matrix4_project(this.bounding_box, this.geometry.bounding_box, m);
-        sphere_matrix4_project(this.bounding_sphere, this.geometry.bounding_sphere, m);
+        sphere_matrix4_transform(this.bounding_sphere, this.geometry.bounding_sphere, m);
     }
 
     updateBoundsTight() {
@@ -128,7 +126,7 @@ export class Mesh extends Node3D {
 
             {
                 // todo do a tight sphere bounds
-                sphere_matrix4_project(this.bounding_sphere, this.geometry.bounding_sphere, this.transform_global);
+                sphere_matrix4_transform(this.bounding_sphere, this.geometry.bounding_sphere, this.transform_global);
             }
         }
     }

package/src/shade/renderer/shadow/map/GPUSceneShadowmapContext.d.ts

@@ -81,7 +81,8 @@ export class GPUSceneShadowmapContext {
      * Runs at the top of every frame, before {@link draw}. Responsibilities:
      *
      *  1. **Reset per-frame signals.** `should_draw` is cleared on every map so a stale "yes"
-     *     from a prior frame can never cause a spurious extra raster.
+     *     from a prior frame can never cause a spurious extra raster. Folded into the selector's
+     *     scoring pass, which walks every map anyway.
      *  2. **Measure on-screen presence.** `projected_area_px` is computed once per map and stored
      *     on the map itself — consumed by the resolution policy, the scorer, and the selector,
      *     and exposed for debug tooling.
@@ -90,7 +91,8 @@ export class GPUSceneShadowmapContext {
      *     resize. The committed `layout` is left untouched so sampling remains valid; the
      *     pending is consumed later by {@link draw} when the scheduler naturally picks this map
      *     up (no forced redraw).
-     *  4. **Score + select.** For each map:
+     *  4. **Score + select.** Delegated to {@link ShadowmapDrawSelector}, which sets `should_draw`
+     *     on the winners and reports the view spend and whether any candidate went unmet:
      *        - **Directional** → always selected (infinite score); view cost still charged.
      *        - **Local, off-screen** (`projected_area_px <= 0`) → skipped entirely.
      *        - **Local, in-view, invalid** → MUST draw. `is_invalid` means the committed layout
@@ -99,15 +101,16 @@ export class GPUSceneShadowmapContext {
      *          layout model — this flag fires only on first-draw.
      *        - **Local, in-view, valid** → compete for the remaining budget by score. Ordering
      *          is descending score so the most important (largest-on-screen, stalest) maps win.
-     *  5. **Commit selection.** On each winner we set `should_draw = true` and call
-     *     `map.update()` so its projection matrices reflect the current frame. The
-     *     `last_updated_frame_index` stamp is deferred to {@link draw} — it records when the
-     *     atlas contents become current, not when the projection is fitted.
+     *  5. **Fit the winners.** `map.update()` on each selected map, so its projection matrices
+     *     reflect the current frame. The `last_updated_frame_index` stamp is deferred to
+     *     {@link draw} — it records when the atlas contents become current, not when the
+     *     projection is fitted.
      *
      * Shadow records are NOT written here; they're written at the end of {@link draw} so the
      * shader reads slots that reflect any just-committed pending swaps within the same frame.
      *
-     * See {@link compute_shadowmap_update_score} for the scoring formula and rationale.
+     * See {@link compute_shadowmap_update_score} for the scoring formula and rationale, and
+     * {@link ShadowmapDrawSelector} for why the ordering is a heap drain rather than a sort.
      *
      * @param {Camera} main_camera used both for rendering the final frame and for projected-area
      *        computation and directional CSM fit; must be callable for `.update()`
@@ -160,6 +163,12 @@ export class GPUSceneShadowmapContext {
      * {@link LightCollection.version} hasn't moved — `light.casts_shadow` flips are not
      * tracked by version and are detected here.
      *
+     * Runs as three linear passes — mark, reclaim, allocate — over {@link #registry}, which owns
+     * the light -> map index and the marks. It used to scan the map array once per light to find
+     * out whether that light already had one, which made the pass quadratic: 148us per frame at
+     * 512 lights against 19us now, and 554us against 45us at 1024. See
+     * benchmark/reconcile.spec.js.
+     *
      * @returns {boolean} true when at least one map was added/evicted or at least one light's
      *          per-type shadow_id moved. The caller uses this to decide whether the light
      *          records need to be re-published (their `shadow_id` and CASTS_SHADOW_BIT may

package/src/shade/renderer/shadow/map/GPUSceneShadowmapContext.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"GPUSceneShadowmapContext.d.ts","sourceRoot":"","sources":["../../../../../../src/shade/renderer/shadow/map/GPUSceneShadowmapContext.js"],"names":[],"mappings":"AAsFA;;GAEG;AACH;IA8JI;;;;;;;;OAQG;IACH,8FA0DC;IAhOD,2BAAwG;IAExG;;;OAGG;IACH,SAFU,iBAAiB,CAEnB;IAQR;;;;;;;;OAQG;IACH,qBAFU,WAAW,CAED;IAsBpB;;;;;;;;OAQG;IACH,SAFU,OAAO,CAEF;IAEf;;;;;;;;;;OAUG;IACH,+BAFU,OAAO,CAEqB;IAqCtC;;OAEG;IACH,iCAEC;IAED;;;;;;OAMG;IACH,oCAEC;IAED;;;;;OAKG;IACH,oCAEC;IAgGD;;;;OAIG;IACH,uBAFa,YAAU,SAAS,CAI/B;IAED;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;OAwCG;IACH,0EAJW,MAAM,mBACN,UAAU,MAAM,CAAC,QA6G3B;IAyED;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;OA+BG;IACH,gDAiFC;IA6aD;;;;;;;;;;;;;;OAcG;IACH,kBALa,OAAO,CAkMnB;IAED;;;;OAIG;IACH,iBAHW,MAAM,GACJ,KAAK,CAWjB;IAED,gBAWC;;CACJ;oCAvyCmC,+DAA+D;kCAkBjE,oCAAoC;4BAG1C,2BAA2B;kBAtBrC,wCAAwC"}
+{"version":3,"file":"GPUSceneShadowmapContext.d.ts","sourceRoot":"","sources":["../../../../../../src/shade/renderer/shadow/map/GPUSceneShadowmapContext.js"],"names":[],"mappings":"AAwFA;;GAEG;AACH;IA8KI;;;;;;;;OAQG;IACH,8FA0DC;IAhPD,2BAAwG;IAExG;;;OAGG;IACH,SAFU,iBAAiB,CAEnB;IAQR;;;;;;;;OAQG;IACH,qBAFU,WAAW,CAED;IAsCpB;;;;;;;;OAQG;IACH,SAFU,OAAO,CAEF;IAEf;;;;;;;;;;OAUG;IACH,+BAFU,OAAO,CAEqB;IAqCtC;;OAEG;IACH,iCAEC;IAED;;;;;;OAMG;IACH,oCAEC;IAED;;;;;OAKG;IACH,oCAEC;IAgGD;;;;OAIG;IACH,uBAFa,YAAU,SAAS,CAI/B;IAED;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;OA2CG;IACH,0EAJW,MAAM,mBACN,UAAU,MAAM,CAAC,QAgE3B;IAyED;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;OA+BG;IACH,gDAiFC;IA6aD;;;;;;;;;;;;;;;;;;;;OAoBG;IACH,kBALa,OAAO,CAuOnB;IAED;;;;OAIG;IACH,iBAHW,MAAM,GACJ,KAAK,CAWjB;IAED,gBAYC;;CACJ;oCA3zCmC,+DAA+D;kCAkBjE,oCAAoC;4BAG1C,2BAA2B;kBAtBrC,wCAAwC"}