@woosh/meep-engine 2.98.3 → 2.99.1

package/build/meep.cjs

@@ -1150,6 +1150,7 @@ class Signal {
      * Please note that this will remove even all handlers, irrespective of where they were added from. If another script is attaching to the same signal, using this method will potentially break that code.
      * For most use cases, prefer to use {@link remove} method instead, or make use of {@link SignalBinding} if you need to keep track of multiple handlers
      * NOTE: Consider this method to be unsafe, only use it when you understand the implications
+     * @deprecated
      */
     removeAll() {
         const handlers = this.handlers;
@@ -97291,6 +97292,7 @@ ObjectPoolFactory.prototype.release = function (object) {
 };
 
 /**
+ * Will invoke A.equals(B) on members if such exists
  * @template T,R
  * @param {T[]} first
  * @param {R[]} second
@@ -97318,16 +97320,16 @@ function isArrayEqual(first, second) {
 
 
         if (a === undefined) {
-            //a is undefined, and B is something else
+            // A is undefined, and B is something else
             return false;
         }
 
         if (a === null) {
-            //a is null and B is something else
+            // A is null and B is something else
             return false;
         }
 
-        //try "equals" method
+        // try "equals" method
         if (typeof a.equals === "function") {
 
             if (!a.equals(b)) {

package/build/meep.module.js

@@ -1148,6 +1148,7 @@ class Signal {
      * Please note that this will remove even all handlers, irrespective of where they were added from. If another script is attaching to the same signal, using this method will potentially break that code.
      * For most use cases, prefer to use {@link remove} method instead, or make use of {@link SignalBinding} if you need to keep track of multiple handlers
      * NOTE: Consider this method to be unsafe, only use it when you understand the implications
+     * @deprecated
      */
     removeAll() {
         const handlers = this.handlers;
@@ -97289,6 +97290,7 @@ ObjectPoolFactory.prototype.release = function (object) {
 };
 
 /**
+ * Will invoke A.equals(B) on members if such exists
  * @template T,R
  * @param {T[]} first
  * @param {R[]} second
@@ -97316,16 +97318,16 @@ function isArrayEqual(first, second) {
 
 
         if (a === undefined) {
-            //a is undefined, and B is something else
+            // A is undefined, and B is something else
             return false;
         }
 
         if (a === null) {
-            //a is null and B is something else
+            // A is null and B is something else
             return false;
         }
 
-        //try "equals" method
+        // try "equals" method
         if (typeof a.equals === "function") {
 
             if (!a.equals(b)) {

package/package.json

@@ -5,7 +5,7 @@
   "description": "Fully featured ECS game engine written in JavaScript",
   "type": "module",
   "author": "Alexander Goldring",
-  "version": "2.98.3",
+  "version": "2.99.1",
   "main": "build/meep.module.js",
   "module": "build/meep.module.js",
   "exports": {

package/src/core/collection/array/isArrayEqual.d.ts

@@ -1,4 +1,5 @@
 /**
+ * Will invoke A.equals(B) on members if such exists
  * @template T,R
  * @param {T[]} first
  * @param {R[]} second

package/src/core/collection/array/isArrayEqual.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"isArrayEqual.d.ts","sourceRoot":"","sources":["../../../../../src/core/collection/array/isArrayEqual.js"],"names":[],"mappings":"AAAA;;;;;GAKG;AACH,6DAFY,OAAO,CAgDlB"}
+{"version":3,"file":"isArrayEqual.d.ts","sourceRoot":"","sources":["../../../../../src/core/collection/array/isArrayEqual.js"],"names":[],"mappings":"AAEA;;;;;;GAMG;AACH,6DAFY,OAAO,CAqDlB"}

package/src/core/collection/array/isArrayEqual.js

@@ -1,10 +1,18 @@
+import { assert } from "../../assert.js";
+
 /**
+ * Will invoke A.equals(B) on members if such exists
  * @template T,R
  * @param {T[]} first
  * @param {R[]} second
  * @return {boolean}
  */
 export function isArrayEqual(first, second) {
+    assert.defined(first, 'first');
+    assert.isArray(first, 'first');
+
+    assert.defined(second, 'second');
+    assert.isArray(second, 'second');
 
     const il = first.length;
 
@@ -26,16 +34,16 @@ export function isArrayEqual(first, second) {
 
 
         if (a === undefined) {
-            //a is undefined, and B is something else
+            // A is undefined, and B is something else
             return false;
         }
 
         if (a === null) {
-            //a is null and B is something else
+            // A is null and B is something else
             return false;
         }
 
-        //try "equals" method
+        // try "equals" method
         if (typeof a.equals === "function") {
 
             if (!a.equals(b)) {

package/src/core/events/signal/Signal.d.ts

@@ -39,14 +39,17 @@ export default class Signal<A = any, B = any, C = any, D = any, E = any, F = any
 
     send4(a: A, b: B, c: C, d: D): void
 
-    send5(a: A, b: B, c: C, d: D, e: E): void
-
     send6(a: A, b: B, c: C, d: D, e: E, f: F): void
 
+    send8(a: A, b: B, c: C, d: D, e: E, f: F, g: G, h: H): void
+
     /**
      * @deprecated use strongly typed dispatch methods instead (send0, send1 etc)
      */
     dispatch(...params: any[]): void
 
+    /**
+     * @deprecated
+     */
     removeAll(): void
 }

package/src/core/events/signal/Signal.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"Signal.d.ts","sourceRoot":"","sources":["../../../../../src/core/events/signal/Signal.js"],"names":[],"mappings":"AAslBA;;;;;;GAMG;AACH,yDALW,aAAa,EAAE,+BAGb,MAAM,CAoBlB;AAED;;;;;;GAMG;AACH,mEALW,aAAa,EAAE,0BAGb,MAAM,CAclB;AAiDD;;;;GAIG;AACH,2CAHW,aAAa,EAAE,sBA8BzB;AAlsBD;;;;GAIG;AACH;IACI;;;OAGG;IACH,iBAAc;IAEd;;;;OAIG;IACH,cAAU;IAWV;;;OAGG;IACH,yBAEC;IAfD;;;OAGG;IACH,sBAEC;IAYD;;;;OAIG;IACH,cAHW,MAAM;;KAAY,GAChB,IAAI,CAIhB;IAED;;;;OAIG;IACH,gBAHW,MAAM;;KAAY,GAChB,IAAI,CAIhB;IAED;;;;OAIG;IACH,gBAHW,MAAM;;KAAY,SAClB,OAAO,QAQjB;IAED;;;;OAIG;IACH,cAHW,MAAM;;KAAY,GAChB,OAAO,CAInB;IAGD;;;;;OAKG;IACH,4CAFa,OAAO,CAQnB;IAED,aAEC;IAED,eAEC;IAED;;;OAGG;IACH,eAFa,OAAO,CAInB;IAED;;;;OAIG;IACH,yCAQC;IAED;;;;OAIG;IACH,sCAYC;IAED;;;;;OAKG;IACH,oCAFa,OAAO,CAUnB;IAED;;;;;OAKG;IACH,kBAGC;IAED;;;OAGG;IACH,+BAQC;IAED;;;OAGG;IACH,cA4CC;IAED;;;;OAIG;IACH,sBA6CC;IAED;;;;OAIG;IACH,4BA4CC;IAED;;;;;OAKG;IACH,oCA4CC;IAED;;;;;;OAMG;IACH,4CA4CC;IAED;;;;;;;;OAQG;IACH,4DA4CC;IAED;;;;;;;;;;OAUG;IACH,4EA4CC;IAED;;;;OAIG;IACH,aAHW,MAAM,GACJ,MAAM,CAalB;IAIL;;;OAGG;IACH,mBAFU,OAAO,CAEQ;CAPxB;;8BApkBiD,oBAAoB"}
+{"version":3,"file":"Signal.d.ts","sourceRoot":"","sources":["../../../../../src/core/events/signal/Signal.js"],"names":[],"mappings":"AAulBA;;;;;;GAMG;AACH,yDALW,aAAa,EAAE,+BAGb,MAAM,CAoBlB;AAED;;;;;;GAMG;AACH,mEALW,aAAa,EAAE,0BAGb,MAAM,CAclB;AAiDD;;;;GAIG;AACH,2CAHW,aAAa,EAAE,sBA8BzB;AAnsBD;;;;GAIG;AACH;IACI;;;OAGG;IACH,iBAAc;IAEd;;;;OAIG;IACH,cAAU;IAWV;;;OAGG;IACH,yBAEC;IAfD;;;OAGG;IACH,sBAEC;IAYD;;;;OAIG;IACH,cAHW,MAAM;;KAAY,GAChB,IAAI,CAIhB;IAED;;;;OAIG;IACH,gBAHW,MAAM;;KAAY,GAChB,IAAI,CAIhB;IAED;;;;OAIG;IACH,gBAHW,MAAM;;KAAY,SAClB,OAAO,QAQjB;IAED;;;;OAIG;IACH,cAHW,MAAM;;KAAY,GAChB,OAAO,CAInB;IAGD;;;;;OAKG;IACH,4CAFa,OAAO,CAQnB;IAED,aAEC;IAED,eAEC;IAED;;;OAGG;IACH,eAFa,OAAO,CAInB;IAED;;;;OAIG;IACH,yCAQC;IAED;;;;OAIG;IACH,sCAYC;IAED;;;;;OAKG;IACH,oCAFa,OAAO,CAUnB;IAED;;;;;;OAMG;IACH,kBAGC;IAED;;;OAGG;IACH,+BAQC;IAED;;;OAGG;IACH,cA4CC;IAED;;;;OAIG;IACH,sBA6CC;IAED;;;;OAIG;IACH,4BA4CC;IAED;;;;;OAKG;IACH,oCA4CC;IAED;;;;;;OAMG;IACH,4CA4CC;IAED;;;;;;;;OAQG;IACH,4DA4CC;IAED;;;;;;;;;;OAUG;IACH,4EA4CC;IAED;;;;OAIG;IACH,aAHW,MAAM,GACJ,MAAM,CAalB;IAIL;;;OAGG;IACH,mBAFU,OAAO,CAEQ;CAPxB;;8BArkBiD,oBAAoB"}

package/src/core/events/signal/Signal.js

@@ -180,6 +180,7 @@ export class Signal {
      * Please note that this will remove even all handlers, irrespective of where they were added from. If another script is attaching to the same signal, using this method will potentially break that code.
      * For most use cases, prefer to use {@link remove} method instead, or make use of {@link SignalBinding} if you need to keep track of multiple handlers
      * NOTE: Consider this method to be unsafe, only use it when you understand the implications
+     * @deprecated
      */
     removeAll() {
         const handlers = this.handlers;

package/src/core/events/signal/Signal.spec.js

@@ -163,3 +163,91 @@ test("handlers should be executed in the order in which they are added", () => {
 
     expect(marks).toEqual([1, 2]);
 });
+
+
+test("send0", () => {
+
+    function handler() {
+
+        expect(arguments.length).toEqual(0);
+
+    }
+
+    const signal = new Signal();
+
+    signal.add(handler);
+
+    signal.send0();
+});
+test("send1", () => {
+
+    const call_param_list = [];
+
+    const signal = new Signal();
+
+    signal.add(Array.prototype.push, call_param_list);
+
+    signal.send1(7);
+
+    expect(call_param_list).toEqual([7]);
+});
+test("send2", () => {
+
+    const call_param_list = [];
+
+    const signal = new Signal();
+
+    signal.add(Array.prototype.push, call_param_list);
+
+    signal.send2(3, 7);
+
+    expect(call_param_list).toEqual([3, 7]);
+});
+test("send3", () => {
+
+    const call_param_list = [];
+
+    const signal = new Signal();
+
+    signal.add(Array.prototype.push, call_param_list);
+
+    signal.send3(3, 7, 11);
+
+    expect(call_param_list).toEqual([3, 7, 11]);
+});
+test("send4", () => {
+
+    const call_param_list = [];
+
+    const signal = new Signal();
+
+    signal.add(Array.prototype.push, call_param_list);
+
+    signal.send4(3, 7, 11, 13);
+
+    expect(call_param_list).toEqual([3, 7, 11, 13]);
+});
+test("send6", () => {
+
+    const call_param_list = [];
+
+    const signal = new Signal();
+
+    signal.add(Array.prototype.push, call_param_list);
+
+    signal.send6(3, 7, 11, 13, 17, 23);
+
+    expect(call_param_list).toEqual([3, 7, 11, 13, 17, 23]);
+});
+test("send8", () => {
+
+    const call_param_list = [];
+
+    const signal = new Signal();
+
+    signal.add(Array.prototype.push, call_param_list);
+
+    signal.send8(3, 7, 11, 13, 17, 23, 31, 37);
+
+    expect(call_param_list).toEqual([3, 7, 11, 13, 17, 23, 31, 37]);
+});

package/src/core/model/node-graph/NodeGraph.d.ts

@@ -1,26 +1,30 @@
 export class NodeGraph {
     /**
      * @private
+     * @readonly
      * @type {List<NodeInstance>}
      */
-    private nodes;
+    private readonly nodes;
     /**
      * @private
+     * @readonly
      * @type {List<Connection>}
      */
-    private connections;
+    private readonly connections;
     /**
      *
      * @type {IdPool}
+     * @readonly
      * @private
      */
-    private __idpNodes;
+    private readonly __idpNodes;
     /**
      *
      * @type {IdPool}
+     * @readonly
      * @private
      */
-    private __idpConnections;
+    private readonly __idpConnections;
     /**
      * @readonly
      */

package/src/core/model/node-graph/NodeGraph.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"NodeGraph.d.ts","sourceRoot":"","sources":["../../../../../src/core/model/node-graph/NodeGraph.js"],"names":[],"mappings":"AASA;IAEI;;;OAGG;IACH,cAAmB;IAEnB;;;OAGG;IACH,oBAAyB;IAEzB;;;;OAIG;IACH,mBAA0B;IAE1B;;;;OAIG;IACH,yBAAgC;IAEhC;;OAEG;IACH;QACI;;;WAGG;;QAGH;;;WAGG;;QAGH;;;WAGG;;QAGH;;;WAGG;;MAEL;IAEF;;OAEG;IACH,cAMC;IAED;;;OAGG;IACH,YAFW,SAAS,QAYnB;IAED;;;OAGG;IACH,SAFa,SAAS,CAQrB;IAED;;;;;;OAMG;IACH,aAHW,SAAS,GACP;QAAC,WAAW,EAAC,UAAU,EAAE,CAAC;QAAC,KAAK,EAAC,YAAY,EAAE,CAAA;KAAC,CAY5D;IAED;;;;;;;;OAQG;IACH,sCAJW,YAAY,EAAE,GAEZ;QAAC,WAAW,EAAC,UAAU,EAAE,CAAC;QAAC,KAAK,EAAC,YAAY,EAAE,CAAA;KAAC,CAwE5D;IAED;;;;OAIG;IACH,8BAHoB,YAAY,+BAK/B;IAED;;;;OAIG;IACH,oCAHoB,UAAU,+BAK7B;IAED;;;OAGG;IACH,YAFY,YAAY,EAAE,CAIzB;IAED;;;OAGG;IACH,kBAFY,UAAU,EAAE,CAIvB;IAED;;;;OAIG;IACH,cAHW,YAAY,GACV,OAAO,CAenB;IAED;;;;OAIG;IACH,qDAFa,YAAY,EAAE,CAqB1B;IAED;;;;OAIG;IACH,0DAFa,YAAY,EAAE,CAqB1B;IAED;;;;OAIG;IACH,YAHW,MAAM,GACJ,YAAY,GAAC,SAAS,CAkBlC;IAED;;;;OAIG;IACH,gBAHW,MAAM,GACJ,YAAY,CAUxB;IAED;;;;OAIG;IACH,kBAHW,MAAM,GACJ,UAAU,GAAC,SAAS,CAgBhC;IAED;;;;;OAKG;IACH,+BAJW,MAAM,WACN,MAAM,GACJ,4BAA0B,SAAS,CAY/C;IAED;;;;OAIG;IACH,mCAFa,MAAM,CAclB;IAED;;;OAGG;IACH,cAFW,YAAY,QAgBtB;IAED;;;;OAIG;IACH,eAHW,MAAM,GACJ,OAAO,CA4BnB;IAED;;;;;;;;OAQG;IACH,uCANW,MAAM,cACN,MAAM,cACN,MAAM,cACN,MAAM,GACJ,MAAM,CAqClB;IAED;;;;;;;OAOG;IACH,6BANW,MAAM,cACN,MAAM,cACN,MAAM,cACN,MAAM,GACJ,MAAM,CAsDlB;IAED;;;;OAIG;IACH,qBAHW,MAAM,GACJ,OAAO,CAuBnB;IAED;;;;;OAKG;IACH,iCAJW,MAAM,UACN,MAAM,EAAE,GACN,MAAM,CAyBlB;IAGL;;;OAGG;IACH,sBAFU,OAAO,CAEc;CAN9B;6BA5mB0B,wBAAwB;2BAD1B,iBAAiB"}
+{"version":3,"file":"NodeGraph.d.ts","sourceRoot":"","sources":["../../../../../src/core/model/node-graph/NodeGraph.js"],"names":[],"mappings":"AASA;IAEI;;;;OAIG;IACH,uBAAmB;IAEnB;;;;OAIG;IACH,6BAAyB;IAEzB;;;;;OAKG;IACH,4BAA0B;IAE1B;;;;;OAKG;IACH,kCAAgC;IAEhC;;OAEG;IACH;QACI;;;WAGG;;QAGH;;;WAGG;;QAGH;;;WAGG;;QAGH;;;WAGG;;MAEL;IAEF;;OAEG;IACH,cAMC;IAED;;;OAGG;IACH,YAFW,SAAS,QAYnB;IAED;;;OAGG;IACH,SAFa,SAAS,CAQrB;IAED;;;;;;OAMG;IACH,aAHW,SAAS,GACP;QAAC,WAAW,EAAC,UAAU,EAAE,CAAC;QAAC,KAAK,EAAC,YAAY,EAAE,CAAA;KAAC,CAe5D;IAED;;;;;;;;OAQG;IACH,sCAJW,YAAY,EAAE,GAEZ;QAAC,WAAW,EAAC,UAAU,EAAE,CAAC;QAAC,KAAK,EAAC,YAAY,EAAE,CAAA;KAAC,CAmF5D;IAED;;;;OAIG;IACH,8BAHoB,YAAY,+BAK/B;IAED;;;;OAIG;IACH,oCAHoB,UAAU,+BAK7B;IAED;;;OAGG;IACH,YAFY,YAAY,EAAE,CAIzB;IAED;;;OAGG;IACH,kBAFY,UAAU,EAAE,CAIvB;IAED;;;;OAIG;IACH,cAHW,YAAY,GACV,OAAO,CAenB;IAED;;;;OAIG;IACH,qDAFa,YAAY,EAAE,CAqB1B;IAED;;;;OAIG;IACH,0DAFa,YAAY,EAAE,CAqB1B;IAED;;;;OAIG;IACH,YAHW,MAAM,GACJ,YAAY,GAAC,SAAS,CAkBlC;IAED;;;;OAIG;IACH,gBAHW,MAAM,GACJ,YAAY,CAUxB;IAED;;;;OAIG;IACH,kBAHW,MAAM,GACJ,UAAU,GAAC,SAAS,CAgBhC;IAED;;;;;OAKG;IACH,+BAJW,MAAM,WACN,MAAM,GACJ,4BAA0B,SAAS,CAY/C;IAED;;;;OAIG;IACH,mCAFa,MAAM,CAclB;IAED;;;OAGG;IACH,cAFW,YAAY,QAgBtB;IAED;;;;OAIG;IACH,eAHW,MAAM,GACJ,OAAO,CA4BnB;IAED;;;;;;;;OAQG;IACH,uCANW,MAAM,cACN,MAAM,cACN,MAAM,cACN,MAAM,GACJ,MAAM,CAqClB;IAED;;;;;;;OAOG;IACH,6BANW,MAAM,cACN,MAAM,cACN,MAAM,cACN,MAAM,GACJ,MAAM,CAoDlB;IAED;;;;OAIG;IACH,qBAHW,MAAM,GACJ,OAAO,CAuBnB;IAED;;;;;OAKG;IACH,iCAJW,MAAM,UACN,MAAM,EAAE,GACN,MAAM,CAyBlB;IAGL;;;OAGG;IACH,sBAFU,OAAO,CAEc;CAN9B;6BA5nB4B,wBAAwB;2BAD1B,iBAAiB"}

package/src/core/model/node-graph/NodeGraph.js

@@ -1,22 +1,24 @@
-import {assert} from "../../assert.js";
-import {array_push_if_unique} from "../../collection/array/array_push_if_unique.js";
-import {array_remove_first} from "../../collection/array/array_remove_first.js";
+import { assert } from "../../assert.js";
+import { array_push_if_unique } from "../../collection/array/array_push_if_unique.js";
+import { array_remove_first } from "../../collection/array/array_remove_first.js";
 import List from "../../collection/list/List.js";
 import IdPool from "../../IdPool.js";
-import {Connection} from "./Connection.js";
-import {NodeInstance} from "./node/NodeInstance.js";
-import {PortDirection} from "./node/PortDirection.js";
+import { Connection } from "./Connection.js";
+import { NodeInstance } from "./node/NodeInstance.js";
+import { PortDirection } from "./node/PortDirection.js";
 
 export class NodeGraph {
 
     /**
      * @private
+     * @readonly
      * @type {List<NodeInstance>}
      */
     nodes = new List();
 
     /**
      * @private
+     * @readonly
      * @type {List<Connection>}
      */
     connections = new List();
@@ -24,6 +26,7 @@ export class NodeGraph {
     /**
      *
      * @type {IdPool}
+     * @readonly
      * @private
      */
     __idpNodes = new IdPool();
@@ -31,6 +34,7 @@ export class NodeGraph {
     /**
      *
      * @type {IdPool}
+     * @readonly
      * @private
      */
     __idpConnections = new IdPool();
@@ -111,6 +115,9 @@ export class NodeGraph {
      * @returns {{connections:Connection[], nodes:NodeInstance[]}}
      */
     merge(other) {
+        assert.defined(other, 'other');
+        assert.notNull(other, 'other');
+
         if (other === this) {
             // can't merge with self, invalid operation
             throw new Error("Can't merge with self, invalid operation");
@@ -131,7 +138,18 @@ export class NodeGraph {
      * @param {Connection[]} [connections]
      * @returns {{connections:Connection[], nodes:NodeInstance[]}} local created instances
      */
-    mergeFragment({nodes, connections = []}) {
+    mergeFragment({
+                      nodes,
+                      connections = []
+                  }) {
+
+        assert.defined(nodes, 'nodes');
+        assert.notNull(nodes, 'nodes');
+        assert.isArray(nodes, 'nodes');
+
+        assert.defined(connections, 'connections');
+        assert.notNull(connections, 'connections');
+        assert.isArray(connections, 'connections');
 
         const previous_node_count = this.nodes.length;
         const previous_connection_count = this.connections.length;
@@ -518,8 +536,6 @@ export class NodeGraph {
         assert.isNonNegativeInteger(targetNode, 'targetNode');
         assert.isNonNegativeInteger(targetPort, 'targetPort');
 
-        //TODO validate if connection already exists
-
         const sourceNodeInstance = this.getNode(sourceNode);
 
         if (sourceNodeInstance === undefined) {
@@ -536,13 +552,13 @@ export class NodeGraph {
         const sourceEndpoint = sourceNodeInstance.getEndpoint(sourcePort);
 
         if (sourceEndpoint === undefined) {
-            throw new Error(`Source port '${sourcePort}' not found`);
+            throw new Error(`Source port '${sourcePort}' not found on ${sourceNodeInstance}`);
         }
 
         const targetEndpoint = targetNodeInstance.getEndpoint(targetPort);
 
         if (targetEndpoint === undefined) {
-            throw new Error(`Target port '${targetPort}' not found`);
+            throw new Error(`Target port '${targetPort}' not found on ${targetNodeInstance}`);
         }
 
         //create connection

package/src/core/model/node-graph/node/NodeDescription.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"NodeDescription.d.ts","sourceRoot":"","sources":["../../../../../../src/core/model/node-graph/node/NodeDescription.js"],"names":[],"mappings":"AAyCA;IACI;;;OAGG;IACH,MAFU,MAAM,CAEN;IAEV;;;;;;OAMG;IACH,IAFU,MAAM,CAEO;IAEvB;;;OAGG;IACH,iBAFU,IAAI,EAAE,CAEL;IAEX;;;OAGG;IACH,YAFU,wBAAwB,EAAE,CAEpB;IAEhB;;OAEG;IACH;QACI;;;WAGG;4BADO,OAAO,IAAI,CAAC;QAGtB;;;WAGG;8BADO,OAAO,IAAI,CAAC;MAGxB;IAEF;;;;OAIG;IACH,4CAEC;IAED;;;OAGG;IACH,uBAEC;IAED;;;OAGG;IACH,sBAEC;IAED;;;;;;OAMG;IACH,sBALW,MAAM,QACN,qBAAqB,iBACrB,MAAM,GAAC,OAAO,GAAC,MAAM,GACnB,MAAM,CA0ClB;IAED;;;;OAIG;IACH,iBAHW,MAAM,GACJ,wBAAwB,CAiBpC;IAGD;;;;;;OAMG;IACH,oDAHW,aAAa,GACX,MAAM,CA2BlB;IAED;;;;OAIG;IACH,eAHW,MAAM,GACJ,OAAO,CAuBnB;IAED;;;;OAIG;IACH,gBAHW,MAAM,GACJ,IAAI,GAAC,IAAI,CAgBrB;IAED;;;;OAIG;IACH,qBAHW,MAAM,GACL,IAAI,EAAE,CAwBjB;IAED;;;;OAIG;IACH,+BAHW,aAAa,GACZ,IAAI,EAAE,CAuBjB;IAED;;;;;OAKG;IACH,iCAJW,MAAM,aACN,aAAa,GACZ,IAAI,GAAC,SAAS,CAmBzB;IAED;;;OAGG;IACH,YAFa,IAAI,EAAE,CAIlB;IAED;;;;OAIG;IACH,cAHW,eAAe,GACb,OAAO,CAOnB;IAED,mBAEC;IAED;;;;MAMC;IAED;;;;;;OAMG;IACH;;;;qCAIC;IAKL;;;OAGG;IACH,4BAFU,OAAO,CAE0B;CAR1C;;;;qBAjYoB,WAAW;yCADS,yCAAyC;mBAH/D,kCAAkC;sCAEf,sCAAsC;8BAG9C,oBAAoB"}
+{"version":3,"file":"NodeDescription.d.ts","sourceRoot":"","sources":["../../../../../../src/core/model/node-graph/node/NodeDescription.js"],"names":[],"mappings":"AAwCA;IACI;;;OAGG;IACH,MAFU,MAAM,CAEN;IAEV;;;;;;OAMG;IACH,IAFU,MAAM,CAEO;IAEvB;;;OAGG;IACH,iBAFU,IAAI,EAAE,CAEL;IAEX;;;OAGG;IACH,YAFU,wBAAwB,EAAE,CAEpB;IAEhB;;OAEG;IACH;QACI;;;WAGG;4BADO,OAAO,IAAI,CAAC;QAGtB;;;WAGG;8BADO,OAAO,IAAI,CAAC;MAGxB;IAEF;;;;OAIG;IACH,4CAEC;IAED;;;OAGG;IACH,uBAEC;IAED;;;OAGG;IACH,sBAEC;IAED;;;;;;OAMG;IACH,sBALW,MAAM,QACN,qBAAqB,iBACrB,MAAM,GAAC,OAAO,GAAC,MAAM,GACnB,MAAM,CA0ClB;IAED;;;;OAIG;IACH,iBAHW,MAAM,GACJ,wBAAwB,CAiBpC;IAGD;;;;;;OAMG;IACH,oDAHW,aAAa,GACX,MAAM,CA2BlB;IAED;;;;OAIG;IACH,eAHW,MAAM,GACJ,OAAO,CAuBnB;IAED;;;;OAIG;IACH,gBAHW,MAAM,GACJ,IAAI,GAAC,IAAI,CAgBrB;IAED;;;;OAIG;IACH,qBAHW,MAAM,GACL,IAAI,EAAE,CAwBjB;IAED;;;;OAIG;IACH,+BAHW,aAAa,GACZ,IAAI,EAAE,CAuBjB;IAED;;;;;OAKG;IACH,iCAJW,MAAM,aACN,aAAa,GACZ,IAAI,GAAC,SAAS,CAmBzB;IAED;;;OAGG;IACH,YAFa,IAAI,EAAE,CAIlB;IAED;;;;OAIG;IACH,cAHW,eAAe,GACb,OAAO,CAYnB;IAED,mBAEC;IAED;;;;MAMC;IAED;;;;;;OAMG;IACH,8BALW,EAAE,gCAaZ;IAKL;;;OAGG;IACH,4BAFU,OAAO,CAE0B;CAR1C;;;;qBAxYoB,WAAW;yCADS,yCAAyC;mBAH/D,kCAAkC;sCAEf,sCAAsC;8BAG9C,oBAAoB"}

package/src/core/model/node-graph/node/NodeDescription.js

@@ -1,4 +1,5 @@
 import { assert } from "../../../assert.js";
+import { BitSet } from "../../../binary/BitSet.js";
 import { isArrayEqual } from "../../../collection/array/isArrayEqual.js";
 import Signal from "../../../events/signal/Signal.js";
 import { invokeObjectToJSON } from "../../object/invokeObjectToJSON.js";
@@ -9,28 +10,26 @@ import { PortDirection } from "./PortDirection.js";
 
 
 /**
- * @template T
  * @private
- * @param {T[]} things
+ * @param {{id:number}[]} things
  * @returns {number}
  */
 function pickNewSetId(things) {
 
+    const used = new BitSet();
 
     const n = things.length;
 
-    let r = n;
-
     for (let i = 0; i < n; i++) {
 
-        if (things[i] === undefined) {
-            r = i;
-            break;
+        const thing = things[i];
+        if (thing !== undefined) {
+            used.set(thing.id, true);
         }
 
     }
 
-    return r;
+    return used.nextClearBit(0);
 }
 
 /**
@@ -359,6 +358,11 @@ export class NodeDescription {
      * @returns {boolean}
      */
     equals(other) {
+        if (this === other) {
+            // fast shortcut
+            return true;
+        }
+
         return this.id === other.id
             && this.name === other.name
             && isArrayEqual(this.ports, other.ports)
@@ -379,12 +383,16 @@ export class NodeDescription {
 
     /**
      *
-     * @param ports
-     * @param id
-     * @param name
+     * @param {[]} ports
+     * @param {number} id
+     * @param {string} name
      * @param {NodeRegistry} registry
      */
-    fromJSON({ ports, id, name }, registry) {
+    fromJSON({ ports = [], id, name = "" }, registry) {
+        assert.isNonNegativeInteger(id, 'id');
+        assert.isString(name, 'name');
+        assert.isArray(ports, 'ports');
+
         this.id = id;
         this.name = name;
         this.ports = ports.map(p => Port.fromJSON(p, registry));

package/src/core/model/node-graph/node/NodeDescription.spec.js

@@ -57,9 +57,25 @@ test("delete port", () => {
     expect(node.getPorts()).toEqual([]);
 });
 
+test("id uniqueness is preserved when ports are added and deleted out of order", () => {
+
+    const node = new NodeDescription();
+
+    const a = node.createPort(DUMMY_TYPE, "a", PortDirection.In);
+    const b = node.createPort(DUMMY_TYPE, "b", PortDirection.In);
+    const c = node.createPort(DUMMY_TYPE, "c", PortDirection.In);
+
+    node.deletePort(b);
+
+    const d = node.createPort(DUMMY_TYPE, "d", PortDirection.In);
+
+    expect(d).toEqual(b);
+
+});
+
 test("toString", () => {
     const node = new NodeDescription();
 
     expect(typeof node.toString()).toBe("string");
     expect(node.toString().length).toBeGreaterThan(0);
-});
+});

package/src/core/model/node-graph/node/NodeInstance.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"NodeInstance.d.ts","sourceRoot":"","sources":["../../../../../../src/core/model/node-graph/node/NodeInstance.js"],"names":[],"mappings":"AAcA;;;;GAIG;AACH;IAEI;;;;OAIG;IACH,aAFU,MAAM,CAEE;IAElB;;;OAGG;IACH,6BAAmB;IAEnB;;;OAGG;IACH,WAFU,yBAAyB,EAAE,CAEtB;IAEf;;;OAGG;IACH,gBAAgB;IAEhB;;;OAGG;IACH,qBAAmB;IAEnB;;;OAGG;IACH,aAFU,gBAAgB,CAED;IAEzB;;;;;;OAMG;IACH,wBAFU,MAAM,CAEE;IAElB;;OAEG;IACH;QACI;;;WAGG;mCADO,OAAO,MAAM,WAAO;QAG9B;;;WAGG;iCADO,OAAO,MAAM,MAAI;QAG3B;;;WAGG;mCADO,OAAO,MAAM,MAAI;QAI3B;;;;WAIG;qCADO,wCAAwC;MAGpD;IAEF;;;;;;OAMG;IACH,yBALW,MAAM,aACN,aAAa,UACb,YAAY,GACV,MAAM,CAsBlB;IAED;;;OAGG;IACH,gDAEC;IAED;;;OAGG;IACH,+CAEC;IAGD;;;OAGG;IACH,mCAEC;IAED;;;;OAIG;IACH,kCAEC;IAED;;;;OAIG;IACH,mBAHW,MAAM,oBAKhB;IAED;;;;OAIG;IACH,mBAHW,MAAM,OAKhB;IAED;;;;OAIG;IACH,yBAHW,MAAM,KAOhB;IAED;;;;OAIG;IACH,2BAHW,MAAM,oBAmChB;IAED;;;;OAIG;IACH,oBAHW,MAAM,GACJ,OAAO,CAkBnB;IAED;;;OAGG;IACH,uCAQC;IAED,wBAIC;IAED;;;OAGG;IACH,mDAqCC;IAED;;;;OAIG;IACH,kBAHW,MAAM,GACJ,yBAAyB,GAAC,SAAS,CAe/C;IAED,eAEC;IAED;;;;OAIG;IACH,cAHW,YAAY,GACV,OAAO,CAQnB;IAED,mBAEC;IAIL;;;OAGG;IACH,yBAFU,OAAO,CAEoB;CAPpC;0CA3VyC,gCAAgC;iBAHzD,kCAAkC;mBAChC,kCAAkC;8BAGvB,oBAAoB"}
+{"version":3,"file":"NodeInstance.d.ts","sourceRoot":"","sources":["../../../../../../src/core/model/node-graph/node/NodeInstance.js"],"names":[],"mappings":"AAcA;;;;GAIG;AACH;IAEI;;;;OAIG;IACH,aAFU,MAAM,CAEE;IAElB;;;OAGG;IACH,6BAAmB;IAEnB;;;OAGG;IACH,WAFU,yBAAyB,EAAE,CAEtB;IAEf;;;OAGG;IACH,gBAAgB;IAEhB;;;OAGG;IACH,qBAAmB;IAEnB;;;OAGG;IACH,aAFU,gBAAgB,CAED;IAEzB;;;;;;OAMG;IACH,wBAFU,MAAM,CAEE;IAElB;;OAEG;IACH;QACI;;;WAGG;mCADO,OAAO,MAAM,WAAO;QAG9B;;;WAGG;iCADO,OAAO,MAAM,MAAI;QAG3B;;;WAGG;mCADO,OAAO,MAAM,MAAI;QAI3B;;;;WAIG;qCADO,yCAAyC,YAAY,CAAC;MAGlE;IAEF;;;;;;OAMG;IACH,yBALW,MAAM,aACN,aAAa,UACb,YAAY,GACV,MAAM,CAsBlB;IAED;;;OAGG;IACH,gDAEC;IAED;;;OAGG;IACH,+CAEC;IAGD;;;OAGG;IACH,mCAEC;IAED;;;;OAIG;IACH,kCAEC;IAED;;;;OAIG;IACH,mBAHW,MAAM,oBAKhB;IAED;;;;OAIG;IACH,mBAHW,MAAM,OAKhB;IAED;;;;OAIG;IACH,yBAHW,MAAM,KAOhB;IAED;;;;OAIG;IACH,2BAHW,MAAM,oBAmChB;IAED;;;;OAIG;IACH,oBAHW,MAAM,GACJ,OAAO,CAkBnB;IAED;;;OAGG;IACH,uCAQC;IAED,wBAIC;IAED;;;OAGG;IACH,mDAqCC;IAED;;;;OAIG;IACH,kBAHW,MAAM,GACJ,yBAAyB,GAAC,SAAS,CAe/C;IAED,eAEC;IAED;;;;OAIG;IACH,cAHW,YAAY,GACV,OAAO,CAQnB;IAED,mBAEC;IAIL;;;OAGG;IACH,yBAFU,OAAO,CAEoB;CAPpC;0CA3VyC,gCAAgC;iBAHzD,kCAAkC;mBAChC,kCAAkC;8BAGvB,oBAAoB"}

package/src/core/model/node-graph/node/NodeInstance.js

@@ -86,9 +86,9 @@ export class NodeInstance {
         parameterRemoved: new Signal(),
 
         /**
-         * fires: (newDescription:NodeDescription, oldDescription:NodeDescription|null)
+         * fires: (newDescription:NodeDescription, oldDescription:NodeDescription|null, this)
          * @readonly
-         * @type {Signal<NodeDescription, NodeDescription>}
+         * @type {Signal<NodeDescription, NodeDescription, NodeInstance>}
          */
         descriptionChanged: new Signal()
     };
@@ -307,7 +307,7 @@ export class NodeInstance {
             this.parameters[pd.id] = pd.defaultValue;
         });
 
-        this.on.descriptionChanged.send2(description, old_description);
+        this.on.descriptionChanged.send3(description, old_description, this);
     }
 
     /**