@woosh/meep-engine 2.97.0 → 2.98.1

package/package.json

@@ -5,7 +5,7 @@
   "description": "Fully featured ECS game engine written in JavaScript",
   "type": "module",
   "author": "Alexander Goldring",
-  "version": "2.97.0",
+  "version": "2.98.1",
   "main": "build/meep.module.js",
   "module": "build/meep.module.js",
   "exports": {

package/src/core/bvh2/bvh3/query/bvh_query_leaves_ray.js

@@ -76,8 +76,8 @@ export function bvh_query_leaves_ray(
         if (child_1 !== NULL_NODE) {
 
             // this is not a leaf node, push children onto traversal stack
-            stack[stack.pointer++] = child_1;
             stack[stack.pointer++] = uint32[address + COLUMN_CHILD_2];
+            stack[stack.pointer++] = child_1;
 
         } else {
             // leaf node

package/src/core/bvh2/bvh3/query/bvh_query_user_data_generic.js

@@ -65,8 +65,8 @@ export function bvh_query_user_data_generic(
             const child2 = bvh.node_get_child2(node);
 
             // write to stack in reverse order, so that fist child ends up being visited first
-            stack[stack.pointer++] = child1;
             stack[stack.pointer++] = child2;
+            stack[stack.pointer++] = child1;
 
         } else {
             // leaf node

package/src/core/bvh2/bvh3/query/bvh_query_user_data_ray.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"bvh_query_user_data_ray.d.ts","sourceRoot":"","sources":["../../../../../../src/core/bvh2/bvh3/query/bvh_query_user_data_ray.js"],"names":[],"mappings":"AAOA;;;;;;;;;;;;;GAaG;AACH,wDAXW,MAAM,UACN,MAAM,EAAE,iBACR,MAAM,YACN,MAAM,YACN,MAAM,YACN,MAAM,eACN,MAAM,eACN,MAAM,eACN,MAAM,GACJ,MAAM,CAsElB"}
+{"version":3,"file":"bvh_query_user_data_ray.d.ts","sourceRoot":"","sources":["../../../../../../src/core/bvh2/bvh3/query/bvh_query_user_data_ray.js"],"names":[],"mappings":"AAMA;;;;;;;;;;;;;GAaG;AACH,wDAXW,MAAM,UACN,MAAM,EAAE,iBACR,MAAM,YACN,MAAM,YACN,MAAM,YACN,MAAM,eACN,MAAM,eACN,MAAM,eACN,MAAM,GACJ,MAAM,CAwElB"}

package/src/core/bvh2/bvh3/query/bvh_query_user_data_ray.js

@@ -4,7 +4,6 @@ import { COLUMN_CHILD_1, COLUMN_CHILD_2, COLUMN_USER_DATA, ELEMENT_WORD_COUNT, N
 
 const stack = SCRATCH_UINT32_TRAVERSAL_STACK;
 
-
 /**
  *
  * @param {BVH} bvh
@@ -76,8 +75,10 @@ export function bvh_query_user_data_ray(
         if (child_1 !== NULL_NODE) {
 
             // this is not a leaf node, push children onto traversal stack
+            const child_2 = uint32[address + COLUMN_CHILD_2];
+
+            stack[stack.pointer++] = child_2;
             stack[stack.pointer++] = child_1;
-            stack[stack.pointer++] = uint32[address + COLUMN_CHILD_2];
 
         } else {
             // leaf node

package/src/core/collection/array/arrayQuickSort.js

@@ -1,4 +1,4 @@
-import { arraySwapElements } from "./arraySwapElements.js";
+import { array_swap_one } from "./array_swap_one.js";
 
 const stack = [];
 
@@ -16,7 +16,7 @@ export function arrayQuickSort(
     data,
     score_function, score_function_context,
     start, end,
-    swap_operator = arraySwapElements, swap_context = undefined
+    swap_operator = array_swap_one, swap_context = undefined
 ) {
     if (start >= end) {
         // section of 0 size, nothing to sort

package/src/core/collection/array/array_compute_max.d.ts

@@ -0,0 +1,9 @@
+/**
+ * @template V
+ * @param {V[]} data
+ * @param {number} [start]
+ * @param {number} [end]
+ * @return {number}
+ */
+export function array_compute_max<V>(data: V[], start?: number, end?: number): number;
+//# sourceMappingURL=array_compute_max.d.ts.map

package/src/core/collection/array/array_compute_max.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"array_compute_max.d.ts","sourceRoot":"","sources":["../../../../../src/core/collection/array/array_compute_max.js"],"names":[],"mappings":"AAAA;;;;;;GAMG;AACH,wDAJW,MAAM,QACN,MAAM,GACL,MAAM,CAajB"}

package/src/core/collection/array/{computeArrayMax.js → array_compute_max.js}

@@ -5,7 +5,7 @@
  * @param {number} [end]
  * @return {number}
  */
-export function computeArrayMax(data, start = 0, end = data.length) {
+export function array_compute_max(data, start = 0, end = data.length) {
     let result = Number.NEGATIVE_INFINITY;
 
     for (let i = start; i < end; i++) {

package/src/core/collection/array/array_compute_min.d.ts

@@ -0,0 +1,9 @@
+/**
+ * @template V
+ * @param {V[]} data
+ * @param {number} [start]
+ * @param {number} [end]
+ * @return {number}
+ */
+export function array_compute_min<V>(data: V[], start?: number, end?: number): number;
+//# sourceMappingURL=array_compute_min.d.ts.map

package/src/core/collection/array/array_compute_min.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"array_compute_min.d.ts","sourceRoot":"","sources":["../../../../../src/core/collection/array/array_compute_min.js"],"names":[],"mappings":"AAAA;;;;;;GAMG;AACH,wDAJW,MAAM,QACN,MAAM,GACL,MAAM,CAajB"}

package/src/core/collection/array/{computeArrayMin.js → array_compute_min.js}

@@ -5,7 +5,7 @@
  * @param {number} [end]
  * @return {number}
  */
-export function computeArrayMin(data, start = 0, end = data.length) {
+export function array_compute_min(data, start = 0, end = data.length) {
     let result = Number.POSITIVE_INFINITY;
 
     for (let i = start; i < end; i++) {

package/src/core/collection/array/array_compute_min_max.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"array_compute_min_max.d.ts","sourceRoot":"","sources":["../../../../../src/core/collection/array/array_compute_min_max.js"],"names":[],"mappings":"AAGA;;;;GAIG;AACH,4CAHW,MAAM,EAAE,GACP,MAAM,EAAE,CAanB"}
+{"version":3,"file":"array_compute_min_max.d.ts","sourceRoot":"","sources":["../../../../../src/core/collection/array/array_compute_min_max.js"],"names":[],"mappings":"AAGA;;;;GAIG;AACH,4CAHW,MAAM,EAAE,GACP,MAAM,EAAE,CAcnB"}

package/src/core/collection/array/array_compute_min_max.js

@@ -11,6 +11,7 @@ export function array_compute_min_max(data) {
 
     let min = Number.POSITIVE_INFINITY;
     let max = Number.NEGATIVE_INFINITY;
+
     for (let i = 0; i < point_count; i++) {
         min = min2(data[i], min);
         max = max2(data[i], max);

package/src/core/collection/array/array_swap.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"array_swap.d.ts","sourceRoot":"","sources":["../../../../../src/core/collection/array/array_swap.js"],"names":[],"mappings":"AAAA;;;;;;;GAOG;AACH,gDALW,MAAM,oBAEN,MAAM,UACN,MAAM,QAehB"}
+{"version":3,"file":"array_swap.d.ts","sourceRoot":"","sources":["../../../../../src/core/collection/array/array_swap.js"],"names":[],"mappings":"AAAA;;;;;;;GAOG;AACH,gDALW,MAAM,oBAEN,MAAM,UACN,MAAM,QAkBhB"}

package/src/core/collection/array/array_swap.js

@@ -6,17 +6,20 @@
  * @param {number} b_offset
  * @param {number} length How many elements should be moved
  */
-export function array_swap(a, a_offset, b, b_offset, length) {
+export function array_swap(
+    a, a_offset,
+    b, b_offset,
+    length
+) {
 
-    let i, j, k;
+    for (let k = 0; k < length; k++) {
+        const i = a_offset + k;
+        const j = b_offset + k;
 
-    for (k = 0; k < length; k++) {
-        i = a_offset + k;
-        j = b_offset + k;
-
-        const t = b[j];
+        const swap = b[j];
 
         b[j] = a[i];
-        a[i] = t;
+        a[i] = swap;
     }
+
 }

package/src/core/collection/array/array_swap_one.d.ts

@@ -0,0 +1,8 @@
+/**
+ * @template T
+ * @param {T[]} array
+ * @param {number} index0
+ * @param {number} index1
+ */
+export function array_swap_one<T>(array: T[], index0: number, index1: number): void;
+//# sourceMappingURL=array_swap_one.d.ts.map

package/src/core/collection/array/array_swap_one.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"array_swap_one.d.ts","sourceRoot":"","sources":["../../../../../src/core/collection/array/array_swap_one.js"],"names":[],"mappings":"AAAA;;;;;GAKG;AACH,sDAHW,MAAM,UACN,MAAM,QAOhB"}

package/src/core/collection/array/{arraySwapElements.js → array_swap_one.js}

@@ -4,7 +4,7 @@
  * @param {number} index0
  * @param {number} index1
  */
-export function arraySwapElements(array, index0, index1) {
+export function array_swap_one(array, index0, index1) {
     const t = array[index0];
 
     array[index0] = array[index1];

package/src/core/collection/array/iterator/AbstractArrayIterator.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"AbstractArrayIterator.d.ts","sourceRoot":"","sources":["../../../../../../src/core/collection/array/iterator/AbstractArrayIterator.js"],"names":[],"mappings":"AAAA;;GAEG;AACH;IACI;;;OAGG;IACH,iBAFW,CAAC,EAAE,QASb;IANG;;;;OAIG;IACH,kBAHU,CAAC,EAAE,CAGK;IAGtB;;OAEG;IACH,aAFW;QAAC,KAAK,EAAC,CAAC,CAAC;QAAC,IAAI,EAAC,OAAO,CAAA;KAAC,QAIjC;CACJ"}

package/src/core/collection/array/iterator/ArrayIteratorRandom.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"ArrayIteratorRandom.d.ts","sourceRoot":"","sources":["../../../../../../src/core/collection/array/iterator/ArrayIteratorRandom.js"],"names":[],"mappings":"AAIA;IACI,cAOC;IAJG,YAAY;IACZ,kBAAoB;IAEpB,uBAA+B;IAGnC;;;OAGG;IACH,WAFW,MAAM,QAIhB;IAED,4BAYC;IAED,wBAgBC;CACJ;sCAnDqC,4BAA4B"}

package/src/core/collection/array/{ArrayIteratorRandom.js → iterator/ArrayIteratorRandom.js}

@@ -1,6 +1,6 @@
-import { seededRandom } from "../../math/random/seededRandom.js";
+import { seededRandom } from "../../../math/random/seededRandom.js";
+import { randomizeArrayElementOrder } from "../randomizeArrayElementOrder.js";
 import { AbstractArrayIterator } from "./AbstractArrayIterator.js";
-import { randomizeArrayElementOrder } from "./randomizeArrayElementOrder.js";
 
 export class ArrayIteratorRandom extends AbstractArrayIterator {
     constructor() {

package/src/core/collection/array/iterator/ArrayIteratorSequential.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"ArrayIteratorSequential.d.ts","sourceRoot":"","sources":["../../../../../../src/core/collection/array/iterator/ArrayIteratorSequential.js"],"names":[],"mappings":"AAEA;IACI,cAIC;IADG,YAAY;IAGhB,4BAIC;IAED,wBAcC;CACJ;sCA9BqC,4BAA4B"}

package/src/core/collection/array/randomizeArrayElementOrder.js

@@ -1,5 +1,5 @@
 import { randomIntegerBetween } from "../../math/random/randomIntegerBetween.js";
-import { arraySwapElements } from "./arraySwapElements.js";
+import { array_swap_one } from "./array_swap_one.js";
 
 /**
  * Randomly re-orders of items in-place
@@ -19,6 +19,6 @@ export function randomizeArrayElementOrder(random, array) {
             continue;
         }
 
-        arraySwapElements(array, i, t);
+        array_swap_one(array, i, t);
     }
 }

package/src/core/collection/map/HashMap.js

@@ -6,7 +6,7 @@ import { min2 } from "../../math/min2.js";
 import { invokeObjectEquals } from "../../model/object/invokeObjectEquals.js";
 import { invokeObjectHash } from "../../model/object/invokeObjectHash.js";
 import { array_copy } from "../array/array_copy.js";
-import { arraySwapElements } from "../array/arraySwapElements.js";
+import { array_swap_one } from "../array/array_swap_one.js";
 import { UintArrayForCount } from "../array/typed/uint_array_for_count.js";
 
 /*
@@ -38,7 +38,7 @@ export function generate_next_linear_congruential_index(index, mask) {
 /**
  * @template K,V
  */
-class MapEntry {
+class HashMapEntry {
     /**
      *
      * @param {K} key
@@ -126,7 +126,7 @@ const UNDEFINED_BIN_INDEX = ~0;
 
 /**
  * @template K,V
- * @param {MapEntry<K,V>} record
+ * @param {HashMapEntry<K,V>} record
  * @param {number} hash
  * @param {K} key
  * @param {function(a:K,b:K):boolean} equality_op
@@ -168,7 +168,7 @@ export class HashMap {
 
     /**
      * Note that dead entries are marked as such with a special reserved hash values, so records can be reused for new entries
-     * @type {Array<MapEntry<K,V>>}
+     * @type {Array<HashMapEntry<K,V>>}
      */
     #entries = new Array(0);
 
@@ -358,7 +358,7 @@ export class HashMap {
             entry.key = k;
             entry.value = v;
         } else {
-            this.#entries[i] = new MapEntry(k, v, hash);
+            this.#entries[i] = new HashMapEntry(k, v, hash);
         }
 
         return i;
@@ -366,7 +366,7 @@ export class HashMap {
 
     /**
      *
-     * @param {MapEntry<K,V>} entry
+     * @param {HashMapEntry<K,V>} entry
      */
     #deallocate(entry) {
 
@@ -634,7 +634,7 @@ export class HashMap {
             }
 
             /**
-             * @type {MapEntry<K,V>}
+             * @type {HashMapEntry<K,V>}
              */
             const entry = this.#entries[bin - ENTRY_BASE];
 
@@ -685,7 +685,7 @@ export class HashMap {
 
             if (new_index !== existing_entry_index) {
                 // move entries to the new position, compacting holes
-                arraySwapElements(entries, new_index, existing_entry_index);
+                array_swap_one(entries, new_index, existing_entry_index);
             }
 
             let bin_index = this.#compute_bin_index(hash);
@@ -746,7 +746,7 @@ export class HashMap {
             }
 
             /**
-             * @type {MapEntry<K,V>}
+             * @type {HashMapEntry<K,V>}
              */
             const entry = entries[bin - ENTRY_BASE];
 
@@ -818,7 +818,7 @@ export class HashMap {
             }
 
             /**
-             * @type {MapEntry<K,V>}
+             * @type {HashMapEntry<K,V>}
              */
             const entry = entries[bin - ENTRY_BASE];
 

package/src/core/collection/map/ObservedMap.d.ts

@@ -1,8 +1,11 @@
-export class ObservedMap {
+/**
+ * Decorator that wraps another map and lets you observe mutations
+ * @template K,V
+ */
+export class ObservedMap<K, V> {
     /**
      * @template K,V
      * @constructor
-     * @property {number} size
      */
     constructor(source?: Map<any, any>);
     on: {
@@ -13,7 +16,7 @@ export class ObservedMap {
      *
      * @type {Map<K, V>}
      */
-    data: Map<K, V>;
+    data: Map<K_1, V_1>;
     /**
      *
      * @param {K} key
@@ -26,7 +29,7 @@ export class ObservedMap {
      * @param {V} value
      * @returns {ObservedMap}
      */
-    set(key: K, value: V): ObservedMap;
+    set(key: K, value: V): ObservedMap<any, any>;
     /**
      *
      * @param {K} key

package/src/core/collection/map/ObservedMap.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"ObservedMap.d.ts","sourceRoot":"","sources":["../../../../../src/core/collection/map/ObservedMap.js"],"names":[],"mappings":"AAEA;IACI;;;;OAIG;IACH,oCAWC;IAVG;;;MAGC;IAED;;;OAGG;IACH,gBAAkB;IAGtB;;;;OAIG;IACH,aAFa,IAAE,SAAS,CAIvB;IAED;;;;;OAKG;IACH,uBAFa,WAAW,CAOvB;IAED;;;;OAIG;IACH,gBAFa,OAAO,CAUnB;IAED;;;;OAIG;IACH,iDAEC;IAED;;;OAGG;IACH,mBAEC;CACJ;mBA1EkB,+BAA+B"}
+{"version":3,"file":"ObservedMap.d.ts","sourceRoot":"","sources":["../../../../../src/core/collection/map/ObservedMap.js"],"names":[],"mappings":"AAEA;;;GAGG;AACH;IACI;;;OAGG;IACH,oCAWC;IAVG;;;MAGC;IAED;;;OAGG;IACH,oBAAkB;IAGtB;;;;OAIG;IACH,SAHW,CAAC,GACC,CAAC,GAAC,SAAS,CAIvB;IAED;;;;;OAKG;IACH,SAJW,CAAC,SACD,CAAC,yBAQX;IAED;;;;OAIG;IACH,YAHW,CAAC,GACC,OAAO,CAUnB;IAED;;;;OAIG;IACH,iDAEC;IAED;;;OAGG;IACH,mBAEC;CACJ;mBA7EkB,+BAA+B"}

package/src/core/collection/map/ObservedMap.js

@@ -1,10 +1,13 @@
 import Signal from "../../events/signal/Signal.js";
 
+/**
+ * Decorator that wraps another map and lets you observe mutations
+ * @template K,V
+ */
 export class ObservedMap {
     /**
      * @template K,V
      * @constructor
-     * @property {number} size
      */
     constructor(source = new Map()) {
         this.on = {

package/src/core/collection/queue/Deque.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"Deque.d.ts","sourceRoot":"","sources":["../../../../../src/core/collection/queue/Deque.js"],"names":[],"mappings":"AAWA;;;GAGG;AACH;IACI;;OAEG;IACH,8BAmBC;IAbG;;;;;;OAMG;IACH,eAA6B;IAE7B,eAAe;IACf,eAAe;IAEf,iBAA4B;IAGhC;;;OAGG;IACH,oBAFW,OAAO,QAWjB;IAED;;;;;OAKG;IACH,4BAKC;IAED;;;;;OAKG;IACH,6BAGC;IAED,yBA8BC;IAED,mBAEC;IAED,cAeC;IAED;;OAEG;IACH,QAFa,MAAM,CAalB;IAED;;;;;OAKG;IACH,yBAwBC;IAED;;;;OAIG;IACH,UAHW,CAAC,GACC,OAAO,CAYnB;IAED;;;;;OAKG;IACH,mBAiBC;IAED;;;;OAIG;IACH,WAFa,OAAO,CAInB;IAED;;;OAGG;IACH,YAFW,CAAC,QAOX;IAED;;;OAGG;IACH,eAFa,CAAC,CAQb;IAED;;;OAGG;IACH,YAFa,CAAC,GAAC,SAAS,CAIvB;IAED;;;OAGG;IACH,WAFW,CAAC,QAOX;IAED;;;OAGG;IACH,cAFa,CAAC,CASb;IAGD;;;OAGG;IACH,WAFa,CAAC,CAKb;IAOL,gBAAoB;IACpB,uBAAoB;IACpB,eAAmB;IAEnB;;OAEG;IACH,sBAAmB;CAblB"}
+{"version":3,"file":"Deque.d.ts","sourceRoot":"","sources":["../../../../../src/core/collection/queue/Deque.js"],"names":[],"mappings":"AAYA;;;GAGG;AACH;IACI;;;OAGG;IACH,uBAFW,MAAM,EAoChB;IA5BG;;;;;;OAMG;IACH,eAA6B;IAE7B;;;;OAIG;IACH,eAAe;IACf;;;;OAIG;IACH,eAAe;IAEf;;;;OAIG;IACH,iBAA4B;IAGhC;;;;OAIG;IACH,oBASC;IAED;;;;;OAKG;IACH,iCAMC;IAED;;;;;OAKG;IACH,qCAGC;IAED,2BAwCC;IAED;;;OAGG;IACH,WAFY,OAAO,CAIlB;IAED,cAeC;IAED;;OAEG;IACH,QAFa,MAAM,CAalB;IAED;;;;;OAKG;IACH,0BAqCC;IAED;;;;OAIG;IACH,UAHW,CAAC,GACC,OAAO,CAYnB;IAED;;;;;OAKG;IACH,mBAiBC;IAED;;;;OAIG;IACH,WAFa,OAAO,CAInB;IAED;;;OAGG;IACH,YAFW,CAAC,QAOX;IAED;;;OAGG;IACH,eAFa,CAAC,GAAC,SAAS,CAQvB;IAED;;;OAGG;IACH,YAFa,CAAC,GAAC,SAAS,CAIvB;IAED;;;OAGG;IACH,WAFW,CAAC,QAOX;IAED;;;OAGG;IACH,cAFa,CAAC,CASb;IAGD;;;OAGG;IACH,WAFa,CAAC,GAAC,SAAS,CAKvB;IAOL,gBAAoB;IACpB,uBAAoB;IACpB,eAAmB;IAEnB;;OAEG;IACH,sBAAmB;CAblB"}

package/src/core/collection/queue/Deque.js

@@ -1,7 +1,8 @@
+import { assert } from "../../assert.js";
 import { ceilPowerOfTwo } from "../../binary/operations/ceilPowerOfTwo.js";
+import { UINT32_MAX } from "../../binary/UINT32_MAX.js";
 import { max2 } from "../../math/max2.js";
 import { array_copy } from "../array/array_copy.js";
-import { assert } from "../../assert.js";
 
 const DEFAULT_SIZE = 16;
 
@@ -16,12 +17,13 @@ const STATUS_NORMAL = 2;
 export class Deque {
     /**
      * @template T
+     * @param {number} [min_size]
      */
-    constructor(minSize = DEFAULT_SIZE) {
+    constructor(min_size = DEFAULT_SIZE) {
 
-        assert.isNonNegativeInteger(minSize, 'minSize');
+        assert.isNonNegativeInteger(min_size, 'minSize');
 
-        const size = ceilPowerOfTwo(max2(1, minSize));
+        const size = ceilPowerOfTwo(max2(1, min_size));
 
         /**
          * Using static array allocator to preserve data locality.
@@ -32,15 +34,31 @@ export class Deque {
          */
         this.__data = new Array(size);
 
+        /**
+         *
+         * @type {number}
+         * @private
+         */
         this.__head = 0;
+        /**
+         *
+         * @type {number}
+         * @private
+         */
         this.__tail = 0;
 
+        /**
+         *
+         * @type {number}
+         * @private
+         */
         this.__status = STATUS_EMPTY;
     }
 
     /**
      *
      * @param {boolean} adding
+     * @private
      */
     resetStatus(adding) {
         const head = this.__head;
@@ -59,11 +77,12 @@ export class Deque {
      * @returns {number}
      * @private
      */
-    __circularBiggerPos(current) {
-        // TODO this can be done faster using mod operator (%)
+    __circular_next_position(current) {
         const next = current + 1;
 
-        return (next >= this.__data.length) ? 0 : next;
+        const length = this.__data.length;
+
+        return (next >= length) ? 0 : next;
     }
 
     /**
@@ -72,43 +91,57 @@ export class Deque {
      * @returns {number}
      * @private
      */
-    __circularSmallerPos(current) {
+    __circular_previous_position(current) {
         const prev = current - 1;
         return (prev < 0) ? (this.__data.length - 1) : prev;
     }
 
-    __checkAndExpand() {
+    __check_and_expand() {
         const status = this.__status;
+
         if (status !== STATUS_FULL) {
+            // queue still has space, we're done
             return;
         }
+
         const length = this.__data.length;
 
-        if (Number.MAX_SAFE_INTEGER === length) {
+        if (UINT32_MAX === length) {
             throw new Error('Maximum array size exceeded');
         }
 
-        let newLength = length * 2;
+        let new_length = length * 2;
+
         // bigger than Integer.MAX_VALUE
-        if (newLength < 0) {
-            newLength = Number.MAX_SAFE_INTEGER;
+        if (new_length > UINT32_MAX) {
+            new_length = UINT32_MAX;
         }
 
-        const newElements = new Array(newLength);
+        /**
+         *
+         * @type {T[]}
+         */
+        const new_data = new Array(new_length);
 
-        // copy front portion of data
         const head = this.__head;
 
-        array_copy(this.__data, head, newElements, 0, length - head);
-        array_copy(this.__data, 0, newElements, length - head, head);
+        // copy the front portion
+        array_copy(this.__data, head, new_data, 0, length - head);
+        // copy the remainder
+        array_copy(this.__data, 0, new_data, length - head, head);
 
         this.__head = 0;
         this.__tail = length;
+
         this.__status = STATUS_NORMAL;
 
-        this.__data = newElements;
+        this.__data = new_data;
     }
 
+    /**
+     *
+     * @return {boolean}
+     */
     isEmpty() {
         return this.size() === 0;
     }
@@ -120,7 +153,7 @@ export class Deque {
 
             do {
                 this.__data[cursor] = undefined;
-                cursor = this.__circularBiggerPos(cursor);
+                cursor = this.__circular_next_position(cursor);
             } while (cursor !== tail);
 
             this.__status = STATUS_EMPTY;
@@ -149,32 +182,45 @@ export class Deque {
     /**
      *
      * @param {number} current
-     * @param {boolean} frontShift
+     * @param {boolean} shift_front should we shift elements before the removed element or after?
      * @private
      */
-    __removeInternal(current, frontShift) {
+    __remove_internal(current, shift_front) {
         let cursor = current;
-        if (frontShift) {
+
+        if (shift_front) {
+
+            // shift towards tail
+
             const head = this.__head;
+
             while (cursor !== head) {
-                const next = this.__circularSmallerPos(cursor);
+                const next = this.__circular_previous_position(cursor);
                 this.__data[cursor] = this.__data[next];
                 cursor = next;
             }
-            this.__head = this.__circularBiggerPos(head);
+
+            this.__head = this.__circular_next_position(head);
+
         } else {
+
+            // shift towards head
+
             const tail = this.__tail;
 
             while (cursor !== tail) {
-                const next = this.__circularBiggerPos(cursor);
+                const next = this.__circular_next_position(cursor);
                 this.__data[cursor] = this.__data[next];
                 cursor = next;
             }
 
-            this.__tail = this.__circularSmallerPos(tail);
+            this.__tail = this.__circular_previous_position(tail);
+
         }
 
+        // fill in slot of last moved element
         this.__data[cursor] = undefined;
+
         this.resetStatus(false);
     }
 
@@ -190,7 +236,7 @@ export class Deque {
             return false;
         }
 
-        this.__removeInternal(i, true);
+        this.__remove_internal(i, true);
 
         return true;
     }
@@ -234,20 +280,20 @@ export class Deque {
      * @param {T} e
      */
     addFirst(e) {
-        this.__checkAndExpand();
-        this.__head = this.__circularSmallerPos(this.__head);
+        this.__check_and_expand();
+        this.__head = this.__circular_previous_position(this.__head);
         this.__data[this.__head] = e;
         this.resetStatus(true);
     }
 
     /**
      * Remove element from the front of the queue
-     * @returns {T}
+     * @returns {T|undefined}
      */
     removeFirst() {
         const element = this.__data[this.__head];
         this.__data[this.__head] = undefined;
-        this.__head = this.__circularBiggerPos(this.__head);
+        this.__head = this.__circular_next_position(this.__head);
         this.resetStatus(false);
         return element;
     }
@@ -265,9 +311,9 @@ export class Deque {
      * @param {T} e
      */
     addLast(e) {
-        this.__checkAndExpand();
+        this.__check_and_expand();
         this.__data[this.__tail] = e;
-        this.__tail = this.__circularBiggerPos(this.__tail);
+        this.__tail = this.__circular_next_position(this.__tail);
         this.resetStatus(true);
     }
 
@@ -276,7 +322,7 @@ export class Deque {
      * @returns {T}
      */
     removeLast() {
-        const last = this.__circularSmallerPos(this.__tail);
+        const last = this.__circular_previous_position(this.__tail);
         const element = this.__data[last];
         this.__data[last] = undefined;
         this.__tail = last;
@@ -287,10 +333,10 @@ export class Deque {
 
     /**
      * Peek element from the end of the queue without removing it
-     * @returns {T}
+     * @returns {T|undefined}
      */
     getLast() {
-        const last = this.__circularSmallerPos(this.__tail);
+        const last = this.__circular_previous_position(this.__tail);
         return this.__data[last];
     }
 }

package/src/core/collection/set/compute_set_difference.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"compute_set_difference.d.ts","sourceRoot":"","sources":["../../../../../src/core/collection/set/compute_set_difference.js"],"names":[],"mappings":"AAAA;;;;;GAKG;AACH,0EAyBC"}
+{"version":3,"file":"compute_set_difference.d.ts","sourceRoot":"","sources":["../../../../../src/core/collection/set/compute_set_difference.js"],"names":[],"mappings":"AAEA;;;;;GAKG;AACH,0EA+BC"}