@woosh/meep-engine 2.55.0 → 2.56.0

package/src/core/geom/3d/aabb/aabb3_from_threejs_geometry.js

@@ -1,4 +1,5 @@
 import { assert } from "../../../assert.js";
+import { aabb3_from_min_max } from "./aabb3_from_min_max.js";
 
 /**
  *
@@ -13,29 +14,5 @@ export function aabb3_from_threejs_geometry(result, geometry) {
     const min = gbb.min;
     const max = gbb.max;
 
-    const x0 = min.x;
-    const y0 = min.y;
-    const z0 = min.z;
-
-    const x1 = max.x;
-    const y1 = max.y;
-    const z1 = max.z;
-
-    // validate bounds
-    assert.notNaN(x0, 'x0');
-    assert.notNaN(y0, 'y0');
-    assert.notNaN(z0, 'z0');
-
-    assert.notNaN(x1, 'x1');
-    assert.notNaN(y1, 'y1');
-    assert.notNaN(z1, 'z1');
-
-    // marshal into transform-accepted format
-    result[0] = x0;
-    result[1] = y0;
-    result[2] = z0;
-
-    result[3] = x1;
-    result[4] = y1;
-    result[5] = z1;
+    aabb3_from_min_max(result, min, max);
 }

package/src/core/geom/3d/aabb/aabb3_signed_distance_sqr_to_point.js

@@ -13,7 +13,11 @@ import { max2 } from "../../../math/max2.js";
  * @param {number} point_z
  * @returns {number}
  */
-export function aabb3_signed_distance_sqr_to_point(x0, y0, z0, x1, y1, z1, point_x, point_y, point_z) {
+export function aabb3_signed_distance_sqr_to_point(
+    x0, y0, z0,
+    x1, y1, z1,
+    point_x, point_y, point_z
+) {
     //do projection
     const xp0 = x0 - point_x;
     const xp1 = point_x - x1;

package/src/core/geom/3d/apply_mat4_transform_to_direction_v3_array.js

@@ -8,7 +8,11 @@
  * @param {number} vertex_count
  * @param {mat4|number[]|Float32Array} mat4
  */
-export function apply_mat4_transform_to_direction_v3_array(source, source_offset, destination, destination_offset, vertex_count, mat4) {
+export function apply_mat4_transform_to_direction_v3_array(
+    source, source_offset,
+    destination, destination_offset,
+    vertex_count, mat4
+) {
 
     const a0 = mat4[0];
     const a1 = mat4[1];

package/src/core/geom/3d/apply_mat4_transform_to_v3_array.js

@@ -8,7 +8,11 @@
  * @param {number} vertex_count
  * @param {mat4|number[]|Float32Array} mat4
  */
-export function apply_mat4_transform_to_v3_array(source, source_offset, destination, destination_offset, vertex_count, mat4) {
+export function apply_mat4_transform_to_v3_array(
+    source, source_offset,
+    destination, destination_offset,
+    vertex_count, mat4
+) {
 
     const a0 = mat4[0];
     const a1 = mat4[1];

package/src/core/geom/3d/tetrahedra/TetrahedralMesh.js

@@ -4,9 +4,9 @@ import { max3 } from "../../../math/max3.js";
 import { assert } from "../../../assert.js";
 import { array_copy } from "../../../collection/array/array_copy.js";
 import { array_quick_sort_by_comparator } from "../../../collection/array/arrayQuickSort.js";
-import { compareNumbersDescending } from "../../../function/Functions.js";
 import { BinaryBuffer } from "../../../binary/BinaryBuffer.js";
 import { Base64 } from "../../../binary/Base64.js";
+import { number_compare_descending } from "../../../primitives/numbers/number_compare_descending.js";
 
 /**
  * @readonly
@@ -546,7 +546,7 @@ export class TetrahedralMesh {
      */
     compact() {
         // sort free
-        array_quick_sort_by_comparator(this.__free, compareNumbersDescending, null, 0, this.__free_pointer - 1);
+        array_quick_sort_by_comparator(this.__free, number_compare_descending, null, 0, this.__free_pointer - 1);
 
         let relocation_count = 0;
         let free_head_pointer = 0;

package/src/core/geom/3d/triangle/computeTriangleRayIntersectionBarycentric.spec.js

@@ -0,0 +1,26 @@
+import { computeTriangleRayIntersectionBarycentric } from "./computeTriangleRayIntersectionBarycentric.js";
+
+test("orthogonal, through center", () => {
+
+    const result = [];
+
+    const hit_found = computeTriangleRayIntersectionBarycentric(
+        result,
+        0, 0, 3,
+        0, 0, -1,
+        -1, -1, 0,
+        1, -1, 0,
+        1, 1, 0
+    );
+
+    expect(hit_found).toBe(true);
+
+    expect(result[0]).toBeCloseTo(3);
+
+    // note that UVs are just checked for sanity
+    expect(result[1]).toBeGreaterThanOrEqual(0);
+    expect(result[1]).toBeLessThanOrEqual(1);
+
+    expect(result[2]).toBeGreaterThanOrEqual(0);
+    expect(result[2]).toBeLessThanOrEqual(1);
+});

package/src/core/geom/3d/v3_compute_triangle_normal.spec.js

@@ -25,3 +25,21 @@ test("axis aligned triangles on -X plane", () => {
 
     expect(result).toEqual([-1, 0, 0]);
 });
+
+test("degenerate triangle with all points at the same position", () => {
+    const result = [];
+
+    v3_compute_triangle_normal(
+        result, 0,
+        1, 3, 5,
+        1, 3, 5,
+        1, 3, 5,
+    );
+
+    expect(result[0]).not.toBeNaN();
+    expect(result[1]).not.toBeNaN();
+    expect(result[2]).not.toBeNaN();
+
+    // normal vector length should be 1
+    expect(Math.hypot(result[0], result[1], result[2])).toBeCloseTo(1);
+});

package/src/core/geom/Vector2.js

@@ -581,7 +581,7 @@ class Vector2 {
     }
 
     toString() {
-        return `Vector2{x:${this.x}, y:${this.y}}`;
+        return `Vector2{ x:${this.x}, y:${this.y} }`;
     }
 
     /**

package/src/core/geom/Vector3.js

@@ -806,7 +806,7 @@ class Vector3 {
     }
 
     toString() {
-        return `{ x:${this.x}, y:${this.y}, z:${this.z} }`;
+        return `Vector3{ x:${this.x}, y:${this.y}, z:${this.z} }`;
     }
 
     /**

package/src/core/geom/packing/miniball/Miniball.spec.js

@@ -1,6 +1,13 @@
 import { Miniball } from "./Miniball.js";
 import { PointSet } from "./PointSet.js";
 
+
+test("empty point set in 1d", () => {
+
+    new Miniball(new PointSet(0, 1, []));
+
+});
+
 test("single point in 1d", () => {
 
     const miniball = new Miniball(new PointSet(1, 1, [7]));
@@ -9,3 +16,20 @@ test("single point in 1d", () => {
     expect(miniball.radius()).toEqual(0);
 
 });
+
+test("3 points in 1d", () => {
+    const miniball = new Miniball(new PointSet(3, 1, [-3, 7, 11]));
+
+    expect(miniball.center()[0]).toBeCloseTo(4);
+    expect(miniball.radius()).toBeCloseTo(7);
+});
+
+test("toString produces a valid string", () => {
+
+    const miniball = new Miniball(new PointSet(1, 1, [7]));
+
+    const s = miniball.toString();
+
+    expect(typeof s).toBe("string");
+    expect(s.trim().length).toBeGreaterThan(0);
+});

package/src/core/math/statistics/computeStatisticalPartialMedian.js

@@ -1,5 +1,5 @@
-import { compareNumbersAscending } from "../../function/Functions.js";
 import { assert } from "../../assert.js";
+import { number_compare_ascending } from "../../primitives/numbers/number_compare_ascending.js";
 
 /**
  *
@@ -14,7 +14,7 @@ export function computeStatisticalPartialMedian(values, start, end) {
 
     const copy = values.slice();
 
-    copy.sort(compareNumbersAscending);
+    copy.sort(number_compare_ascending);
 
     const range = end - start;
 

package/src/core/model/object/read_property.js

@@ -1,4 +1,4 @@
-import { capitalize } from "../../primitives/strings/StringUtils.js";
+import { string_capitalize } from "../../primitives/strings/string_capitalize.js";
 
 /**
  * @template T
@@ -19,7 +19,7 @@ export function read_property(root, parts, part_offset, part_count) {
         if (typeof thing[part] !== 'undefined') {
             thing = thing[part];
         } else {
-            const getter_name = `get${capitalize(part)}`;
+            const getter_name = `get${string_capitalize(part)}`;
             const getter = thing[getter_name];
 
             if (typeof getter === "function") {

package/src/core/model/object/write_property.js

@@ -1,4 +1,4 @@
-import { capitalize } from "../../primitives/strings/StringUtils.js";
+import { string_capitalize } from "../../primitives/strings/string_capitalize.js";
 
 /**
  * @template T
@@ -23,7 +23,7 @@ export function write_property(root, parts, part_offset, part_count, value) {
             thing = thing_part;
         } else {
 
-            const getter_name = `get${capitalize(part)}`;
+            const getter_name = `get${string_capitalize(part)}`;
             const getter = thing[getter_name];
 
             if (typeof getter === "function") {
@@ -38,7 +38,7 @@ export function write_property(root, parts, part_offset, part_count, value) {
 
     const last_part = parts[last_index];
 
-    const setter_name = `set${capitalize(last_part)}`;
+    const setter_name = `set${string_capitalize(last_part)}`;
     const setter = thing[setter_name];
 
     if (typeof setter === "function") {

package/src/core/primitives/numbers/compareNumbers.js

@@ -1,9 +1,9 @@
+import { number_compare_ascending } from "./number_compare_ascending.js";
+
 /**
- *
+ * @deprecated use {@link number_compare_ascending} directly
  * @param {number} a
  * @param {number} b
  * @returns {number}
  */
-export function compareNumbers(a, b) {
-    return a - b;
-}
+export const compareNumbers = number_compare_ascending;

package/src/core/primitives/numbers/number_compare_ascending.js

@@ -0,0 +1,9 @@
+/**
+ *
+ * @param {number} a
+ * @param {number} b
+ * @return {number}
+ */
+export function number_compare_ascending(a, b) {
+    return a - b;
+}

package/src/core/primitives/numbers/number_compare_ascending.spec.js

@@ -0,0 +1,9 @@
+import { number_compare_ascending } from "./number_compare_ascending.js";
+
+test("basics", () => {
+
+    expect([1, 2].sort(number_compare_ascending)).toEqual([1, 2]);
+
+    expect([2, 1].sort(number_compare_ascending)).toEqual([1, 2]);
+
+});

package/src/core/primitives/numbers/number_compare_descending.js

@@ -0,0 +1,9 @@
+/**
+ *
+ * @param {number} a
+ * @param {number} b
+ * @return {number}
+ */
+export function number_compare_descending(a, b) {
+    return b - a;
+}

package/src/core/primitives/numbers/number_compare_descending.spec.js

@@ -0,0 +1,9 @@
+import { number_compare_descending } from "./number_compare_descending.js";
+
+test("basics", () => {
+
+    expect([2, 1].sort(number_compare_descending)).toEqual([2, 1]);
+
+    expect([1, 2].sort(number_compare_descending)).toEqual([2, 1]);
+
+});

package/src/core/primitives/numbers/number_format_by_thousands.spec.js

@@ -0,0 +1,12 @@
+import { number_format_by_thousands } from "./number_format_by_thousands.js";
+
+test("basics", () => {
+
+    expect(number_format_by_thousands(0, ',')).toEqual("0");
+    expect(number_format_by_thousands(987, ',')).toEqual("987");
+    expect(number_format_by_thousands(1234, ',')).toEqual("1,234");
+    expect(number_format_by_thousands(987654321, ',')).toEqual("987,654,321");
+
+    // different separator
+    expect(number_format_by_thousands(1234, ' -> ')).toEqual("1 -> 234");
+});

package/src/core/primitives/numbers/number_pretty_print.js

@@ -29,7 +29,7 @@ function countDecimals(value) {
 /**
  *
  * @param {number} value
- * @returns {string|number}
+ * @returns {string}
  */
 export function number_pretty_print(value) {
     assert.isNumber(value, 'value');

package/src/core/primitives/strings/compareStrings.spec.js

@@ -0,0 +1,12 @@
+import { compareStrings } from "./compareStrings.js";
+
+test("stability", () => {
+
+    const array_a = ["a", undefined, "test", null, ""];
+    const array_b = [null, undefined, "", "a", "test"];
+
+    array_a.sort(compareStrings);
+    array_b.sort(compareStrings);
+
+    expect(array_a).toEqual(array_b);
+});

package/src/core/primitives/strings/string_capitalize.js

@@ -0,0 +1,15 @@
+/**
+ * Turn first letter in the string to capital
+ * @example "text" will become "Text"
+ * @param {string} string
+ * @returns {string}
+ */
+export function string_capitalize(string) {
+    const length = string.length;
+
+    if (length === 0) {
+        return string;
+    } else {
+        return string.charAt(0).toLocaleUpperCase() + string.substring(1);
+    }
+}

package/src/core/primitives/strings/string_capitalize.spec.js

@@ -0,0 +1,13 @@
+import { string_capitalize } from "./string_capitalize.js";
+
+test("capitalize", () => {
+    expect(string_capitalize("")).toBe("");
+
+    expect(string_capitalize("a")).toBe("A");
+
+    expect(string_capitalize("A")).toBe("A");
+
+    expect(string_capitalize("aa")).toBe("Aa");
+
+    expect(string_capitalize("AA")).toBe("AA");
+});

package/src/core/primitives/strings/string_compute_byte_size.js

@@ -0,0 +1,21 @@
+/**
+ * Compute byte size of a UTF8 string
+ * @param {string} value
+ * @returns {number}
+ */
+export function string_compute_byte_size(value) {
+    const length = value.length;
+
+    let p = 0;
+
+    for (let i = 0; i < length; i++) {
+        let c = value.charCodeAt(i);
+        while (c > 0xff) {
+            p++;
+            c >>= 8;
+        }
+        p++;
+    }
+
+    return p;
+}

package/src/core/primitives/strings/string_compute_common_prefix.js

@@ -0,0 +1,44 @@
+/**
+ * @example: ['abra', 'abc', 'abode'] => 'ab'
+ * @param {String[]} strings
+ * @returns string
+ */
+export function string_compute_common_prefix(strings) {
+    let i, j;
+
+    const numInputs = strings.length;
+
+    let result = "";
+
+    if (numInputs === 0) {
+        return result;
+    }
+
+    const firstString = strings[0];
+
+    let lengthLimit = firstString.length;
+
+    for (i = 1; i < numInputs; i++) {
+        lengthLimit = Math.min(strings[i].length, lengthLimit);
+    }
+
+
+    main_loop:for (i = 0; i < lengthLimit; i++) {
+        const letter0 = firstString.charAt(i);
+
+        for (j = 1; j < numInputs; j++) {
+
+            const string = strings[j];
+
+            const letter1 = string.charAt(i);
+
+            if (letter0 !== letter1) {
+                break main_loop;
+            }
+        }
+
+        result += letter0;
+    }
+
+    return result;
+}

package/src/core/primitives/strings/string_compute_common_prefix.spec.js

@@ -0,0 +1,23 @@
+import { string_compute_common_prefix } from "./string_compute_common_prefix.js";
+
+test("common prefix", () => {
+    expect(string_compute_common_prefix([])).toBe("");
+
+    expect(string_compute_common_prefix([""])).toBe("");
+
+    expect(string_compute_common_prefix(["a"])).toBe("a");
+
+    expect(string_compute_common_prefix(["abc"])).toBe("abc");
+
+    expect(string_compute_common_prefix(["aa"])).toBe("aa");
+
+    expect(string_compute_common_prefix(["aa", "ab"])).toBe("a");
+
+    expect(string_compute_common_prefix(["abc", "abb"])).toBe("ab");
+
+    expect(string_compute_common_prefix(["abc", "abc"])).toBe("abc");
+
+    expect(string_compute_common_prefix(["abc", "abc", "a"])).toBe("a");
+
+    expect(string_compute_common_prefix(["abc", "abc", ""])).toBe("");
+});

package/src/core/primitives/strings/string_format_camel_to_kebab.js

@@ -0,0 +1,9 @@
+/**
+ * Convert camelCaseString to kebab-format-string
+ * useful for resolving CSS property names
+ * @param {string} string
+ * @returns {string}
+ */
+export function string_format_camel_to_kebab(string) {
+    return string.replace(/([a-z])([A-Z])/g, '$1-$2').toLowerCase();
+}

package/src/core/primitives/strings/string_format_camel_to_kebab.spec.js

@@ -0,0 +1,8 @@
+import { string_format_camel_to_kebab } from "./string_format_camel_to_kebab.js";
+
+test('camelToKebab', () => {
+    expect(string_format_camel_to_kebab('a')).toBe('a');
+    expect(string_format_camel_to_kebab('aA')).toBe('a-a');
+    expect(string_format_camel_to_kebab('helloWoRLD')).toBe('hello-wo-rld');
+    expect(string_format_camel_to_kebab('A')).toBe('a');
+});

package/src/core/primitives/strings/string_format_kebab_to_underscore.js

@@ -0,0 +1,8 @@
+/**
+ * Convert kebab-format-string to underscore_format_string
+ * @param {string} string
+ * @returns {string}
+ */
+export function string_format_kebab_to_underscore(string) {
+    return string.replace('-', '_');
+}

package/src/core/time/current_time_in_seconds.js

@@ -0,0 +1,11 @@
+
+//Use highest available resolution time source
+const source = typeof performance === "undefined" ? Date : performance;
+
+/**
+ * Current time in seconds
+ * @returns {number}
+ */
+export function current_time_in_seconds() {
+    return source.now() * 1e-3;
+}

package/src/engine/Clock.js

@@ -4,24 +4,14 @@
 
 
 import Stat from "../core/model/stat/Stat.js";
-
-//Use highest available resolution time source
-const source = typeof performance === "undefined" ? Date : performance;
-
-/**
- *
- * @returns {number}
- */
-export function currentTimeInSeconds() {
-    return source.now() * 0.001;
-}
+import { current_time_in_seconds } from "../core/time/current_time_in_seconds.js";
 
 /**
  *
  * @param {Clock} clock
  */
 function updateElapsedTime(clock) {
-    const now = currentTimeInSeconds();
+    const now = current_time_in_seconds();
     const delta = (now - clock.__lastMeasurement) * clock.speed;
     clock.__lastMeasurement = now;
     clock.elapsedTime += delta;
@@ -79,7 +69,7 @@ class Clock {
     }
 
     start() {
-        this.__lastMeasurement = currentTimeInSeconds();
+        this.__lastMeasurement = current_time_in_seconds();
         this.timeAtDelta = this.updateElapsedTime();
         this.__isRunning = true;
     }

package/src/engine/animation/curve/AnimationCurve.spec.js

@@ -46,6 +46,19 @@ test("removing exising key", () => {
     expect(curve.length).toBe(0);
 });
 
+test("evaluate on empty curve", () => {
+    const curve = new AnimationCurve();
+
+    expect(curve.evaluate(0)).toBe(0);
+});
+
+test("evaluate before first frame", () => {
+    const curve = new AnimationCurve();
+
+    curve.add(Keyframe.from(1, 7));
+
+    expect(curve.evaluate(0.9)).toEqual(7);
+});
 
 test("sample linear curve with 2 points", () => {
     const curve = new AnimationCurve();
@@ -78,6 +91,20 @@ test("smooth tangents with a single keyframe does not throw", () => {
 
     expect(() => curve.smoothTangents(0, 1)).not.toThrow()
 });
+test("smooth tangents on a middle frame", () => {
+    const curve = new AnimationCurve();
+
+    curve.add(Keyframe.from(0, 1));
+    curve.add(Keyframe.from(1, 2));
+    curve.add(Keyframe.from(2, 3));
+
+    curve.smoothTangents(1, 1);
+
+    const key = curve.keys[1];
+
+    expect(key.inTangent).toEqual(key.outTangent);
+});
+
 
 test("to/from JSON consistency", () => {
 

package/src/engine/asset/AssetManager.js

@@ -9,7 +9,6 @@ import { extractAssetListFromManager } from "./preloader/extractAssetListFromMan
 import { assert } from "../../core/assert.js";
 import { HashSet } from "../../core/collection/set/HashSet.js";
 import { CrossOriginConfig } from "./CORS/CrossOriginConfig.js";
-import { array_remove_element } from "../../core/collection/array/array_remove_element.js";
 import { AssetDescription } from "./AssetDescription.js";
 import { noop } from "../../core/function/Functions.js";
 import { Deque } from "../../core/collection/queue/Deque.js";
@@ -23,6 +22,7 @@ import ConcurrentExecutor from "../../core/process/executor/ConcurrentExecutor.j
 import { AssetLoader } from "./loaders/AssetLoader.js";
 import { array_push_if_unique } from "../../core/collection/array/array_push_if_unique.js";
 import { AssetRequestScope } from "./AssetRequestScope.js";
+import { array_remove_first } from "../../core/collection/array/array_remove_first.js";
 
 
 class Response {
@@ -701,7 +701,7 @@ export class AssetManager {
             return false;
         }
 
-        if (!array_remove_element(transformers, 0, transformers.length, transformer)) {
+        if (!array_remove_first(transformers, transformer)) {
             // not found
             return false;
         }

package/src/engine/ecs/EntityManager.js

@@ -202,7 +202,7 @@ EntityManager.prototype.detachDataSet = function () {
 };
 
 /**
- *
+ * Get list of all components referenced by active systems
  * @returns {Class[]}
  */
 EntityManager.prototype.getComponentTypeMap = function () {
@@ -237,6 +237,12 @@ EntityManager.prototype.getComponentTypeMap = function () {
 EntityManager.prototype.attachDataSet = function (dataset) {
     //check if another dataset is attached
     if (this.dataset !== null) {
+
+        if (this.dataset === dataset) {
+            // special case, we already have this dataset attached. Nothing to more to do
+            return;
+        }
+
         throw new Error("Illegal status, another dataset is currently attached");
     }
 
@@ -285,6 +291,7 @@ EntityManager.prototype.getSystem = function (systemClass) {
 
 
 /**
+ * @deprecated use {@link EntityComponentDataset.getComponentClassByName} instead
  * @template T
  * @param {string} className
  * @returns {null|Class<T>}