@woosh/meep-engine 2.49.9 → 2.50.1

package/src/engine/navigation/ecs/components/computeCatmullRomSpline.js

@@ -1,6 +1,6 @@
 import { assert } from "../../../../core/assert.js";
 import { clamp } from "../../../../core/math/clamp.js";
-import { array_copy } from "../../../../core/collection/array/copyArray.js";
+import { array_copy } from "../../../../core/collection/array/array_copy.js";
 import { computeNonuniformCatmullRomSplineSample } from "./computeNonuniformCatmullRomSplineSample.js";
 
 /**

package/src/engine/navigation/ecs/components/computeCatmullRomSplineUniformDistance.js

@@ -1,5 +1,5 @@
 import { clamp } from "../../../../core/math/clamp.js";
-import { array_copy } from "../../../../core/collection/array/copyArray.js";
+import { array_copy } from "../../../../core/collection/array/array_copy.js";
 import { computeNonuniformCatmullRomSplineSample } from "./computeNonuniformCatmullRomSplineSample.js";
 import { assert } from "../../../../core/assert.js";
 

package/src/engine/physics/cannon/CannonJSPhysicsSystem.js

@@ -5,7 +5,7 @@ import { System } from '../../engine/ecs/System';
 import Transform from '../../engine/ecs/components/Transform';
 import PhysicalBody from '../../engine/ecs/components/PhysicalBody';
 import Vector3 from '../../core/geom/Vector3';
-import Cannon from './cannon.min.js';
+import Cannon from './cannon.min.js'; //TODO replace with package import
 
 
 class CannonPhysicsSystem extends System {

package/src/engine/save/GameStateLoader.js

@@ -26,7 +26,7 @@ class GameStateLoader extends EnginePlugin {
     save(name, resolve, reject, progress) {
         const engine = this.engine;
 
-        const currentScene = engine.sceneManager.currentScene;
+        const currentScene = engine.sceneManager.current_scene;
 
 
         /**

package/src/engine/scene/Scene.d.ts

@@ -1,5 +1,7 @@
 import {EntityComponentDataset} from "../ecs/EntityComponentDataset";
 
 export default class Scene {
+    constructor(name?: string)
+
     public dataset: EntityComponentDataset
 }

package/src/engine/scene/Scene.js

@@ -11,10 +11,10 @@ import { promiseTask } from "../../core/process/task/util/promiseTask.js";
 class Scene {
     /**
      *
-     * @param {string} name
+     * @param {string} [name]
      * @constructor
      */
-    constructor(name) {
+    constructor(name = "Unnamed") {
         /**
          *
          * @type {string}

package/src/engine/scene/Scene.spec.js

@@ -0,0 +1,20 @@
+import Scene from "./Scene.js";
+import { EntityComponentDataset } from "../ecs/EntityComponentDataset.js";
+
+test("constructor should not throw", () => {
+    expect(() => new Scene()).not.toThrow();
+});
+
+test("new scene has it's own dataset", () => {
+    const scene = new Scene();
+
+    expect(scene.dataset).not.toBeNull();
+    expect(scene.dataset).toBeDefined();
+    expect(scene.dataset).toBeInstanceOf(EntityComponentDataset);
+});
+
+test("name properly through constructor", () => {
+    const scene = new Scene("x");
+
+    expect(scene.name).toBe("x");
+});

package/src/engine/scene/SceneManager.d.ts

@@ -1,6 +1,10 @@
 import Scene from "./Scene";
+import {EntityManager} from "../ecs/EntityManager";
 
 export default class SceneManager {
+    readonly current_scene:Scene|null
+    readonly entity_manager: EntityManager
+
     create(name: string): Scene
 
     add(scene: Scene): void

package/src/engine/scene/SceneManager.js

@@ -7,6 +7,34 @@ import List from "../../core/collection/list/List.js";
 
 
 class SceneManager {
+    /**
+     *
+     * @type {Scene|null}
+     */
+    #current_scene = null
+
+    /**
+     *
+     * @return {Scene|null}
+     */
+    get current_scene() {
+        return this.#current_scene;
+    }
+
+    /**
+     *
+     * @type {EntityManager|null}
+     */
+    #entity_manager = null;
+
+    /**
+     *
+     * @return {EntityManager|null}
+     */
+    get entity_manager(){
+        return this.#entity_manager;
+    }
+
     /**
      *
      * @param {EntityManager} entityManager
@@ -14,20 +42,17 @@ class SceneManager {
      * @constructor
      */
     constructor(entityManager, clock) {
-        /**
-         *
-         * @type {Scene|null}
-         */
-        this.currentScene = null;
+
         /**
          * @type {List<Scene>}
          */
         this.scenes = new List();
+
         /**
          *
          * @type {EntityManager}
          */
-        this.entityManager = entityManager;
+        this.#entity_manager = entityManager;
 
         /**
          *
@@ -113,10 +138,10 @@ class SceneManager {
         const scene = this.scenes.get(sceneIndex);
 
 
-        if (this.currentScene === scene) {
+        if (this.#current_scene === scene) {
             this.deactivateCurrentScene();
 
-            this.currentScene = null;
+            this.#current_scene = null;
         }
 
         this.scenes.remove(sceneIndex);
@@ -130,11 +155,11 @@ class SceneManager {
      */
     clear() {
 
-        if (this.currentScene !== null) {
-            this.currentScene.active.set(false);
-            this.entityManager.detachDataSet();
+        if (this.#current_scene !== null) {
+            this.#current_scene.active.set(false);
+            this.#entity_manager.detachDataSet();
 
-            this.currentScene = null;
+            this.#current_scene = null;
         }
 
         return this;
@@ -146,9 +171,7 @@ class SceneManager {
      * @returns {boolean}
      */
     exists(name) {
-        return this.scenes.some(function (scene) {
-            return scene.name === name;
-        });
+        return this.getByName(name) !== undefined;
     }
 
     /**
@@ -170,8 +193,8 @@ class SceneManager {
 
         scene.active.set(false);
 
-        if (this.entityManager.dataset === scene.dataset) {
-            this.entityManager.detachDataSet();
+        if (this.#entity_manager.dataset === scene.dataset) {
+            this.#entity_manager.detachDataSet();
         }
 
         //remove speed modifiers
@@ -200,7 +223,7 @@ class SceneManager {
             console.error(`Exception in pre-activation routine of scene '${scene.id}'`, e);
         }
 
-        const em = this.entityManager;
+        const em = this.#entity_manager;
 
         em.attachDataSet(scene.dataset);
 
@@ -218,7 +241,7 @@ class SceneManager {
             console.error(`Exception in post-activation routine of scene '${scene.id}'`, e);
         }
 
-        this.currentScene = scene;
+        this.#current_scene = scene;
     }
 
     /**
@@ -226,7 +249,7 @@ class SceneManager {
      */
     deactivateCurrentScene() {
 
-        const currentScene = this.currentScene;
+        const currentScene = this.#current_scene;
 
         if (currentScene !== null) {
             this.deactivateScene(currentScene);
@@ -261,12 +284,12 @@ class SceneManager {
             throw new Error(`Scene named '${name}' doesn't exist, valid options are: [${this.scenes.map(s => s.name).join(', ')}]`);
         }
 
-        if (this.currentScene === scene) {
+        if (this.#current_scene === scene) {
             //already at that scene
             return;
         }
 
-        const em = this.entityManager;
+        const em = this.#entity_manager;
 
         // Ensure that all system components are registered
         scene.dataset.registerManyComponentTypes(em.getComponentTypeMap());
@@ -281,7 +304,7 @@ class SceneManager {
      */
     stackPush(id) {
         //take current scene and put it onto the stack
-        this.stack.push(this.currentScene.name);
+        this.stack.push(this.#current_scene.name);
 
         this.set(id);
     }

package/src/engine/scene/SceneManager.spec.js

@@ -0,0 +1,131 @@
+import SceneManager from "./SceneManager.js";
+import { EntityManager } from "../ecs/EntityManager.js";
+import Clock from "../Clock.js";
+
+
+function makeSM() {
+    const em = new EntityManager();
+    const clock = new Clock();
+
+    return {
+        manager: new SceneManager(em, clock),
+        entityManager: em
+    };
+}
+
+test("constructor", () => {
+
+    const { manager } = makeSM();
+
+    expect(manager.current_scene).toBeNull();
+});
+
+test("create method", () => {
+
+    const { manager } = makeSM();
+
+    const scene_x = manager.create('x');
+
+    expect(scene_x).toBeDefined();
+    expect(scene_x).not.toBeNull();
+
+    expect(() => manager.create('x')).toThrow();
+
+    const scene_y = manager.create('y');
+
+    expect(scene_y).toBeDefined();
+    expect(scene_y).not.toBeNull();
+
+});
+
+test("getByName", () => {
+    const { manager } = makeSM();
+
+    expect(manager.getByName('x')).toBeUndefined();
+
+    const scene_x = manager.create('x');
+
+    expect(manager.getByName('x')).toBe(scene_x);
+
+    const scene_y = manager.create('y');
+
+    expect(manager.getByName('x')).toBe(scene_x);
+    expect(manager.getByName('y')).toBe(scene_y);
+});
+
+test("remove", () => {
+
+    const { manager } = makeSM();
+
+    expect(manager.remove('x')).toBe(false);
+
+    manager.create('x');
+
+    expect(manager.remove('x')).toBe(true);
+    expect(manager.remove('x')).toBe(false);
+
+});
+
+test("exists", () => {
+
+    const { manager } = makeSM();
+
+    expect(manager.exists('x')).toBe(false);
+
+    manager.create('x');
+
+    expect(manager.exists('x')).toBe(true);
+});
+
+test("set active scene", () => {
+    const { manager, entityManager } = makeSM();
+
+    const scene = manager.create('x');
+
+    manager.set('x');
+
+    expect(manager.current_scene).toBe(scene);
+    expect(scene.active.getValue()).toBe(true);
+    expect(entityManager.dataset).toBe(scene.dataset);
+});
+
+test("stack push/pop", () => {
+
+    const { manager } = makeSM();
+
+    const scene_x = manager.create('x');
+    const scene_y = manager.create('y');
+
+    manager.set('x');
+
+    manager.stackPush('y');
+
+    expect(manager.current_scene).toBe(scene_y);
+
+    manager.stackPop();
+
+    expect(manager.current_scene).toBe(scene_x);
+});
+
+test("clear on empty does nothing", () => {
+    const { manager } = makeSM();
+
+    manager.clear();
+
+    expect(manager.current_scene).toBeNull();
+});
+
+test("clear correctly clears active scene", () => {
+
+    const { manager, entityManager } = makeSM();
+
+    const scene = manager.create('x');
+
+    manager.set('x');
+
+    manager.clear();
+
+    expect(manager.current_scene).toBeNull();
+    expect(scene.active.getValue()).toBe(false);
+    expect(entityManager.dataset).toBe(null);
+});

package/src/engine/sound/material/detector/terrain/TerrainSoundMaterialSurfaceDetector.js

@@ -5,7 +5,7 @@ import { SilentSoundMaterial } from "../../concrete/SilentSoundMaterial.js";
 import { SingleSoundMaterial } from "../../concrete/SingleSoundMaterial.js";
 import { deserializeSoundMaterialFromJSON } from "../../concrete/json/deserializeSoundMaterialFromJSON.js";
 import { assert } from "../../../../../core/assert.js";
-import { normalizeArrayVector } from "../../../../../core/math/normalizeArrayVector.js";
+import { vector_nd_normalize } from "../../../../../core/math/vector_nd_normalize.js";
 
 const v2_temp = new Vector2();
 
@@ -112,7 +112,7 @@ export class TerrainSoundMaterialSurfaceDetector extends SoundMaterialSurfaceDet
 
         }
 
-        normalizeArrayVector(this.__composite.weights, this.__composite.weights, layer_count);
+        vector_nd_normalize(this.__composite.weights, this.__composite.weights, layer_count);
 
         const additions = this.__composite.computeInteractionSounds(result, 0, interaction);
 

package/src/engine/ui/GUIEngine.js

@@ -462,7 +462,7 @@ GUIEngine.prototype.getActiveSceneContext = function () {
 
     const sm = engine.sceneManager;
 
-    const scene = sm.currentScene;
+    const scene = sm.current_scene;
 
     if (scene === null) {
         return null;

package/src/generation/grid/GridData.js

@@ -3,7 +3,6 @@ import { QuadTreeNode } from "../../core/geom/2d/quad-tree/QuadTreeNode.js";
 import { OffsetScaleTransform2D } from "../../engine/ecs/terrain/ecs/OffsetScaleTransform2D.js";
 import { max2 } from "../../core/math/max2.js";
 import { qt_collect_by_circle } from "../../core/geom/2d/quad-tree/qt_collect_by_circle.js";
-import { v2_length_sqr } from "../../core/geom/Vector2.js";
 
 /**
  *
@@ -122,7 +121,14 @@ export class GridData {
             const distance_limit_sqr = distance_limit * distance_limit;
 
             // check refined containment
-            if (v2_length_sqr(x - marker.position.x, y - marker.position.y) > distance_limit_sqr) {
+            const position = marker.position;
+
+            const dx = x - position.x;
+            const dy = y - position.y;
+
+            const distance_sqr = dx * dx + dy * dy;
+
+            if (distance_sqr > distance_limit_sqr) {
                 continue;
             }
 

package/src/generation/grid/GridData.spec.js

@@ -0,0 +1,5 @@
+import { GridData } from "./GridData.js";
+
+test("constructor does not throw", () => {
+    expect(() => new GridData()).not.toThrow()
+});

package/src/generation/grid/generation/util/buildUnsignedDistanceField.js

@@ -1,5 +1,7 @@
-import { computeUnsignedDistanceField } from "../../../../engine/graphics/texture/sampler/distanceField.js";
 import { Sampler2D } from "../../../../engine/graphics/texture/sampler/Sampler2D.js";
+import {
+    computeUnsignedDistanceField
+} from "../../../../engine/graphics/texture/sampler/distance/computeUnsignedDistanceField.js";
 
 /**
  *

package/src/generation/markers/MarkerNode.js

@@ -1,7 +1,7 @@
 import Vector2 from "../../core/geom/Vector2.js";
 import { Transform } from "../../engine/ecs/transform/Transform.js";
-import { copyArray } from "../../core/collection/array/copyArray.js";
 import { circleIntersectsCircle } from "../../core/geom/2d/circle/circleIntersectsCircle.js";
+import { array_copy_entire } from "../../core/collection/array/array_copy_entire.js";
 
 export class MarkerNode {
     constructor() {
@@ -95,7 +95,7 @@ export class MarkerNode {
     copy(other) {
         this.type = other.type;
 
-        copyArray(other.tags, this.tags);
+        array_copy_entire(other.tags, this.tags);
 
         this.position.copy(other.position);
 

package/src/generation/markers/actions/MarkerNodeActionEntityPlacement.js

@@ -64,7 +64,7 @@ export class MarkerNodeActionEntityPlacement extends MarkerNodeAction {
     execute(grid, ecd, node) {
         const blueprint = this.entity;
 
-        const entityBuilder = blueprint.buildEntityBuilder(node.properties);
+        const entityBuilder = blueprint.build(node.properties);
 
         // execute post-process step
         if (this.processor !== null) {

package/src/generation/theme/AreaMask.js

@@ -1,6 +1,8 @@
 import { Sampler2D } from "../../engine/graphics/texture/sampler/Sampler2D.js";
 import AABB2 from "../../core/geom/2d/aabb/AABB2.js";
-import { computeUnsignedDistanceField } from "../../engine/graphics/texture/sampler/distanceField.js";
+import {
+    computeUnsignedDistanceField
+} from "../../engine/graphics/texture/sampler/distance/computeUnsignedDistanceField.js";
 
 export class AreaMask {
     constructor() {

package/src/view/elements/progress/RectangularPieProgressView.js

@@ -1,7 +1,9 @@
 import View from "../../View.js";
 import SVG from "../../SVG.js";
-import { line2_line2_intersection } from "../../../core/geom/2d/LineSegment2.js";
 import Vector1 from "../../../core/geom/Vector1.js";
+import {
+    line_segment_compute_line_segment_intersection_array_2d
+} from "../../../core/geom/2d/line/line_segment_compute_line_segment_intersection_array_2d.js";
 
 export class RectangularPieProgressView extends View {
 
@@ -76,31 +78,31 @@ export class RectangularPieProgressView extends View {
 
         if (fraction < .125) {
 
-            line2_line2_intersection(p, 0, 0, size_x, 0, center_x, center_y, line_x, line_y);
+            line_segment_compute_line_segment_intersection_array_2d(p, 0, 0, 0, size_x, 0, center_x, center_y, line_x, line_y);
 
             path = `M ${center_x} 0 L ${center_x} ${center_y} L ${p[0]} ${p[1]} L ${size_x} 0 L ${size_x} ${size_y} L 0 ${size_y} L 0 0 Z`;
 
         } else if (fraction < 0.375) {
 
-            line2_line2_intersection(p, size_x, 0, size_x, size_y, center_x, center_y, line_x, line_y);
+            line_segment_compute_line_segment_intersection_array_2d(p, 0, size_x, 0, size_x, size_y, center_x, center_y, line_x, line_y);
 
             path = `M ${center_x} 0 L ${center_x} ${center_y} L ${p[0]} ${p[1]} L ${size_x} ${size_y} L 0 ${size_y} L 0 0 Z`;
 
         } else if (fraction < 0.625) {
 
-            line2_line2_intersection(p, size_x, size_y, 0, size_y, center_x, center_y, line_x, line_y);
+            line_segment_compute_line_segment_intersection_array_2d(p, 0, size_x, size_y, 0, size_y, center_x, center_y, line_x, line_y);
 
             path = `M ${center_x} 0 L ${center_x} ${center_y} L ${p[0]} ${p[1]} L 0 ${size_y} L 0 0 Z`;
 
         } else if (fraction < 0.875) {
 
-            line2_line2_intersection(p, 0, size_y, 0, 0, center_x, center_y, line_x, line_y);
+            line_segment_compute_line_segment_intersection_array_2d(p, 0, 0, size_y, 0, 0, center_x, center_y, line_x, line_y);
 
             path = `M ${center_x} 0 L ${center_x} ${center_y} L ${p[0]} ${p[1]} L 0 0 Z`;
 
         } else {
 
-            line2_line2_intersection(p, 0, 0, size_x, 0, center_x, center_y, line_x, line_y);
+            line_segment_compute_line_segment_intersection_array_2d(p, 0, 0, 0, size_x, 0, center_x, center_y, line_x, line_y);
 
             path = `M ${center_x} 0 L ${center_x} ${center_y} L ${p[0]} ${p[1]} Z`;
 

package/src/view/minimap/dom/MinimapCameraView.js

@@ -3,7 +3,7 @@ import Vector3 from "../../../core/geom/Vector3.js";
 import ObservedValue from "../../../core/model/ObservedValue.js";
 import { SurfacePoint3 } from "../../../core/geom/3d/SurfacePoint3.js";
 import SVG from "../../SVG.js";
-import { computePlaneRayIntersection } from "../../../core/geom/3d/plane/computePlaneRayIntersection.js";
+import { plane3_compute_ray_intersection } from "../../../core/geom/3d/plane/plane3_compute_ray_intersection.js";
 
 
 const rayContact = new SurfacePoint3();
@@ -93,7 +93,7 @@ export class MinimapCameraView extends View {
         const JITTER = 0.00001;
 
         if (terrain === null) {
-            computePlaneRayIntersection(result, originX, originY, originZ, directionX, directionY, directionZ, 0, 1, 0, 0);
+            plane3_compute_ray_intersection(result, originX, originY, originZ, directionX, directionY, directionZ, 0, 1, 0, 0);
         } else {
 
             let oX = originX;
@@ -118,7 +118,7 @@ export class MinimapCameraView extends View {
 
             if (!foundHit) {
                 //no hit found, fall back to planar test
-                computePlaneRayIntersection(result, originX, originY, originZ, directionX, directionY, directionZ, 0, 1, 0, 0);
+                plane3_compute_ray_intersection(result, originX, originY, originZ, directionX, directionY, directionZ, 0, 1, 0, 0);
             }
 
         }