@woosh/meep-engine 2.48.1 → 2.48.5

package/src/engine/ecs/terrain/ecs/Terrain.js

@@ -30,12 +30,9 @@ import { SplatMapping } from "./splat/SplatMapping.js";
 import { OffsetScaleTransform2D } from "./OffsetScaleTransform2D.js";
 import { GridTransformKind } from "./GridTransformKind.js";
 import { makeTerrainWorkerProxy } from "./makeTerrainWorkerProxy.js";
-import { loadLegacyTerrainLayers } from "./layers/loadLegacyTerrainLayers.js";
 import { TerrainFlags } from "./TerrainFlags.js";
 import { IllegalStateException } from "../../../../core/fsm/exceptions/IllegalStateException.js";
 import { buildLightTexture } from "./BuildLightTexture.js";
-import { promiseSamplerHeight } from "./PromiseSamplerHeight.js";
-import { loadLegacyTerrainSplats } from "./splat/loadLegacyTerrainSplats.js";
 import { WHITE_PIXEL_DATA_URL } from "../../../graphics/WHITE_PIXEL_DATA_URL.js";
 import { mat4 } from "gl-matrix";
 import { SurfacePoint3 } from "../../../../core/geom/3d/SurfacePoint3.js";
@@ -470,7 +467,7 @@ class Terrain {
      * @return {boolean}
      */
     raycastVerticalFirstSync(contact, x, y) {
-           return this.__tiles.raycastVerticalFirstSync(contact, x, y);
+        return this.__tiles.raycastVerticalFirstSync(contact, x, y);
     }
 
     /**
@@ -727,25 +724,7 @@ class Terrain {
      * @param {AssetManager} assetManager
      */
     buildFromLegacy(assetManager) {
-        const pSamplerHeight = promiseSamplerHeight(this.heightRange, this.__legacyHeightSamplerURL, assetManager);
-
-        const material = this.__legacyMaterialSpec;
-
-        const pLayers = loadLegacyTerrainLayers(material, this.layers, assetManager, this.size, this.gridScale);
-        const pSplats = loadLegacyTerrainSplats(material, this.splat, assetManager);
-
-        Promise.all([pLayers, pSplats])
-            .then(() => {
-                this.updateMaterial();
-            });
-
-        pSamplerHeight.then((sampler) => {
-            this.samplerHeight = sampler;
-            this.updateHeightTexture();
-
-            this.updateWorkerHeights();
-        });
-
+        throw new Error('Deprecated, no longer supported');
     }
 
     startBuildService() {
@@ -786,6 +765,27 @@ class Terrain {
         }
     }
 
+    buildNonVisual() {
+
+        this.buildGridTransform();
+
+        this.bvh.reset();
+        this.bvh.setNegativelyInfiniteBounds();
+
+        //
+        this.overlay.size.copy(this.size);
+
+        this.__tiles.totalSize.copy(this.size);
+        this.__tiles.scale.set(this.gridScale, this.gridScale);
+        this.__tiles.resolution.set(this.resolution);
+
+
+        this.updateHeightTexture();
+
+        this.updateWorkerHeights();
+
+    }
+
     /**
      *
      * @param {AssetManager} assetManager
@@ -803,29 +803,11 @@ class Terrain {
 
         this.__assetManager = assetManager;
 
-        this.buildGridTransform();
+        this.buildNonVisual();
 
-        this.bvh.reset();
-        this.bvh.setNegativelyInfiniteBounds();
-        //
-        this.overlay.size.copy(this.size);
-
-        this.__tiles.totalSize.copy(this.size);
-        this.__tiles.scale.set(this.gridScale, this.gridScale);
-        this.__tiles.resolution.set(this.resolution);
+        this.layers.buildTexture();
 
-        if (this.__legacyMaterialSpec !== null) {
-            this.buildFromLegacy(assetManager);
-        } else {
-            //modern build path
-            this.updateHeightTexture();
-
-            this.updateWorkerHeights();
-
-            this.layers.buildTexture();
-
-            this.layers.loadTextureData(assetManager);
-        }
+        this.layers.loadTextureData(assetManager);
 
         if (this.lightMapURL !== null) {
             this.material.aoMap = true;

package/src/engine/ecs/terrain/ecs/cling/ClingToTerrainSystem.js

@@ -16,6 +16,9 @@ import { Deque } from "../../../../../core/collection/queue/Deque.js";
 import { obtainTerrain } from "../../util/obtainTerrain.js";
 import { clamp01 } from "../../../../../core/math/clamp01.js";
 import { EPSILON } from "../../../../../core/math/EPSILON.js";
+import { ResourceAccessSpecification } from "../../../../../core/model/ResourceAccessSpecification.js";
+import { ResourceAccessKind } from "../../../../../core/model/ResourceAccessKind.js";
+import Terrain from "../Terrain.js";
 
 
 /**
@@ -55,6 +58,12 @@ class ClingToTerrainSystem extends System {
 
         this.dependencies = [ClingToTerrain, Transform];
 
+
+        this.components_used = [
+            ResourceAccessSpecification.from(Transform, ResourceAccessKind.Read | ResourceAccessKind.Write),
+            ResourceAccessSpecification.from(Terrain, ResourceAccessKind.Read)
+        ];
+
         /**
          *
          * @type {EntityManager|null}

package/src/engine/ecs/terrain/tiles/TerrainTile.js

@@ -515,12 +515,17 @@ class TerrainTile {
     }
 
     dispose() {
+        if (!this.isBuilt) {
+            return;
+        }
+
         if (this.geometry !== null) {
             this.geometry.dispose();
             this.geometry = null;
         }
 
         this.isBuilt = false;
+        this.onDestroyed.send1(this);
     }
 
     build(tileData) {

package/src/engine/ecs/terrain/tiles/TerrainTileManager.js

@@ -218,9 +218,17 @@ class TerrainTileManager {
     destroyTiles() {
 
         //destroy all existing tiles
-        this.tiles.forEach(this.release, this);
+        const tiles = this.tiles;
+        const tile_count = tiles.length;
+
+        for (let i = 0; i < tile_count; i++) {
+            const tile = tiles[i];
+
+            tile.dispose();
+
+        }
 
-        this.tiles.splice(0, this.tiles.length);
+        tiles.splice(0, tile_count);
 
         //clear out BVH
         this.bvh.right = null;
@@ -302,7 +310,9 @@ class TerrainTileManager {
 
     initializeTiles() {
 
-        const gridSize = this.totalSize.clone().divide(this.tileSize).ceil();
+        const gridSize = this.totalSize.clone();
+        gridSize.divide(this.tileSize);
+        gridSize.ceil();
 
         const tileCount = gridSize.x * gridSize.y;
 
@@ -397,6 +407,12 @@ class TerrainTileManager {
      * @returns {TerrainTile}
      */
     getRawTileByPosition(x, y) {
+        assert.isNumber(x, 'x');
+        assert.notNaN(x, 'x');
+
+        assert.isNumber(y, 'y');
+        assert.notNaN(y, 'y');
+
         const tileX = Math.floor(x / this.tileSize.x);
         const tileY = Math.floor(y / this.tileSize.y);
 
@@ -419,7 +435,7 @@ class TerrainTileManager {
 
         vec3.transformMat4(v3, v3, world_inverse);
 
-        return this.getRawTileByPosition(v3.x, v3.z);
+        return this.getRawTileByPosition(v3[0], v3[1]);
     }
 
     /**
@@ -429,6 +445,12 @@ class TerrainTileManager {
      * @returns {Promise<TerrainTile>}
      */
     obtainTileAtWorldPosition2D(x, y) {
+        assert.isNumber(x, 'x')
+        assert.notNaN(x, 'x')
+
+        assert.isNumber(y, 'y')
+        assert.notNaN(y, 'y')
+
         const tile = this.getTileByWorldPosition2D(x, y);
 
         return this.obtain(tile.gridPosition.x, tile.gridPosition.y);
@@ -500,8 +522,6 @@ class TerrainTileManager {
             tile.dispose();
         }
 
-        // TODO check tile.isBuilt flag
-        tile.onDestroyed.send1(tile);
     }
 
     dispose() {

package/src/engine/ecs/tooltip/TooltipComponentSystem.js

@@ -6,6 +6,9 @@ import { SurfacePoint3 } from "../../../core/geom/3d/SurfacePoint3.js";
 import { VisualTip } from "../../../view/tooltip/VisualTip.js";
 import Rectangle from "../../../core/geom/Rectangle.js";
 import { modelHitTest } from "../../graphics/util/modelHitTest.js";
+import { ResourceAccessSpecification } from "../../../core/model/ResourceAccessSpecification.js";
+import { ResourceAccessKind } from "../../../core/model/ResourceAccessKind.js";
+import Mesh from "../../graphics/ecs/mesh/Mesh.js";
 
 const ray_source = new Vector3();
 const ray_direction = new Vector3();
@@ -25,6 +28,10 @@ export class TooltipComponentSystem extends System {
 
         this.dependencies = [TooltipComponent];
 
+        this.components_used = [
+            ResourceAccessSpecification.from(Mesh, ResourceAccessKind.Read)
+        ];
+
         /**
          *
          * @type {GraphicsEngine}

package/src/engine/graphics/ecs/animation/animator/AnimationGraphSystem.js

@@ -10,6 +10,8 @@ import { CameraSystem } from "../../camera/CameraSystem.js";
 import { AnimationGraphFlag } from "./graph/AnimationGraphFlag.js";
 import { projectSphere } from "../../../util/projectSphere.js";
 import { MeshEvents } from "../../mesh/MeshEvents.js";
+import { ResourceAccessSpecification } from "../../../../../core/model/ResourceAccessSpecification.js";
+import { ResourceAccessKind } from "../../../../../core/model/ResourceAccessKind.js";
 
 /**
  *
@@ -40,6 +42,10 @@ export class AnimationGraphSystem extends System {
 
         this.dependencies = [AnimationGraph, Mesh];
 
+        this.components_used = [
+            ResourceAccessSpecification.from(Mesh, ResourceAccessKind.Write)
+        ];
+
         /**
          *
          * @type {number}

package/src/engine/graphics/ecs/camera/CameraSystem.js

@@ -15,6 +15,8 @@ import { update_camera_transform } from "./update_camera_transform.js";
 import { auto_set_camera_clipping_planes } from "./auto_set_camera_clipping_planes.js";
 import { frustum_from_camera } from "./frustum_from_camera.js";
 import { invertQuaternionOrientation } from "./InvertQuaternionOrientation.js";
+import { ResourceAccessSpecification } from "../../../../core/model/ResourceAccessSpecification.js";
+import { ResourceAccessKind } from "../../../../core/model/ResourceAccessKind.js";
 
 export class CameraSystem extends System {
     /**
@@ -30,6 +32,10 @@ export class CameraSystem extends System {
 
         this.dependencies = [Camera, Transform];
 
+        this.components_used = [
+            ResourceAccessSpecification.from(Camera,ResourceAccessKind.Write)
+        ];
+
         /**
          *
          * @type {EntityManager}

package/src/engine/graphics/ecs/camera/pp/PerfectPanner.js

@@ -93,6 +93,7 @@ export class PerfectPanner {
      * @param {Vector2} screen_position
      */
     update(screen_position) {
+        //console.log(`PerfectPanner/update: ${screen_position}`)
 
         const C = this.#grab_world_reference;
         const A = this.#grab_eye_position;
@@ -115,9 +116,12 @@ export class PerfectPanner {
         translation.multiplyScalar(AC.length() / EC.length());
 
         this.#translation.copy(translation);
+
+        // console.log(`translation: ${translation}`);
     }
 
     start(screen_position) {
+        //console.log(`PerfectPanner/start: ${screen_position}`)
 
         // obtain reference point
 

package/src/engine/graphics/ecs/camera/topdown/TopDownCameraControllerSystem.js

@@ -11,6 +11,8 @@ import { System } from '../../../../ecs/System.js';
 
 
 import TopDownCameraController from './TopDownCameraController.js';
+import { ResourceAccessSpecification } from "../../../../../core/model/ResourceAccessSpecification.js";
+import { ResourceAccessKind } from "../../../../../core/model/ResourceAccessKind.js";
 
 
 const v3_scratch = new Vector3();
@@ -22,6 +24,9 @@ class TopDownCameraControllerSystem extends System {
         this.enabled = new ObservedValue(true);
         this.dependencies = [TopDownCameraController];
 
+        this.components_used = [
+            ResourceAccessSpecification.from(Transform,ResourceAccessKind.Write)
+        ];
     }
 
     /**

package/src/engine/graphics/ecs/camera/topdown/TopDownCameraLanderSystem.js

@@ -7,6 +7,8 @@ import TopDownCameraController from "./TopDownCameraController.js";
 import Vector2 from "../../../../../core/geom/Vector2.js";
 import { SignalBinding } from "../../../../../core/events/signal/SignalBinding.js";
 import { obtainTerrain } from "../../../../ecs/terrain/util/obtainTerrain.js";
+import { ResourceAccessSpecification } from "../../../../../core/model/ResourceAccessSpecification.js";
+import { ResourceAccessKind } from "../../../../../core/model/ResourceAccessKind.js";
 
 
 /**
@@ -83,6 +85,10 @@ export class TopDownCameraLanderSystem extends System {
 
         this.dependencies = [TopDownCameraLander, TopDownCameraController];
 
+        this.components_used = [
+            ResourceAccessSpecification.from(TopDownCameraController,ResourceAccessKind.Read|ResourceAccessKind.Write)
+        ];
+
         /**
          * @private
          * @type {Array}

package/src/engine/graphics/ecs/light/LightSystem.js

@@ -18,6 +18,8 @@ import { ShadowManager } from "./shadow/ShadowManager.js";
 import { AbstractContextSystem } from "../../../ecs/system/AbstractContextSystem.js";
 import { LightContext } from "./LightContext.js";
 import { setShadowCameraDimensionsDiscrete } from "./shadow/setShadowCameraDimensionsDiscrete.js";
+import { ResourceAccessSpecification } from "../../../../core/model/ResourceAccessSpecification.js";
+import { ResourceAccessKind } from "../../../../core/model/ResourceAccessKind.js";
 
 class LightSystem extends AbstractContextSystem {
     /**
@@ -40,6 +42,12 @@ class LightSystem extends AbstractContextSystem {
 
         this.dependencies = [Light, Transform];
 
+
+        this.components_used = [
+            ResourceAccessSpecification.from(Light, ResourceAccessKind.Write)
+        ];
+
+
         this.engine = engine;
         this.scene = graphics.scene;
         this.settings = settings;

package/src/engine/graphics/ecs/mesh/MeshSystem.js

@@ -19,6 +19,8 @@ import { applyComponentPropertiesToThreeObject, setMesh } from "./setMesh.js";
 import { GLTFAssetLoader } from "../../../asset/loaders/GLTFAssetLoader.js";
 import { MeshEvents } from "./MeshEvents.js";
 import { assert } from "../../../../core/assert.js";
+import { ResourceAccessSpecification } from "../../../../core/model/ResourceAccessSpecification.js";
+import { ResourceAccessKind } from "../../../../core/model/ResourceAccessKind.js";
 
 const placeholderGeometry = new BoxBufferGeometry(1, 1, 1);
 
@@ -51,6 +53,11 @@ export class MeshSystem extends System {
 
         this.dependencies = [Mesh, Transform];
 
+        this.components_used = [
+            ResourceAccessSpecification.from(Mesh, ResourceAccessKind.Write)
+        ];
+
+
         /**
          *
          * @type {AssetManager}
@@ -119,7 +126,7 @@ export class MeshSystem extends System {
         component.setFlag(MeshFlags.Loaded);
 
         // override
-        if (asset.override_mesh !== undefined ) {
+        if (asset.override_mesh !== undefined) {
             component.override_mesh = asset.override_mesh.clone();
 
             applyComponentPropertiesToThreeObject(component, component.override_mesh, entity);

package/src/engine/graphics/ecs/path/PathDisplaySystem.js

@@ -13,6 +13,10 @@ import { assert } from "../../../../core/assert.js";
 import { TubePathBuilder } from "./tube/build/TubePathBuilder.js";
 import { Deque } from "../../../../core/collection/queue/Deque.js";
 import Signal from "../../../../core/events/signal/Signal.js";
+import { ResourceAccessSpecification } from "../../../../core/model/ResourceAccessSpecification.js";
+import { ResourceAccessKind } from "../../../../core/model/ResourceAccessKind.js";
+import { ShadedGeometry } from "../mesh-v2/ShadedGeometry.js";
+import { Transform } from "../../../ecs/transform/Transform.js";
 
 const builders = {
     [PathDisplayType.None]: function (style, path, result) {
@@ -254,7 +258,9 @@ export class PathDisplaySystem extends AbstractContextSystem {
         ];
 
         this.components_used = [
-            ParentEntity
+            ResourceAccessSpecification.from(ParentEntity, ResourceAccessKind.Create),
+            ResourceAccessSpecification.from(ShadedGeometry, ResourceAccessKind.Create),
+            ResourceAccessSpecification.from(Transform, ResourceAccessKind.Create),
         ];
 
         /**

package/src/engine/graphics/ecs/trail2d/Trail2DSystem.js

@@ -20,6 +20,8 @@ import {
 import { Reference } from "../../../reference/v2/Reference.js";
 import { RibbonXPlugin } from "../../trail/x/RibbonXPlugin.js";
 import { assert } from "../../../../core/assert.js";
+import { ResourceAccessSpecification } from "../../../../core/model/ResourceAccessSpecification.js";
+import { ResourceAccessKind } from "../../../../core/model/ResourceAccessKind.js";
 
 const v3Temp1 = new Vector3();
 
@@ -39,6 +41,11 @@ class Trail2DSystem extends System {
 
         this.dependencies = [Trail2D, Transform];
 
+        this.components_used = [
+            ResourceAccessSpecification.from(Trail2D, ResourceAccessKind.Write)
+        ];
+
+
         /**
          *
          * @type {Engine}

package/src/engine/graphics/geometry/instancing/InstancedMeshGroup.js

@@ -18,6 +18,17 @@ import { max3 } from "../../../../core/math/max3.js";
 import { min2 } from "../../../../core/math/min2.js";
 import { DrawMode } from "../../ecs/mesh-v2/DrawMode.js";
 import { array_copy } from "../../../../core/collection/array/copyArray.js";
+import { Cache } from "../../../../core/cache/Cache.js";
+import { computeMaterialHash } from "../../../asset/loaders/material/computeMaterialHash.js";
+
+/**
+ * @readonly
+ * @type {Cache<Material, {color:Material, depth:Material}>}
+ */
+const material_cache = new Cache({
+    maxWeight: 1024,
+    keyHashFunction: computeMaterialHash
+});
 
 export class InstancedMeshGroup {
     /**
@@ -227,8 +238,11 @@ export class InstancedMeshGroup {
     /**
      *
      * @param {THREE.Material|THREE.ShaderMaterial} sourceMaterial
+     * @returns {{depth: Material, color: Material}}
      */
-    setMaterial(sourceMaterial) {
+    #buildMaterial(sourceMaterial) {
+        //console.warn(`building material : {id:${sourceMaterial.id}, name: ${sourceMaterial.name}, type: ${sourceMaterial.type}`)
+
         const material = sourceMaterial.clone();
 
         if (material.isShaderMaterial) {
@@ -254,13 +268,26 @@ export class InstancedMeshGroup {
 
         depthMaterial.onBeforeCompile = rewriteMaterial;
 
-
         const cachedMaterial = StaticMaterialCache.Global.acquire(material);
 
-        this.__material = cachedMaterial;
+        return {
+            color: cachedMaterial,
+            depth: StaticMaterialCache.Global.acquire(depthMaterial)
+        };
+
+    }
+
+    /**
+     *
+     * @param {THREE.Material|THREE.ShaderMaterial} sourceMaterial
+     */
+    setMaterial(sourceMaterial) {
+        const m = material_cache.getOrCompute(sourceMaterial, this.#buildMaterial, this);
+
+        this.__material = m.color;
 
-        this.mesh.material = cachedMaterial;
-        this.mesh.customDepthMaterial = StaticMaterialCache.Global.acquire(depthMaterial);
+        this.mesh.material = m.color;
+        this.mesh.customDepthMaterial = m.depth;
     }
 
     /**
@@ -317,7 +344,7 @@ export class InstancedMeshGroup {
      * @param {number[]|ArrayLike<number>|Float32Array} transform 4x4 transform matrix of the instance
      */
     setTransformAt(index, transform) {
-        array_copy(transform,0,this.__attributeTransformArray,index*16,16);
+        array_copy(transform, 0, this.__attributeTransformArray, index * 16, 16);
     }
 
     /**
@@ -326,7 +353,7 @@ export class InstancedMeshGroup {
      * @param {number[]|ArrayLike<number>|Float32Array} color RGBA color in uint8 format (0...255), LDR
      */
     setColorAt(index, color) {
-        array_copy(color,0,this.__attributeColorArray,index*4,4);
+        array_copy(color, 0, this.__attributeColorArray, index * 4, 4);
     }
 
     /**

package/src/engine/graphics/particles/ecs/ParticleEmitterSystem.js

@@ -7,6 +7,8 @@ import { RenderPassType } from "../../render/RenderPassType.js";
 import { ImageRGBADataLoader } from "../../../asset/loaders/image/ImageRGBADataLoader.js";
 import { StandardFrameBuffers } from "../../StandardFrameBuffers.js";
 import { assert } from "../../../../core/assert.js";
+import { ResourceAccessSpecification } from "../../../../core/model/ResourceAccessSpecification.js";
+import { ResourceAccessKind } from "../../../../core/model/ResourceAccessKind.js";
 
 /**
  *
@@ -33,6 +35,10 @@ export class ParticleEmitterSystem extends System {
 
         this.dependencies = [ParticleEmitter, Transform];
 
+        this.components_used = [
+            ResourceAccessSpecification.from(ParticleEmitter, ResourceAccessKind.Read | ResourceAccessKind.Write)
+        ];
+
         /**
          *
          * @type {GraphicsEngine}

package/src/engine/grid/systems/GridPosition2TransformSystem.js

@@ -8,6 +8,8 @@ import { GridPosition2Transform } from '../components/GridPosition2Transform.js'
 import Vector3 from "../../../core/geom/Vector3.js";
 import { GridPosition2TransformFlags } from "../components/GridPosition2TransformFlags.js";
 import { obtainTerrain } from "../../ecs/terrain/util/obtainTerrain.js";
+import { ResourceAccessSpecification } from "../../../core/model/ResourceAccessSpecification.js";
+import { ResourceAccessKind } from "../../../core/model/ResourceAccessKind.js";
 
 
 export class GridPosition2TransformSystem extends System {
@@ -16,6 +18,10 @@ export class GridPosition2TransformSystem extends System {
 
         this.dependencies = [GridPosition2Transform, GridPosition, Transform];
 
+        this.components_used = [
+            ResourceAccessSpecification.from(Transform, ResourceAccessKind.Write)
+        ];
+
 
         this.mapPoint = (x, y, v3) => {
             const terrain = obtainTerrain(this.entityManager.dataset);

package/src/engine/grid/transform2grid/Transform2GridPositionSystem.js

@@ -5,6 +5,8 @@ import { Transform } from "../../ecs/transform/Transform.js";
 import Vector2 from "../../../core/geom/Vector2.js";
 import { Transform2GridPositionMode } from "./Transform2GridPositionMode.js";
 import { obtainTerrain } from "../../ecs/terrain/util/obtainTerrain.js";
+import { ResourceAccessSpecification } from "../../../core/model/ResourceAccessSpecification.js";
+import { ResourceAccessKind } from "../../../core/model/ResourceAccessKind.js";
 
 const v2 = new Vector2();
 
@@ -84,6 +86,10 @@ export class Transform2GridPositionSystem extends System {
 
         this.dependencies = [Transform2GridPosition, Transform, GridPosition];
 
+        this.components_used = [
+            ResourceAccessSpecification.from(GridPosition, ResourceAccessKind.Write)
+        ];
+
         /**
          *
          * @type {Synchronizer[]}

package/src/engine/intelligence/behavior/Behavior.js

@@ -3,12 +3,14 @@ import { BehaviorStatus } from "./BehaviorStatus.js";
 /**
  * Base class of behavior tree implementation
  * @see "The Behavior Tree Starter Kit" by Alex J. Champandard and Philip Dunstan
+ * @see https://en.wikipedia.org/wiki/Behavior_tree_(artificial_intelligence,_robotics_and_control)
  * @template CTX
  */
 export class Behavior {
 
     /**
      * Any internal state used by the behavior
+     * This provides a way to interact with the outside as well as to pass data between themselves
      * @type {CTX|null}
      */
     context = null;
@@ -36,11 +38,20 @@ export class Behavior {
      * Used to clean up any resources
      */
     finalize() {
+        // extend in subclasses as necessary
     }
 }
 
 /**
+ * Useful for type checking
  * @readonly
  * @type {boolean}
  */
 Behavior.prototype.isBehavior = true;
+
+/**
+ * Useful for type checking
+ * @readonly
+ * @type {string}
+ */
+Behavior.typeName = "Behavior";

package/src/engine/intelligence/behavior/composite/CompositeBehavior.js

@@ -30,14 +30,20 @@ export class CompositeBehavior extends Behavior {
 
     /**
      *
-     * @param {Behavior[]} many
+     * @param {Behavior[]} children
      */
-    addChildren(many) {
-        const n = many.length;
+    addChildren(children) {
+        assert.isArray(children, 'children');
+
+        const n = children.length;
+
         for (let i = 0; i < n; i++) {
-            const e = many[i];
+
+            const e = children[i];
             this.addChild(e);
+
         }
+
     }
 
     /**

package/src/engine/intelligence/behavior/decorator/AbstractDecoratorBehavior.js

@@ -27,6 +27,7 @@ export class AbstractDecoratorBehavior extends Behavior {
      */
     setSource(source) {
         assert.defined(source, 'source');
+        assert.notNull(source, 'source');
 
         assert.equal(source.isBehavior, true, 'source.isBehavior');