@woosh/meep-engine 2.47.3 → 2.47.10

package/src/engine/graphics/ecs/decal/v2/prototypeDecalSystem.js

@@ -27,6 +27,10 @@ import { OctahedralUvEncoder } from "../../../impostors/octahedral/grid/Octahedr
 import { makeSolidArrowGeometry } from "../../../../../../editor/process/symbolic/makeSolidArrowGeometry.js";
 import { vec3 } from "gl-matrix";
 import Quaternion from "../../../../../core/geom/Quaternion.js";
+import { GizmoRenderingPlugin } from "../../../render/gizmo/GizmoRenderingPlugin.js";
+import { Gizmo } from "../../../render/gizmo/Gizmo.js";
+import { ForwardPlusRenderingPlugin } from "../../../render/forward_plus/plugin/ForwardPlusRenderingPlugin.js";
+import { TaskLoadingScreen } from "../../../../../view/task/TaskLoadingScreen.js";
 
 const decal_urls = `data/textures/icons/FantasyIconsMegaPack/MagicItems/MagicItems_png/transparent/x64/staff_13_t.png
 data/textures/icons/FantasyIconsMegaPack/MagicItems/MagicItems_png/transparent/x64/artifact_01_t.png
@@ -371,18 +375,87 @@ function makeNormalTestDecal() {
     return entity;
 }
 
+function sample_grid(ecd) {
+    const q_down = new Quaternion();
+    q_down.lookRotation(Vector3.down)
+
+    makeNormalTestGridDecal(ecd, Transform.fromJSON({
+        position: new Vector3(5, 0, 5),
+        rotation: q_down
+    }));
+
+
+    const q_forward = new Quaternion();
+    q_forward.lookRotation(Vector3.forward)
+
+    const t_forward_grid = Transform.fromJSON({
+        position: new Vector3(5, 4, 5),
+        rotation: q_forward
+    });
+    makeNormalTestGridDecal(ecd, t_forward_grid);
+
+    new EntityBuilder()
+        .add(SGMesh.fromURL('data/models/snaps/cube_white.gltf'))
+        .add(Transform.fromJSON({
+            position: new Vector3(14, 1, 4.8),
+            rotation: t_forward_grid.rotation,
+            scale: new Vector3(25, 25, 0.1)
+        }))
+        .build(ecd);
+}
+
+function raycast_tool(engine) {
+    let hits = [];
+
+    engine.graphics.on.preRender.add(() => {
+
+        hits.forEach(hit => {
+
+            Gizmo.draw_solid_sphere(hit.contact.position.asArray(), 0.1);
+
+        });
+
+    });
+
+    engine.devices.pointer.position.onChanged.add(() => {
+        const ray_origin = new Vector3();
+        const ray_direction = new Vector3();
+
+
+        const pointer = engine.devices.pointer.position;
+
+        const ndc = new Vector2();
+
+        engine.graphics.normalizeViewportPoint(pointer, ndc);
+        engine.graphics.viewportProjectionRay(ndc.x, ndc.y, ray_origin, ray_direction);
+
+        hits = engine.entityManager.getSystem(FPDecalSystem)?.raycast(
+            ray_origin.x, ray_origin.y, ray_origin.z,
+            ray_direction.x, ray_direction.y, ray_direction.z
+        );
+
+        console.warn(hits);
+
+    });
+}
+
 /**
  *
  * @param {Engine} engine
  */
 async function main(engine) {
 
+    const fpp = engine.plugins.getPlugin(ForwardPlusRenderingPlugin);
+    fpp.setClusterResolution(12, 8, 1);
+
+    const TERRAIN_SIZE = 1000;
+
     await EngineHarness.buildBasics({
         engine,
         enableWater: false,
         cameraFarDistance: 300,
         terrainResolution: 1,
-        terrainSize: new Vector2(1000, 1000)
+        terrainSize: new Vector2(TERRAIN_SIZE, TERRAIN_SIZE)
     });
 
     new EntityBuilder()
@@ -396,10 +469,12 @@ async function main(engine) {
 
     const random = seededRandom();
 
-    const ENTITY_COUNT = 1;
+    const ENTITY_COUNT = 100000;
 
     const ecd = engine.entityManager.dataset;
 
+    console.log('Decal image pool size:', decal_urls.length);
+
     function makeOne() {
         const decal = new Decal();
 
@@ -411,17 +486,17 @@ async function main(engine) {
 
         const transform = new Transform();
         transform.position.set(
-            randomFloatBetween(random, -400, 400),
+            randomFloatBetween(random, 0, TERRAIN_SIZE),
             randomFloatBetween(random, 0, 0),
-            randomFloatBetween(random, -400, 400)
+            randomFloatBetween(random, 0, TERRAIN_SIZE)
         );
-        transform.rotation.random(random);
-        transform.scale.setScalar(0.5);
+        transform.rotation._lookRotation(0, -1, 0, 0, 1, 0);
+        transform.scale.set(1,1,0.5);
 
         entity
             .add(transform)
             .add(decal)
-            .add(BehaviorComponent.fromOne(RotationBehavior.fromJSON({ speed: 1 })))
+        // .add(BehaviorComponent.fromOne(RotationBehavior.fromJSON({ speed: 1 })))
 
         entity.build(ecd);
     }
@@ -433,34 +508,9 @@ async function main(engine) {
 
     const task = countTask(0, ENTITY_COUNT, makeOne);
 
-    const q_down = new Quaternion();
-    q_down.lookRotation(Vector3.down)
-
-    makeNormalTestGridDecal(ecd, Transform.fromJSON({
-        position: new Vector3(5, 0, 5),
-        rotation: q_down
-    }));
-
-
-    const q_forward = new Quaternion();
-    q_forward.lookRotation(Vector3.forward)
-
-    const t_forward_grid = Transform.fromJSON({
-        position: new Vector3(5, 4, 5),
-        rotation: q_forward
-    });
-    makeNormalTestGridDecal(ecd, t_forward_grid);
-
-    new EntityBuilder()
-        .add(SGMesh.fromURL('data/models/snaps/cube_white.gltf'))
-        .add(Transform.fromJSON({
-            position: new Vector3(14, 1, 4.8),
-            rotation: t_forward_grid.rotation,
-            scale: new Vector3(25, 25, 0.1)
-        }))
-        .build(ecd);
+    //sample_grid(ecd);
 
-    // TaskLoadingScreen.instance.load(engine, task);
+    TaskLoadingScreen.instance.load(engine, task);
 
     // console.profile('spawn');
 
@@ -468,34 +518,14 @@ async function main(engine) {
         // console.profileEnd('spawn');
     });
 
-    // engine.executor.run(task);
+    engine.executor.run(task);
 
 
     //grid(engine.entityManager.dataset, 20,10,80, 25, .4, .6, .1, decal_urls.slice(105, 105+3));
 
     //grid(engine.entityManager.dataset, 20,30,80, 25, .4, .6, .1, decal_urls.slice(105, 105+3));
     // await promise_time_out(10);
-
-    engine.devices.pointer.position.onChanged.add(() => {
-        const ray_origin = new Vector3();
-        const ray_direction = new Vector3();
-
-
-        const pointer = engine.devices.pointer.position;
-
-        const ndc = new Vector2();
-
-        engine.graphics.normalizeViewportPoint(pointer,ndc);
-        engine.graphics.viewportProjectionRay(ndc.x, ndc.y, ray_origin, ray_direction);
-
-        const hits = engine.entityManager.getSystem(FPDecalSystem)?.raycast(
-            ray_origin.x, ray_origin.y, ray_origin.z,
-            ray_direction.x, ray_direction.y, ray_direction.z
-        );
-
-        console.warn(hits);
-
-    });
+    // raycast_tool(engine);
 
 }
 
@@ -504,6 +534,8 @@ new EngineHarness()
         configuration(config, engine) {
             const gltfAssetLoader = new GLTFAssetLoader();
 
+            config.addPlugin(GizmoRenderingPlugin);
+
             config.addLoader(GameAssetType.ModelGLTF_JSON, gltfAssetLoader);
             config.addLoader(GameAssetType.ModelGLTF, gltfAssetLoader);
 

package/src/engine/graphics/geometry/buffered/compute_buffer_geometry_byte_size.js

@@ -6,7 +6,11 @@
 export function compute_buffer_geometry_byte_size(g) {
     let result = 0;
 
-    result += g.getIndex().array.buffer.byteLength;
+    const index = g.getIndex();
+
+    if (index !== null) {
+        result += index.array.buffer.byteLength;
+    }
 
     for (const attribute_name in g.attributes) {
         result += g.attributes[attribute_name].array.buffer.byteLength;

package/src/engine/graphics/geometry/buffered/query/ClippingPlaneContainmentComputingVisitor.js

@@ -1,4 +1,4 @@
-import { computeAABB3PlaneSide } from "../../../../../core/geom/3d/aabb/computeAABB3PlaneSide.js";
+import { aabb3_compute_plane_side } from "../../../../../core/geom/3d/aabb/aabb3_compute_plane_side.js";
 import { NodeType } from "../../../../../core/bvh2/binary/NodeType.js";
 import { computeTrianglePlaneSide } from "../../../../../core/geom/3d/triangle/computeTrianglePlaneSide.js";
 import { GeometrySpatialAcceleratorVisitor } from "./GeometryVisitor.js";
@@ -162,7 +162,7 @@ export class ClippingPlaneContainmentComputingVisitor extends GeometrySpatialAcc
                 const plane_normal_z = plane.normal.z;
                 const plane_constant = plane.constant;
 
-                const side = computeAABB3PlaneSide(
+                const side = aabb3_compute_plane_side(
                     plane_normal_x,
                     plane_normal_y,
                     plane_normal_z,

package/src/engine/graphics/geometry/buffered/query/RaycastNearestHitComputingVisitor.js

@@ -3,7 +3,7 @@ import { NodeType } from "../../../../../core/bvh2/binary/NodeType.js";
 import Vector3 from "../../../../../core/geom/Vector3.js";
 import { computeTriangleRayIntersection } from "../../../../../core/geom/3d/triangle/computeTriangleRayIntersection.js";
 import { GeometrySpatialAcceleratorVisitor } from "./GeometryVisitor.js";
-import { aabb3_intersects_ray } from "../../../../../core/bvh2/aabb3/aabb3_intersects_ray.js";
+import { aabb3_intersects_ray } from "../../../../../core/geom/3d/aabb/aabb3_intersects_ray.js";
 import { assert } from "../../../../../core/assert.js";
 
 export class RaycastNearestHitComputingVisitor extends GeometrySpatialAcceleratorVisitor {

package/src/engine/graphics/geometry/instancing/InstancedMeshGroup.js

@@ -17,6 +17,7 @@ import { rewriteMaterial } from "./rewriteMaterial.js";
 import { max3 } from "../../../../core/math/max3.js";
 import { min2 } from "../../../../core/math/min2.js";
 import { DrawMode } from "../../ecs/mesh-v2/DrawMode.js";
+import { array_copy } from "../../../../core/collection/array/copyArray.js";
 
 export class InstancedMeshGroup {
     /**
@@ -316,7 +317,7 @@ export class InstancedMeshGroup {
      * @param {number[]|ArrayLike<number>|Float32Array} transform 4x4 transform matrix of the instance
      */
     setTransformAt(index, transform) {
-        this.__attributeTransformArray.set(transform, index * 16);
+        array_copy(transform,0,this.__attributeTransformArray,index*16,16);
     }
 
     /**
@@ -325,7 +326,7 @@ export class InstancedMeshGroup {
      * @param {number[]|ArrayLike<number>|Float32Array} color RGBA color in uint8 format (0...255), LDR
      */
     setColorAt(index, color) {
-        this.__attributeColorArray.set(color, index * 4);
+        array_copy(color,0,this.__attributeColorArray,index*4,4);
     }
 
     /**

package/src/engine/graphics/geometry/skining/computeSkinnedMeshBoundingVolumes.js

@@ -3,7 +3,7 @@ import { AABB3 } from "../../../../core/bvh2/aabb3/AABB3.js";
 import Vector4 from "../../../../core/geom/Vector4.js";
 import { computeBoundingSphereFromVertexData } from "../computeBoundingSphereFromVertexData.js";
 import { Box3, Sphere as ThreeSphere, Vector3 as ThreeVector3 } from "three";
-import { computeBoundingBoxFromVertexData } from "../../../../core/geom/3d/aabb/computeBoundingBoxFromVertexData.js";
+import { aabb3_from_v3_array } from "../../../../core/geom/3d/aabb/aabb3_from_v3_array.js";
 
 /**
  *
@@ -21,7 +21,8 @@ export function computeSkinnedMeshBoundingVolumes(mesh) {
     const aabb3 = new AABB3(0, 0, 0, 0, 0, 0);
     const sphere = new Vector4();
 
-    computeBoundingBoxFromVertexData(vertices, aabb3);
+
+    aabb3_from_v3_array(aabb3, vertices, vertices.length);
     computeBoundingSphereFromVertexData(vertices, sphere);
 
     const min = new ThreeVector3(aabb3.x0, aabb3.y0, aabb3.z0);

package/src/engine/graphics/micron/format/MicronGeometry.js

@@ -2,7 +2,7 @@ import { VertexDataSpec } from "../../geometry/VertexDataSpec.js";
 import { assert } from "../../../../core/assert.js";
 import { computeTriangleRayIntersection } from "../../../../core/geom/3d/triangle/computeTriangleRayIntersection.js";
 import { SurfacePoint3 } from "../../../../core/geom/3d/SurfacePoint3.js";
-import { aabb3_array_intersects_ray } from "../../../../core/bvh2/aabb3/aabb3_array_intersects_ray.js";
+import { aabb3_array_intersects_ray } from "../../../../core/geom/3d/aabb/aabb3_array_intersects_ray.js";
 import { sphere_array_intersects_ray } from "../../../../core/geom/3d/sphere/sphere_array_intersects_ray.js";
 import { BitSet } from "../../../../core/binary/BitSet.js";
 import { micron_build_proxy_geometry } from "./micron_build_proxy_geometry.js";

package/src/engine/graphics/micron/format/validate_patch_bounds.js

@@ -1,5 +1,5 @@
 import { noop } from "../../../../core/function/Functions.js";
-import { aabb3_array_contains_point } from "../../../../core/bvh2/aabb3/aabb3_array_contains_point.js";
+import { aabb3_array_contains_point } from "../../../../core/geom/3d/aabb/aabb3_array_contains_point.js";
 import { sphere_array_intersects_point } from "../../../../core/geom/3d/sphere/sphere_array_intersects_point.js";
 
 /**

package/src/engine/graphics/micron/render/refinement/ActivePatchList.js

@@ -4,7 +4,7 @@ import { aabb3_project_to_2d } from "../../../../../core/geom/3d/aabb/aabb3_comp
 import { BitSet } from "../../../../../core/binary/BitSet.js";
 import {
     aabb3_array_intersects_frustum_array
-} from "../../../../../core/bvh2/aabb3/aabb3_array_intersects_frustum_array.js";
+} from "../../../../../core/geom/3d/aabb/aabb3_array_intersects_frustum_array.js";
 
 export class ActivePatchList {
     constructor() {

package/src/engine/graphics/micron/render/refinement/get_geometry_patch_cut.js

@@ -1,8 +1,9 @@
 import { BitSet } from "../../../../../core/binary/BitSet.js";
 import {
     aabb3_array_intersects_frustum_array
-} from "../../../../../core/bvh2/aabb3/aabb3_array_intersects_frustum_array.js";
+} from "../../../../../core/geom/3d/aabb/aabb3_array_intersects_frustum_array.js";
 import { aabb3_estimate_projected_area2 } from "../../../../../core/geom/3d/aabb/aabb3_estimate_projected_area2.js";
+import { SCRATCH_UINT32_TRAVERSAL_STACK } from "../../../../../core/collection/SCRATCH_UINT32_TRAVERSAL_STACK.js";
 
 
 /**
@@ -12,12 +13,7 @@ import { aabb3_estimate_projected_area2 } from "../../../../../core/geom/3d/aabb
 const scratch_traversal_bitset = new BitSet();
 scratch_traversal_bitset.preventShrink();
 
-/**
- * Using a pre-allocated continuous chunk of memory gets us better cache coherence
- * @readonly
- * @type {number[]}
- */
-const scratch_traversal_stack = new Uint32Array(781250);
+const stack = SCRATCH_UINT32_TRAVERSAL_STACK;
 
 /**
  *
@@ -41,16 +37,20 @@ export function get_geometry_patch_cut(
 
     const geometry_id = geometry.id;
 
-    const destination_patch_address = destination.patch_count;
-    let output_patch_cursor = destination_patch_address;
+    let output_patch_cursor = destination.patch_count;
 
     let i;
-    let stack_cursor = 1;
 
     // initialize stack
-    const stack = scratch_traversal_stack;
     const root = geometry.root;
-    stack[0] = root.id;
+
+    /**
+     *
+     * @type {number}
+     */
+    const stack_top = stack.pointer++;
+
+    stack[stack_top] = root.id;
 
     const included_set = scratch_traversal_bitset;
     included_set.reset();
@@ -60,10 +60,10 @@ export function get_geometry_patch_cut(
     const patches = geometry.patches;
     const destination_patches = destination.patches;
 
-    while (stack_cursor > 0) {
-        stack_cursor--;
+    while (stack.pointer > stack_top) {
+        stack.pointer--;
 
-        const patch_id = stack[stack_cursor];
+        const patch_id = stack[stack.pointer];
         const patch = patches[patch_id];
 
         /*
@@ -101,7 +101,7 @@ export function get_geometry_patch_cut(
                         continue;
                     }
 
-                    stack[stack_cursor++] = child_id;
+                    stack[stack.pointer++] = child_id;
                 }
 
                 continue;

package/src/engine/graphics/render/forward_plus/LightManager.js

@@ -1133,14 +1133,17 @@ export class LightManager {
         assert.isNumber(x, 'x');
         assert.isNonNegativeInteger(x, 'x');
         assert.isFiniteNumber(x, 'x');
+        assert.greaterThan(x,0,'x must be > 0');
 
         assert.isNumber(y, 'y');
         assert.isNonNegativeInteger(y, 'y');
         assert.isFiniteNumber(y, 'y');
+        assert.greaterThan(y,0,'y must be > 0');
 
         assert.isNumber(z, 'z');
         assert.isNonNegativeInteger(z, 'z');
         assert.isFiniteNumber(z, 'z');
+        assert.greaterThan(z,0,'z must be > 0');
 
         const r = this.__tiles_resolution;
 

package/src/engine/graphics/render/forward_plus/LightManager.spec.js

@@ -20,7 +20,7 @@ test('correct cluster content (empty)', () => {
 
     const tex = lm.getTextureClusters();
 
-    expect(Array.from(tex.image.data)).toEqual([0, 0, 0]);
+    expect(Array.from(tex.image.data)).toEqual([0, 0, 0, 0]);
 });
 
 test('correct cluster content (single small light)', () => {
@@ -35,7 +35,7 @@ test('correct cluster content (single small light)', () => {
 
     const camera = new PerspectiveCamera(45, 1, 1, 10);
     camera.lookAt(0, 0, 5);
-    
+
     camera.updateProjectionMatrix();
     camera.updateMatrix();
     camera.updateMatrixWorld(true);
@@ -46,7 +46,7 @@ test('correct cluster content (single small light)', () => {
 
     const tex = lm.getTextureClusters();
 
-    expect(Array.from(tex.image.data)).toEqual([0, 1, 0]);
+    expect(Array.from(tex.image.data)).toEqual([0, 1, 0, 0]);
 });
 
 test('correct cluster content (single huge light)', () => {
@@ -68,7 +68,7 @@ test('correct cluster content (single huge light)', () => {
 
     const tex = lm.getTextureClusters();
 
-    expect(Array.from(tex.image.data)).toEqual([0, 1, 0]);
+    expect(Array.from(tex.image.data)).toEqual([0, 1, 0, 0]);
 });
 
 test('correct cluster content (single huge light overlapping)', () => {
@@ -90,5 +90,5 @@ test('correct cluster content (single huge light overlapping)', () => {
 
     const tex = lm.getTextureClusters();
 
-    expect(Array.from(tex.image.data)).toEqual([0, 1, 0]);
+    expect(Array.from(tex.image.data)).toEqual([0, 1, 0, 0]);
 });

package/src/engine/graphics/render/forward_plus/materials/FP_SHADER_CHUNK_APPLY_DECALS.js

@@ -54,6 +54,10 @@ export const FP_SHADER_CHUNK_APPLY_DECALS = `
                             
             vec4 decal_color = texture2D(fp_t_decal_atlas,decal_uv, -0.2);
             
+            vec4 decal_color_tint = texelFetch(fp_t_light_data, address_to_data_texture_coordinates(light_address+5u), 0);
+            
+            decal_color*= decal_color_tint;
+            
             // compute decal alpha
             float decal_alpha = decal_color.a * decal_surface_angle_fade;
             

package/src/engine/graphics/render/forward_plus/model/Decal.js

@@ -19,6 +19,11 @@ export class Decal extends AbstractLight {
         this.transform_inverse = new Float32Array(16);
         this.uv = new Float32Array(4);
 
+        this.color = new Float32Array(4);
+        // initialize color to full white
+        this.color.fill(1);
+
+
         /**
          *
          * @type {Sampler2D}
@@ -98,8 +103,11 @@ export class Decal extends AbstractLight {
         array_copy(this.uv, 0, destination, address + 16, 4);
 
         // required for sorting
-        destination[address + 20] = this.draw_priority;
-        destination[address + 21] = this.id;
+        // destination[address + 20] = this.draw_priority;
+        // destination[address + 21] = this.id;
+
+        // color
+        array_copy(this.color, 0, destination, address + 20, 4);
 
         return 24;
     }

package/src/engine/graphics/render/forward_plus/query/query_bvh_frustum_from_objects.js

@@ -1,5 +1,5 @@
 import {
-    aabb3_computeDistanceAbovePlane_max
+    aabb3_compute_distance_above_plane_max
 } from "../../../../../core/geom/3d/aabb/aabb3_compute_distance_above_plane_max.js";
 import { point_light_inside_volume } from "./point_light_inside_volume.js";
 import { spot_light_inside_volume } from "./spot_light_inside_volume.js";
@@ -52,7 +52,7 @@ export function query_bvh_frustum_from_objects(
                 const plane_normal_z = planes[plane_address + 2];
                 const plane_constant = planes[plane_address + 3];
 
-                const distanceAbovePlane = aabb3_computeDistanceAbovePlane_max(
+                const distanceAbovePlane = aabb3_compute_distance_above_plane_max(
                     plane_normal_x, plane_normal_y, plane_normal_z, plane_constant,
                     n.x0, n.y0, n.z0,
                     n.x1, n.y1, n.z1

package/src/engine/graphics/render/forward_plus/query/query_bvh_frustum_from_texture.js

@@ -1,14 +1,11 @@
 import {
-    aabb3_computeDistanceAbovePlane_max
+    aabb3_compute_distance_above_plane_max
 } from "../../../../../core/geom/3d/aabb/aabb3_compute_distance_above_plane_max.js";
 import { point_light_inside_volume } from "./point_light_inside_volume.js";
 import { BVH_BINARY_NODE_SIZE, BVH_LEAF_NODE_SIZE } from "../../../../../core/bvh2/binary/2/BinaryUint32BVH.js";
+import { SCRATCH_UINT32_TRAVERSAL_STACK } from "../../../../../core/collection/SCRATCH_UINT32_TRAVERSAL_STACK.js";
 
-/**
- *
- * @type {number[]}
- */
-const stack = [];
+const stack = SCRATCH_UINT32_TRAVERSAL_STACK;
 
 /**
  *
@@ -33,7 +30,7 @@ function frustum_check(data_view, address, planes) {
         const plane_normal_z = planes[plane_address + 2];
         const plane_constant = planes[plane_address + 3];
 
-        const distanceAbovePlane = aabb3_computeDistanceAbovePlane_max(
+        const distanceAbovePlane = aabb3_compute_distance_above_plane_max(
             plane_normal_x, plane_normal_y, plane_normal_z, plane_constant,
             n_x0, n_y0, n_z0,
             n_x1, n_y1, n_z1
@@ -70,8 +67,6 @@ export function query_bvh_frustum_from_texture(
     source_data,
     planes, points
 ) {
-
-    let stackPointer = 1;
     let result = 0;
 
     const binary_node_count = root.getBinaryNodeCount();
@@ -81,19 +76,26 @@ export function query_bvh_frustum_from_texture(
         return 0;
     }
 
+    /**
+     *
+     * @type {number}
+     */
+    const stack_top = stack.pointer++;
+
     /**
      * After performing empirical tests, stack-based depth-first traversal turns out faster than using a queue
      * @type {number}
      */
-    stack[0] = 0;
+    stack[stack_top] = 0;
 
     const last_valid_index = binary_node_count + root.getLeafNodeCount();
     const data_view = root.getDataView();
 
-    while (stackPointer-- > 0) {
+    do {
+        stack.pointer--;
 
         // query_bvh_frustum_from_objects.iteration_count++;
-        const node_index = stack[stackPointer];
+        const node_index = stack[stack.pointer];
 
         if (node_index < binary_node_count) {
             // is intermediate node
@@ -108,11 +110,11 @@ export function query_bvh_frustum_from_texture(
 
             // left node ends up on top of the stack, which aligns with the desired access sequence
             if (right_index < last_valid_index) {
-                stack[stackPointer++] = right_index;
+                stack[stack.pointer++] = right_index;
                 // micro-optimization, since we know that right node is valid and left appears before that, left is valid too
-                stack[stackPointer++] = left_index;
+                stack[stack.pointer++] = left_index;
             } else if (left_index < last_valid_index) {
-                stack[stackPointer++] = left_index;
+                stack[stack.pointer++] = left_index;
             }
 
 
@@ -160,7 +162,7 @@ export function query_bvh_frustum_from_texture(
             result++;
         }
 
-    }
+    }while (stack.pointer > stack_top)
 
     return result;
 }

package/src/engine/graphics/render/gizmo/GizmoShapeRenderingInterface.js

@@ -35,6 +35,8 @@ function add_instance(group, matrix, color) {
         Math.round(color[2] * 255),
         Math.round(color[3] * 255)
     );
+
+    group.requestAttributeUpdate();
 }
 
 /**