@woosh/meep-engine 2.46.8 → 2.46.10

package/package.json

@@ -4,7 +4,7 @@
   "productName": "Meep",
   "description": "production-ready JavaScript game engine based on Entity Component System Architecture",
   "author": "Alexander Goldring",
-  "version": "2.46.8",
+  "version": "2.46.10",
   "main": "build/meep.module.js",
   "module": "build/meep.module.js",
   "scripts": {

package/src/core/model/node-graph/node/NodeDescription.js

@@ -29,6 +29,12 @@ function pickNewSetId(things) {
     return r;
 }
 
+/**
+ *
+ * @type {number}
+ */
+let node_id_counter = 0;
+
 export class NodeDescription {
     constructor() {
         /**
@@ -38,10 +44,13 @@ export class NodeDescription {
         this.name = "";
 
         /**
-         *
+         * A unique identifier in the scope of a single registry
+         * If two nodes belong to the same registry - they must have different IDs
+         * By default an auto-incrementing ID is assigned, as this ID is assigned at the time of object construction - it may be subject to race conditions
+         * In case nodes are loaded or constructed in async manner - consider using your own ID assignment scheme
          * @type {number}
          */
-        this.id = 0;
+        this.id = node_id_counter++;
 
         /**
          * @protected

package/src/core/model/node-graph/node/NodeRegistry.js

@@ -38,12 +38,21 @@ export class NodeRegistry {
     /**
      *
      * @param {NodeDescription} node
+     * @returns {boolean} true if node was added, false if node already exists
      */
     addNode(node) {
         assert.defined(node, "node");
         assert.notNull(node, "node");
 
-        if (this.nodes.has(node.id)) {
+        const existing_node = this.nodes.get(node.id);
+
+        if (existing_node !== undefined) {
+
+            if (existing_node !== node) {
+                // node with the same ID exists and is not the same node
+                throw new Error(`A different node with the same ID ${node.id} is already registered. IDs of all nodes in the registry must be unique`);
+            }
+
             // console.warn(`Node with id ${node.id} already exists`);
 
             return false;