@woosh/meep-engine 2.46.16 → 2.46.18

package/package.json

@@ -4,7 +4,7 @@
   "productName": "Meep",
   "description": "production-ready JavaScript game engine based on Entity Component System Architecture",
   "author": "Alexander Goldring",
-  "version": "2.46.16",
+  "version": "2.46.18",
   "main": "build/meep.module.js",
   "module": "build/meep.module.js",
   "scripts": {

package/src/core/model/node-graph/NodeGraph.js

@@ -131,8 +131,7 @@ export class NodeGraph {
         const previous_node_count = this.nodes.length;
         const previous_connection_count = this.connections.length;
 
-        const other_nodes = nodes;
-        const additional_node_count = other_nodes.length;
+        const additional_node_count = nodes.length;
 
         /**
          * Mapping from original IDs to IDs in this graph
@@ -141,26 +140,25 @@ export class NodeGraph {
         const this_nodes = {};
 
         for (let i = 0; i < additional_node_count; i++) {
-            const other_node = other_nodes[i];
+            const other_node = nodes[i];
             this_nodes[other_node.id] = this.createNode(other_node.description);
         }
 
         // create connections
-        const other_connections = connections;
-        const additional_connection_count = other_connections.length;
+        const additional_connection_count = connections.length;
 
         for (let i = 0; i < additional_connection_count; i++) {
-            const other_connection = other_connections[i];
+            const other_connection = connections[i];
 
             const other_source = other_connection.source;
 
             const this_source_node_id = this_nodes[other_source.instance.id];
-            const this_source_port_id = this.getNode(this_source_node_id).getEndpoint(other_source.port.id).id;
+            const this_source_port_id = other_source.port.id;
 
             const other_target = other_connection.target;
 
             const this_target_node_id = this_nodes[other_target.instance.id];
-            const this_target_port_id = this.getNode(this_target_node_id).getEndpoint(other_target.port.id).id;
+            const this_target_port_id = other_target.port.id;
 
             this.createConnection(
                 this_source_node_id, this_source_port_id,
@@ -328,7 +326,7 @@ export class NodeGraph {
         const n = connections.length;
 
         for (let i = 0; i < n; i++) {
-            const connection = connections[i];
+            const connection = connections.get(i);
 
             if (connection.id === id) {
                 return connection;
@@ -572,6 +570,11 @@ export class NodeGraph {
      * @returns {number} number of found connections
      */
     getConnectionsAttachedToNode(id, result) {
+        assert.isNonNegativeInteger(id, 'id');
+
+        assert.defined(result, 'result');
+        assert.isArray(result, 'result');
+
         let count = 0;
 
         const connections = this.connections;

package/src/core/model/node-graph/NodeGraph.spec.js

@@ -51,6 +51,29 @@ test("createConnection populates NodeInstance.connections", () => {
     expect(g.getNode(i1).connections.length).toBe(1);
 });
 
+test("getConnection", () => {
+
+    const g = new NodeGraph();
+
+    const node = new NodeDescription();
+
+    const dt = new DataType();
+
+    const pInt = node.createPort(dt, "in", PortDirection.In);
+    const pOut = node.createPort(dt, "out", PortDirection.Out);
+
+    const i0 = g.createNode(node);
+    const i1 = g.createNode(node);
+
+    const connectionId = g.createConnection(i0, pOut, i1, pInt);
+
+    const connection = g.getConnection(connectionId);
+
+    expect(connection).toBeDefined();
+    expect(connection.id).toBe(connectionId);
+
+});
+
 test('getNode produces correct result', () => {
     const graph = new NodeGraph();