@woosh/meep-engine 2.43.37 → 2.43.38

package/core/geom/3d/sphere/harmonics/sh3_basis_at.js

@@ -0,0 +1,30 @@
+/**
+ * evaluate the basis functions
+ * shBasis is an Array[ 9 ]
+ *
+ * @param {number} x
+ * @param {number} y
+ * @param {number} z
+ * @param {number[]|ArrayLike<number>|Float32Array|Float64Array} shBasis
+ */
+export function sh3_basis_at(x, y, z, shBasis) {
+
+    // normal is assumed to be unit length
+
+
+    // band 0
+    shBasis[0] = 0.282095;
+
+    // band 1
+    shBasis[1] = 0.488603 * y;
+    shBasis[2] = 0.488603 * z;
+    shBasis[3] = 0.488603 * x;
+
+    // band 2
+    shBasis[4] = 1.092548 * x * y;
+    shBasis[5] = 1.092548 * y * z;
+    shBasis[6] = 0.315392 * (3 * z * z - 1);
+    shBasis[7] = 1.092548 * x * z;
+    shBasis[8] = 0.546274 * (x * x - y * y);
+
+}

package/core/geom/3d/sphere/harmonics/sh3_sample_by_direction.js

@@ -27,21 +27,22 @@ export function sh3_sample_by_direction(
     let channel_value;
 
     for (let i = 0; i < dimension_count; i++) {
+        const offset = harmonics_offset + dimension_count * i;
 
         // band 0
-        channel_value = harmonics[harmonics_offset + i] * 0.282095;
+        channel_value = harmonics[offset] * 0.282095;
 
         // band 1
-        channel_value += harmonics[harmonics_offset + dimension_count + i] * 0.488603 * y;
-        channel_value += harmonics[harmonics_offset + dimension_count * 2 + i] * 0.488603 * z;
-        channel_value += harmonics[harmonics_offset + dimension_count * 3 + i] * 0.488603 * x;
+        channel_value += harmonics[offset + 1] * 0.488603 * y;
+        channel_value += harmonics[offset + 2] * 0.488603 * z;
+        channel_value += harmonics[offset + 3] * 0.488603 * x;
 
         // band 2
-        channel_value += harmonics[harmonics_offset + dimension_count * 4 + i] * 1.092548 * (x * y);
-        channel_value += harmonics[harmonics_offset + dimension_count * 5 + i] * 1.092548 * (y * z);
-        channel_value += harmonics[harmonics_offset + dimension_count * 6 + i] * 0.315392 * (3.0 * z * z - 1.0);
-        channel_value += harmonics[harmonics_offset + dimension_count * 7 + i] * 1.092548 * (x * z);
-        channel_value += harmonics[harmonics_offset + dimension_count * 8 + i] * 0.546274 * (x * x - y * y);
+        channel_value += harmonics[offset + 4] * 1.092548 * (x * y);
+        channel_value += harmonics[offset + 5] * 1.092548 * (y * z);
+        channel_value += harmonics[offset + 6] * 0.315392 * (3.0 * z * z - 1.0);
+        channel_value += harmonics[offset + 7] * 1.092548 * (x * z);
+        channel_value += harmonics[offset + 8] * 0.546274 * (x * x - y * y);
 
         // write out
         result[result_offset + i] = channel_value;

package/engine/graphics/sh3/LightProbeVolume.js

@@ -29,40 +29,10 @@ import { build_three_object } from "../ecs/mesh-v2/build_three_object.js";
 import { ShadedGeometryFlags } from "../ecs/mesh-v2/ShadedGeometryFlags.js";
 import { v3_length_sqr } from "../../../core/geom/v3_length_sqr.js";
 import { sh3_dering_optimize_positive } from "../../../core/geom/3d/sphere/harmonics/sh3_dering_optimize_positive.js";
+import { sh3_basis_at } from "../../../core/geom/3d/sphere/harmonics/sh3_basis_at.js";
 
 const TEMP_CONTACT = new SurfacePoint3();
 
-/**
- * evaluate the basis functions
- * shBasis is an Array[ 9 ]
- *
- * @param {number} x
- * @param {number} y
- * @param {number} z
- * @param {number[]|ArrayLike<number>|Float32Array|Float64Array} shBasis
- */
-function getBasisAt(x, y, z, shBasis) {
-
-    // normal is assumed to be unit length
-
-
-    // band 0
-    shBasis[0] = 0.282095;
-
-    // band 1
-    shBasis[1] = 0.488603 * y;
-    shBasis[2] = 0.488603 * z;
-    shBasis[3] = 0.488603 * x;
-
-    // band 2
-    shBasis[4] = 1.092548 * x * y;
-    shBasis[5] = 1.092548 * y * z;
-    shBasis[6] = 0.315392 * (3 * z * z - 1);
-    shBasis[7] = 1.092548 * x * z;
-    shBasis[8] = 0.546274 * (x * x - y * y);
-
-}
-
 /**
  *
  * @param {Uint8Array} data
@@ -160,7 +130,7 @@ function fromCubeRenderTarget(data, renderer, cubeRenderTarget) {
             normal_z /= length;
 
             // evaluate SH basis functions in direction dir
-            getBasisAt(normal_x, normal_y, normal_z, sh_basis);
+            sh3_basis_at(normal_x, normal_y, normal_z, sh_basis);
 
             // pixel color, already in linear space so no sRGB->Linear conversion necessary
 
@@ -266,7 +236,7 @@ class CubeRenderer {
             //
             //     object3D.material.color.copy(source_material.color);
             // } else {
-                object3D.material = source_material.clone();
+            object3D.material = source_material.clone();
             // }
 
             applyTransformToThreeObject(object3D, t);

package/package.json

@@ -5,7 +5,7 @@
   "productName": "Meep",
   "description": "production-ready JavaScript game engine based on Entity Component System Architecture",
   "author": "Alexander Goldring",
-  "version": "2.43.37",
+  "version": "2.43.38",
   "dependencies": {
     "gl-matrix": "3.4.3",
     "fast-levenshtein": "2.0.6",