@woosh/meep-engine 2.39.35 → 2.39.36

package/core/bvh2/bvh3/bvh_query_user_data_overlaps_frustum.js

@@ -18,7 +18,8 @@ export function bvh_query_user_data_overlaps_frustum(
     result,
     result_offset,
     bvh,
-    frustum) {
+    frustum
+) {
     const root = bvh.root;
 
     if (root === NULL_NODE) {
@@ -58,19 +59,19 @@ export function bvh_query_user_data_overlaps_frustum(
         if (!node_is_leaf) {
 
             if (intersection === 2) {
-                // fully inside
+                // fully inside, fast collection path
                 result_cursor += bvh_collect_user_data(result, result_cursor, bvh, node);
-                continue;
+            } else {
+                // partially inside
+                // read in-order
+                const child1 = bvh.node_get_child1(node);
+                const child2 = bvh.node_get_child2(node);
+
+                // write to stack in reverse order, so that fist child ends up being visited first
+                traversal_stack[traversal_cursor++] = child1;
+                traversal_stack[traversal_cursor++] = child2;
             }
 
-            // read in-order
-            const child1 = bvh.node_get_child1(node);
-            const child2 = bvh.node_get_child2(node);
-
-            // write to stack in reverse order, so that fist child ends up being visited first
-            traversal_stack[traversal_cursor++] = child1;
-            traversal_stack[traversal_cursor++] = child2;
-
         } else {
             // leaf node
 

package/core/collection/array/computeHashIntegerArray.d.ts

@@ -0,0 +1 @@
+export function computeHashIntegerArray(...value: number[]): number

package/core/collection/array/computeHashIntegerArray.js

@@ -1,15 +1,10 @@
+import { computeIntegerArrayHash } from "../../primitives/array/computeIntegerArrayHash.js";
+
 /**
  * Computes hash on integer values
  * @param {...number} value
  * @returns {number}
  */
-export function computeHashIntegerArray(value) {
-    let hash = 0;
-    const numArguments = arguments.length;
-    for (let i = 0; i < numArguments; i++) {
-        const singleValue = arguments[i];
-        hash = ((hash << 5) - hash) + singleValue;
-        hash |= 0; // Convert to 32bit integer
-    }
-    return hash;
+export function computeHashIntegerArray(...value) {
+    return computeIntegerArrayHash(value, 0, value.length);
 }

package/core/primitives/array/computeIntegerArrayHash.js

@@ -1,6 +1,6 @@
 /**
  *
- * @param {Uint8Array} data
+ * @param {Uint8Array|number[]|ArrayLike<number>|IArguments} data
  * @param {number} offset
  * @param {number} length
  */

package/engine/graphics/ecs/animation/animator/AnimationGraphSystem.js

@@ -200,6 +200,11 @@ export class AnimationGraphSystem extends System {
             return false;
         }
 
+        if (!graph.getFlag(AnimationGraphFlag.Linked)) {
+            // not linked this is generally a case of failed linkage, either way - don't animate
+            return false;
+        }
+
         if (graph.getFlag(AnimationGraphFlag.MeshSizeCulling)) {
 
             //check the size of the mesh in screen space, culling animation of tiny objects

package/engine/graphics/ecs/animation/animator/graph/AnimationGraph.js

@@ -4,7 +4,9 @@ import { AnimationStateType } from "./AnimationStateType.js";
 import { AnimationMixer } from "three";
 import { AnimationGraphFlag } from "./AnimationGraphFlag.js";
 import { writeAnimationGraphDefinitionToJSON } from "./definition/serialization/writeAnimationGraphDefinitionToJSON.js";
-import { readAnimationGraphDefinitionFromJSON } from "./definition/serialization/readAnimationGraphDefinitionFromJSON.js";
+import {
+    readAnimationGraphDefinitionFromJSON
+} from "./definition/serialization/readAnimationGraphDefinitionFromJSON.js";
 import { assert } from "../../../../../../core/assert.js";
 import { threeUpdateTransform } from "../../../../util/threeUpdateTransform.js";
 import { computeHashIntegerArray } from "../../../../../../core/collection/array/computeHashIntegerArray.js";
@@ -399,7 +401,6 @@ export class AnimationGraph {
         const clipIndex = graphDefinition.clipIndex;
         const nClips = clipIndex.length;
 
-
         /**
          * @type {AnimationClip[]}
          */
@@ -433,6 +434,7 @@ export class AnimationGraph {
 
             throw new Error(`Animation '${animationClipDefinition.name}' not found`);
         }
+
     }
 
     link(entity, ecd) {
@@ -549,6 +551,10 @@ export class AnimationGraph {
              */
             const action = this.__actions[i];
 
+            if (action === undefined) {
+                console.warn(`Action[${i}] is undefined`);
+            }
+
             action.weight = weight;
             action.timeScale = timeScale;
         }

package/engine/knowledge/database/StaticKnowledgeDataTable.js

@@ -64,6 +64,13 @@ export class StaticKnowledgeDataTable {
      */
     __automatic_ids = false;
 
+    /**
+     *
+     * @type {string}
+     * @protected
+     */
+    __element_type_name = 'element';
+
     reset() {
         Object.keys(this.elements).forEach(id => {
             delete this.elements[id];
@@ -134,7 +141,7 @@ export class StaticKnowledgeDataTable {
             const element = this.get(id);
 
             if (element === null) {
-                throw new Error(`Failed to get element '${id}' from the database'`);
+                throw new Error(`Failed to get ${this.__element_type_name} '${id}' from the database'`);
             }
 
             result.push(element);
@@ -248,6 +255,17 @@ export class StaticKnowledgeDataTable {
 
             }
 
+            const flag_ignore = datum['@ignore'];
+            if (flag_ignore !== undefined) {
+                if (typeof flag_ignore !== "boolean") {
+                    console.warn(`@ignore flag is present on ${this.__element_type_name} '${id}'. @ignore must be a boolean (true/false), instead was '${typeof flag_ignore}'(=${flag_ignore})`);
+                } else if (flag_ignore) {
+                    console.warn(`[${this.__element_type_name}:${id}] @ignore flag is set to true, skipping`);
+                } else {
+                    console.warn(`[${this.__element_type_name}:${id}] @ignore flag is set to false and has no effect, please remove this field from JSON`);
+                }
+            }
+
             let element;
 
             try {
@@ -262,7 +280,7 @@ export class StaticKnowledgeDataTable {
                     _id = 'ERROR';
                 }
 
-                console.error(`Failed to parse element (id=${_id})`, e, datum);
+                console.error(`Failed to parse ${this.__element_type_name} (id=${_id})`, e, datum);
                 return;
             }
 
@@ -291,7 +309,7 @@ export class StaticKnowledgeDataTable {
             const added = this.add(element);
 
             if (!added) {
-                console.error(`Failed to add element '${id}', most likely this a duplicate key`);
+                console.error(`Failed to add ${this.__element_type_name} '${id}', most likely this a duplicate key`);
             }
         });
 
@@ -344,10 +362,14 @@ export class StaticKnowledgeDataTable {
             try {
                 promise = this.linkOne(element, json, database, assetManager);
             } catch (e) {
-                console.error(`.linkOne(#id=${id}) threw unexpectedly:`, e);
+                const wrap = new Error(`.linkOne(#id=${id}) threw unexpectedly: ${e.message}`);
+
+                if (e.stack !== undefined) {
+                    wrap.stack = e.stack;
+                }
 
                 //re-throw to fail
-                throw e;
+                throw wrap;
             }
 
             if (promise === undefined) {

package/engine/plugin/EnginePluginManager.js

@@ -153,7 +153,6 @@ export class EnginePluginManager extends BaseProcess {
         const removed = this.__plugins.delete(PluginClass);
 
         if (!removed) {
-            console.error('Plugin was not found', PluginClass);
             return;
         }
 
@@ -259,7 +258,7 @@ export class EnginePluginManager extends BaseProcess {
 
         const engine = this.engine;
 
-        await ctx.transition(manager_state_value,engine);
+        await ctx.transition(manager_state_value, engine);
 
         return reference;
 

package/package.json

@@ -5,7 +5,7 @@
   "productName": "Meep",
   "description": "production-ready JavaScript game engine based on Entity Component System Architecture",
   "author": "Alexander Goldring",
-  "version": "2.39.35",
+  "version": "2.39.36",
   "dependencies": {
     "gl-matrix": "3.4.3",
     "fast-levenshtein": "2.0.6",