@woosh/meep-engine 2.39.33 → 2.39.36

package/core/binary/EncodingBinaryBuffer.js

@@ -36,62 +36,59 @@ class Dictionary {
 }
 
 
-function EncodingBinaryBuffer() {
-    BinaryBuffer.call(this);
-    this.__dictionary = new Dictionary();
-}
-
-EncodingBinaryBuffer.prototype = Object.create(BinaryBuffer.prototype);
+export class EncodingBinaryBuffer extends BinaryBuffer {
+    constructor() {
+        super();
+        this.__dictionary = new Dictionary();
+    }
 
-EncodingBinaryBuffer.prototype.writeUTF8String = function (value) {
-    const address = this.__dictionary.getAddress(value);
+    writeUTF8String(value) {
+        const address = this.__dictionary.getAddress(value);
 
-    if (address === undefined) {
-        this.writeUint8(0); //mark as complete value
+        if (address === undefined) {
+            this.writeUint8(0); //mark as complete value
 
-        const address1 = this.position;
+            const address1 = this.position;
 
-        BinaryBuffer.prototype.writeUTF8String.call(this, value);
+            super.writeUTF8String(value);
 
-        this.__dictionary.add(value, address1);
-    } else {
-        //write as reference
-        this.writeUint32LE(1 | (address << 1));
+            this.__dictionary.add(value, address1);
+        } else {
+            //write as reference
+            this.writeUint32LE(1 | (address << 1));
+        }
     }
-};
 
-EncodingBinaryBuffer.prototype.readUTF8String = function () {
-    const header0 = this.readUint8();
+    readUTF8String() {
+        const header0 = this.readUint8();
 
-    if (header0 === 0) {
-        //complete value
-        return BinaryBuffer.prototype.readUTF8String.call(this);
-    } else {
-        this.position--;
+        if (header0 === 0) {
+            //complete value
+            return super.readUTF8String();
+        } else {
+            this.position--;
 
-        const header = this.readUint32LE();
+            const header = this.readUint32LE();
 
-        const address = header >> 1;
+            const address = header >> 1;
 
-        let value = this.__dictionary.getValue(address);
+            let value = this.__dictionary.getValue(address);
 
-        if (value === undefined) {
-            //remember position
-            const p = this.position;
+            if (value === undefined) {
+                //remember position
+                const p = this.position;
 
-            this.position = address;
+                this.position = address;
 
-            value = BinaryBuffer.prototype.readUTF8String.call(this);
+                value = super.readUTF8String();
 
-            //restore position
-            this.position = p;
+                //restore position
+                this.position = p;
 
-            this.__dictionary.add(value, address);
-        }
+                this.__dictionary.add(value, address);
+            }
 
-        return value;
+            return value;
+        }
     }
-};
-
-
-export { EncodingBinaryBuffer };
+}

package/core/bvh2/binary/IndexedBinaryBVH.js

@@ -47,6 +47,14 @@ export default class IndexedBinaryBVH {
         this.data = new Float32Array(16);
     }
 
+    /**
+     *
+     * @returns {number}
+     */
+    estimateByteSize(){
+        return this.data.buffer.byteLength + 248;
+    }
+
     /**
      *
      * @param {int} leafCount

package/core/bvh2/bvh3/ExplicitBinaryBoundingVolumeHierarchy.d.ts

@@ -1,3 +1,23 @@
 export class ExplicitBinaryBoundingVolumeHierarchy {
+    readonly root: number
 
+    allocate_node(): number
+
+    release_node(node: number): void
+
+    insert_leaf(node: number): void
+
+    remove_leaf(node: number): void
+
+    collect_nodes_all(destination: ArrayLike<number>, destination_offset: number): void
+
+    node_set_aabb(node: number, aabb: ArrayLike<number>): void
+
+    node_get_aabb(node: number, aabb: ArrayLike<number>): void
+
+    node_set_user_data(node: number, data: number): void
+
+    node_get_user_data(node: number): number
+
+    release_all(): void
 }

package/core/bvh2/bvh3/ExplicitBinaryBoundingVolumeHierarchy.js

@@ -49,12 +49,6 @@ const ELEMENT_WORD_COUNT = 10;
  */
 const INITIAL_CAPACITY = 128;
 
-/**
- *
- * @type {number[]}
- */
-const scratch_stack = [];
-
 /**
  * Bounding Volume Hierarchy implementation. Stores unsigned integer values at leaves, these are typically IDs or Index values.
  * Highly optimized both in terms of memory usage and CPU. Most of the code inlined. No allocation are performed during usage (except for growing the tree capacity).
@@ -300,7 +294,7 @@ export class ExplicitBinaryBoundingVolumeHierarchy {
     /**
      *
      * @param {number} id
-     * @param {number[]} aabb
+     * @param {number[]|ArrayLike<number>} aabb
      */
     node_set_aabb(id, aabb) {
         assert.isNonNegativeInteger(id, 'id');
@@ -882,36 +876,12 @@ export class ExplicitBinaryBoundingVolumeHierarchy {
 
     /**
      * Release all nodes, this essentially resets the tree to empty state
+     * NOTE: For performance reasons, released memory is not reset, this means that attempting to access cleared nodes' memory will yield garbage data
      */
     release_all() {
-        let cursor = 0;
-        const stack = scratch_stack;
-
-        const root = this.__root;
-
-        if (root !== NULL_NODE) {
-            stack[cursor++] = root;
-        }
-
-        const uint32 = this.__data_uint32;
-
-        while (cursor > 0) {
-            cursor--;
-
-            const node = stack[cursor];
-
-            const node_address = node * ELEMENT_WORD_COUNT;
-
-            const child1 = uint32[node_address + COLUMN_CHILD_1];
-            const child2 = uint32[node_address + COLUMN_CHILD_2];
-
-            if (child1 !== NULL_NODE) {
-                stack[cursor++] = child2;
-                stack[cursor++] = child1;
-            }
-
-            this.release_node(node);
-        }
+        this.__root = NULL_NODE;
+        this.__size = 0;
+        this.__free_pointer = 0;
     }
 
     /**

package/core/bvh2/bvh3/ExplicitBinaryBoundingVolumeHierarchy.spec.js

@@ -143,3 +143,22 @@ test("add and remove 5 nodes", () => {
     }
 
 });
+
+
+test("release_all from empty doesn't throw", () => {
+    const bvh = new ExplicitBinaryBoundingVolumeHierarchy();
+
+    expect(() => bvh.release_all()).not.toThrow();
+});
+
+test("release_all with 1 leaf", () => {
+    const bvh = new ExplicitBinaryBoundingVolumeHierarchy();
+
+    const a = bvh.allocate_node();
+
+    bvh.insert_leaf(a);
+
+    bvh.release_all();
+
+    expect(bvh.root).toBe(NULL_NODE);
+});

package/core/bvh2/bvh3/bvh_query_user_data_overlaps_frustum.js

@@ -18,7 +18,8 @@ export function bvh_query_user_data_overlaps_frustum(
     result,
     result_offset,
     bvh,
-    frustum) {
+    frustum
+) {
     const root = bvh.root;
 
     if (root === NULL_NODE) {
@@ -58,19 +59,19 @@ export function bvh_query_user_data_overlaps_frustum(
         if (!node_is_leaf) {
 
             if (intersection === 2) {
-                // fully inside
+                // fully inside, fast collection path
                 result_cursor += bvh_collect_user_data(result, result_cursor, bvh, node);
-                continue;
+            } else {
+                // partially inside
+                // read in-order
+                const child1 = bvh.node_get_child1(node);
+                const child2 = bvh.node_get_child2(node);
+
+                // write to stack in reverse order, so that fist child ends up being visited first
+                traversal_stack[traversal_cursor++] = child1;
+                traversal_stack[traversal_cursor++] = child2;
             }
 
-            // read in-order
-            const child1 = bvh.node_get_child1(node);
-            const child2 = bvh.node_get_child2(node);
-
-            // write to stack in reverse order, so that fist child ends up being visited first
-            traversal_stack[traversal_cursor++] = child1;
-            traversal_stack[traversal_cursor++] = child2;
-
         } else {
             // leaf node
 

package/core/collection/array/computeHashIntegerArray.d.ts

@@ -0,0 +1 @@
+export function computeHashIntegerArray(...value: number[]): number

package/core/collection/array/computeHashIntegerArray.js

@@ -1,15 +1,10 @@
+import { computeIntegerArrayHash } from "../../primitives/array/computeIntegerArrayHash.js";
+
 /**
  * Computes hash on integer values
  * @param {...number} value
  * @returns {number}
  */
-export function computeHashIntegerArray(value) {
-    let hash = 0;
-    const numArguments = arguments.length;
-    for (let i = 0; i < numArguments; i++) {
-        const singleValue = arguments[i];
-        hash = ((hash << 5) - hash) + singleValue;
-        hash |= 0; // Convert to 32bit integer
-    }
-    return hash;
+export function computeHashIntegerArray(...value) {
+    return computeIntegerArrayHash(value, 0, value.length);
 }

package/core/events/signal/Signal.js

@@ -182,7 +182,7 @@ export class Signal {
      * @returns {boolean} true if a handler was removed, false otherwise
      */
     remove(h, thisArg) {
-        assert.typeOf(h, "function", "handler");
+        assert.isFunction(h, "handler");
 
         if (thisArg === undefined) {
             return removeHandlerByHandler(this, h);
@@ -707,7 +707,7 @@ function removeHandlerByHandlerAndContext(signal, h, ctx) {
 }
 
 function dispatchCallback(f, context, args) {
-    assert.typeOf(f, 'function', 'f');
+    assert.isFunction(f, 'f');
 
     try {
         f.apply(context, args)

package/core/events/signal/SignalHandler.js

@@ -19,7 +19,7 @@ export class SignalHandler {
      */
     constructor(handle, context) {
         assert.notEqual(handle, undefined, 'handle must be defined');
-        assert.typeOf(handle, 'function', 'handle');
+        assert.isFunction(handle, 'handle');
 
 
         this.handle = handle;

package/core/function/FunctionCompiler.js

@@ -22,7 +22,7 @@ class FunctionDefinition {
      * @param {string[]} [args]
      */
     constructor({ name, body, args = [] }) {
-        assert.typeOf(body, 'string', 'body');
+        assert.isString(body, 'body');
 
         /**
          *

package/core/land/reactive/compileReactiveExpression.js

@@ -8,7 +8,7 @@ import { ReactivePegParser } from "./pegjs/ReactivePegParser.js";
  * @returns {ReactiveExpression}
  */
 export function compileReactiveExpression(code) {
-    assert.typeOf(code, 'string', 'code');
+    assert.isString(code, 'code');
 
     const parseTree = ReactivePegParser.INSTANCE.parse(code);
 

package/core/land/reactive/compiler/ReactiveCompiler.js

@@ -320,7 +320,7 @@ class CompilingVisitor extends AbstractParseTreeVisitor {
  * @returns {ReactiveExpression}
  */
 export function compileReactiveExpression(code) {
-    assert.typeOf(code, 'string', 'code');
+    assert.isString(code, 'code');
 
     const chars = new ANTLRInputStream(code);
 

package/core/primitives/array/computeIntegerArrayHash.js

@@ -1,6 +1,6 @@
 /**
  *
- * @param {Uint8Array} data
+ * @param {Uint8Array|number[]|ArrayLike<number>|IArguments} data
  * @param {number} offset
  * @param {number} length
  */

package/editor/tools/v2/BlenderCameraOrientationGizmo.js

@@ -57,7 +57,7 @@ class DirectionStyle {
     }
 }
 
-function apply_hierarchical_options(source, target) {
+function apply_hierarchical_options_from_json(source, target) {
     for (const prop_name in source) {
         if (!target.hasOwnProperty(prop_name)) {
             console.warn(`Property '${prop_name}' doesn't exist, valid properties are : ${Object.keys(target)}`);
@@ -71,7 +71,7 @@ function apply_hierarchical_options(source, target) {
             if (typeof existing_target_value.fromJSON === "function") {
                 existing_target_value.fromJSON(source_value);
             } else {
-                apply_hierarchical_options(source_value, existing_target_value);
+                apply_hierarchical_options_from_json(source_value, existing_target_value);
             }
         } else {
             target[prop_name] = source_value;
@@ -153,7 +153,7 @@ export class BlenderCameraOrientationGizmo extends CanvasView {
         };
 
         // read options
-        apply_hierarchical_options(options, this.options);
+        apply_hierarchical_options_from_json(options, this.options);
 
         // Generate list of axes
         this.bubbles = [

package/engine/ecs/EntityComponentDataset.js

@@ -1473,8 +1473,8 @@ export class EntityComponentDataset {
     addEntityEventListener(entity, eventName, listener, thisArg) {
 
         if (!ENV_PRODUCTION) {
-            assert.typeOf(eventName, "string", "eventName");
-            assert.typeOf(listener, "function", "listener");
+            assert.isString(eventName,  "eventName");
+            assert.isFunction(listener,  "listener");
         }
 
         if (!this.entityExists(entity)) {

package/engine/ecs/speaker/VoiceSystem.js

@@ -28,6 +28,8 @@ import { AnimationBehavior } from "../../animation/keyed2/behavior/AnimationBeha
 import AnimationTrack from "../../animation/keyed2/AnimationTrack.js";
 import TransitionFunctions from "../../animation/TransitionFunctions.js";
 import AnimationTrackPlayback from "../../animation/keyed2/AnimationTrackPlayback.js";
+import { globalMetrics } from "../../metrics/GlobalMetrics.js";
+import { MetricsCategory } from "../../metrics/MetricsCategory.js";
 
 /**
  * Delay before the user notices the text and begins to read
@@ -443,5 +445,11 @@ export class VoiceSystem extends AbstractContextSystem {
 
         entityBuilder
             .build(ecd);
+
+        // send metrics
+        globalMetrics.record('ecs.system.voice', {
+            category: MetricsCategory.System,
+            label: line_id
+        });
     }
 }

package/engine/graphics/ecs/animation/animator/AnimationGraphSystem.js

@@ -200,6 +200,11 @@ export class AnimationGraphSystem extends System {
             return false;
         }
 
+        if (!graph.getFlag(AnimationGraphFlag.Linked)) {
+            // not linked this is generally a case of failed linkage, either way - don't animate
+            return false;
+        }
+
         if (graph.getFlag(AnimationGraphFlag.MeshSizeCulling)) {
 
             //check the size of the mesh in screen space, culling animation of tiny objects

package/engine/graphics/ecs/animation/animator/graph/AnimationGraph.js

@@ -4,7 +4,9 @@ import { AnimationStateType } from "./AnimationStateType.js";
 import { AnimationMixer } from "three";
 import { AnimationGraphFlag } from "./AnimationGraphFlag.js";
 import { writeAnimationGraphDefinitionToJSON } from "./definition/serialization/writeAnimationGraphDefinitionToJSON.js";
-import { readAnimationGraphDefinitionFromJSON } from "./definition/serialization/readAnimationGraphDefinitionFromJSON.js";
+import {
+    readAnimationGraphDefinitionFromJSON
+} from "./definition/serialization/readAnimationGraphDefinitionFromJSON.js";
 import { assert } from "../../../../../../core/assert.js";
 import { threeUpdateTransform } from "../../../../util/threeUpdateTransform.js";
 import { computeHashIntegerArray } from "../../../../../../core/collection/array/computeHashIntegerArray.js";
@@ -399,7 +401,6 @@ export class AnimationGraph {
         const clipIndex = graphDefinition.clipIndex;
         const nClips = clipIndex.length;
 
-
         /**
          * @type {AnimationClip[]}
          */
@@ -433,6 +434,7 @@ export class AnimationGraph {
 
             throw new Error(`Animation '${animationClipDefinition.name}' not found`);
         }
+
     }
 
     link(entity, ecd) {
@@ -549,6 +551,10 @@ export class AnimationGraph {
              */
             const action = this.__actions[i];
 
+            if (action === undefined) {
+                console.warn(`Action[${i}] is undefined`);
+            }
+
             action.weight = weight;
             action.timeScale = timeScale;
         }

package/engine/graphics/geometry/buffered/query/GeometrySpatialQueryAccelerator.js

@@ -25,7 +25,7 @@ export class GeometrySpatialQueryAccelerator {
              * @param {IndexedBinaryBVH} tree
              */
             valueWeigher(tree) {
-                return tree.data.buffer.byteLength + 248;
+                return tree.estimateByteSize();
             }
         });
 

package/engine/knowledge/database/StaticKnowledgeDataTable.js

@@ -64,6 +64,13 @@ export class StaticKnowledgeDataTable {
      */
     __automatic_ids = false;
 
+    /**
+     *
+     * @type {string}
+     * @protected
+     */
+    __element_type_name = 'element';
+
     reset() {
         Object.keys(this.elements).forEach(id => {
             delete this.elements[id];
@@ -134,7 +141,7 @@ export class StaticKnowledgeDataTable {
             const element = this.get(id);
 
             if (element === null) {
-                throw new Error(`Failed to get element '${id}' from the database'`);
+                throw new Error(`Failed to get ${this.__element_type_name} '${id}' from the database'`);
             }
 
             result.push(element);
@@ -248,6 +255,17 @@ export class StaticKnowledgeDataTable {
 
             }
 
+            const flag_ignore = datum['@ignore'];
+            if (flag_ignore !== undefined) {
+                if (typeof flag_ignore !== "boolean") {
+                    console.warn(`@ignore flag is present on ${this.__element_type_name} '${id}'. @ignore must be a boolean (true/false), instead was '${typeof flag_ignore}'(=${flag_ignore})`);
+                } else if (flag_ignore) {
+                    console.warn(`[${this.__element_type_name}:${id}] @ignore flag is set to true, skipping`);
+                } else {
+                    console.warn(`[${this.__element_type_name}:${id}] @ignore flag is set to false and has no effect, please remove this field from JSON`);
+                }
+            }
+
             let element;
 
             try {
@@ -262,7 +280,7 @@ export class StaticKnowledgeDataTable {
                     _id = 'ERROR';
                 }
 
-                console.error(`Failed to parse element (id=${_id})`, e, datum);
+                console.error(`Failed to parse ${this.__element_type_name} (id=${_id})`, e, datum);
                 return;
             }
 
@@ -291,7 +309,7 @@ export class StaticKnowledgeDataTable {
             const added = this.add(element);
 
             if (!added) {
-                console.error(`Failed to add element '${id}', most likely this a duplicate key`);
+                console.error(`Failed to add ${this.__element_type_name} '${id}', most likely this a duplicate key`);
             }
         });
 
@@ -344,10 +362,14 @@ export class StaticKnowledgeDataTable {
             try {
                 promise = this.linkOne(element, json, database, assetManager);
             } catch (e) {
-                console.error(`.linkOne(#id=${id}) threw unexpectedly:`, e);
+                const wrap = new Error(`.linkOne(#id=${id}) threw unexpectedly: ${e.message}`);
+
+                if (e.stack !== undefined) {
+                    wrap.stack = e.stack;
+                }
 
                 //re-throw to fail
-                throw e;
+                throw wrap;
             }
 
             if (promise === undefined) {

package/engine/metrics/GoogleAnalyticsMetrics.js

@@ -1,7 +1,8 @@
 import { MetricsGateway } from "./MetricsGateway.js";
 
 // const GOOGLE_ANALYTICS_KEY = 'UA-66021000-1'; //Lazy-Kitty.com
-const GOOGLE_ANALYTICS_KEY = 'UA-138821093-1'; //Itch.com
+// const GOOGLE_ANALYTICS_KEY = 'UA-138821093-1'; //Itch.com
+const GOOGLE_ANALYTICS_KEY = 'G-ZBGZD4ZMZ1'; //ASKARA
 
 function loadGTAG(MEASUREMENT_ID) {
 

package/engine/plugin/EnginePluginManager.js

@@ -153,7 +153,6 @@ export class EnginePluginManager extends BaseProcess {
         const removed = this.__plugins.delete(PluginClass);
 
         if (!removed) {
-            console.error('Plugin was not found', PluginClass);
             return;
         }
 
@@ -259,7 +258,7 @@ export class EnginePluginManager extends BaseProcess {
 
         const engine = this.engine;
 
-        await ctx.transition(manager_state_value,engine);
+        await ctx.transition(manager_state_value, engine);
 
         return reference;
 

package/package.json

@@ -5,7 +5,7 @@
   "productName": "Meep",
   "description": "production-ready JavaScript game engine based on Entity Component System Architecture",
   "author": "Alexander Goldring",
-  "version": "2.39.33",
+  "version": "2.39.36",
   "dependencies": {
     "gl-matrix": "3.4.3",
     "fast-levenshtein": "2.0.6",