@woosh/meep-engine 2.36.23 → 2.36.24

package/engine/graphics/ecs/highlight/renderer/OutlineRenderer.js

@@ -84,6 +84,39 @@ function makeIdMaterialStatic() {
 
 const material_id_unskinned = makeIdMaterialStatic();
 
+/**
+ *
+ * @type {WeakMap<Object3D, Object3D>}
+ */
+const object_id_cache = new WeakMap();
+
+/**
+ *
+ * @param {Mesh|SkinnedMesh} object
+ */
+function obtain_id_mesh(object) {
+    const existing = object_id_cache.get(object);
+
+    if (existing !== undefined) {
+        return existing;
+    }
+
+    let material, mesh;
+    if (object.isSkinnedMesh) {
+        material = makeIdMaterialSkinned();
+        mesh = new SkinnedMesh(object.geometry, material);
+        mesh.bindMatrix.copy(object.bindMatrix);
+        mesh.bindMatrixInverse.copy(object.bindMatrixInverse);
+        mesh.skeleton = object.skeleton;
+    } else {
+        material = makeIdMaterialStatic();
+        mesh = new Mesh(object.geometry, material);
+    }
+
+    object_id_cache.set(object, mesh);
+
+    return mesh;
+}
 
 function makeIdMaterialSkinned() {
     return new ShaderMaterial({
@@ -99,8 +132,6 @@ const material_id_skinned = makeIdMaterialSkinned();
 material_id_skinned.skinning = true;
 
 
-const PARAMETER_COUNT = 5;
-const PARAMETER_PER_OBJECT_SLOTS = 4;
 const OBJECT_MAX_COUNT = 256;
 
 
@@ -373,22 +404,10 @@ export class OutlineRenderer {
     __append_to_id_scene(object) {
         if (object.isMesh) {
 
-            let material;
-            let mesh;
-
-            if (object.isSkinnedMesh) {
-                material = makeIdMaterialSkinned();
-                mesh = new SkinnedMesh(object.geometry, material);
-                mesh.bindMatrix.copy(object.bindMatrix);
-                mesh.bindMatrixInverse.copy(object.bindMatrixInverse);
-                mesh.skeleton = object.skeleton;
-            } else {
-                material = makeIdMaterialStatic();
-                mesh = new Mesh(object.geometry, material);
-            }
+            const mesh = obtain_id_mesh(object);
 
             const parameter_set_id = this.__definition_dictionary.get(this.__active_definition);
-            material.uniforms.id.value = parameter_set_id;
+            mesh.material.uniforms.id.value = parameter_set_id;
 
             mesh.matrixAutoUpdate = false;
             mesh.matrixWorldNeedsUpdate = false;
@@ -399,6 +418,7 @@ export class OutlineRenderer {
             mesh.modelViewMatrix.copy(object.modelViewMatrix);
 
             this.__id_scene.children.push(mesh);
+
         }
     }
 

package/package.json

@@ -5,7 +5,7 @@
   "productName": "Meep",
   "description": "production-ready JavaScript game engine based on Entity Component System Architecture",
   "author": "Alexander Goldring",
-  "version": "2.36.23",
+  "version": "2.36.24",
   "dependencies": {
     "gl-matrix": "3.4.3",
     "fast-levenshtein": "2.0.6",