@woosh/meep-engine 2.33.59 → 2.33.60

package/engine/graphics/particles/particular/engine/utils/volume/prototypeParticleVolume.js

@@ -132,6 +132,7 @@ function makeConfig(engine) {
 
     // Plugins
     config.addPlugin(MicronRenderPlugin);
+    config.addPlugin(AmbientOcclusionPostProcessEffect);
 
 
     // Knowledge
@@ -159,8 +160,6 @@ async function init(harness) {
     await engine.graphics.loadEnvironmentMap(buildCubeURLs('data/textures/cubemaps/hip_miramar/32/', '.png'));
 
 
-    await engine.plugins.acquire(AmbientOcclusionPostProcessEffect);
-
     await harness.initialize();
 
     main(engine);

package/engine/graphics/render/forward_plus/query/query_bvh_frustum_from_texture.js

@@ -116,14 +116,16 @@ export function query_bvh_frustum_from_texture(
                 const radius = source_data[light_address + 3];
 
                 if (!point_light_inside_volume(light_x, light_y, light_z, radius, points, planes)) {
+                    // cull
                     continue;
                 }
+
             } else if (light_type === 3) {
                 // decal
                 debugger;
 
             } else {
-                throw new Error('Unsupported light type');
+                throw new Error(`Unsupported light type ${light_type}`);
             }
 
             // write to output

package/engine/graphics/shadows/ShadowMapRenderer.js

@@ -95,12 +95,18 @@ export class ShadowMapRenderer {
 
         this.onBeforeRender.send3(renderer, shadow_camera, scene);
 
-        renderer.render(scene, shadow_camera);
-
-        if (renderer.shadowMap.type === VSMShadowMap) {
-            this.__do_vsm_pass(shadow);
+        if (target.width <= 0 || target.height <= 0) {
+            // no point in rendering
+        } else {
+            // do the draw
+            renderer.render(scene, shadow_camera);
+
+            if (renderer.shadowMap.type === VSMShadowMap) {
+                this.__do_vsm_pass(shadow);
+            }
         }
 
+
         // restore state
         renderer.setRenderTarget(__rt, __acf, __aml);
         renderer.setScissorTest(__scissor);

package/engine/graphics/texture/sampler/Sampler2D.js

@@ -570,6 +570,10 @@ Sampler2D.prototype.sampleChannelBicubic = function (x, y, channel) {
     const x1 = clamp(x, 0, x_max) | 0;
     const y1 = clamp(y, 0, y_max) | 0;
 
+    // fractional texel position (from the nearest low texel)
+    const xd = x - x1;
+    const yd = y - y1;
+
     const x0 = max2(0, x1 - 1);
     const y0 = max2(0, y1 - 1);
 
@@ -595,61 +599,36 @@ Sampler2D.prototype.sampleChannelBicubic = function (x, y, channel) {
     const col2_offset = x2 * itemSize;
     const col3_offset = x3 * itemSize;
 
-    // compute sample addresses
-    const i0 = row0_address + col0_offset;
-    const i1 = row0_address + col1_offset;
-    const i2 = row0_address + col2_offset;
-    const i3 = row0_address + col3_offset;
-
-    const j0 = row1_address + col0_offset;
-    const j1 = row1_address + col1_offset;
-    const j2 = row1_address + col2_offset;
-    const j3 = row1_address + col3_offset;
+    // read samples
+    const vi0 = data[row0_address + col0_offset];
+    const vi1 = data[row0_address + col1_offset];
+    const vi2 = data[row0_address + col2_offset];
+    const vi3 = data[row0_address + col3_offset];
 
-    const k0 = row2_address + col0_offset;
-    const k1 = row2_address + col1_offset;
-    const k2 = row2_address + col2_offset;
-    const k3 = row2_address + col3_offset;
+    const vj0 = data[row1_address + col0_offset];
+    const vj1 = data[row1_address + col1_offset];
+    const vj2 = data[row1_address + col2_offset];
+    const vj3 = data[row1_address + col3_offset];
 
-    const l0 = row3_address + col0_offset;
-    const l1 = row3_address + col1_offset;
-    const l2 = row3_address + col2_offset;
-    const l3 = row3_address + col3_offset;
+    const vk0 = data[row2_address + col0_offset];
+    const vk1 = data[row2_address + col1_offset];
+    const vk2 = data[row2_address + col2_offset];
+    const vk3 = data[row2_address + col3_offset];
 
-    // read samples
-    const vi0 = data[i0];
-    const vi1 = data[i1];
-    const vi2 = data[i2];
-    const vi3 = data[i3];
-
-    const vj0 = data[j0];
-    const vj1 = data[j1];
-    const vj2 = data[j2];
-    const vj3 = data[j3];
-
-    const vk0 = data[k0];
-    const vk1 = data[k1];
-    const vk2 = data[k2];
-    const vk3 = data[k3];
-
-    const vl0 = data[l0];
-    const vl1 = data[l1];
-    const vl2 = data[l2];
-    const vl3 = data[l3];
+    const vl0 = data[row3_address + col0_offset];
+    const vl1 = data[row3_address + col1_offset];
+    const vl2 = data[row3_address + col2_offset];
+    const vl3 = data[row3_address + col3_offset];
 
-    const xd = x - x1;
-    const yd = y - y1;
 
-    // perform filtering in X
+    // perform filtering in X (rows)
     const s0 = bicubic_terp(xd, vi0, vi1, vi2, vi3);
     const s1 = bicubic_terp(xd, vj0, vj1, vj2, vj3);
     const s2 = bicubic_terp(xd, vk0, vk1, vk2, vk3);
     const s3 = bicubic_terp(xd, vl0, vl1, vl2, vl3);
 
-    // filter in Y
-    const result = bicubic_terp(yd, s0, s1, s2, s3);
-
-    return result;
+    // filter in Y (columns)
+    return bicubic_terp(yd, s0, s1, s2, s3);
 };
 
 /**

package/engine/intelligence/behavior/ecs/WaitForEventBehavior.js

@@ -1,6 +1,7 @@
 import { EntityBehavior } from "./EntityBehavior.js";
 import { BehaviorStatus } from "../BehaviorStatus.js";
 import { BinaryClassSerializationAdapter } from "../../../ecs/storage/binary/BinaryClassSerializationAdapter.js";
+import { assert } from "../../../../core/assert.js";
 
 export class WaitForEventBehavior extends EntityBehavior {
     constructor() {
@@ -26,6 +27,8 @@ export class WaitForEventBehavior extends EntityBehavior {
     }
 
     fromJSON({ event, target = -1 }) {
+        assert.isString(event, 'event');
+
         this.event = event;
         this.target = target;
     }

package/engine/save/storage/IndexedDBStorage.js

@@ -1,12 +1,18 @@
 import Storage from "../Storage.js";
 import { IndexedDBTransactionMode } from "./IndexedDBTransactionMode.js";
+import { assert } from "../../../core/assert.js";
 
 const MAIN_STORE_NAME = 'main';
 
+/**
+ * TODO add QuotaExceededError handling
+ */
 export class IndexedDBStorage extends Storage {
     constructor(name) {
         super();
 
+        assert.isString(name, 'name');
+
         /**
          *
          * @param {IDBDatabase} database
@@ -43,7 +49,7 @@ export class IndexedDBStorage extends Storage {
 
                 const objectStore = transaction.objectStore(MAIN_STORE_NAME);
 
-                const idbRequest = objectStore.delete( key);
+                const idbRequest = objectStore.delete(key);
 
                 if (typeof resolve === "function") {
 
@@ -60,6 +66,7 @@ export class IndexedDBStorage extends Storage {
                     });
 
                 }
+
             });
 
         if (typeof reject === "function") {

package/package.json

@@ -5,7 +5,7 @@
   "productName": "Meep",
   "description": "production-ready JavaScript game engine based on Entity Component System Architecture",
   "author": "Alexander Goldring",
-  "version": "2.33.59",
+  "version": "2.33.60",
   "dependencies": {
     "gl-matrix": "3.4.3",
     "fast-levenshtein": "2.0.6",