@wkovacs64/eslint-config 7.1.0 → 7.2.1

package/index.js

@@ -116,8 +116,7 @@ export const config = [
       }
     : null,
 
-  // react-hook rules are applicable in ts/js/tsx/jsx, but only with React as a
-  // dep
+  // react-hook rules are applicable in ts/js/tsx/jsx, but only with React as a dep
   hasReact
     ? {
         files: ['**/*.ts?(x)', '**/*.js?(x)'],
@@ -131,14 +130,18 @@ export const config = [
       }
     : null,
 
-  // JS and JSX files
+  // JS, JSX, and CJS files
   {
-    files: ['**/*.js?(x)'],
+    files: ['**/*.{js,jsx,cjs}'],
+    // most of these rules are useful for JS but not TS because TS handles these better
     rules: {
-      // most of these rules are useful for JS but not TS because TS handles these better
-      // if it weren't for https://github.com/import-js/eslint-plugin-import/issues/2132
-      // we could enable this :(
-      // 'import/no-unresolved': ERROR,
+      // Blocked by https://github.com/import-js/eslint-plugin-import/issues/2132
+      // 'import/no-unresolved': [
+      //   ERROR,
+      //   {
+      //     ignore: ['^#icons/icon', '^~/icons/icon', './icons-sprite.svg'],
+      //   },
+      // ],
       'no-unused-vars': [
         WARN,
         {
@@ -181,15 +184,15 @@ export const config = [
             },
           ],
           '@typescript-eslint/consistent-type-definitions': OFF,
-          'import/consistent-type-specifier-style': [WARN, 'prefer-inline'],
-          '@typescript-eslint/consistent-type-imports': [
-            ERROR,
-            {
-              prefer: 'type-imports',
-              disallowTypeAnnotations: true,
-              fixStyle: 'inline-type-imports',
-            },
-          ],
+          // Note: use this rule _OR_ verbatimModuleSyntax in tsconfig.json - not both
+          // '@typescript-eslint/consistent-type-imports': [
+          //   ERROR,
+          //   {
+          //     prefer: 'type-imports',
+          //     disallowTypeAnnotations: true,
+          //     fixStyle: 'inline-type-imports',
+          //   },
+          // ],
           '@typescript-eslint/explicit-module-boundary-types': OFF,
           '@typescript-eslint/naming-convention': [
             ERROR,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@wkovacs64/eslint-config",
-  "version": "7.1.0",
+  "version": "7.2.1",
   "description": "@wKovacs64 ESLint config",
   "keywords": [
     "eslint",
@@ -18,7 +18,8 @@
   "type": "module",
   "main": "index.js",
   "exports": {
-    ".": "./index.js"
+    ".": "./index.js",
+    "./package.json": "./package.json"
   },
   "files": [
     "index.js"