@wkovacs64/eslint-config 7.0.2 → 7.2.0

package/README.md

@@ -11,14 +11,13 @@ This is my personal [ESLint][eslint] configuration.
 npm install --save-dev @wkovacs64/eslint-config
 ```
 
-> Be sure to install the appropriately versioned `eslint` peer dependency as
-> well.
+> Be sure to install the appropriately versioned `eslint` peer dependency as well.
 
 ### Usage
 
-Follow the ESLint documentation on [shared configurations][eslint-sharing]. See
-the documentation on [ignoring files][eslint-ignores] if you need to ignore
-anything the config doesn't already ignore by default.
+Follow the ESLint documentation on [shared configurations][eslint-sharing]. See the documentation on
+[ignoring files][eslint-ignores] if you need to ignore anything the config doesn't already ignore by
+default.
 
 ### Examples
 
@@ -48,17 +47,14 @@ export default config;
 }
 ```
 
-[npm-image]:
-  https://img.shields.io/npm/v/@wkovacs64/eslint-config.svg?style=flat-square
+[npm-image]: https://img.shields.io/npm/v/@wkovacs64/eslint-config.svg?style=flat-square
 [npm-url]: https://www.npmjs.com/package/@wkovacs64/eslint-config
 [ci-image]:
   https://img.shields.io/github/actions/workflow/status/wKovacs64/eslint-config/ci.yml?logo=github&style=flat-square
 [ci-url]: https://github.com/wKovacs64/eslint-config/actions?query=workflow%3Aci
-[changesets-image]:
-  https://img.shields.io/badge/maintained%20with-changesets-blue?style=flat-square
+[changesets-image]: https://img.shields.io/badge/maintained%20with-changesets-blue?style=flat-square
 [changesets-url]: https://github.com/changesets/changesets
 [eslint]: https://eslint.org/
 [eslint-sharing]:
   https://eslint.org/docs/latest/use/configure/configuration-files#using-a-shareable-configuration-package
-[eslint-ignores]:
-  https://eslint.org/docs/latest/use/configure/migration-guide#ignoring-files
+[eslint-ignores]: https://eslint.org/docs/latest/use/configure/migration-guide#ignoring-files

package/index.js

@@ -5,6 +5,8 @@
 import globals from 'globals';
 import eslint from '@eslint/js';
 import tseslint from 'typescript-eslint';
+import reactPlugin from 'eslint-plugin-react';
+import jsxA11yPlugin from 'eslint-plugin-jsx-a11y';
 import playwright from 'eslint-plugin-playwright';
 
 const ERROR = 'error';
@@ -26,7 +28,7 @@ const hasPlaywright = await has('playwright');
 
 const vitestFiles = ['**/__tests__/**/*', '**/*.test.*'];
 const testFiles = ['**/tests/**', '**/#tests/**', ...vitestFiles];
-const playwrightFiles = ['**/playwright/tests/**'];
+const playwrightFiles = ['**/playwright/**/*.(spec|test).*'];
 
 export const config = [
   {
@@ -66,14 +68,7 @@ export const config = [
             { pattern: '#*/**', group: 'internal' },
             { pattern: '~/**', group: 'internal' },
           ],
-          groups: [
-            'builtin',
-            'external',
-            'internal',
-            'parent',
-            'sibling',
-            'index',
-          ],
+          groups: ['builtin', 'external', 'internal', 'parent', 'sibling', 'index'],
         },
       ],
     },
@@ -82,10 +77,10 @@ export const config = [
   // JSX/TSX files
   hasReact
     ? {
-        files: ['**/*.tsx', '**/*.jsx'].filter(Boolean),
+        files: ['**/*.tsx', '**/*.jsx'],
         plugins: {
-          react: (await import('eslint-plugin-react')).default,
-          'jsx-a11y': (await import('eslint-plugin-jsx-a11y')).default,
+          react: reactPlugin,
+          'jsx-a11y': jsxA11yPlugin,
         },
         languageOptions: {
           parserOptions: {
@@ -95,6 +90,8 @@ export const config = [
           },
         },
         rules: {
+          ...reactPlugin.configs.recommended.rules,
+          ...jsxA11yPlugin.configs.recommended.rules,
           'react/function-component-definition': [
             'error',
             {
@@ -102,7 +99,8 @@ export const config = [
               unnamedComponents: 'arrow-function',
             },
           ],
-          'react/jsx-key': WARN,
+          'react/react-in-jsx-scope': OFF,
+          'react/prop-types': OFF,
           'jsx-a11y/label-has-associated-control': [
             ERROR,
             {
@@ -118,8 +116,7 @@ export const config = [
       }
     : null,
 
-  // react-hook rules are applicable in ts/js/tsx/jsx, but only with React as a
-  // dep
+  // react-hook rules are applicable in ts/js/tsx/jsx, but only with React as a dep
   hasReact
     ? {
         files: ['**/*.ts?(x)', '**/*.js?(x)'],
@@ -133,14 +130,18 @@ export const config = [
       }
     : null,
 
-  // JS and JSX files
+  // JS, JSX, and CJS files
   {
-    files: ['**/*.js?(x)'],
+    files: ['**/*.{js,jsx,cjs}'],
+    // most of these rules are useful for JS but not TS because TS handles these better
     rules: {
-      // most of these rules are useful for JS but not TS because TS handles these better
-      // if it weren't for https://github.com/import-js/eslint-plugin-import/issues/2132
-      // we could enable this :(
-      // 'import/no-unresolved': ERROR,
+      // Blocked by https://github.com/import-js/eslint-plugin-import/issues/2132
+      // 'import/no-unresolved': [
+      //   ERROR,
+      //   {
+      //     ignore: ['^#icons/icon', '^~/icons/icon', './icons-sprite.svg'],
+      //   },
+      // ],
       'no-unused-vars': [
         WARN,
         {
@@ -252,6 +253,13 @@ export const config = [
           '@typescript-eslint/require-await': OFF,
           '@typescript-eslint/unified-signatures': 'warn',
         },
+        settings: {
+          'import/resolver': {
+            typescript: {
+              alwaysTryTypes: true,
+            },
+          },
+        },
       }
     : null,
 
@@ -281,8 +289,7 @@ export const config = [
         files: testFiles,
         ignores: [...playwrightFiles],
         plugins: {
-          'testing-library': (await import('eslint-plugin-testing-library'))
-            .default,
+          'testing-library': (await import('eslint-plugin-testing-library')).default,
         },
         rules: {
           // 'testing-library/await-async-events': ERROR,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@wkovacs64/eslint-config",
-  "version": "7.0.2",
+  "version": "7.2.0",
   "description": "@wKovacs64 ESLint config",
   "keywords": [
     "eslint",
@@ -65,10 +65,10 @@
     "@changesets/changelog-github": "0.5.0",
     "@changesets/cli": "2.27.5",
     "@types/eslint__js": "8.42.3",
-    "@types/node": "20.13.0",
+    "@types/node": "20.14.1",
     "@types/react": "18.3.3",
     "@types/react-dom": "18.3.0",
-    "@wkovacs64/prettier-config": "4.0.0",
+    "@wkovacs64/prettier-config": "4.1.0",
     "eslint": "8.57.0",
     "prettier": "3.3.0",
     "typescript": "5.4.5"