@wix/zero-config-implementation 1.93.0 → 1.94.0

package/package.json

@@ -4,7 +4,7 @@
     "registry": "https://registry.npmjs.org/",
     "access": "public"
   },
-  "version": "1.93.0",
+  "version": "1.94.0",
   "description": "Core library for extracting component manifests from JS and CSS files",
   "type": "module",
   "main": "dist/index.js",
@@ -39,7 +39,7 @@
     }
   },
   "dependencies": {
-    "@wix/react-component-schema": "1.8.0",
+    "@wix/react-component-schema": "1.9.0",
     "@wix/seo-service": "^1.9.0",
     "@wix/services-manager": "^1.0.7",
     "@wix/services-manager-react": "^1.0.8",
@@ -106,5 +106,5 @@
       ]
     }
   },
-  "falconPackageHash": "d7c036bb07aaafe708985efa56e88c2eefb34077d2d892938112978f"
+  "falconPackageHash": "c359f3991c9148a6bb0473cbb1eef6bfef7fd8401e45720aaed8b44c"
 }

package/src/converters/to-editor-component.test.ts

@@ -107,6 +107,103 @@ describe('toEditorReactComponent display conversion', () => {
     })
   })
 
+  // CSS display values whose spelling differs from the enum's. Emitting one
+  // unmapped makes DevCenter reject the whole components override, permanently
+  // blocking Checkpoint for the project (ECL-18531).
+  describe('display value enum mapping', () => {
+    const { DISPLAY_VALUE } = CSS_PROPERTIES
+    const tagDefaults: [tag: string, cssDisplay: string, enumValue: string][] = [
+      ['td', 'table-cell', DISPLAY_VALUE.tableCell],
+      ['th', 'table-cell', DISPLAY_VALUE.tableCell],
+      ['tr', 'table-row', DISPLAY_VALUE.tableRow],
+      ['tbody', 'table-row-group', DISPLAY_VALUE.tableRowGroup],
+      ['thead', 'table-header-group', DISPLAY_VALUE.tableHeaderGroup],
+      ['tfoot', 'table-footer-group', DISPLAY_VALUE.tableFooterGroup],
+      ['caption', 'table-caption', DISPLAY_VALUE.tableCaption],
+      ['col', 'table-column', DISPLAY_VALUE.tableColumn],
+      ['colgroup', 'table-column-group', DISPLAY_VALUE.tableColumnGroup],
+    ]
+
+    it.each(tagDefaults)('maps a <%s> tag default (%s) onto its enum name', (tag, _cssDisplay, expectedEnumValue) => {
+      const rootElement = createElementWithDisplayMatcher(tag, matcherDataFromCss(''))
+
+      const result = toEditorReactComponent(createComponent(rootElement))
+
+      expect(result.editorElement?.cssProperties?.display).toEqual({
+        display: {
+          displayValues: [CSS_PROPERTIES.DISPLAY_VALUE.none, expectedEnumValue],
+        },
+      })
+    })
+
+    it('treats an explicit `display: table-cell` declaration the same as the tag default', () => {
+      const fromTag = toEditorReactComponent(
+        createComponent(createElementWithDisplayMatcher('td', matcherDataFromCss(''))),
+      )
+      const fromCss = toEditorReactComponent(
+        createComponent(createElementWithDisplayMatcher('div', matcherDataFromCss('display: table-cell'))),
+      )
+
+      expect(fromCss.editorElement?.cssProperties?.display).toEqual(fromTag.editorElement?.cssProperties?.display)
+      expect(fromCss.editorElement?.cssProperties?.display).toEqual({
+        display: {
+          displayValues: [CSS_PROPERTIES.DISPLAY_VALUE.none, CSS_PROPERTIES.DISPLAY_VALUE.tableCell],
+        },
+      })
+    })
+
+    it('still maps kebab-case values that do have an enum representation', () => {
+      const rootElement = createElementWithDisplayMatcher('div', matcherDataFromCss('display: inline-block'))
+
+      const result = toEditorReactComponent(createComponent(rootElement))
+
+      expect(result.editorElement?.cssProperties?.display).toEqual({
+        display: {
+          displayValues: [CSS_PROPERTIES.DISPLAY_VALUE.none, CSS_PROPERTIES.DISPLAY_VALUE.inlineBlock],
+        },
+      })
+    })
+
+    it('never emits a display value outside the enum for any known tag default', () => {
+      const allowedValues = new Set<string>(Object.values(CSS_PROPERTIES.DISPLAY_VALUE))
+
+      for (const [tag] of tagDefaults) {
+        const rootElement = createElementWithDisplayMatcher(tag, matcherDataFromCss(''))
+        const result = toEditorReactComponent(createComponent(rootElement))
+        const emittedValues = result.editorElement?.cssProperties?.display?.display?.displayValues ?? []
+
+        expect(emittedValues.filter((displayValue) => !allowedValues.has(displayValue))).toEqual([])
+      }
+    })
+
+    /**
+     * Completeness check driven by the enum itself, so a value added in a future
+     * `@wix/component-protocol` bump cannot sit unmapped — which is the gap that
+     * made ECL-18531 possible. Values whose CSS spelling already matches the enum
+     * name need no entry; those that differ must be mapped.
+     *
+     * Skips names containing `_`: `UNKNOWN_DisplayValue` and the deprecated
+     * snake_case aliases, none of which are CSS spellings.
+     */
+    it('reaches every enum value from its CSS spelling', () => {
+      const toCssSpelling = (enumValue: string) => enumValue.replace(/[A-Z]/g, (char) => `-${char.toLowerCase()}`)
+
+      const unreachable = Object.values(CSS_PROPERTIES.DISPLAY_VALUE)
+        .filter((enumValue) => !enumValue.includes('_'))
+        .filter((enumValue) => {
+          const rootElement = createElementWithDisplayMatcher(
+            'div',
+            matcherDataFromCss(`display: ${toCssSpelling(enumValue)}`),
+          )
+          const result = toEditorReactComponent(createComponent(rootElement))
+
+          return result.editorElement?.cssProperties?.display?.display?.displayValues?.[1] !== enumValue
+        })
+
+      expect(unreachable).toEqual([])
+    })
+  })
+
   it('omits the nearest matching ancestor class prefix from inner element display names', () => {
     const rootElement = createSemanticElement({
       traceId: 'trace-root',

package/src/converters/to-editor-component.ts

@@ -541,20 +541,30 @@ function getMatchedPropertyValues(element: ExtractedElement): Map<string, string
   return values
 }
 
-const CSS_DISPLAY_TO_ENUM: Record<string, string> = {
-  'inline-block': 'inlineBlock',
-  'inline-flex': 'inlineFlex',
-  'inline-grid': 'inlineGrid',
-  'inline-table': 'inlineTable',
-  'list-item': 'listItem',
-  'flow-root': 'flowRoot',
-}
+const { CSS_PROPERTY_TYPE, DISPLAY_VALUE } = CSS_PROPERTIES
 
-function toDisplayEnumValue(cssValue: string): NonNullable<Display['displayValues']>[number] {
-  return (CSS_DISPLAY_TO_ENUM[cssValue] ?? cssValue) as NonNullable<Display['displayValues']>[number]
+type DisplayEnumValue = NonNullable<Display['displayValues']>[number]
+
+const CSS_DISPLAY_TO_ENUM: Record<string, DisplayEnumValue> = {
+  'inline-block': DISPLAY_VALUE.inlineBlock,
+  'inline-flex': DISPLAY_VALUE.inlineFlex,
+  'inline-grid': DISPLAY_VALUE.inlineGrid,
+  'inline-table': DISPLAY_VALUE.inlineTable,
+  'list-item': DISPLAY_VALUE.listItem,
+  'flow-root': DISPLAY_VALUE.flowRoot,
+  'table-row-group': DISPLAY_VALUE.tableRowGroup,
+  'table-header-group': DISPLAY_VALUE.tableHeaderGroup,
+  'table-footer-group': DISPLAY_VALUE.tableFooterGroup,
+  'table-row': DISPLAY_VALUE.tableRow,
+  'table-cell': DISPLAY_VALUE.tableCell,
+  'table-column-group': DISPLAY_VALUE.tableColumnGroup,
+  'table-column': DISPLAY_VALUE.tableColumn,
+  'table-caption': DISPLAY_VALUE.tableCaption,
 }
 
-const { CSS_PROPERTY_TYPE, DISPLAY_VALUE } = CSS_PROPERTIES
+function toDisplayEnumValue(cssValue: string): DisplayEnumValue {
+  return (CSS_DISPLAY_TO_ENUM[cssValue] ?? cssValue) as DisplayEnumValue
+}
 
 function buildCssProperties(element: ExtractedElement | undefined): Record<string, CssPropertyItem> {
   const result: Record<string, CssPropertyItem> = {}