@wix/zero-config-implementation 1.92.0 → 1.94.0

package/package.json

@@ -4,7 +4,7 @@
     "registry": "https://registry.npmjs.org/",
     "access": "public"
   },
-  "version": "1.92.0",
+  "version": "1.94.0",
   "description": "Core library for extracting component manifests from JS and CSS files",
   "type": "module",
   "main": "dist/index.js",
@@ -39,7 +39,7 @@
     }
   },
   "dependencies": {
-    "@wix/react-component-schema": "1.8.0",
+    "@wix/react-component-schema": "1.9.0",
     "@wix/seo-service": "^1.9.0",
     "@wix/services-manager": "^1.0.7",
     "@wix/services-manager-react": "^1.0.8",
@@ -106,5 +106,5 @@
       ]
     }
   },
-  "falconPackageHash": "db2c3fec617a486d30e2d52ed7e239747365a40d14666a5ea04cf07d"
+  "falconPackageHash": "c359f3991c9148a6bb0473cbb1eef6bfef7fd8401e45720aaed8b44c"
 }

package/src/converters/to-editor-component.test.ts

@@ -107,6 +107,103 @@ describe('toEditorReactComponent display conversion', () => {
     })
   })
 
+  // CSS display values whose spelling differs from the enum's. Emitting one
+  // unmapped makes DevCenter reject the whole components override, permanently
+  // blocking Checkpoint for the project (ECL-18531).
+  describe('display value enum mapping', () => {
+    const { DISPLAY_VALUE } = CSS_PROPERTIES
+    const tagDefaults: [tag: string, cssDisplay: string, enumValue: string][] = [
+      ['td', 'table-cell', DISPLAY_VALUE.tableCell],
+      ['th', 'table-cell', DISPLAY_VALUE.tableCell],
+      ['tr', 'table-row', DISPLAY_VALUE.tableRow],
+      ['tbody', 'table-row-group', DISPLAY_VALUE.tableRowGroup],
+      ['thead', 'table-header-group', DISPLAY_VALUE.tableHeaderGroup],
+      ['tfoot', 'table-footer-group', DISPLAY_VALUE.tableFooterGroup],
+      ['caption', 'table-caption', DISPLAY_VALUE.tableCaption],
+      ['col', 'table-column', DISPLAY_VALUE.tableColumn],
+      ['colgroup', 'table-column-group', DISPLAY_VALUE.tableColumnGroup],
+    ]
+
+    it.each(tagDefaults)('maps a <%s> tag default (%s) onto its enum name', (tag, _cssDisplay, expectedEnumValue) => {
+      const rootElement = createElementWithDisplayMatcher(tag, matcherDataFromCss(''))
+
+      const result = toEditorReactComponent(createComponent(rootElement))
+
+      expect(result.editorElement?.cssProperties?.display).toEqual({
+        display: {
+          displayValues: [CSS_PROPERTIES.DISPLAY_VALUE.none, expectedEnumValue],
+        },
+      })
+    })
+
+    it('treats an explicit `display: table-cell` declaration the same as the tag default', () => {
+      const fromTag = toEditorReactComponent(
+        createComponent(createElementWithDisplayMatcher('td', matcherDataFromCss(''))),
+      )
+      const fromCss = toEditorReactComponent(
+        createComponent(createElementWithDisplayMatcher('div', matcherDataFromCss('display: table-cell'))),
+      )
+
+      expect(fromCss.editorElement?.cssProperties?.display).toEqual(fromTag.editorElement?.cssProperties?.display)
+      expect(fromCss.editorElement?.cssProperties?.display).toEqual({
+        display: {
+          displayValues: [CSS_PROPERTIES.DISPLAY_VALUE.none, CSS_PROPERTIES.DISPLAY_VALUE.tableCell],
+        },
+      })
+    })
+
+    it('still maps kebab-case values that do have an enum representation', () => {
+      const rootElement = createElementWithDisplayMatcher('div', matcherDataFromCss('display: inline-block'))
+
+      const result = toEditorReactComponent(createComponent(rootElement))
+
+      expect(result.editorElement?.cssProperties?.display).toEqual({
+        display: {
+          displayValues: [CSS_PROPERTIES.DISPLAY_VALUE.none, CSS_PROPERTIES.DISPLAY_VALUE.inlineBlock],
+        },
+      })
+    })
+
+    it('never emits a display value outside the enum for any known tag default', () => {
+      const allowedValues = new Set<string>(Object.values(CSS_PROPERTIES.DISPLAY_VALUE))
+
+      for (const [tag] of tagDefaults) {
+        const rootElement = createElementWithDisplayMatcher(tag, matcherDataFromCss(''))
+        const result = toEditorReactComponent(createComponent(rootElement))
+        const emittedValues = result.editorElement?.cssProperties?.display?.display?.displayValues ?? []
+
+        expect(emittedValues.filter((displayValue) => !allowedValues.has(displayValue))).toEqual([])
+      }
+    })
+
+    /**
+     * Completeness check driven by the enum itself, so a value added in a future
+     * `@wix/component-protocol` bump cannot sit unmapped — which is the gap that
+     * made ECL-18531 possible. Values whose CSS spelling already matches the enum
+     * name need no entry; those that differ must be mapped.
+     *
+     * Skips names containing `_`: `UNKNOWN_DisplayValue` and the deprecated
+     * snake_case aliases, none of which are CSS spellings.
+     */
+    it('reaches every enum value from its CSS spelling', () => {
+      const toCssSpelling = (enumValue: string) => enumValue.replace(/[A-Z]/g, (char) => `-${char.toLowerCase()}`)
+
+      const unreachable = Object.values(CSS_PROPERTIES.DISPLAY_VALUE)
+        .filter((enumValue) => !enumValue.includes('_'))
+        .filter((enumValue) => {
+          const rootElement = createElementWithDisplayMatcher(
+            'div',
+            matcherDataFromCss(`display: ${toCssSpelling(enumValue)}`),
+          )
+          const result = toEditorReactComponent(createComponent(rootElement))
+
+          return result.editorElement?.cssProperties?.display?.display?.displayValues?.[1] !== enumValue
+        })
+
+      expect(unreachable).toEqual([])
+    })
+  })
+
   it('omits the nearest matching ancestor class prefix from inner element display names', () => {
     const rootElement = createSemanticElement({
       traceId: 'trace-root',

package/src/converters/to-editor-component.ts

@@ -541,20 +541,30 @@ function getMatchedPropertyValues(element: ExtractedElement): Map<string, string
   return values
 }
 
-const CSS_DISPLAY_TO_ENUM: Record<string, string> = {
-  'inline-block': 'inlineBlock',
-  'inline-flex': 'inlineFlex',
-  'inline-grid': 'inlineGrid',
-  'inline-table': 'inlineTable',
-  'list-item': 'listItem',
-  'flow-root': 'flowRoot',
-}
+const { CSS_PROPERTY_TYPE, DISPLAY_VALUE } = CSS_PROPERTIES
 
-function toDisplayEnumValue(cssValue: string): NonNullable<Display['displayValues']>[number] {
-  return (CSS_DISPLAY_TO_ENUM[cssValue] ?? cssValue) as NonNullable<Display['displayValues']>[number]
+type DisplayEnumValue = NonNullable<Display['displayValues']>[number]
+
+const CSS_DISPLAY_TO_ENUM: Record<string, DisplayEnumValue> = {
+  'inline-block': DISPLAY_VALUE.inlineBlock,
+  'inline-flex': DISPLAY_VALUE.inlineFlex,
+  'inline-grid': DISPLAY_VALUE.inlineGrid,
+  'inline-table': DISPLAY_VALUE.inlineTable,
+  'list-item': DISPLAY_VALUE.listItem,
+  'flow-root': DISPLAY_VALUE.flowRoot,
+  'table-row-group': DISPLAY_VALUE.tableRowGroup,
+  'table-header-group': DISPLAY_VALUE.tableHeaderGroup,
+  'table-footer-group': DISPLAY_VALUE.tableFooterGroup,
+  'table-row': DISPLAY_VALUE.tableRow,
+  'table-cell': DISPLAY_VALUE.tableCell,
+  'table-column-group': DISPLAY_VALUE.tableColumnGroup,
+  'table-column': DISPLAY_VALUE.tableColumn,
+  'table-caption': DISPLAY_VALUE.tableCaption,
 }
 
-const { CSS_PROPERTY_TYPE, DISPLAY_VALUE } = CSS_PROPERTIES
+function toDisplayEnumValue(cssValue: string): DisplayEnumValue {
+  return (CSS_DISPLAY_TO_ENUM[cssValue] ?? cssValue) as DisplayEnumValue
+}
 
 function buildCssProperties(element: ExtractedElement | undefined): Record<string, CssPropertyItem> {
   const result: Record<string, CssPropertyItem> = {}

package/src/information-extractors/react/extractors/css-properties.test.ts

@@ -38,7 +38,7 @@ function createElementWithCssProperties(
 ): ExtractedElement {
   const extractorData = new Map<string, unknown>()
   extractorData.set('css-matcher', matcherDataFromCss(declarations))
-  extractorData.set('css-properties', { relevant: getCssPropertiesForTag(tag, attributes.role) })
+  extractorData.set('css-properties', { relevant: getCssPropertiesForTag(tag, attributes) })
 
   return {
     traceId: 'trace-1',
@@ -173,11 +173,38 @@ describe('getCssPropertiesForTag', () => {
     expect(relevantProperties).not.toContain(CSS_PROPERTIES.CSS_PROPERTY_TYPE.font)
   })
 
-  it('derives box properties from default display for controls', () => {
-    const relevantProperties = getCssPropertiesForTag('button')
+  it('gives interactive controls both box and text properties', () => {
+    for (const tag of ['button', 'select', 'textarea']) {
+      const relevantProperties = getCssPropertiesForTag(tag)
+
+      expect(relevantProperties).toContain(CSS_PROPERTIES.CSS_PROPERTY_TYPE.paddingTop)
+      expect(relevantProperties).toContain(CSS_PROPERTIES.CSS_PROPERTY_TYPE.font)
+      expect(relevantProperties).toContain(CSS_PROPERTIES.CSS_PROPERTY_TYPE.color)
+    }
+  })
+
+  it('treats an input with no type as text-bearing', () => {
+    const relevantProperties = getCssPropertiesForTag('input')
 
     expect(relevantProperties).toContain(CSS_PROPERTIES.CSS_PROPERTY_TYPE.paddingTop)
-    expect(relevantProperties).not.toContain(CSS_PROPERTIES.CSS_PROPERTY_TYPE.font)
+    expect(relevantProperties).toContain(CSS_PROPERTIES.CSS_PROPERTY_TYPE.font)
+  })
+
+  it('treats text-entry and button-like input types as text-bearing', () => {
+    for (const inputType of ['text', 'email', 'password', 'search', 'number', 'submit', 'button', 'reset']) {
+      const relevantProperties = getCssPropertiesForTag('input', { type: inputType })
+
+      expect(relevantProperties).toContain(CSS_PROPERTIES.CSS_PROPERTY_TYPE.font)
+    }
+  })
+
+  it('keeps typography off input types that render no text of their own', () => {
+    for (const inputType of ['checkbox', 'radio', 'range', 'color', 'file', 'image', 'hidden']) {
+      const relevantProperties = getCssPropertiesForTag('input', { type: inputType })
+
+      expect(relevantProperties).toContain(CSS_PROPERTIES.CSS_PROPERTY_TYPE.paddingTop)
+      expect(relevantProperties).not.toContain(CSS_PROPERTIES.CSS_PROPERTY_TYPE.font)
+    }
   })
 
   it('keeps media elements out of box properties even when their default display is non-inline', () => {
@@ -203,7 +230,7 @@ describe('getCssPropertiesForTag', () => {
   })
 
   it('keeps role-based heading text-only by default', () => {
-    const relevantProperties = getCssPropertiesForTag('div', 'heading')
+    const relevantProperties = getCssPropertiesForTag('div', { role: 'heading' })
 
     expect(relevantProperties).toContain(CSS_PROPERTIES.CSS_PROPERTY_TYPE.font)
     expect(relevantProperties).not.toContain(CSS_PROPERTIES.CSS_PROPERTY_TYPE.paddingTop)

package/src/information-extractors/react/extractors/css-properties.ts

@@ -19,12 +19,18 @@ export interface CssPropertiesData {
   relevant: string[]
 }
 
+export interface SemanticAttributes {
+  role?: string
+  type?: string
+}
+
 // ─────────────────────────────────────────────────────────────────────────────
 // Semantic Traits
 // ─────────────────────────────────────────────────────────────────────────────
 
 /**
- * Text & Typography - elements where readability and hierarchy are primary
+ * Text & Typography - elements where readability and hierarchy are primary.
+ * Form controls render their own text; `input` varies by type (see below).
  */
 const TEXT_TAGS = new Set([
   'h1',
@@ -42,8 +48,14 @@ const TEXT_TAGS = new Set([
   'em',
   'b',
   'i',
+  'button',
+  'select',
+  'textarea',
 ])
 
+/** Anything else - including a missing or invalid `type` - defaults to text. */
+const NON_TEXT_INPUT_TYPES = new Set(['checkbox', 'radio', 'range', 'color', 'file', 'image', 'hidden'])
+
 const DEFAULT_NON_BOX_TEXT_TAGS = new Set(['p', 'h1', 'h2', 'h3', 'h4', 'h5', 'h6'])
 
 /**
@@ -107,13 +119,15 @@ const MEDIA_CSS_PROPERTIES = [
   CSS_PROPERTY_TYPE.boxShadow,
 ]
 
-function hasTextSemantics(tag: string, role?: string): boolean {
+function hasTextSemantics(tag: string, attributes: SemanticAttributes = {}): boolean {
+  const normalizedRole = attributes.role?.toLowerCase()
+  if (normalizedRole === 'heading' || normalizedRole === 'paragraph') {
+    return true
+  }
+
   const normalizedTag = tag.toLowerCase()
-  if (role) {
-    const normalizedRole = role.toLowerCase()
-    if (normalizedRole === 'heading' || normalizedRole === 'paragraph') {
-      return true
-    }
+  if (normalizedTag === 'input') {
+    return !NON_TEXT_INPUT_TYPES.has((attributes.type ?? 'text').toLowerCase())
   }
   return TEXT_TAGS.has(normalizedTag)
 }
@@ -135,11 +149,11 @@ function hasMediaSemantics(tag: string, role?: string): boolean {
  * Note: hasTextContent determination is deferred to tree building since
  * we can't know during createElement if a child will have text content.
  */
-export function getCssPropertiesForTag(tag: string, role?: string): string[] {
+export function getCssPropertiesForTag(tag: string, attributes: SemanticAttributes = {}): string[] {
   const properties: string[] = []
-  const hasTextProperties = hasTextSemantics(tag, role)
-  const hasMediaProperties = hasMediaSemantics(tag, role)
-  const hasBoxProperties = hasDefaultBoxProperties(tag, role) && !hasMediaProperties
+  const hasTextProperties = hasTextSemantics(tag, attributes)
+  const hasMediaProperties = hasMediaSemantics(tag, attributes.role)
+  const hasBoxProperties = hasDefaultBoxProperties(tag, attributes.role) && !hasMediaProperties
 
   if (hasTextProperties) {
     properties.push(...TEXT_CSS_PROPERTIES)
@@ -465,12 +479,11 @@ export function enrichGapProperties(elements: ExtractedElement[]): ExtractedElem
  */
 export function enrichContainerProperties(elements: ExtractedElement[]): ExtractedElement[] {
   return elements.map((element) => {
-    const role = element.attributes.role
-    if (hasTextSemantics(element.tag, role)) {
+    if (hasTextSemantics(element.tag, element.attributes)) {
       const matcherData = element.extractorData.get('css-matcher') as MatchedCssData | undefined
       const cssData = element.extractorData.get('css-properties') as CssPropertiesData | undefined
 
-      if (cssData && hasEffectiveContainerDisplay(element.tag, role, matcherData)) {
+      if (cssData && hasEffectiveContainerDisplay(element.tag, element.attributes.role, matcherData)) {
         element.extractorData.set('css-properties', {
           relevant: addBoxProperties(cssData.relevant),
         })
@@ -500,9 +513,10 @@ export function createCssPropertiesExtractor(): ReactExtractor {
       if (!event.isDomElement || !event.tag || !event.traceId) return
 
       const { tag, props, traceId, store } = event
-      const role = props.role as string | undefined
-
-      const relevant = getCssPropertiesForTag(tag, role)
+      const relevant = getCssPropertiesForTag(tag, {
+        role: props.role as string | undefined,
+        type: props.type as string | undefined,
+      })
       const data: CssPropertiesData = { relevant }
 
       store.set(traceId, 'css-properties', data)