@wix/zero-config-implementation 1.80.0 → 1.81.0

package/dist/{index-CGnbp9jn.js → index-B5j6kWzS.js}

@@ -1,4 +1,4 @@
-import { g as x } from "./index-B8oF7hWg.js";
+import { g as x } from "./index-CqoYtob0.js";
 function h(r, a) {
   for (var i = 0; i < a.length; i++) {
     const o = a[i];

package/dist/{index-B8oF7hWg.js → index-CqoYtob0.js}

@@ -6979,7 +6979,7 @@ const One = ({ isSSR: t, animatedScrollTo: e }) => {
       return Promise.resolve();
     if (!l)
       return Promise.reject({ error: "unable to copy null value" });
-    (await import("./index-CGnbp9jn.js").then((f) => f.i)).default(l);
+    (await import("./index-B5j6kWzS.js").then((f) => f.i)).default(l);
   };
   function i(l, h, f) {
     if (typeof l !== f)
@@ -99767,7 +99767,9 @@ function oWe() {
     const r = new sWe();
     t.window = r, t.document = r.document, t.HTMLElement = r.HTMLElement, t.customElements = r.customElements;
   }
-  const e = t.window, n = e.IntersectionObserver ?? aWe;
+  const e = t.window;
+  t.navigator === void 0 && (t.navigator = e.navigator), t.Element === void 0 && (t.Element = e.Element);
+  const n = e.IntersectionObserver ?? aWe;
   t.IntersectionObserver === void 0 && (t.IntersectionObserver = n), e.IntersectionObserver === void 0 && (e.IntersectionObserver = n), t.React === void 0 && (t.React = gr), t.ReactDOM === void 0 && (t.ReactDOM = _3), e.React === void 0 && (e.React = gr), e.ReactDOM === void 0 && (e.ReactDOM = _3);
 }
 function vKe(t) {

package/dist/index.js

@@ -1,4 +1,4 @@
-import { B as t, D as e, E as o, I as n, N as c, P as l, R as i, a as p, V as E, b as m, c as x, d as f, e as d, f as u, h as C, i as I, j as k, k as y, l as A, m as D, n as P, o as R, p as h, q as B, r as M, s as T, t as b, w } from "./index-B8oF7hWg.js";
+import { B as t, D as e, E as o, I as n, N as c, P as l, R as i, a as p, V as E, b as m, c as x, d as f, e as d, f as u, h as C, i as I, j as k, k as y, l as A, m as D, n as P, o as R, p as h, q as B, r as M, s as T, t as b, w } from "./index-CqoYtob0.js";
 import "react";
 export {
   t as BaseError,

package/package.json

@@ -4,7 +4,7 @@
     "registry": "https://registry.npmjs.org/",
     "access": "public"
   },
-  "version": "1.80.0",
+  "version": "1.81.0",
   "description": "Core library for extracting component manifests from JS and CSS files",
   "type": "module",
   "main": "dist/index.js",
@@ -82,5 +82,5 @@
       ]
     }
   },
-  "falconPackageHash": "9e634a5f6a97f802dcc3b2dbc92f56c3c9623790346ee5278ca65f03"
+  "falconPackageHash": "a62684e6a36b7c409927242d6d286817a3aa7b2ef5601dac8e42ab5f"
 }

package/src/__fixtures__/esm-browser-globals-entry.mjs

@@ -0,0 +1,2 @@
+export const navigatorUserAgent = navigator.userAgent
+export const elementPrototype = Element.prototype

package/src/__fixtures__/esm-browser-globals-existing-navigator-entry.mjs

@@ -0,0 +1,2 @@
+export const navigatorUserAgent = navigator.userAgent
+export const elementPrototype = Element.prototype

package/src/__fixtures__/esm-browser-globals-preservation-entry.mjs

@@ -0,0 +1,2 @@
+export const navigatorUserAgent = navigator.userAgent
+export const elementPrototype = Element.prototype

package/src/__fixtures__/esm-browser-globals-runtime-error-entry.mjs

@@ -0,0 +1,4 @@
+void navigator.userAgent
+void Element.prototype
+
+throw new Error('browser-global fixture runtime failure')

package/src/module-loader.test.ts

@@ -8,7 +8,170 @@ import { readLoaderPortRefStateForTests, readRegisteredRefElementModuleUrlsForTe
 
 const require = createRequire(import.meta.url)
 
+const extractionGlobalPropertyNames = [
+  'window',
+  'document',
+  'HTMLElement',
+  'Element',
+  'navigator',
+  'customElements',
+  'IntersectionObserver',
+  'React',
+  'ReactDOM',
+] as const
+
+type ExtractionGlobalPropertyName = (typeof extractionGlobalPropertyNames)[number]
+
+function snapshotExtractionGlobalDescriptors(): Map<ExtractionGlobalPropertyName, PropertyDescriptor | undefined> {
+  return new Map(
+    extractionGlobalPropertyNames.map((propertyName) => [
+      propertyName,
+      Object.getOwnPropertyDescriptor(globalThis, propertyName),
+    ]),
+  )
+}
+
+function clearExtractionGlobals(): void {
+  for (const propertyName of extractionGlobalPropertyNames) {
+    Reflect.deleteProperty(globalThis, propertyName)
+  }
+}
+
+function restoreExtractionGlobalDescriptors(
+  originalDescriptors: Map<ExtractionGlobalPropertyName, PropertyDescriptor | undefined>,
+): void {
+  clearExtractionGlobals()
+  for (const [propertyName, propertyDescriptor] of originalDescriptors) {
+    if (propertyDescriptor !== undefined) {
+      Object.defineProperty(globalThis, propertyName, propertyDescriptor)
+    }
+  }
+}
+
 describe('module loading', () => {
+  it('loads an ESM entry that reads navigator and Element during module evaluation', async () => {
+    const originalDescriptors = snapshotExtractionGlobalDescriptors()
+    clearExtractionGlobals()
+
+    try {
+      const entryPath = path.resolve(__dirname, '__fixtures__/esm-browser-globals-entry.mjs')
+      const loadedModuleResult = await loadModuleForExtraction(entryPath)
+      const loadedModule = loadedModuleResult._unsafeUnwrap()
+      const globals = globalThis as Record<string, unknown>
+      const configuredWindow = globals.window as Record<string, unknown>
+
+      expect(loadedModule.moduleExports.navigatorUserAgent).toBe(
+        (configuredWindow.navigator as { userAgent: string }).userAgent,
+      )
+      expect(loadedModule.moduleExports.elementPrototype).toBe(
+        (configuredWindow.Element as { prototype: unknown }).prototype,
+      )
+      expect(globals.navigator).toBe(configuredWindow.navigator)
+      expect(globals.Element).toBe(configuredWindow.Element)
+
+      await loadedModule.cleanup()
+    } finally {
+      restoreExtractionGlobalDescriptors(originalDescriptors)
+    }
+  })
+
+  it('preserves caller-provided navigator and Element globals', async () => {
+    const originalDescriptors = snapshotExtractionGlobalDescriptors()
+    clearExtractionGlobals()
+
+    const callerNavigator = { userAgent: 'caller-provided navigator' }
+    class CallerProvidedElement {}
+
+    try {
+      Object.defineProperty(globalThis, 'navigator', {
+        configurable: true,
+        value: callerNavigator,
+        writable: true,
+      })
+      Object.defineProperty(globalThis, 'Element', {
+        configurable: true,
+        value: CallerProvidedElement,
+        writable: true,
+      })
+
+      const entryPath = path.resolve(__dirname, '__fixtures__/esm-browser-globals-preservation-entry.mjs')
+      const loadedModuleResult = await loadModuleForExtraction(entryPath)
+      const loadedModule = loadedModuleResult._unsafeUnwrap()
+      const globals = globalThis as Record<string, unknown>
+
+      expect(globals.navigator).toBe(callerNavigator)
+      expect(globals.Element).toBe(CallerProvidedElement)
+      expect(loadedModule.moduleExports.elementPrototype).toBe(CallerProvidedElement.prototype)
+
+      await loadedModule.cleanup()
+    } finally {
+      restoreExtractionGlobalDescriptors(originalDescriptors)
+    }
+  })
+
+  it('preserves an existing navigator while adding a missing Element global', async () => {
+    const originalDescriptors = snapshotExtractionGlobalDescriptors()
+    clearExtractionGlobals()
+
+    const existingNavigator = { userAgent: 'existing Node navigator' }
+
+    try {
+      Object.defineProperty(globalThis, 'navigator', {
+        configurable: true,
+        value: existingNavigator,
+        writable: true,
+      })
+
+      const entryPath = path.resolve(__dirname, '__fixtures__/esm-browser-globals-existing-navigator-entry.mjs')
+      const loadedModuleResult = await loadModuleForExtraction(entryPath)
+      const loadedModule = loadedModuleResult._unsafeUnwrap()
+      const globals = globalThis as Record<string, unknown>
+      const configuredWindow = globals.window as Record<string, unknown>
+
+      expect(loadedModule.moduleExports.navigatorUserAgent).toBe(existingNavigator.userAgent)
+      expect(loadedModule.moduleExports.elementPrototype).toBe(
+        (configuredWindow.Element as { prototype: unknown }).prototype,
+      )
+      expect(globals.navigator).toBe(existingNavigator)
+      expect(globals.Element).toBe(configuredWindow.Element)
+
+      await loadedModule.cleanup()
+    } finally {
+      restoreExtractionGlobalDescriptors(originalDescriptors)
+    }
+  })
+
+  it('keeps unrelated module-evaluation failures visible after browser-global setup', async () => {
+    const originalDescriptors = snapshotExtractionGlobalDescriptors()
+    clearExtractionGlobals()
+
+    const callerNavigator = { userAgent: 'caller-provided navigator' }
+    class CallerProvidedElement {}
+
+    try {
+      Object.defineProperty(globalThis, 'navigator', {
+        configurable: true,
+        value: callerNavigator,
+        writable: true,
+      })
+      Object.defineProperty(globalThis, 'Element', {
+        configurable: true,
+        value: CallerProvidedElement,
+        writable: true,
+      })
+
+      const entryPath = path.resolve(__dirname, '__fixtures__/esm-browser-globals-runtime-error-entry.mjs')
+      const loadedModuleResult = await loadModuleForExtraction(entryPath)
+
+      expect(loadedModuleResult.isErr()).toBe(true)
+      if (loadedModuleResult.isErr()) {
+        expect(loadedModuleResult.error.esmError?.message).toContain('browser-global fixture runtime failure')
+      }
+    } finally {
+      restoreExtractionGlobalDescriptors(originalDescriptors)
+    }
+  })
+
   it('temporarily tags ref-element modules in the CJS fallback and cleans them up afterwards', async () => {
     const entryPath = path.resolve(__dirname, '__fixtures__/cjs-ref-element-entry.cjs')
     const targetPath = path.resolve(__dirname, '__fixtures__/cjs-ref-element-target.cjs')

package/src/module-loader.ts

@@ -44,6 +44,8 @@ function setupWindowGlobals(): void {
   }
 
   const windowObj = globals.window as Record<string, unknown>
+  if (globals.navigator === undefined) globals.navigator = windowObj.navigator
+  if (globals.Element === undefined) globals.Element = windowObj.Element
   const intersectionObserver = windowObj.IntersectionObserver ?? NoopIntersectionObserver
   if (globals.IntersectionObserver === undefined) globals.IntersectionObserver = intersectionObserver
   if (windowObj.IntersectionObserver === undefined) windowObj.IntersectionObserver = intersectionObserver