@wix/zero-config-implementation 1.70.0 → 1.71.0

package/dist/{index-DnxDZx90.js → index-C4cP1dwy.js}

@@ -7352,7 +7352,7 @@ function ane() {
         return Promise.resolve();
       if (!p)
         return Promise.reject({ error: "unable to copy null value" });
-      (await import("./index-D_XmjZkE.js").then((E) => E.i)).default(p);
+      (await import("./index-DT1jTZEG.js").then((E) => E.i)).default(p);
     };
     function u(p, y, E) {
       if (typeof p !== E)
@@ -41292,7 +41292,9 @@ const RLe = (t) => t.declarations && t.declarations.length > 0 ? !t.declarations
 }) : !0, LLe = {
   shouldRemoveUndefinedFromOptional: !0,
   shouldIncludePropTagMap: !0,
-  skipChildrenPropWithoutDoc: !0,
+  // historically `children` were skipped as in older versions of React they ALWAYS were present in props
+  // as we using newer React versions, we don't need to skip them
+  skipChildrenPropWithoutDoc: !1,
   propFilter: RLe,
   // react-docgen-typescript resolves `commentSource` for known wrapper types (MemoExoticComponent,
   // ForwardRefExoticComponent, etc.) but not for NamedExoticComponent — the base type that

package/dist/{index-D_XmjZkE.js → index-DT1jTZEG.js}

@@ -1,4 +1,4 @@
-import { g as x } from "./index-DnxDZx90.js";
+import { g as x } from "./index-C4cP1dwy.js";
 function h(r, a) {
   for (var i = 0; i < a.length; i++) {
     const o = a[i];

package/dist/index.js

@@ -1,4 +1,4 @@
-import { B as t, D as e, E as o, I as n, N as c, P as l, R as i, a as p, V as E, b as m, c as x, d as f, e as d, f as u, h as C, i as I, j as k, k as y, l as A, m as D, n as P, o as R, p as h, q as B, r as M, s as T, t as b, w } from "./index-DnxDZx90.js";
+import { B as t, D as e, E as o, I as n, N as c, P as l, R as i, a as p, V as E, b as m, c as x, d as f, e as d, f as u, h as C, i as I, j as k, k as y, l as A, m as D, n as P, o as R, p as h, q as B, r as M, s as T, t as b, w } from "./index-C4cP1dwy.js";
 import "react";
 export {
   t as BaseError,

package/package.json

@@ -4,7 +4,7 @@
     "registry": "https://registry.npmjs.org/",
     "access": "public"
   },
-  "version": "1.70.0",
+  "version": "1.71.0",
   "description": "Core library for extracting component manifests from JS and CSS files",
   "type": "module",
   "main": "dist/index.js",
@@ -81,5 +81,5 @@
       ]
     }
   },
-  "falconPackageHash": "f7f9d07ab6659b53c4a239fd98c2c3f0e24345cb528a5f5108c7e6ba"
+  "falconPackageHash": "d6c8e03493b96fe9947b6b075e997e8ba6e5fea0f79a417f6e26c201"
 }

package/src/converters/data-item-builder.test.ts

@@ -78,3 +78,36 @@ describe('buildDataItem — arrayItems oneof branching', () => {
     expect(arrayItems?.dataItem).toBeUndefined()
   })
 })
+
+describe('buildDataItem — container dataType', () => {
+  const buildProp = (name: string, type: string, resolvedType: ResolvedType): PropInfo => ({
+    name,
+    type,
+    required: false,
+    resolvedType,
+  })
+
+  it('maps a React `ReactNode` semantic type to dataType container', () => {
+    const result = buildDataItem(
+      buildProp('content', 'ReactNode', { kind: 'semantic', value: 'ReactNode', source: '@types/react' }),
+    )
+    expect(result.isOk()).toBe(true)
+    expect(result._unsafeUnwrap().dataType).toBe('container')
+  })
+
+  it('maps a React `ReactElement` semantic type to dataType container', () => {
+    const result = buildDataItem(
+      buildProp('icon', 'ReactElement', { kind: 'semantic', value: 'ReactElement', source: 'react' }),
+    )
+    expect(result.isOk()).toBe(true)
+    expect(result._unsafeUnwrap().dataType).toBe('container')
+  })
+
+  it('maps a Wix `Container` semantic type to dataType container', () => {
+    const result = buildDataItem(
+      buildProp('children', 'Container', { kind: 'semantic', value: 'Container', source: '@wix/editor-react-types' }),
+    )
+    expect(result.isOk()).toBe(true)
+    expect(result._unsafeUnwrap().dataType).toBe('container')
+  })
+})

package/src/information-extractors/ts/components.test.ts

@@ -8,6 +8,16 @@ const propTriggeredFixture = path.resolve(
   '../../../../example-components/src/components/DesignStates/Custom/PropTriggered/WithMatchingClass/component.tsx',
 )
 
+const childrenContainerFixture = path.resolve(
+  __dirname,
+  '../../../../example-components/src/components/ChildrenContainer/component.tsx',
+)
+
+const inheritedChildrenFixture = path.resolve(
+  __dirname,
+  '../../../../example-components/src/components/InheritedChildren/component.tsx',
+)
+
 describe('TS extractor — ElementState<> trigger detection', () => {
   it('flags an ElementState<>-wrapped prop and unwraps its inner type', async () => {
     const programResult = await compileTsFile(propTriggeredFixture)
@@ -27,3 +37,45 @@ describe('TS extractor — ElementState<> trigger detection', () => {
     expect(component!.props.showLabel.isStateTrigger).toBeUndefined()
   })
 })
+
+describe('TS extractor — container children props', () => {
+  const containerSemanticType = {
+    kind: 'semantic',
+    value: 'Container',
+    source: '@wix/editor-react-types',
+  }
+
+  it('keeps an undocumented `children: Container` prop and resolves it as a container', async () => {
+    const programResult = await compileTsFile(childrenContainerFixture)
+    expect(programResult.isOk()).toBe(true)
+    const program = programResult._unsafeUnwrap()
+
+    const components = extractAllComponentInfo(program, childrenContainerFixture)
+    const component = components.find((candidate) => candidate.componentName === 'ChildrenContainer')
+    expect(component).toBeDefined()
+
+    // `children` survives even without a JSDoc comment (skipChildrenPropWithoutDoc: false)
+    // and resolves to the Wix `Container` semantic type.
+    const childrenProp = component!.props.children
+    expect(childrenProp).toBeDefined()
+    expect(childrenProp.resolvedType).toEqual(containerSemanticType)
+
+    // A named container prop resolves the same way.
+    expect(component!.props.content?.resolvedType).toEqual(containerSemanticType)
+  })
+
+  it('still drops React-implicit `children` from PropsWithChildren (React 17 FC proxy)', async () => {
+    const programResult = await compileTsFile(inheritedChildrenFixture)
+    expect(programResult.isOk()).toBe(true)
+    const program = programResult._unsafeUnwrap()
+
+    const components = extractAllComponentInfo(program, inheritedChildrenFixture)
+    const component = components.find((candidate) => candidate.componentName === 'InheritedChildren')
+    expect(component).toBeDefined()
+
+    // The `children` member comes from `@types/react` (PropsWithChildren), so sharedPropFilter
+    // removes it — no spurious container slot. This mirrors React 17's implicit FC children.
+    expect(component!.props.children).toBeUndefined()
+    expect(component!.props.label).toBeDefined()
+  })
+})

package/src/information-extractors/ts/components.ts

@@ -23,7 +23,9 @@ const sharedPropFilter = (prop: PropItem) => {
 const sharedParserOptions = {
   shouldRemoveUndefinedFromOptional: true,
   shouldIncludePropTagMap: true,
-  skipChildrenPropWithoutDoc: true,
+  // historically `children` were skipped as in older versions of React they ALWAYS were present in props
+  // as we using newer React versions, we don't need to skip them
+  skipChildrenPropWithoutDoc: false,
   propFilter: sharedPropFilter,
   // react-docgen-typescript resolves `commentSource` for known wrapper types (MemoExoticComponent,
   // ForwardRefExoticComponent, etc.) but not for NamedExoticComponent — the base type that