@wix/zero-config-implementation 1.58.0 → 1.59.0

package/package.json

@@ -4,7 +4,7 @@
     "registry": "https://registry.npmjs.org/",
     "access": "public"
   },
-  "version": "1.58.0",
+  "version": "1.59.0",
   "description": "Core library for extracting component manifests from JS and CSS files",
   "type": "module",
   "main": "dist/index.js",
@@ -85,5 +85,5 @@
       ]
     }
   },
-  "falconPackageHash": "f7fcdc7c7a9bd8348098a4e3301700ca40fb26281cd6352c13146b45"
+  "falconPackageHash": "3762cf48efbed240f0744fc678539dd9e70ea2021dc6171c70fb714b"
 }

package/src/ts-compiler.ts

@@ -4,6 +4,7 @@ import { ResultAsync, errAsync } from 'neverthrow'
 import { parseNative } from 'tsconfck'
 import ts from 'typescript'
 import { NotFoundError, ParseError } from './errors'
+import { createCompilerHostWithBundledLibs } from './ts-lib-host'
 
 /**
  * Compile a TypeScript file into a ts.Program.
@@ -30,5 +31,8 @@ export function compileTsFile(
         cause: error as Error,
         props: { phase: 'compile' },
       }),
-  ).map(({ result }) => ts.createProgram([filePath], result.options))
+  ).map(({ result }) => {
+    const compilerHost = createCompilerHostWithBundledLibs(result.options)
+    return ts.createProgram([filePath], result.options, compilerHost)
+  })
 }

package/src/ts-lib-host.ts

@@ -0,0 +1,44 @@
+import { createRequire } from 'node:module'
+import path from 'node:path'
+import ts from 'typescript'
+
+/**
+ * Creates a `ts.CompilerHost` that resolves TypeScript's `lib.*.d.ts` files
+ * from the host project's installed `typescript` package, rather than from
+ * the (potentially bundled) `typescript` we imported.
+ *
+ * Why: consumers that bundle this package (esbuild/tsup) inline `typescript`'s
+ * JS but cannot reach its on-disk `lib.*.d.ts` files at runtime. Without this
+ * override, `ts.getDefaultLibFilePath` returns a non-existent path and global
+ * symbols like `Array` and `Promise` go missing, silently collapsing prop types
+ * to `any`. `typescript` is declared as a peer dependency, so we can rely on
+ * the host project having an intact on-disk install reachable from its cwd.
+ */
+export function createCompilerHostWithBundledLibs(options: ts.CompilerOptions): ts.CompilerHost {
+  const compilerHost = ts.createCompilerHost(options, true)
+  const hostLibDirectory = resolveHostTypeScriptLibDirectory()
+  if (!hostLibDirectory) return compilerHost
+
+  compilerHost.getDefaultLibLocation = () => hostLibDirectory
+  compilerHost.getDefaultLibFileName = (compilerOptions) =>
+    path.join(hostLibDirectory, ts.getDefaultLibFileName(compilerOptions))
+
+  return compilerHost
+}
+
+/**
+ * Locates the `lib/` directory of the host project's installed `typescript`
+ * package, walking up from the current working directory. Returns `undefined`
+ * if `typescript` cannot be resolved — in which case the default host's own
+ * lib location is used (correct for non-bundled callers, broken for bundled
+ * callers without a peer install).
+ */
+function resolveHostTypeScriptLibDirectory(): string | undefined {
+  try {
+    const requireFromCwd = createRequire(path.join(process.cwd(), 'package.json'))
+    const typescriptEntryPath = requireFromCwd.resolve('typescript/lib/typescript.js')
+    return path.dirname(typescriptEntryPath)
+  } catch {
+    return undefined
+  }
+}