@wix/zero-config-implementation 1.42.0 → 1.43.0

package/package.json

@@ -4,7 +4,7 @@
     "registry": "https://registry.npmjs.org/",
     "access": "public"
   },
-  "version": "1.42.0",
+  "version": "1.43.0",
   "description": "Core library for extracting component manifests from JS and CSS files",
   "type": "module",
   "main": "dist/index.js",
@@ -84,5 +84,5 @@
       ]
     }
   },
-  "falconPackageHash": "219d4cc3565eadeca72414aa6e2921c8b84ac51dd259bd133a6125cd"
+  "falconPackageHash": "2d91bb3d2ec5e1ed0c93907f33a6c14307f0cfe7d85c2a4b3210af66"
 }

package/src/index.ts

@@ -1,5 +1,5 @@
 import type { EditorReactComponent } from '@wix/zero-config-schema'
-import { Result, type ResultAsync, okAsync } from 'neverthrow'
+import { Result, type ResultAsync, errAsync, okAsync } from 'neverthrow'
 import type { ComponentType } from 'react'
 
 import { toEditorReactComponent } from './converters'
@@ -34,6 +34,7 @@ export interface ManifestResult {
  * @errors
  * - {@link NotFoundError} — Source file does not exist (phase: `compile`)
  * - {@link ParseError} — TypeScript config or component types could not be parsed (phase: `compile` | `extract`)
+ * - {@link IoError} — Component loaded but render/extractors failed (phase: `render`)
  */
 export interface ExtractComponentManifestOptions extends RunExtractorsOptions {
   onError?: (error: ExtractionError) => void
@@ -43,7 +44,10 @@ export function extractComponentManifestResult(
   componentPath: string,
   compiledEntryPath: string,
   options?: ExtractComponentManifestOptions,
-): ResultAsync<ManifestResult, InstanceType<typeof NotFoundError> | InstanceType<typeof ParseError>> {
+): ResultAsync<
+  ManifestResult,
+  InstanceType<typeof NotFoundError> | InstanceType<typeof ParseError> | InstanceType<typeof IoError>
+> {
   const errors: ExtractionError[] = []
   const report = (error: ExtractionError): void => {
     errors.push(error)
@@ -81,7 +85,7 @@ export function extractComponentManifestResult(
           failure: null as LoadModuleFailure | null,
         }))
         .orElse((failure) => okAsync({ loadComponent: () => null as ComponentType<unknown> | null, failure }))
-        .map(({ loadComponent, failure }) => {
+        .andThen(({ loadComponent, failure }) => {
           if (failure) {
             if (failure.esmError) {
               report({
@@ -114,7 +118,7 @@ export function extractComponentManifestResult(
             })
           }
 
-          // Step 5: Process the default-exported component (non-fatal)
+          // Step 5: Process the default-exported component (non-fatal unless render fails after load)
           const processResult = processComponent(
             componentInfo,
             loadComponent,
@@ -123,8 +127,11 @@ export function extractComponentManifestResult(
             report,
             options,
           )
+          if (!processResult.ok) {
+            return errAsync(processResult.error)
+          }
           const component = toEditorReactComponent(processResult.component)
-          return { component, errors }
+          return okAsync({ component, errors })
         })
     })
 }

package/src/manifest-pipeline.ts

@@ -41,9 +41,9 @@ export interface ComponentInfoWithCss extends CoupledComponentInfo {
 }
 
 /** The result of processing a single component through the manifest pipeline. */
-export interface ProcessComponentResult {
-  component: ComponentInfoWithCss
-}
+export type ProcessComponentResult =
+  | { ok: true; component: ComponentInfoWithCss }
+  | { ok: false; error: InstanceType<typeof IoError> }
 
 // ─────────────────────────────────────────────────────────────────────────────
 // Component Processing
@@ -53,9 +53,12 @@ export interface ProcessComponentResult {
  * Processes a single component through the full manifest pipeline:
  * loading, rendering with prop tracking, CSS extraction, and selector matching.
  *
- * Returns the enriched component info alongside any non-fatal warnings
- * encountered during processing. Always returns a component, falling back
- * to minimal info (without DOM coupling) when rendering fails.
+ * On success (`ok: true`), returns enriched component info. Non-fatal loader/CSS
+ * issues are reported via `report` only; when the module did not load, a fallback
+ * manifest (TS props without DOM coupling) is still returned.
+ *
+ * When the component was loaded but render/extractors throw, returns `ok: false`
+ * with an {@link IoError} — Tier-1 callers should turn that into a failed `Result`.
  */
 export function processComponent(
   componentInfo: ComponentInfo,
@@ -117,14 +120,12 @@ export function processComponent(
         propUsages: state.stores.propUsages,
       }
     } catch (thrownError) {
-      report({
-        componentName,
-        phase: 'render',
-        error: new IoError(thrownError instanceof Error ? thrownError.message : String(thrownError), {
-          cause: thrownError instanceof Error ? thrownError : undefined,
-          props: { phase: 'render' },
-        }),
+      const error = new IoError(thrownError instanceof Error ? thrownError.message : String(thrownError), {
+        cause: thrownError instanceof Error ? thrownError : undefined,
+        props: { phase: 'render' },
       })
+      report({ componentName, phase: 'render', error })
+      return { ok: false, error }
     }
   }
 
@@ -174,6 +175,7 @@ export function processComponent(
   }
 
   return {
+    ok: true,
     component: {
       ...enhancedInfo,
       css,