@wix/origami-lint 1.34.39 → 1.34.40

package/dist/bi/stats.js

@@ -46,11 +46,11 @@ export function recordStats(run) {
         }
         for (const statsRow of rules) {
             const row = run.recordRow('lint_rule', statsRow.rule, { item_type: statsRow.kind, item_id: statsRow.page, step_details: { violations: statsRow.violations } }, {
-                success: statsRow.violations === 0, duration_ms: statsRow.duration_ms,
+                success: statsRow.violations === 0, failure: statsRow.violations > 0 ? { error_name: 'lint_violations' } : undefined, duration_ms: statsRow.duration_ms,
             });
             for (const [check, violations] of Object.entries(statsRow.checks)) {
                 if (violations > 0)
-                    run.recordRow('lint_rule', statsRow.rule, { item_type: statsRow.kind, item_id: statsRow.page, step_details: { check, violations } }, { success: false, duration_ms: 0 }, row);
+                    run.recordRow('lint_rule', statsRow.rule, { item_type: statsRow.kind, item_id: statsRow.page, step_details: { check, violations } }, { success: false, failure: { error_name: 'lint_violations' }, duration_ms: 0 }, row);
             }
         }
     }

package/dist/lint.js

@@ -22,10 +22,10 @@ await run.trackCommand(async () => {
         }
     });
     const changedFiles = getChangedFiles();
-    const projectPassed = trackSync('step', 'run_project_rules', {}, row => {
-        const passed = runProjectRules(changedFiles.all, { parentRow: row });
-        row?.end(passed);
-        return passed;
+    const projectResult = trackSync('step', 'run_project_rules', {}, row => {
+        const result = runProjectRules(changedFiles.all, { parentRow: row });
+        row?.end(result.passed, result.passed ? undefined : { error_name: result.crashed ? 'rule_crashed' : 'lint_violations' });
+        return result;
     });
     const pagesToLint = trackSync('step', 'find_pages_to_lint', {}, row => {
         const pages = findPagesToLint(changedFiles);
@@ -35,19 +35,21 @@ await run.trackCommand(async () => {
     });
     if (run.enabled)
         collectStats();
-    const pagesPassed = await track('step', 'run_rules', { items_total: pagesToLint.length }, async (row) => {
+    const pagesResult = await track('step', 'run_rules', { items_total: pagesToLint.length }, async (row) => {
         const result = await runRules(pagesToLint);
         if (run.enabled)
             recordStats(run);
         row?.update({ step_details: { outcome: result.outcome } });
-        row?.end(result.passed);
-        return result.passed;
+        row?.end(result.passed, result.passed ? undefined : { error_name: result.outcome === 'plugin_crash' ? 'rule_crashed' : 'lint_violations' });
+        return result;
     });
-    const passed = projectPassed && pagesPassed;
+    const passed = projectResult.passed && pagesResult.passed;
     if (passed)
         trackSync('step', 'mark_passing', {}, row => {
             const outcome = markPassing(changedFiles);
             row?.update({ step_details: { outcome } });
         });
+    if (!passed)
+        run.commandRow.recordFailure({ error_name: projectResult.crashed || pagesResult.outcome === 'plugin_crash' ? 'rule_crashed' : 'lint_violations' });
     await sendAndExit(passed ? 0 : 1);
 });

package/dist/project-rules-runner/run-project-rules.js

@@ -4,10 +4,11 @@ import { projectRuleRegistry } from "../rules/project/index.js";
 import { formatProblemLine, log } from "../shared/log.js";
 import { ROOT } from "../shared/paths.js";
 import { createProjectModel } from "../project-model/index.js";
-/** true when no error rule reported a problem, on the site of these files. Logs how many rules run, and whether they passed. */
+/** Reports whether the rules passed and whether any rule crashed. Logs how many rules run, and whether they passed. */
 export function runProjectRules(files, { rules = projectRuleRegistry, readFile = readFromSite, print = console.log, parentRow } = {}) {
     log(`${rules.length} project rules to run`);
     let passed = true;
+    let crashed = false;
     for (const rule of rules) {
         const started = performance.now();
         const details = { scope: 'project', severity: rule.severity ?? 'error' };
@@ -20,14 +21,15 @@ export function runProjectRules(files, { rules = projectRuleRegistry, readFile =
             print(formatProblem({ name: rule.name }, { file: '.', message: `the rule couldn't finish, so this run can't pass: ${error instanceof Error ? error.message : String(error)}` }));
             parentRow?.run.recordRow('lint_rule', rule.name, { item_type: 'site', step_details: details }, { success: false, failure: { error_name: 'rule_crashed' }, duration_ms: performance.now() - started });
             passed = false;
+            crashed = true;
             continue;
         }
         const duration = performance.now() - started;
-        const row = parentRow?.run.recordRow('lint_rule', rule.name, { item_type: 'site', step_details: { ...details, violations: problems.length } }, { success: problems.length === 0, duration_ms: duration });
+        const row = parentRow?.run.recordRow('lint_rule', rule.name, { item_type: 'site', step_details: { ...details, violations: problems.length } }, { success: problems.length === 0, failure: problems.length > 0 ? { error_name: 'lint_violations' } : undefined, duration_ms: duration });
         for (const check of rule.checks) {
             const violations = problems.filter(problem => problem.check === check).length;
             if (violations > 0 && row)
-                row.run.recordRow('lint_rule', rule.name, { item_type: 'site', step_details: { ...details, check, violations } }, { success: false, duration_ms: 0 }, row);
+                row.run.recordRow('lint_rule', rule.name, { item_type: 'site', step_details: { ...details, check, violations } }, { success: false, failure: { error_name: 'lint_violations' }, duration_ms: 0 }, row);
         }
         for (const problem of problems) {
             print(formatProblem(rule, problem));
@@ -36,7 +38,7 @@ export function runProjectRules(files, { rules = projectRuleRegistry, readFile =
         }
     }
     log(passed ? 'project rules passed' : 'project rules failed');
-    return passed;
+    return { passed, crashed };
 }
 /** `file:line:1: error origami(name): message`, the shape the page rules' problems print in. */
 export function formatProblem({ name, severity = 'error' }, { file, line = 1, message }) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@wix/origami-lint",
-  "version": "1.34.39",
+  "version": "1.34.40",
   "description": "Offline lint for an exported Origami site: lints the pages that changed since the last passing run",
   "type": "module",
   "bin": {
@@ -26,7 +26,7 @@
     "eslint": "^10.12.0",
     "postcss": "^8.5.3",
     "typescript": "^5.8.3 || ~6.0.3",
-    "@wix/origami-bi": "0.15.0"
+    "@wix/origami-bi": "0.16.0"
   },
   "devDependencies": {
     "@types/node": "^22.0.0",
@@ -54,5 +54,5 @@
       ]
     }
   },
-  "falconPackageHash": "fd39c304c90c1c35b1edfb15132c0f6fb6f7334253e642eabd7112c3"
+  "falconPackageHash": "9c6ab750e32b2a94bd49882a2a34c6242fba5eb6ba4bd879b9eced82"
 }