@wix/origami-lint 1.34.13 → 1.34.14

package/dist/rules/site-app/apply-and-presets.js

@@ -1,4 +1,4 @@
-import { createCssFileReporter, describeAtRule, getCssChildren, getDashedId, getSegmentClass, getSelectorSegments, isPresetProperty, isSafeCssIdentifier } from "../../rules-api/index.js";
+import { createCssFileReporter, describeAtRule, getCssChildren, getDashedId, getMixinId, getSegmentClass, getSelectorSegments, isOneEditAway, isPresetProperty, isSafeCssIdentifier } from "../../rules-api/index.js";
 import { defineRule } from "./define-rule.js";
 export default defineRule({
     name: 'apply-and-presets',
@@ -30,6 +30,7 @@ function checkAppliesAndPresets(root, kind, rulesApi, report) {
                 elementRules.push(elementRule);
         }
     });
+    checkApplyTargets(elementRules, getDeclaredMixinIds([root, rulesApi.page.css.files.theme]), kind, reportInFile);
     const groups = groupBySelector(elementRules.filter((rule) => !rule.selector.startsWith(':root') && isSelectorParsed(rule.selector)));
     const componentClasses = new Set(Object.values(rulesApi.page.components).flatMap((component) => component.classNames));
     for (const group of groups)
@@ -108,6 +109,26 @@ function checkSelectorRules(group, componentClasses, reportInFile) {
         }
     }
 }
+/** An element's `@apply --id` names a `@mixin --id` that theme.css or the same file declares (OUR-006), `--id()` included: the import reads
+ * the parentheses as part of the id. A mixin's own links are global-styles' (CONV-styleParser.ts:673). */
+function checkApplyTargets(elementRules, declaredIds, kind, reportInFile) {
+    for (const { apply, selector } of elementRules) {
+        if (!apply)
+            continue;
+        const id = getDashedId(apply.params);
+        if (declaredIds.has(id))
+            continue;
+        // the build strips a trailing `()`; the import doesn't, and reads `btn()` as the id (astParser.ts MIXIN_ID_PATTERN)
+        const called = id.endsWith('()') ? id.slice(0, -2) : null;
+        if (called !== null && declaredIds.has(called)) {
+            reportInFile(apply, `rule \`${selector.trim()}\`: \`@apply --${id}\` reads as the global style \`${id}\`, which the site doesn't have: write \`@apply --${called}\`, without the parentheses (tracker OUR-006).`);
+            continue;
+        }
+        const nearMiss = [...declaredIds].find((declared) => isOneEditAway(id, declared));
+        const fix = nearMiss ? `Did you mean \`@apply --${nearMiss}\`? Otherwise apply` : 'Apply';
+        reportInFile(apply, `rule \`${selector.trim()}\`: \`@apply --${id}\` names no global style: no \`@mixin --${id}\` in theme.css${kind === 'style' ? ' or style.css' : ''}. ${fix} one theme.css declares, or declare \`@mixin --${id}\` in theme.css (tracker OUR-006).`);
+    }
+}
 /** A `--preset-<path>` names each part as a CSS identifier (CONV-styleParser.ts:62); returns the pick, or none after reporting. */
 function checkPresetName(declaration, where, reportInFile) {
     if (declaration.prop === '--preset')
@@ -262,6 +283,10 @@ function decodePresetPath(suffix) {
     path.push(current);
     return path;
 }
+/** The ids the files' top-level `@mixin`s declare (getMixinId); a file the site doesn't have declares none. */
+function getDeclaredMixinIds(files) {
+    return new Set(files.flatMap((file) => (file ? getCssChildren(file) : []).flatMap((node) => (node.type === 'atrule' && node.name === 'mixin' ? (getMixinId(node) ?? []) : []))));
+}
 /** Whether an `@apply` is one dashed id with no block after it (CONV-astParser.ts:41; an empty block, or one with only comments, passes). */
 const isApplyWritten = (apply) => getDashedId(apply.params) !== undefined && getCssChildren(apply).length === 0;
 // ── grouping ──

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@wix/origami-lint",
-  "version": "1.34.13",
+  "version": "1.34.14",
   "description": "Offline lint for an exported Origami site: lints the pages that changed since the last passing run",
   "type": "module",
   "bin": {
@@ -52,5 +52,5 @@
       ]
     }
   },
-  "falconPackageHash": "70a9ee3d299565f2869a89a7c2269513b67bdf6101e989b4545ecc19"
+  "falconPackageHash": "d2ba4667a9a53d4c6d1aef0526993a1bdc7a46daaa1fc52f8fa7ca81"
 }