@wix/himalaya-cli 0.1035.0 → 0.1037.0

package/templates/community-club/tier5-src/_shared/himi-restaurants.ts

@@ -11,7 +11,7 @@ import { wixMediaUrl, type WixImageSize } from "@himalaya/wix-media";
 // copier recognizes + carries the dependency; resolves to the same file here
 // and in the scaffolded tier5-src/_shared/ layout.
 import { cleanTitle, initials } from "../_shared/himi-text.js";
-import { formatCurrency } from "../_shared/engine-intl.js";
+import { formatCurrency, normalizeFormattedPrice } from "../_shared/engine-intl.js";
 
 /** One dish tile/row: the media-XOR-initials card contract every himi list
  *  uses, plus a formatted price line and the templated detail screen id. */
@@ -97,13 +97,13 @@ export function itemPriceLine(item: WixItem): string {
     | { price?: unknown; currency?: unknown; formattedPrice?: unknown }
     | undefined;
   const formatted = typeof info?.formattedPrice === "string" ? info.formattedPrice.trim() : "";
-  if (formatted) return formatted;
+  if (formatted) return normalizeFormattedPrice(formatted);
   const price = info?.price;
   if (price == null || price === "" || Number.isNaN(Number(price))) return "";
   const currency = typeof info?.currency === "string" ? info.currency : "";
   if (!currency) return `${price}`;
   try {
-    return formatCurrency(Number(price), currency, "en", Number(price) % 1 === 0 ? 0 : 2);
+    return formatCurrency(Number(price), currency, "en");
   } catch {
     return `${price}`;
   }
@@ -149,7 +149,7 @@ export function itemPriceVariants(item: WixItem): Array<{ id: string; name: stri
     let priceLine = `${price}`;
     if (currency) {
       try {
-        priceLine = formatCurrency(Number(price), currency, "en", Number(price) % 1 === 0 ? 0 : 2);
+        priceLine = formatCurrency(Number(price), currency, "en");
       } catch { /* keep the bare amount */ }
     }
     rows.push({ id: typeof node.id === "string" && node.id ? node.id : `variant-${index}`, name: name || "Option", priceLine });

package/templates/community-club/tier5-src/_shared/owner-load-error.ts

@@ -74,6 +74,54 @@ const SITE_CONTEXT_CODES = ["MISSING_METASITE_ID", "MISSING_REQUEST_SITE_CONTEXT
  *  message and starts being a payload dump. */
 const MAX_RAW = 200;
 
+/**
+ * A TRANSPORT failure: the request never got an HTTP answer at all.
+ *
+ * Each host describes one in its own platform's words, and every one of them is a
+ * diagnostic dump rather than a message. iOS's JSWorker hands a worker the Swift
+ * description of the `NSError` —
+ *   `Error Domain=NSURLErrorDomain Code=-1004 "Could not connect to the server."
+ *    UserInfo={… NSErrorFailingURLStringKey=http://127.0.0.1:8178/__dev/wix/proxy, …}`
+ * — which Aria painted verbatim: the domain, the code, and the local server's
+ * own URL. Android's bridge carries the `java.net` exception text, and a browser's
+ * fetch rejects with "Failed to fetch" / "Load failed" / "NetworkError …".
+ *
+ * Only a message with NO HTTP status qualifies: a status means Wix answered, and
+ * that case keeps its own reductions below.
+ */
+const TRANSPORT = [
+  /\bError Domain=\w+/,                       // any Cocoa NSError description
+  /\bNSURLErrorDomain\b/,
+  /\bjava\.(?:net|io)\.\w+(?:Exception|Error)\b/,
+  /\b(?:UnknownHost|Connect|SocketTimeout|NoRouteToHost|SSLHandshake)Exception\b/,
+  // Android's WebViewJSWorker bridges `e.message ?: e.javaClass.simpleName`, so
+  // the class name is usually absent and only OkHttp's own message arrives.
+  /^Failed to connect to \S/,
+  /^Unable to resolve host\b/,
+  /\b(?:Connection refused|Network is unreachable|Software caused connection abort)\b/,
+  /^(?:timeout|Read timed out|connect timed out)$/i,
+  /\bFailed to fetch\b/,
+  /\bNetworkError when attempting to fetch\b/,
+  /^(?:TypeError: )?Load failed$/,
+  /\bnet::ERR_[A-Z_]+/,
+];
+
+/** Did this failure happen below HTTP — no answer from Wix at all? */
+export function isTransportFailure(e: unknown): boolean {
+  const msg = String((e as Error)?.message ?? e ?? "");
+  if (STATUS.test(msg)) return false;
+  return TRANSPORT.some((re) => re.test(msg));
+}
+
+/** The one sentence for a transport failure. Copy-as-configuration: the key is
+ *  under `ownerCommon.`, which every owner screen (Aria included) forwards. */
+export function ownerTransportFailureText(): string {
+  return copyParam(
+    "ownerCommon.networkUnreachable",
+    "Couldn’t reach Wix. Check your connection and try again.",
+  );
+}
+
 /**
  * Reduce a wire failure to something a PERSON can read.
  *
@@ -85,6 +133,7 @@ const MAX_RAW = 200;
  * markup; a long non-HTML body is truncated for the same reason.
  */
 function humanWireError(msg: string): string {
+  if (isTransportFailure(msg)) return ownerTransportFailureText();
   const status = STATUS.exec(msg)?.[1];
   // A JSON ENVELOPE or a NAMED REASON CODE is the machine's word for it, and the
   // owner gets neither. Both reductions used to live in `ownerDisplayError` only,

package/templates/community-club/tier5-src/_shared/wix-service-price.ts

@@ -119,7 +119,7 @@ export function formatServicePrice(service: unknown): string {
   if (amount == null) return "";
   const currency = serviceCurrency(service);
   try {
-    return formatCurrency(amount, currency, "en", 0);
+    return formatCurrency(amount, currency, "en");
   } catch {
     return `${amount}`;
   }

package/templates/community-club/tier5-src/himi-branded-lite-cms/index.ts

@@ -38,14 +38,14 @@ interface State {
 
 function row(collection: CmsCollectionDefinition): CollectionRow {
   const title = collection.displayName.trim() || collection.id;
-  const count = collection.fields.length;
+  // No field count and no "Available to visitors": both are back-office schema/permission
+  // metadata, meaningless to the visitor reading the card ([branded-lite-qa] #3077). "Members
+  // only" stays — it tells the visitor they will need to sign in, which is theirs to know.
   return {
     id: collection.id,
     title,
-    subtitle: `${count} ${count === 1 ? "field" : "fields"}`,
-    meta: collection.readRole === "ANYONE"
-      ? copyParam("cms.visitorAccessLabel", "Available to visitors")
-      : copyParam("cms.membersOnlyAccessLabel", "Members only"),
+    subtitle: "",
+    meta: collection.readRole === "ANYONE" ? "" : copyParam("cms.membersOnlyAccessLabel", "Members only"),
     initial: (title[0] || "C").toUpperCase(),
     detailScreenId: `himi_cms_collection_${encodeURIComponent(collection.id)}`,
   };

package/templates/community-club/tier5-src/himi-branded-lite-home/index.ts

@@ -388,6 +388,10 @@ function resolveEffectiveLayout(arg: unknown, productCount: number): LayoutId {
   });
 }
 
+/** The time-of-day greeting. Read at REFRESH time only, never at boot: the release build hashes
+ *  the initial state, so a greeting read off the build machine's clock made every build of an
+ *  unchanged template a different release (#3268, the `nondeterministic-initial-state` lint).
+ *  The initial state carries `neutralWelcome()` instead, and the first refresh swaps this in. */
 function welcome(): string {
   const hour = new Date().getHours();
   if (hour < 12) return copyParam("home.greetingMorning", "Good morning");
@@ -395,6 +399,11 @@ function welcome(): string {
   return copyParam("home.greetingEvening", "Good evening");
 }
 
+/** The boot-time greeting: clock-free, so the baked initial state is the same on every build. */
+function neutralWelcome(): string {
+  return copyParam("home.greetingNeutral", "Welcome");
+}
+
 function feature(p: StoreProduct): ProductFeature {
   const name = cleanTitle(p.name) || copyParam("home.productFallbackName", "Featured item");
   const image = productImage(p);
@@ -871,7 +880,9 @@ function baseState(): State {
     hideHeroInitial: true,
     hideHeroFallback: true,
     hideFeaturedSkeleton: false,
-    welcome: welcome(),
+    // Not welcome(): that reads the clock, and this state is baked into the release. A neutral
+    // greeting keeps the hero pill painted (same size, no reflow) until the first refresh.
+    welcome: neutralWelcome(),
     refreshedAt: "",
     effectiveLayout: resolveEffectiveLayout(undefined, 0),
     accentColor: resolveAccent(undefined),

package/templates/community-club/tier5-src/himi-branded-lite-info/index.ts

@@ -112,7 +112,10 @@ const svc = defineService<State, {
         // Probe before revealing anything picker-shaped (spec R8) — on a customer build this
         // stays false and the whole subtree is hidden.
         const canPick = await pickerAvailable();
-        next = { ...next, pickerAvailable: canPick, pickerHidden: !canPick };
+        // The runtime line names the internal platform ("HimalayaCore 0.0.1") — a number for
+        // whoever debugs the build, not for a white-label app's customer ([branded-lite-qa]
+        // #3002/#3083). It shows only on a build that opted into the QA picker.
+        next = { ...next, pickerAvailable: canPick, pickerHidden: !canPick, runtimeLine: canPick ? next.runtimeLine : "" };
         if (canPick) {
           // `active()` is more precise than app-info's releasePinned: it also says WHICH pin
           // (user vs baked) is holding the release.
@@ -122,7 +125,7 @@ const svc = defineService<State, {
           }
         }
       } catch {
-        next = { ...next, pickerAvailable: false, pickerHidden: true };
+        next = { ...next, pickerAvailable: false, pickerHidden: true, runtimeLine: "" };
       }
       return next;
     },

package/templates/community-club/tier5-src/himi-events-detail/index.ts

@@ -162,7 +162,7 @@ function tierPrice(t: WixAvailableTicket): string {
   // as "25" — a price that reads as a quantity, and nothing downstream could tell it was a
   // formatting failure. `formatCurrency` uses real Intl where it exists and a symbol-carrying
   // fallback where it does not, diffed against ECMA-402 in engine-intl-fallback.test.ts.
-  return formatCurrency(Number(raw), t.price?.currency || "USD", "en", Number(raw) % 1 === 0 ? 0 : 2);
+  return formatCurrency(Number(raw), t.price?.currency || "USD", "en");
 }
 
 function tierAvailable(t: WixAvailableTicket): boolean {

package/templates/community-club/tier5-src/himi-events-list/index.ts

@@ -35,16 +35,32 @@ const svc = defineBackendCollection<S, EventRow>("himiEvents", {
     id: row => row.id,
     errorMessage: () => copyParam("events.errorText", "Events could not be loaded."),
     async cached(criteria) {
-      if (criteria.query || criteria.filter !== "all" || criteria.sort !== "default") return undefined;
-      return { items: await readCached(), nextCursor: "", metadata: { fromCache: true } };
+      // The list now OPENS on Upcoming, so the default view must keep its offline-first paint:
+      // serve the cache for it too, minus the rows that have finished.
+      const upcoming = criteria.filter === "value:Upcoming";
+      if (criteria.query || (criteria.filter !== "all" && !upcoming) || criteria.sort !== "default") return undefined;
+      const rows = await readCached();
+      return { items: upcoming ? rows.filter((row) => row.statusLabel !== "Past") : rows, nextCursor: "", metadata: { fromCache: true } };
     },
     async fetch(criteria, cursor) {
       if (!cursor) queryNow = new Date().toISOString();
       if (criteria.filter === "saved" && !criteria.savedIds.length) return { items: [], nextCursor: "" };
       const filter: Record<string, unknown> = { status: { $ne: "DRAFT" } };
-      if (criteria.query) filter.title = { $eq: criteria.query };
+      // Prefix, not exact: the placeholder says "Search events", and an exact-title match returned
+      // nothing for "Harvest" when the event is "Harvest Tasting".
+      if (criteria.query) filter.title = { $startsWith: criteria.query };
       if (criteria.filter === "saved") filter.id = { $in: criteria.savedIds };
-      if (criteria.filter === "value:Upcoming") filter["dateAndTimeSettings.startDate"] = { $gte: queryNow };
+      // Upcoming = not started yet OR not finished yet: an event in progress (a festival on its
+      // second day) is still on. The start-date arm is what keeps a START-ONLY event (no endDate
+      // — valid in Wix Events) in the list; a filter on endDate alone dropped it from both views.
+      // Past stays "has started", so an in-progress event may appear under both; its row is only
+      // marked "Past" once it has actually finished (`eventIsPast`).
+      if (criteria.filter === "value:Upcoming") {
+        filter.$or = [
+          { "dateAndTimeSettings.startDate": { $gte: queryNow } },
+          { "dateAndTimeSettings.endDate": { $gte: queryNow } },
+        ];
+      }
       if (criteria.filter === "value:Past") filter["dateAndTimeSettings.startDate"] = { $lt: queryNow };
       const res = await queryEvents({ limit: 50, offset: Number(cursor || 0), query: { filter,
         sort: [{ fieldName: criteria.sort === "default" ? "dateAndTimeSettings.startDate" : "title", order: criteria.sort === "za" ? "DESC" : "ASC" }, { fieldName: "id", order: "ASC" }] } });

package/templates/community-club/tier5-src/himi-events-my-events/index.ts

@@ -63,9 +63,9 @@ async function identityLine(): Promise<string> {
     const identity = await dispatch("himi.wix.memberIdentity") as { email?: string } | null;
     return identity?.email
       ? copyTemplate("myEvents.signedInAs", "Signed in as {email}", { email: identity.email })
-      : copyParam("myEvents.identityGuest", "RSVPs saved on this device — not yet your full Wix Events history.");
+      : copyParam("myEvents.identityGuest", "RSVPs you confirm on this device appear here.");
   } catch {
-    return copyParam("myEvents.identityGuest", "RSVPs saved on this device — not yet your full Wix Events history.");
+    return copyParam("myEvents.identityGuest", "RSVPs you confirm on this device appear here.");
   }
 }
 

package/templates/community-club/tier5-src/wix-spaces-whats-new/index.ts

@@ -4,7 +4,7 @@ import { withEmptyFlags } from "../_shared/empty-flags.js";
 import { listAnnouncements, type WixAnnouncement } from "@himalaya/wix-new-releases";
 
 interface Row { id: string; name: string; subtitle: string }
-interface S { status: "loading" | "ready"; items: Row[]; emptyText: string }
+interface S { status: "loading" | "ready"; items: Row[]; emptyText: string; /** hiddenWhen hides on true: the empty card shows only once loaded AND empty. */ noEmpty: boolean }
 
 function norm(a: WixAnnouncement, i: number): Row {
   const aa = a as unknown as { id?: string; title?: string; bodyText?: string; description?: string };
@@ -12,14 +12,14 @@ function norm(a: WixAnnouncement, i: number): Row {
 }
 
 const svc = defineService<S, { load: (s: S) => Promise<S> }>("spacesWhatsNew", withEmptyFlags({
-  state: { status: "loading", items: [], emptyText: "" },
+  state: { status: "loading", items: [], emptyText: "", noEmpty: true },
   actions: {
     load: async (s) => {
       try {
         const r = await listAnnouncements(20);
         const items = (((r as unknown as { announcements?: WixAnnouncement[] }).announcements) ?? []).map(norm);
-        return { status: "ready", items, emptyText: items.length ? "" : "Nothing new right now" };
-      } catch { return { ...s, status: "ready", items: [], emptyText: "Nothing new right now" }; }
+        return { status: "ready", items, emptyText: items.length ? "" : "Nothing new right now", noEmpty: items.length > 0 };
+      } catch { return { ...s, status: "ready", items: [], emptyText: "Nothing new right now", noEmpty: false }; }
     },
   },
 }, { items: "noItems" }));