@wix/himalaya-cli 0.1034.0 → 0.1036.0

package/templates/retail-store/tier5-src/_shared/collection-service.ts

@@ -18,6 +18,20 @@ type Reducer = (s: State, ...args: unknown[]) => State | undefined | Promise<Sta
 const object = (x: unknown): State => x && typeof x === 'object' && !Array.isArray(x) ? x as State : {};
 const str = (arg: unknown, key: string): string => typeof arg === 'string' ? arg : String(object(arg)[key] ?? '');
 
+/** The toolbar count line — "12 dishes", or "3 of 12 dishes" while a filter narrows the list.
+ *
+ *  It used to read "12 / 12 loaded" and "2 / 2 results" ([branded-lite-qa] #3002): the numbers
+ *  described the implementation (a client-side filter over a fetched page) rather than what the
+ *  customer is looking at, and the slash-and-suffix wrapped onto two lines on web. When the
+ *  backend total is unknown the count shown is simply what is shown; the "Load more" button is
+ *  what says there is more. */
+export function collectionSummary(o: { shown: number; loaded: number; total?: number; backend?: boolean; noun?: [string, string] }): string {
+  const [one, many] = o.noun ?? [copyParam('collection.itemOne', 'item'), copyParam('collection.itemMany', 'items')];
+  const whole = o.backend ? (typeof o.total === 'number' ? o.total : o.shown) : o.loaded;
+  const noun = (whole === 1 ? one : many);
+  return o.shown < whole ? `${o.shown} ${copyParam('collection.of', 'of')} ${whole} ${noun}` : `${o.shown} ${o.shown === 1 ? one : many}`;
+}
+
 /** Opt-in decorator. Domain reducers remain authoritative; collection preferences
  * survive reducers which replace their entire state, including async refreshes. */
 export function decorateCollection(name: string, def: { state: State; actions?: Record<string, Reducer> }, saving?: CollectionSaving, backend?: BackendCollection) {
@@ -179,11 +193,11 @@ export function decorateCollection(name: string, def: { state: State; actions?:
       filtersPresented, previewPresented: !!previewId, preview: projected.items.filter(row => row.collectionId === previewId),
       persistenceLabel: persisted.available ? copyParam('collection.onDevice', 'Saved on this device') : copyParam('collection.sessionOnly', 'Choices last for this session'),
       noEmpty: loading || errored || sourceEmpty || domainNarrowed || projected.items.length > 0,
-      summary: backend && config.backendQuery
-        ? (s.fromCache ? copyParam('collection.cached', 'Saved offline · may be outdated')
-          : typeof s.total === 'number' ? `${projected.items.length} / ${s.total} ${copyParam('collection.results', 'results')}`
-          : `${projected.items.length} ${s.complete ? copyParam('collection.results', 'results') : copyParam('collection.loaded', 'loaded')}`)
-        : `${projected.items.length} / ${projected.loaded} ${copyParam('collection.loaded', 'loaded')}`,
+      summary: backend && config.backendQuery && s.fromCache
+        ? copyParam('collection.cached', 'Saved offline · may be outdated')
+        : collectionSummary({ shown: projected.items.length, loaded: projected.loaded, backend: !!(backend && config.backendQuery),
+          total: typeof s.total === 'number' ? s.total : undefined, noun: config.countNoun
+            ? [copyParam(`collection.${name}.countOne`, config.countNoun[0]), copyParam(`collection.${name}.countMany`, config.countNoun[1])] : undefined }),
       selectedSummary: `${prefs.selectedIds.length} ${copyParam('collection.selected', 'selected')}`,
       filterChoices,
       chips: config.filterValues ? filterChoices.filter(choice => ['all', 'saved', prefs.filter].includes(choice.id)) : filterChoices,

package/templates/retail-store/tier5-src/_shared/engine-intl.ts

@@ -352,3 +352,54 @@ export function compareDateDesc(a: string, b: string): number {
   if (bBad) return -1;
   return tb - ta;
 }
+
+// --- [branded-lite-qa] #3079: one pattern per fact ---------------------------------------
+//
+// Before these existed, four screens formatted the same money four ways — Shop "69.00 ₪" (Wix's
+// pre-formatted string), Services "₪70" (0 decimals), Menu "₪32.00", Plans "$24" — and two
+// screens formatted the same clock two ways (Events "9:00 PM-11:00 PM", Reserve "20:00").
+// Customers read that as sloppiness, and a whole "₪70" beside "₪69.50" reads as a different
+// kind of number. So: one money pattern, one clock, one range.
+
+// Money uses `formatCurrency(amount, currency, "en")` — the currency's NATURAL decimals
+// ("₪70.00", "¥500"). Passing 0 fraction digits for whole amounts is what made a list read
+// "₪70 · ₪69.50".
+
+const KNOWN_SYMBOLS = new Set(Object.values(CURRENCY_SYMBOL));
+
+/** Wix hands some prices over PRE-formatted in the site's regional style — "69.00 ₪" with the
+ *  symbol trailing, often wrapped in bidi marks. Reorder those to the house pattern ("₪69.00") so
+ *  they match every price we format ourselves. Only an en-shaped number ("69.00", "1,234.50") with
+ *  a known trailing symbol is reordered: a comma-decimal or space-grouped string ("69,00 €",
+ *  "1 234,56 €") is kept as Wix wrote it, because half-converting it would be worse. Anything else
+ *  ("Market price") is returned trimmed. The store SDK's product price applies the same rule. */
+export function normalizeFormattedPrice(formatted: string): string {
+  const raw = (formatted || "").replace(/[‎‏]/g, "").trim();
+  const m = /^(-?)(\d{1,3}(?:,\d{3})*(?:\.\d+)?|\d+(?:\.\d+)?)[\s  ]*(\S+)$/.exec(raw);
+  if (!m || !KNOWN_SYMBOLS.has(m[3])) return raw;
+  return `${m[1]}${m[3]}${m[2]}`;
+}
+
+function clockParts(d: Date, locale: string): { time: string; meridiem: string } {
+  const full = hasIntl()
+    ? new Intl.DateTimeFormat(locale, { hour: "numeric", minute: "2-digit", hour12: true }).format(d)
+    : clock12(d);
+  // ICU puts a narrow no-break space before the meridiem; normalize so callers can split on it.
+  const clean = full.replace(/[  ]/g, " ");
+  const m = /^(.*?)\s*([AP]\.?M\.?)$/i.exec(clean);
+  return m ? { time: m[1], meridiem: m[2] } : { time: clean, meridiem: "" };
+}
+
+/** "8:00 PM" — the one clock every customer screen uses (12-hour, en-US shape). */
+export function formatClock(date: Date, locale = "en-US"): string {
+  const { time, meridiem } = clockParts(date, locale);
+  return meridiem ? `${time} ${meridiem}` : time;
+}
+
+/** Is this ISO instant before `now`? A missing or unparseable value is NOT past — "no expiry"
+ *  must never classify an offer as expired. */
+export function isPastDate(iso: string | undefined | null, now: number = Date.now()): boolean {
+  if (!iso) return false;
+  const t = Date.parse(iso);
+  return !Number.isNaN(t) && t < now;
+}

package/templates/retail-store/tier5-src/_shared/himi-restaurants.ts

@@ -11,7 +11,7 @@ import { wixMediaUrl, type WixImageSize } from "@himalaya/wix-media";
 // copier recognizes + carries the dependency; resolves to the same file here
 // and in the scaffolded tier5-src/_shared/ layout.
 import { cleanTitle, initials } from "../_shared/himi-text.js";
-import { formatCurrency } from "../_shared/engine-intl.js";
+import { formatCurrency, normalizeFormattedPrice } from "../_shared/engine-intl.js";
 
 /** One dish tile/row: the media-XOR-initials card contract every himi list
  *  uses, plus a formatted price line and the templated detail screen id. */
@@ -97,13 +97,13 @@ export function itemPriceLine(item: WixItem): string {
     | { price?: unknown; currency?: unknown; formattedPrice?: unknown }
     | undefined;
   const formatted = typeof info?.formattedPrice === "string" ? info.formattedPrice.trim() : "";
-  if (formatted) return formatted;
+  if (formatted) return normalizeFormattedPrice(formatted);
   const price = info?.price;
   if (price == null || price === "" || Number.isNaN(Number(price))) return "";
   const currency = typeof info?.currency === "string" ? info.currency : "";
   if (!currency) return `${price}`;
   try {
-    return formatCurrency(Number(price), currency, "en", Number(price) % 1 === 0 ? 0 : 2);
+    return formatCurrency(Number(price), currency, "en");
   } catch {
     return `${price}`;
   }
@@ -149,7 +149,7 @@ export function itemPriceVariants(item: WixItem): Array<{ id: string; name: stri
     let priceLine = `${price}`;
     if (currency) {
       try {
-        priceLine = formatCurrency(Number(price), currency, "en", Number(price) % 1 === 0 ? 0 : 2);
+        priceLine = formatCurrency(Number(price), currency, "en");
       } catch { /* keep the bare amount */ }
     }
     rows.push({ id: typeof node.id === "string" && node.id ? node.id : `variant-${index}`, name: name || "Option", priceLine });

package/templates/retail-store/tier5-src/_shared/owner-load-error.ts

@@ -74,6 +74,54 @@ const SITE_CONTEXT_CODES = ["MISSING_METASITE_ID", "MISSING_REQUEST_SITE_CONTEXT
  *  message and starts being a payload dump. */
 const MAX_RAW = 200;
 
+/**
+ * A TRANSPORT failure: the request never got an HTTP answer at all.
+ *
+ * Each host describes one in its own platform's words, and every one of them is a
+ * diagnostic dump rather than a message. iOS's JSWorker hands a worker the Swift
+ * description of the `NSError` —
+ *   `Error Domain=NSURLErrorDomain Code=-1004 "Could not connect to the server."
+ *    UserInfo={… NSErrorFailingURLStringKey=http://127.0.0.1:8178/__dev/wix/proxy, …}`
+ * — which Aria painted verbatim: the domain, the code, and the local server's
+ * own URL. Android's bridge carries the `java.net` exception text, and a browser's
+ * fetch rejects with "Failed to fetch" / "Load failed" / "NetworkError …".
+ *
+ * Only a message with NO HTTP status qualifies: a status means Wix answered, and
+ * that case keeps its own reductions below.
+ */
+const TRANSPORT = [
+  /\bError Domain=\w+/,                       // any Cocoa NSError description
+  /\bNSURLErrorDomain\b/,
+  /\bjava\.(?:net|io)\.\w+(?:Exception|Error)\b/,
+  /\b(?:UnknownHost|Connect|SocketTimeout|NoRouteToHost|SSLHandshake)Exception\b/,
+  // Android's WebViewJSWorker bridges `e.message ?: e.javaClass.simpleName`, so
+  // the class name is usually absent and only OkHttp's own message arrives.
+  /^Failed to connect to \S/,
+  /^Unable to resolve host\b/,
+  /\b(?:Connection refused|Network is unreachable|Software caused connection abort)\b/,
+  /^(?:timeout|Read timed out|connect timed out)$/i,
+  /\bFailed to fetch\b/,
+  /\bNetworkError when attempting to fetch\b/,
+  /^(?:TypeError: )?Load failed$/,
+  /\bnet::ERR_[A-Z_]+/,
+];
+
+/** Did this failure happen below HTTP — no answer from Wix at all? */
+export function isTransportFailure(e: unknown): boolean {
+  const msg = String((e as Error)?.message ?? e ?? "");
+  if (STATUS.test(msg)) return false;
+  return TRANSPORT.some((re) => re.test(msg));
+}
+
+/** The one sentence for a transport failure. Copy-as-configuration: the key is
+ *  under `ownerCommon.`, which every owner screen (Aria included) forwards. */
+export function ownerTransportFailureText(): string {
+  return copyParam(
+    "ownerCommon.networkUnreachable",
+    "Couldn’t reach Wix. Check your connection and try again.",
+  );
+}
+
 /**
  * Reduce a wire failure to something a PERSON can read.
  *
@@ -85,6 +133,7 @@ const MAX_RAW = 200;
  * markup; a long non-HTML body is truncated for the same reason.
  */
 function humanWireError(msg: string): string {
+  if (isTransportFailure(msg)) return ownerTransportFailureText();
   const status = STATUS.exec(msg)?.[1];
   // A JSON ENVELOPE or a NAMED REASON CODE is the machine's word for it, and the
   // owner gets neither. Both reductions used to live in `ownerDisplayError` only,

package/templates/retail-store/tier5-src/_shared/wix-service-price.ts

@@ -119,7 +119,7 @@ export function formatServicePrice(service: unknown): string {
   if (amount == null) return "";
   const currency = serviceCurrency(service);
   try {
-    return formatCurrency(amount, currency, "en", 0);
+    return formatCurrency(amount, currency, "en");
   } catch {
     return `${amount}`;
   }

package/templates/retail-store/tier5-src/himi-branded-lite-info/index.ts

@@ -112,7 +112,10 @@ const svc = defineService<State, {
         // Probe before revealing anything picker-shaped (spec R8) — on a customer build this
         // stays false and the whole subtree is hidden.
         const canPick = await pickerAvailable();
-        next = { ...next, pickerAvailable: canPick, pickerHidden: !canPick };
+        // The runtime line names the internal platform ("HimalayaCore 0.0.1") — a number for
+        // whoever debugs the build, not for a white-label app's customer ([branded-lite-qa]
+        // #3002/#3083). It shows only on a build that opted into the QA picker.
+        next = { ...next, pickerAvailable: canPick, pickerHidden: !canPick, runtimeLine: canPick ? next.runtimeLine : "" };
         if (canPick) {
           // `active()` is more precise than app-info's releasePinned: it also says WHICH pin
           // (user vs baked) is holding the release.
@@ -122,7 +125,7 @@ const svc = defineService<State, {
           }
         }
       } catch {
-        next = { ...next, pickerAvailable: false, pickerHidden: true };
+        next = { ...next, pickerAvailable: false, pickerHidden: true, runtimeLine: "" };
       }
       return next;
     },

package/templates/retail-store/tier5-src/wix-spaces-collections/index.ts

@@ -26,7 +26,7 @@ function fromCategory(c: StoreCategory): Row {
 function fromCollection(c: WixCollection): Row {
   const cc = c as unknown as { id?: string; name?: string; numberOfProducts?: number };
   const n = cc.numberOfProducts;
-  return { id: cc.id || cc.name || "collection", name: cc.name || "Collection", subtitle: n != null ? `${n} ${n === 1 ? "product" : "products"}` : "" };
+  return { id: cc.id || cc.name || "collection", name: cc.name || "Collection", subtitle: n != null && n > 0 ? `${n} ${n === 1 ? "product" : "products"}` : "" };
 }
 
 type Loaded = { ok: true; rows: Row[] } | { ok: false; error: string };

package/templates/retail-store/tier5-src/wix-spaces-whats-new/index.ts

@@ -4,7 +4,7 @@ import { withEmptyFlags } from "../_shared/empty-flags.js";
 import { listAnnouncements, type WixAnnouncement } from "@himalaya/wix-new-releases";
 
 interface Row { id: string; name: string; subtitle: string }
-interface S { status: "loading" | "ready"; items: Row[]; emptyText: string }
+interface S { status: "loading" | "ready"; items: Row[]; emptyText: string; /** hiddenWhen hides on true: the empty card shows only once loaded AND empty. */ noEmpty: boolean }
 
 function norm(a: WixAnnouncement, i: number): Row {
   const aa = a as unknown as { id?: string; title?: string; bodyText?: string; description?: string };
@@ -12,14 +12,14 @@ function norm(a: WixAnnouncement, i: number): Row {
 }
 
 const svc = defineService<S, { load: (s: S) => Promise<S> }>("spacesWhatsNew", withEmptyFlags({
-  state: { status: "loading", items: [], emptyText: "" },
+  state: { status: "loading", items: [], emptyText: "", noEmpty: true },
   actions: {
     load: async (s) => {
       try {
         const r = await listAnnouncements(20);
         const items = (((r as unknown as { announcements?: WixAnnouncement[] }).announcements) ?? []).map(norm);
-        return { status: "ready", items, emptyText: items.length ? "" : "Nothing new right now" };
-      } catch { return { ...s, status: "ready", items: [], emptyText: "Nothing new right now" }; }
+        return { status: "ready", items, emptyText: items.length ? "" : "Nothing new right now", noEmpty: items.length > 0 };
+      } catch { return { ...s, status: "ready", items: [], emptyText: "Nothing new right now", noEmpty: false }; }
     },
   },
 }, { items: "noItems" }));