@wix/himalaya-cli 0.1033.0 → 0.1034.0

package/templates/beauty-salon/tier5-src/_shared/empty-flags.ts

@@ -0,0 +1,33 @@
+// Empty-collection flags for descriptors.
+//
+// A bound Grid/LazyList with zero rows still renders a zero-height box, and a stack
+// allocates its `spacing` between CHILDREN, not between painted children — so every
+// empty list left a full gap of blank on the screen (the measure pass's `dead-gap`, on
+// iOS and Android as much as on web). `hiddenWhen` hides on a TRUE scalar only, and an
+// empty array is not one, so a descriptor cannot gate a list on its own rows.
+//
+// `withEmptyFlags(def, { rows: "noRows" })` derives `noRows = rows is empty` into the
+// initial state and after EVERY action (sync or async), so a builder can write
+// `hiddenWhen(grid(...), "$service:svc.noRows")` without each reducer remembering to.
+type State = Record<string, unknown>;
+type Action = (s: State, ...args: unknown[]) => unknown;
+
+export function withEmptyFlags<D extends { state: object; actions?: object }>(def: D, flags: Record<string, string>): D {
+  const derive = <T>(s: T): T => {
+    if (!s || typeof s !== "object") return s;
+    const out = { ...(s as State) };
+    for (const [rows, flag] of Object.entries(flags)) {
+      const v = out[rows];
+      out[flag] = !Array.isArray(v) || v.length === 0;
+    }
+    return out as T;
+  };
+  const actions: Record<string, Action> = {};
+  for (const [name, action] of Object.entries((def.actions ?? {}) as Record<string, Action>)) {
+    actions[name] = (s, ...args) => {
+      const r = action(s, ...args);
+      return r && typeof (r as Promise<unknown>).then === "function" ? (r as Promise<unknown>).then(derive) : derive(r);
+    };
+  }
+  return { ...def, state: derive(def.state), actions } as D;
+}

package/templates/beauty-salon/tier5-src/himi-store-saved/index.ts

@@ -1,4 +1,5 @@
 import { defineService } from "@himalaya/state";
+import { withEmptyFlags } from "../_shared/empty-flags.js";
 import { readSavedProducts, removeSavedProduct, type SavedProduct } from "../_shared/himi-store-saved.js";
 import { stashCopy, copyParam } from "../_shared/himi-copy.js";
 
@@ -25,7 +26,7 @@ function failed(s: S): S {
 const svc = defineService<S, {
   load: (s: S, arg?: unknown) => S;
   remove: (s: S, arg?: unknown) => S;
-}>("himiStoreSaved", {
+}>("himiStoreSaved", withEmptyFlags({
   state: shape({ status: "loading", rows: [], error: "" }),
   actions: {
     load: (s, arg) => {
@@ -41,5 +42,5 @@ const svc = defineService<S, {
       } catch { return failed(s); }
     },
   },
-});
+}, { rows: "noRows" }));
 export { svc };

package/templates/beauty-salon/tier5-src/wix-spaces-collections/index.ts

@@ -2,6 +2,7 @@
 // Prefer Catalog V3 Categories API (`queryStoreCategories`); V1 `queryCollections`
 // returns HTTP 428 on modern CATALOG_V3 sites (docs/wix-authentication.md).
 import { defineService } from "@himalaya/state";
+import { withEmptyFlags } from "../_shared/empty-flags.js";
 import {
   categoryCount,
   queryCollections,
@@ -71,7 +72,7 @@ async function loadCollections(): Promise<Loaded> {
   }
 }
 
-const svc = defineService<S, { load: (s: S) => Promise<S> }>("spacesCollections", {
+const svc = defineService<S, { load: (s: S) => Promise<S> }>("spacesCollections", withEmptyFlags({
   state: { status: "loading", collections: [], emptyText: "", error: "" },
   actions: {
     load: async () => {
@@ -93,6 +94,6 @@ const svc = defineService<S, { load: (s: S) => Promise<S> }>("spacesCollections"
       };
     },
   },
-});
+}, { collections: "noCollections" }));
 svc.load();
 export { svc };

package/templates/beauty-salon/tier5-src/wix-spaces-my-subscriptions/index.ts

@@ -1,5 +1,6 @@
 // Tier-5 bundle: Wix Spaces clone — My Subscriptions / plan orders (site-scoped).
 import { defineService } from "@himalaya/state";
+import { withEmptyFlags } from "../_shared/empty-flags.js";
 import { dispatch } from "@himalaya/dispatch";
 import { listPlanOrders, type WixPlanOrder } from "@himalaya/wix-pricing-plans";
 
@@ -21,6 +22,10 @@ const EMPTY_MEMBER = "No subscriptions yet";
 const EMPTY_GUEST = "Sign in from Account to see subscriptions you’ve joined — we don’t invent sample memberships.";
 const EMPTY_FORBIDDEN = "No subscriptions for this member yet.";
 
+/** The signed-in member's email, or "" for anyone else. A visitor's identity is
+ *  `{ email: "" }` and a failed lookup proves nothing, so both read as "no member": the
+ *  plan-orders endpoint is not member-filtered, and calling it for a visitor would list
+ *  orders that are not theirs. Fail closed. */
 async function sessionEmail(): Promise<string> {
   try {
     const identity = await dispatch("himi.wix.memberIdentity") as unknown;
@@ -38,12 +43,16 @@ function looksForbidden(err: unknown): boolean {
   return /403|FORBIDDEN|permission|denied|UNAUTHORIZED|401/i.test(msg);
 }
 
-const svc = defineService<S, { load: (s: S) => Promise<S> }>("spacesMySubscriptions", {
+const svc = defineService<S, { load: (s: S) => Promise<S> }>("spacesMySubscriptions", withEmptyFlags({
   state: { status: "loading", orders: [], emptyText: "", hideAccountCta: false },
   actions: {
     load: async () => {
       const email = await sessionEmail();
       const hideAccountCta = Boolean(email);
+      // plan orders are a MEMBER's own. With no signed-in member there is no
+      // "my" to list, whatever the endpoint answers (a dev mock or a cached session can
+      // answer it): a visitor must never see a subscription as theirs.
+      if (!email) return { status: "ready", orders: [], emptyText: EMPTY_GUEST, hideAccountCta: false };
       try {
         const r = await listPlanOrders();
         const orders = (((r as unknown as { orders?: WixPlanOrder[] }).orders) ?? []).map(norm);
@@ -68,6 +77,6 @@ const svc = defineService<S, { load: (s: S) => Promise<S> }>("spacesMySubscripti
       }
     },
   },
-});
+}, { orders: "noOrders" }));
 svc.load();
 export { svc };

package/templates/beauty-salon/tier5-src/wix-spaces-whats-new/index.ts

@@ -1,5 +1,6 @@
 // Tier-5 bundle: Wix Spaces clone — What's New (ON-DEVICE, account-level).
 import { defineService } from "@himalaya/state";
+import { withEmptyFlags } from "../_shared/empty-flags.js";
 import { listAnnouncements, type WixAnnouncement } from "@himalaya/wix-new-releases";
 
 interface Row { id: string; name: string; subtitle: string }
@@ -10,7 +11,7 @@ function norm(a: WixAnnouncement, i: number): Row {
   return { id: aa.id || `a${i}`, name: aa.title || "Announcement", subtitle: aa.description || aa.bodyText || "" };
 }
 
-const svc = defineService<S, { load: (s: S) => Promise<S> }>("spacesWhatsNew", {
+const svc = defineService<S, { load: (s: S) => Promise<S> }>("spacesWhatsNew", withEmptyFlags({
   state: { status: "loading", items: [], emptyText: "" },
   actions: {
     load: async (s) => {
@@ -21,6 +22,6 @@ const svc = defineService<S, { load: (s: S) => Promise<S> }>("spacesWhatsNew", {
       } catch { return { ...s, status: "ready", items: [], emptyText: "Nothing new right now" }; }
     },
   },
-});
+}, { items: "noItems" }));
 svc.load();
 export { svc };