@wix/himalaya-cli 0.1024.0 → 0.1026.0

package/templates/portfolio-creative/tier5-src/_shared/detail-presence.ts

@@ -0,0 +1,51 @@
+// Whether a detail screen's entity is there — the worker half of the shared not-found
+// state (the `detailNotFound` descriptor builder).
+//
+// A detail screen's descriptor asks two questions, both as `hiddenWhen` flags:
+//   • `noEntity`     → hide the entity's content AND its actions (Like, Follow, Send…)
+//   • `hideNotFound` → hide the not-found state
+// Four answers exist, and only one of them shows the not-found state:
+//   loading  — a loading line (`hideLoading` false); no content, no actions, no verdict
+//   found    — content + actions shown
+//   missing  — not-found shown, content + actions hidden
+//   failed   — a load-error line (`hideLoadError` false); no content, no actions
+// A load that FAILS for any reason other than "not found" is `failed`, never `missing`:
+// an offline device must not tell the user their invoice was deleted.
+
+export type Presence = "loading" | "found" | "missing" | "failed";
+
+export interface PresenceFlags {
+  found: boolean;
+  notFound: boolean;
+  noEntity: boolean;
+  hideNotFound: boolean;
+  hideLoading: boolean;
+  hideLoadError: boolean;
+}
+
+export function presence(p: Presence): PresenceFlags {
+  return {
+    found: p === "found", notFound: p === "missing", noEntity: p !== "found", hideNotFound: p !== "missing",
+    hideLoading: p !== "loading", hideLoadError: p !== "failed",
+  };
+}
+
+/** The entity id the host baked into this detail screen (`himi.open` params). */
+export function detailInputId(): string {
+  const v = (globalThis as { himalaya?: { input?: { id?: unknown } } }).himalaya?.input?.id;
+  return typeof v === "string" ? v.trim() : "";
+}
+
+/** True when a Wix read failed because the record does not exist: the SDK rejects
+ *  with "HTTP <code>: <body>", so an HTTP 404, or Wix's `NOT_FOUND` error code. A bare
+ *  "not found" in a message is NOT enough — "capability wix_api not found" or "Method
+ *  not found" is a broken integration, and must not tell the user the record is gone. */
+export function isNotFoundError(error: unknown): boolean {
+  const msg = String((error as { message?: unknown } | null)?.message ?? error ?? "");
+  return /\bHTTP\s*404\b/.test(msg) || /\bNOT_FOUND\b/.test(msg);
+}
+
+/** `missing` for a not-found failure, `failed` (claim nothing) otherwise. */
+export function presenceAfterError(error: unknown): PresenceFlags {
+  return presence(isNotFoundError(error) ? "missing" : "failed");
+}

package/templates/portfolio-creative/tier5-src/himi-branded-lite-orders/index.ts

@@ -54,6 +54,7 @@ interface State {
   noEmpty: boolean;
   hideList: boolean;
   needsSignIn?: boolean;
+  noSignIn?: boolean;
   nextCursor?: string;
   complete?: boolean;
   pageError?: boolean;
@@ -127,7 +128,9 @@ function derive(state: State): State {
     notLoading: state.status !== "loading",
     isErrored: state.status === "error",
     notErrored: state.status !== "error",
-    noEmpty: state.status !== "ready" || hasRows,
+    // A guest gets the shared member gate, not the "Browse products" empty card.
+    noEmpty: state.status !== "ready" || hasRows || state.needsSignIn === true,
+    noSignIn: state.status !== "ready" || state.needsSignIn !== true,
     hideList: state.status !== "ready" || state.needsSignIn === true,
   };
 }

package/templates/portfolio-creative/tier5-src/himi-branded-lite-portfolio-project/index.ts

@@ -5,6 +5,7 @@ import { defineService } from "@himalaya/state";
 import { listProjectItems, listProjects, type WixPortfolioProjectItem } from "@himalaya/wix-portfolio";
 import { wixMediaUrl, WIX_DETAIL_IMAGE } from "@himalaya/wix-media";
 import { copyParam, stashCopy } from "../_shared/himi-copy.js";
+import { presence, type PresenceFlags } from "../_shared/detail-presence.js";
 
 interface MediaRow {
   id: string;
@@ -20,7 +21,7 @@ interface MediaRow {
   noMedia: boolean;
 }
 
-interface State {
+interface State extends PresenceFlags {
   status: "loading" | "ready" | "error";
   id: string;
   title: string;
@@ -99,6 +100,9 @@ function unavailableProject(state: State, status: "ready" | "error", id: string,
     coverImage: "",
     items: [],
     emptyText,
+    // A project that is not there is `missing`; one that failed to load is not — the
+    // error card speaks, and nothing claims the project was removed.
+    ...presence(status === "ready" ? "missing" : "failed"),
   });
 }
 
@@ -106,7 +110,7 @@ const svc = defineService<State, { load: (state: State, arg?: unknown) => Promis
   state: derive({
     status: "loading", id: "", title: "", initial: "", description: "", coverImage: "", items: [], emptyText: "",
     isLoading: true, notLoading: false, isErrored: false, notErrored: true,
-    hasCover: false, noCover: true, hasItems: false, noItems: true, hideContent: true, noEmpty: true,
+    hasCover: false, noCover: true, hasItems: false, noItems: true, hideContent: true, noEmpty: true, ...presence("loading"),
   }),
   actions: {
     load: async (state, arg) => {
@@ -132,6 +136,7 @@ const svc = defineService<State, { load: (state: State, arg?: unknown) => Promis
           coverImage: wixMediaUrl(project.coverImage || "", WIX_DETAIL_IMAGE),
           items,
           emptyText: items.length ? "" : copyParam("portfolioProject.noMediaText", "This project has no published media yet."),
+          ...presence("found"),
         });
       } catch {
         return unavailableProject(state, "error", id, copyParam("portfolioProject.errorText", "This project could not be loaded. Try again."));

package/templates/portfolio-creative/tier5-src/wix-spaces-collection-detail/index.ts

@@ -7,19 +7,17 @@ import {
   getStoreCategory,
   type WixCollection,
 } from "@himalaya/wix-stores-collections";
+import { presence, presenceAfterError, detailInputId, type PresenceFlags } from "../_shared/detail-presence.js";
 
-interface S { status: "loading" | "ready"; name: string; subtitle: string; description: string }
+interface S extends PresenceFlags { status: "loading" | "ready"; name: string; subtitle: string; description: string }
 
-function inputId(): string {
-  return (globalThis as { himalaya?: { input?: { id?: string } } }).himalaya?.input?.id ?? "";
-}
 
 const svc = defineService<S, { load: (s: S) => Promise<S> }>("spacesCollectionDetail", {
-  state: { status: "loading", name: "", subtitle: "", description: "" },
+  state: { status: "loading", name: "", subtitle: "", description: "", ...presence("loading") },
   actions: {
     load: async (s) => {
-      const id = inputId();
-      if (!id) return { ...s, status: "ready" };
+      const id = detailInputId();
+      if (!id) return { ...s, status: "ready", ...presence("missing") };
       try {
         const res = await getStoreCategory(id);
         const c = res.category;
@@ -29,6 +27,7 @@ const svc = defineService<S, { load: (s: S) => Promise<S> }>("spacesCollectionDe
             name: c.name || "Category",
             subtitle: categoryCount(c),
             description: c.description || "",
+            ...presence("found"),
           };
         }
       } catch { /* fall through to V1 */ }
@@ -43,9 +42,10 @@ const svc = defineService<S, { load: (s: S) => Promise<S> }>("spacesCollectionDe
           name: c.name || "Collection",
           subtitle: n != null ? `${n} ${n === 1 ? "product" : "products"}` : "",
           description: c.description || "",
+          ...presence("found"),
         };
-      } catch {
-        return { ...s, status: "ready" };
+      } catch (e) {
+        return { ...s, status: "ready", ...presenceAfterError(e) };
       }
     },
   },

package/templates/portfolio-creative/tier5-src/wix-spaces-create-post/index.ts

@@ -4,6 +4,7 @@
 // create endpoint in the SDK; blog is the available authored-content write.)
 import { defineService } from "@himalaya/state";
 import { createDraftPost, publishDraftPost } from "@himalaya/wix-blog";
+import { memberAccess } from "../_shared/member-access.js";
 
 // `bodyFocus` is a focus TOKEN, not a flag: the body field focuses whenever this
 // becomes a new non-empty value (`TextFieldProps.focus_path`). A monotonic counter
@@ -14,7 +15,11 @@ import { createDraftPost, publishDraftPost } from "@himalaya/wix-blog";
 // the new state), so there is no way to observe an intermediate value while `submit`
 // is awaiting the network. A type that promises a state nobody can ever see reads as
 // an in-flight guard that exists — see `posting` below for the one that works.
-interface S { status: "ready"; title: string; body: string; hint: string; bodyFocus: string }
+// `needsSignIn` / `noSignIn` / `hideForm` drive the member gate: a guest sees the
+// gate and NO form, a member sees the form, and until `load` has asked the
+// host who is signed in, neither shows — so a guest can never start typing a post
+// that would only fail on submit.
+interface S { status: "ready"; title: string; body: string; hint: string; bodyFocus: string; needsSignIn: boolean; noSignIn: boolean; hideForm: boolean }
 
 // The real double-press guard, module-local because it must live OUTSIDE published
 // state for the reason above. One worker instance owns one composer, so a module flag
@@ -33,15 +38,20 @@ function val(arg?: unknown): string {
   return typeof arg === "string" ? arg : ((arg as { value?: string; text?: string })?.value ?? (arg as { text?: string })?.text ?? "");
 }
 
-const svc = defineService<S, { setTitle: (s: S, a?: unknown) => S; setBody: (s: S, a?: unknown) => S; focusBody: (s: S) => S; submit: (s: S) => Promise<S> }>("spacesCreatePost", {
-  state: { status: "ready", title: "", body: "", hint: "Share something with the community.", bodyFocus: "" },
+const svc = defineService<S, { load: (s: S) => Promise<S>; setTitle: (s: S, a?: unknown) => S; setBody: (s: S, a?: unknown) => S; focusBody: (s: S) => S; submit: (s: S) => Promise<S> }>("spacesCreatePost", {
+  state: { status: "ready", title: "", body: "", hint: "Share something with the community.", bodyFocus: "", needsSignIn: false, noSignIn: true, hideForm: true },
   actions: {
+    load: async (s) => {
+      const { email } = await memberAccess();
+      return { ...s, needsSignIn: !email, noSignIn: !!email, hideForm: !email };
+    },
     setTitle: (s, a) => ({ ...s, title: val(a) }),
     setBody: (s, a) => ({ ...s, body: val(a) }),
     // Title's Next key lands here. The keyboard stays up (that is the "next"
     // contract) and the body field takes focus.
     focusBody: (s) => ({ ...s, bodyFocus: bumpToken(s.bodyFocus) }),
     submit: async (s) => {
+      if (s.needsSignIn) return { ...s, hint: "Sign in to post." };
       const title = s.title.trim();
       if (!title) return { ...s, hint: "Please enter a title." };
       // A second press while the first is still in flight is a NO-OP, not a second
@@ -63,7 +73,7 @@ const svc = defineService<S, { setTitle: (s: S, a?: unknown) => S; setBody: (s:
         // steals focus, so those transitions must clear it (see himi-store-account's
         // NO_FOCUS on its mode switches). Same token, opposite fix; the deciding
         // question is always whether the field stays mounted.
-        return { status: "ready", title: "", body: "", bodyFocus: s.bodyFocus, hint: `Posted “${title}” ✓ — it now appears in Blog.` };
+        return { ...s, status: "ready", title: "", body: "", bodyFocus: s.bodyFocus, hint: `Posted “${title}” ✓ — it now appears in Blog.` };
       } catch {
         return { ...s, status: "ready", hint: "Couldn't post — check your connection and try again." };
       } finally {

package/templates/portfolio-creative/tier5-src/wix-spaces-view-profile/index.ts

@@ -3,10 +3,15 @@
 // paint the seeded "apptestercoowner" demo identity when the session is a real
 // member (or a guest — show honesty instead).
 import { defineService } from "@himalaya/state";
-import { dispatch } from "@himalaya/dispatch";
+import { memberAccess } from "../_shared/member-access.js";
 import { getMyData, displayName } from "@himalaya/wix-users";
 
-interface S { status: "loading" | "ready"; name: string; handle: string; about: string; initial: string; photo: string }
+// `needsSignIn` / `noSignIn` drive the shared member gate: a guest gets the
+// gate with a Sign in button and no placeholder profile. `profileHidden` stays true until
+// `load` has resolved a member, so a guest never glimpses the placeholder avatar while
+// the membership check is still running; `hideLoading` is false for exactly that moment,
+// so the screen shows a loading line instead of going blank.
+interface S { status: "loading" | "ready"; name: string; handle: string; about: string; initial: string; photo: string; needsSignIn: boolean; noSignIn: boolean; profileHidden: boolean; hideLoading: boolean }
 
 const EMPTY: S = {
   status: "loading",
@@ -15,18 +20,17 @@ const EMPTY: S = {
   about: "No info to display.",
   initial: "?",
   photo: "",
+  needsSignIn: false,
+  noSignIn: true,
+  profileHidden: true,
+  hideLoading: false,
 };
 
+// The SAME member check create-post and orders use (`memberAccess`: the host's
+// memberIdentity, falling back to wix-users only on hosts that predate that action), so
+// one shared gate never gives two answers in one app.
 async function sessionEmail(): Promise<string> {
-  try {
-    const identity = await dispatch("himi.wix.memberIdentity") as unknown;
-    const direct = identity as { email?: unknown } | null;
-    const wrapped = identity as { payload?: { email?: unknown } } | null;
-    const email = direct?.email ?? wrapped?.payload?.email;
-    return typeof email === "string" ? email.trim() : "";
-  } catch {
-    return "";
-  }
+  return (await memberAccess()).email;
 }
 
 function wixApi() {
@@ -37,7 +41,7 @@ function fromParts(name: string, handleRaw: string, about: string, photo = ""):
   const clean = name.trim();
   const handle = "@" + (handleRaw || clean || "member").replace(/\s+/g, "").replace(/^@+/, "").toLowerCase();
   const initial = (clean.split(/\s+/).filter(Boolean).map((w) => w[0]).join("").slice(0, 2) || "?").toUpperCase();
-  return { status: "ready", name: clean || "Member", handle, about: about || "No info to display.", initial, photo };
+  return { status: "ready", name: clean || "Member", handle, about: about || "No info to display.", initial, photo, needsSignIn: false, noSignIn: true, profileHidden: false, hideLoading: true };
 }
 
 const svc = defineService<S, { load: (s: S) => Promise<S> }>("spacesViewProfile", {
@@ -48,11 +52,17 @@ const svc = defineService<S, { load: (s: S) => Promise<S> }>("spacesViewProfile"
       if (!email) {
         return {
           status: "ready",
+          // Kept for hosts without the shared member gate (the Spaces clone renders these
+          // fields directly); branded-lite hides the profile block behind `profileHidden`.
           name: "Sign in to view your profile",
           handle: "",
           about: "Your public profile is available after you sign in from Account.",
           initial: "?",
           photo: "",
+          needsSignIn: true,
+          noSignIn: false,
+          profileHidden: true,
+          hideLoading: true,
         };
       }
       try {