@withone/cli 2.14.0 → 2.14.1

package/dist/index.js

@@ -13245,8 +13245,9 @@ function copyDir(src, dest) {
     if (entry.name === SKILL_STAMP) continue;
     const from = path12.join(src, entry.name);
     const to = path12.join(dest, entry.name);
+    if (entry.isSymbolicLink()) continue;
     if (entry.isDirectory()) copyDir(from, to);
-    else fs14.copyFileSync(from, to);
+    else if (entry.isFile()) fs14.copyFileSync(from, to);
   }
 }
 function removePath(target) {
@@ -13273,20 +13274,50 @@ function linkDir(target, linkPath) {
   copyDir(target, linkPath);
   return "copy";
 }
+function knownLinkPaths(skill, scope) {
+  const canonical = `${UNIVERSAL_PROJECT_DIR}/${skill.dirName}`;
+  return new Set(
+    SKILL_AGENT_TARGETS.map((a) => `${scope === "project" ? a.projectDir : a.homeDir}/${skill.dirName}`).filter((p9) => p9 !== canonical)
+  );
+}
+function stampLinkPath(skill, plan, rel) {
+  return knownLinkPaths(skill, plan.scope).has(toPosix(rel)) ? fromStamp(plan.root, rel) : null;
+}
+function assertInsideProject(plan, target) {
+  if (plan.scope !== "project") return;
+  let dir = path12.dirname(target);
+  while (!fs14.existsSync(dir)) {
+    const parent = path12.dirname(dir);
+    if (parent === dir) break;
+    dir = parent;
+  }
+  const realRoot = fs14.realpathSync(plan.root);
+  const rel = path12.relative(realRoot, fs14.realpathSync(dir));
+  if (rel.startsWith("..") || path12.isAbsolute(rel)) {
+    throw new Error(`Refusing to change ${target}: a folder on that path leads outside the project (${plan.root}).`);
+  }
+}
 function installSkill(skill, source, plan, cliVersion2) {
   const canonical = canonicalSkillDir(skill, plan);
   const previous = readStamp(canonical);
   const { readers, folders } = resolveAgentFolders(plan);
   const nextPaths = new Set(folders.map((f) => `${f.dir}/${skill.dirName}`));
+  const targets = folders.map((folder) => {
+    const rel = `${folder.dir}/${skill.dirName}`;
+    return { rel, full: fromStamp(plan.root, rel), agents: folder.agents };
+  });
+  assertInsideProject(plan, canonical);
+  for (const t of targets) assertInsideProject(plan, t.full);
   for (const link of previous?.links ?? []) {
-    if (!nextPaths.has(toPosix(link.path))) removePath(fromStamp(plan.root, link.path));
+    if (nextPaths.has(toPosix(link.path))) continue;
+    const full = stampLinkPath(skill, plan, link.path);
+    if (!full) continue;
+    assertInsideProject(plan, full);
+    removePath(full);
   }
   removePath(canonical);
   copyDir(source.dir, canonical);
-  const links = folders.map((folder) => {
-    const rel = `${folder.dir}/${skill.dirName}`;
-    return { path: rel, kind: linkDir(canonical, fromStamp(plan.root, rel)), agents: folder.agents };
-  });
+  const links = targets.map((t) => ({ path: t.rel, kind: linkDir(canonical, t.full), agents: t.agents }));
   const stamp = {
     skill: skill.name,
     package: skill.packageName,
@@ -13305,8 +13336,11 @@ function removeSkill(skill, plan) {
   const stamp = readStamp(canonical);
   if (!stamp && !fs14.existsSync(path12.join(canonical, "SKILL.md"))) return { removed: false, paths: [] };
   const paths = [];
+  assertInsideProject(plan, canonical);
   for (const link of stamp?.links ?? []) {
-    const full = fromStamp(plan.root, link.path);
+    const full = stampLinkPath(skill, plan, link.path);
+    if (!full) continue;
+    assertInsideProject(plan, full);
     if (fs14.existsSync(full) || isDanglingLink(full)) {
       removePath(full);
       paths.push(full);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@withone/cli",
-  "version": "2.14.0",
+  "version": "2.14.1",
   "description": "CLI for managing One",
   "type": "module",
   "files": [