@withbuddi/buddi 0.1.0-pre.35 → 0.1.0-pre.37

package/node_modules/@buddi/gateway/dist/agents/platform-catalogue.js

@@ -25,7 +25,7 @@
  */
 import { existsSync, readdirSync, readFileSync, rmSync, statSync } from 'node:fs';
 import path from 'node:path';
-import { AGENT_FILE, applyFrontmatterPatch, assertApprovedEffect, getMission, HANDLE_MAX, hashEnvelope, parseAgentFile, parseSkillFile, satisfiesRange, setSchedule, SKILLS_DIR, STARTER_MAX, upsertMission, } from '@buddi/core';
+import { AGENT_FILE, applyFrontmatterPatch, assertApprovedEffect, getMission, setMissionExtras, HANDLE_MAX, hashEnvelope, parseAgentFile, parseSkillFile, satisfiesRange, setSchedule, SKILLS_DIR, STARTER_MAX, upsertMission, } from '@buddi/core';
 import { z } from 'zod';
 import { composePackagePersona, cronAt, cronClock, deniedTools, fileHash, parseClock, } from './catalogue-package.js';
 import { composeProvenance, fileEdited, packageOwnedText, readProvenance, PROVENANCE_FILE } from '../plugins/provenance.js';
@@ -33,7 +33,9 @@ import { composeAgentFile, composeSkillFile, createAgentDirAtomic, trashStamp, w
 import { diffGrant, grantChangeBlock } from './platform-grant.js';
 import { agentMissionId, describeCadence } from '../missions/reminders.js';
 import { normaliseAvatar } from './avatar-image.js';
+import { ownerText } from './owner-text.js';
 import { readAvatar, writeAvatar } from './avatars.js';
+import { DELEGATES_FILE, applyDelegateEdits, readDelegatesFile } from './delegation.js';
 /** Said when there is neither a fresh list nor a copy. */
 export const CATALOGUE_OFFLINE = "The catalogue needs withbuddi.com; try again when you're online.";
 /**
@@ -252,6 +254,21 @@ export class CatalogueRefusal extends Error {
 function refuse(code, message) {
     throw new CatalogueRefusal(code, message);
 }
+/** JSON with sorted keys, so a jsonb column's own key order never reads as a change. */
+function stableJson(value) {
+    if (Array.isArray(value))
+        return `[${value.map(stableJson).join(',')}]`;
+    if (value !== null && typeof value === 'object') {
+        return `{${Object.keys(value).sort().map((k) => `${JSON.stringify(k)}:${stableJson(value[k])}`).join(',')}}`;
+    }
+    return JSON.stringify(value ?? null);
+}
+/** A settings change in the owner's words: "reads news.edition_material before each run; reports up to 3,800 characters". */
+export function missionSettingsWords(change) {
+    const reads = change.context ? `reads ${change.context.plugin}.${change.context.export} before each run` : 'reads nothing before it runs';
+    const length = change.reportMax ? `reports up to ${change.reportMax.toLocaleString('en-US')} characters` : 'reports at the usual length';
+    return `${reads}; ${length}`;
+}
 export const installAgentInput = z
     .object({
     name: z.string().min(1).describe('The package, as platform.catalogue lists it: "chef".'),
@@ -375,8 +392,12 @@ export function resolvePicks(pkg, given, choices) {
         return { id: fill.id, kind: fill.kind, label: fill.label, value };
     });
 }
-/** Lines that differ, `- ` removed and `+ ` added, from a plain longest-common-subsequence. */
-export function lineDiff(before, after) {
+/**
+ * A unified diff of two texts, from a plain longest-common-subsequence: hunks headed `@@ -a,b +c,d @@`
+ * (1-based starts and line counts, as `diff -u` writes them), each line `- ` removed, `+ ` added or
+ * `  ` unchanged context, `context` lines of it around every change. Hunks closer than twice the context merge.
+ */
+export function lineDiff(before, after, context = 2) {
     const a = before.trim().split('\n');
     const b = after.trim().split('\n');
     const n = a.length;
@@ -387,27 +408,85 @@ export function lineDiff(before, after) {
             table[i][j] = a[i] === b[j] ? table[i + 1][j + 1] + 1 : Math.max(table[i + 1][j], table[i][j + 1]);
         }
     }
-    const out = [];
+    // Every line of both texts in order, with its 0-based place in the old (i) and new (j) text.
+    const ops = [];
     let i = 0;
     let j = 0;
     while (i < n && j < m) {
         if (a[i] === b[j]) {
+            ops.push({ k: ' ', text: a[i], i, j });
             i += 1;
             j += 1;
         }
         else if (table[i + 1][j] >= table[i][j + 1]) {
-            out.push(`- ${a[i]}`);
+            ops.push({ k: '-', text: a[i], i, j });
             i += 1;
         }
         else {
-            out.push(`+ ${b[j]}`);
+            ops.push({ k: '+', text: b[j], i, j });
             j += 1;
         }
     }
     while (i < n)
-        out.push(`- ${a[i++]}`);
+        ops.push({ k: '-', text: a[i], i: i++, j });
     while (j < m)
-        out.push(`+ ${b[j++]}`);
+        ops.push({ k: '+', text: b[j], i, j: j++ });
+    // Ranges of ops to show: each change widened by the context, overlapping or touching ranges joined.
+    const ranges = [];
+    ops.forEach((op, at) => {
+        if (op.k === ' ')
+            return;
+        const from = Math.max(0, at - context);
+        const to = Math.min(ops.length - 1, at + context);
+        const last = ranges[ranges.length - 1];
+        if (last && from <= last[1] + 1)
+            last[1] = Math.max(last[1], to);
+        else
+            ranges.push([from, to]);
+    });
+    const out = [];
+    for (const [from, to] of ranges) {
+        const hunk = ops.slice(from, to + 1);
+        const oldCount = hunk.filter((op) => op.k !== '+').length;
+        const newCount = hunk.filter((op) => op.k !== '-').length;
+        const oldStart = oldCount === 0 ? hunk[0].i : hunk[0].i + 1;
+        const newStart = newCount === 0 ? hunk[0].j : hunk[0].j + 1;
+        out.push(`@@ -${oldStart},${oldCount} +${newStart},${newCount} @@`);
+        for (const op of hunk)
+            out.push(`${op.k} ${op.text}`);
+    }
+    return out;
+}
+/** The hunk header's new-file start and line count, or null when the line is not one. */
+export function hunkHeader(line) {
+    const match = /^@@ -\d+,\d+ \+(\d+),(\d+) @@$/.exec(line);
+    return match ? { newStart: Number(match[1]), newCount: Number(match[2]) } : null;
+}
+/**
+ * The diff as the owner reads it: each line under its number in the new file (blank for a removed line),
+ * and `⋯ N lines` where unchanged lines between two hunks are left out. Hunk headers do not show.
+ */
+export function readableDiff(lines) {
+    const out = [];
+    let next = 0;
+    let shownTo = 0;
+    for (const line of lines) {
+        const header = hunkHeader(line);
+        if (header) {
+            const start = header.newCount === 0 ? header.newStart + 1 : header.newStart;
+            if (out.length > 0 && start - 1 > shownTo)
+                out.push(`     ⋯ ${start - 1 - shownTo} line${start - 1 - shownTo === 1 ? '' : 's'}`);
+            next = start;
+            continue;
+        }
+        const kind = line.slice(0, 1);
+        const number = kind === '-' ? '' : String(next);
+        if (kind !== '-') {
+            shownTo = next;
+            next += 1;
+        }
+        out.push(`${number.padStart(4)} ${line}`);
+    }
     return out;
 }
 /** The package the input names, read from the catalogue the gateway keeps; a refusal otherwise. */
@@ -448,6 +527,8 @@ function missionPlans(pkg, agentId, picks, timezone, on) {
             enabled: on.has(m.id),
             ...(m.alwaysDeliver === undefined ? {} : { alwaysDeliver: m.alwaysDeliver }),
             ...(m.misfirePolicy === undefined ? {} : { misfirePolicy: m.misfirePolicy }),
+            ...(m.context === undefined ? {} : { context: m.context }),
+            ...(m.reportMax === undefined ? {} : { reportMax: m.reportMax }),
         };
     });
 }
@@ -476,6 +557,82 @@ function checkDenied(pkg, resolvedTools) {
             'You can add any of them by hand after it is added.');
     }
 }
+const holdsDelegate = (tools) => tools.some((t) => t === 'agent.delegate' || t === 'agent.*');
+/**
+ * Who the agent hands work to, from its package's `delegates` (catalogue
+ * package names), and the lists it joins (docs/agents.md, "Delegation from
+ * the catalogue"). Install: its own list is the names resolved to agents
+ * installed here (by package, or an agent a package replaces); a front desk
+ * with an explicit list gains it, and so does any installed agent whose
+ * package names this one. Update: the resolved names are added to the list
+ * it has, nothing removed. A front desk or maker with no list already asks
+ * everyone and is left alone. Nothing is written here.
+ */
+async function planDelegation(pkg, agent, mode, deps, binding) {
+    const { registry, helpers } = deps;
+    const loaded = await helpers.service(registry)?.load({ cachedOnly: true }).catch(() => undefined);
+    const packages = loaded && 'packages' in loaded ? loaded.packages : [pkg];
+    const added = addedAgents(binding.agentsDir);
+    const installedId = (name) => {
+        const listed = packages.find((p) => p.manifest.name === name);
+        const hit = listed ? installedAsFor(listed, added, (id) => id) : undefined;
+        return hit?.agentId ?? binding.catalog.get(name)?.id;
+    };
+    const wanted = holdsDelegate(agent.tools)
+        ? (pkg.manifest.delegates ?? []).map(installedId).filter((id) => id !== undefined)
+        : [];
+    const resolved = helpers.delegatable(registry, [...new Set(wanted)], agent.id);
+    let before = [];
+    if (mode === 'update') {
+        try {
+            before = readDelegatesFile(agent.id, path.dirname(agent.dir)) ?? [];
+        }
+        catch {
+            before = [];
+        }
+    }
+    const after = [...before, ...resolved.filter((id) => !before.includes(id))];
+    const joins = [];
+    if (mode === 'install') {
+        for (const summary of binding.catalog.list()) {
+            // An example's list is the repo's, never written at runtime.
+            if (summary.id === agent.id || summary.source === 'example')
+                continue;
+            const other = binding.catalog.get(summary.id);
+            if (!other)
+                continue;
+            const otherDir = path.dirname(path.dirname(other.file));
+            let stored;
+            try {
+                stored = readDelegatesFile(other.id, otherDir);
+            }
+            catch {
+                continue;
+            }
+            if (stored?.includes('*') || stored?.includes(agent.id))
+                continue;
+            const open = summary.roles.includes('front-desk') || summary.roles.includes('maker');
+            if (stored === undefined && open)
+                continue;
+            const frontDesk = summary.roles.includes('front-desk') && stored !== undefined;
+            const from = added.find((a) => a.agentId === other.id);
+            const otherPkg = from ? packages.find((p) => matchesPackage(p, from) !== null) : undefined;
+            const named = holdsDelegate(other.tools) && (otherPkg?.manifest.delegates ?? []).includes(pkg.manifest.name);
+            if (!frontDesk && !named)
+                continue;
+            joins.push({
+                id: other.id,
+                handle: other.handle,
+                path: path.join(otherDir, other.id, DELEGATES_FILE),
+                content: `${JSON.stringify([...(stored ?? []), agent.id], null, 2)}\n`,
+            });
+        }
+    }
+    if (after.join(',') === before.join(',') && joins.length === 0)
+        return undefined;
+    const handles = Object.fromEntries(after.map((id) => [id, binding.catalog.get(id)?.handle ?? id]));
+    return { file: path.join(agent.dir, DELEGATES_FILE), before, after, handles, joins };
+}
 /**
  * The plan the owner was shown, as one fingerprint: the whole envelope but who
  * proposed it — the package's integrity, the resolved grant, the file's and
@@ -567,6 +724,7 @@ async function composeInstallEnvelope(input, deps) {
     }, { registry, proposedBy: deps.proposedBy });
     checkDenied(pkg, created.tools);
     const agentDir = path.dirname(created.file);
+    const delegation = await planDelegation(pkg, { id: created.id, tools: created.tools, dir: agentDir }, 'install', deps, binding);
     return {
         tool: 'platform.install_agent',
         mode: 'install',
@@ -587,6 +745,7 @@ async function composeInstallEnvelope(input, deps) {
         picks,
         avatar,
         created,
+        ...(delegation ? { delegation } : {}),
     };
 }
 async function buildUpdate(input, deps, pkg, binding, choices, packageInfo, avatar) {
@@ -683,17 +842,28 @@ async function buildUpdate(input, deps, pkg, binding, choices, packageInfo, avat
     }
     const grant = diffGrant(agent.tools, tools);
     const existing = new Set();
+    const plans = missionPlans(pkg, agent.id, picks, deps.timezone, new Set());
+    const missionSettings = [];
     if (deps.db) {
-        for (const mission of m.missions) {
-            const row = await getMission(deps.db, agentMissionId(agent.id, mission.id)).catch(() => null);
-            if (row)
-                existing.add(mission.id);
+        for (const plan of plans) {
+            const row = await getMission(deps.db, plan.id).catch(() => null);
+            if (!row)
+                continue;
+            existing.add(plan.slug);
+            // An existing mission is the owner's; only what the package says it reads and how long it reports may follow it.
+            const context = plan.context ?? null;
+            const reportMax = plan.reportMax ?? null;
+            if (stableJson(row.context ?? null) !== stableJson(context) || (row.reportMax ?? null) !== reportMax) {
+                missionSettings.push({ id: plan.id, name: row.name, context, reportMax });
+            }
         }
     }
-    const missions = missionPlans(pkg, agent.id, picks, deps.timezone, new Set()).filter((plan) => !existing.has(plan.slug));
+    const missions = plans.filter((plan) => !existing.has(plan.slug));
+    const delegation = await planDelegation(pkg, { id: agent.id, tools, dir }, 'update', deps, binding);
     return {
         tool: 'platform.install_agent',
         mode: 'update',
+        ...(delegation ? { delegation } : {}),
         proposedBy: deps.proposedBy,
         package: packageInfo,
         id: agent.id,
@@ -723,13 +893,37 @@ async function buildUpdate(input, deps, pkg, binding, choices, packageInfo, avat
             removed: grant.removed,
             widened: grant.widened,
             personaDiff: lineDiff(before.body, persona),
+            missionSettings,
         },
     };
 }
-function missionLines(missions) {
-    return missions.map((mission) => `  ${mission.name}, ${describeCadence(mission.cron, mission.timezone)} — ` +
+function personaBlock(diff) {
+    if (diff.length === 0)
+        return ['Its persona is unchanged.'];
+    const lines = readableDiff(diff);
+    return [
+        'Its persona changes:',
+        ...lines.slice(0, 80).map((line) => `  ${line}`),
+        ...(lines.length > 80 ? [`  … and ${lines.length - 80} more lines`] : []),
+    ];
+}
+function missionLines(missions, specs) {
+    return missions.map((mission) => `  ${ownerText(mission.name, specs)}, ${describeCadence(mission.cron, mission.timezone)} — ` +
         (mission.enabled ? 'ON from the start' : 'off until you turn it on'));
 }
+/** What the approval card says about delegation: whom it asks, who may ask it. */
+function delegationLines(envelope) {
+    const d = envelope.delegation;
+    if (!d)
+        return [];
+    const handleOf = (id) => d.handles[id] ?? id;
+    const added = d.after.filter((id) => !d.before.includes(id));
+    return [
+        ...(added.length === 0 ? [] : [`It may hand work to: ${added.map((id) => `@${handleOf(id)}`).join(', ')}.`]),
+        ...(d.joins.length === 0 ? [] : [`${d.joins.map((j) => `@${j.handle}`).join(', ')} may hand work to it.`]),
+        '',
+    ];
+}
 export function renderInstallPreview(envelope, specs, renderCreate) {
     const picks = envelope.picks.filter((p) => p.kind !== 'time' && p.value !== '');
     if (envelope.mode === 'update' && envelope.update) {
@@ -737,7 +931,7 @@ export function renderInstallPreview(envelope, specs, renderCreate) {
         return [
             `Update @${envelope.handle} from the catalogue: ${envelope.package.title} ${envelope.package.version}` +
                 ` (you have ${u.via ? `${u.via} ${u.fromVersion}` : u.fromVersion}).`,
-            `What changed: ${envelope.package.changes}`,
+            `What changed: ${ownerText(envelope.package.changes, specs)}`,
             '',
             ...(u.edited
                 ? [
@@ -759,14 +953,22 @@ export function renderInstallPreview(envelope, specs, renderCreate) {
                 : []),
             ...grantChangeBlock(envelope.handle, { ...diffGrant(u.toolsBefore, envelope.tools) }, specs),
             '',
-            ...(u.personaDiff.length === 0
-                ? ['Its persona is unchanged.']
-                : ['Its persona changes:', ...u.personaDiff.slice(0, 80).map((line) => `  ${line}`), ...(u.personaDiff.length > 80 ? [`  … and ${u.personaDiff.length - 80} more lines`] : [])]),
+            ...personaBlock(u.personaDiff),
+            ...delegationLines(envelope),
             ...(envelope.missions.length === 0
                 ? []
-                : ['', 'New missions it suggests, each off until you turn it on:', ...missionLines(envelope.missions)]),
+                : ['', 'New missions it suggests, each off until you turn it on:', ...missionLines(envelope.missions, specs)]),
+            ...((u.missionSettings ?? []).length === 0
+                ? []
+                : [
+                    '',
+                    'New settings for missions it already has (their prompt, hour and switch stay yours):',
+                    ...(u.missionSettings ?? []).map((c) => `  ${ownerText(c.name, specs)}: ${missionSettingsWords(c)}`),
+                ]),
             '',
-            'Missions it already has are yours and stay exactly as they are. Its handle, its account and its memory do not change.',
+            (u.missionSettings ?? []).length === 0
+                ? 'Missions it already has are yours and stay exactly as they are. Its handle, its account and its memory do not change.'
+                : 'Otherwise the missions it already has stay exactly as they are. Its handle, its account and its memory do not change.',
             `File:  ${envelope.file}`,
             `Proposed by ${envelope.proposedBy}.`,
         ].join('\n');
@@ -776,6 +978,7 @@ export function renderInstallPreview(envelope, specs, renderCreate) {
         '',
         renderCreate(envelope.created, specs),
         '',
+        ...delegationLines(envelope),
         ...(envelope.account === null
             ? []
             : [
@@ -791,26 +994,32 @@ export function renderInstallPreview(envelope, specs, renderCreate) {
             : [
                 `It arrives with ${envelope.skills.length} skill${envelope.skills.length === 1 ? '' : 's'} of its own ` +
                     '(a procedure in its prompt; it grants no tool and lowers no tier):',
-                ...envelope.skills.map((s) => `  ${s.name} — ${s.description}`),
+                ...envelope.skills.map((s) => `  ${s.name} — ${ownerText(s.description, specs)}`),
                 '',
             ]),
         ...(envelope.missions.length === 0
             ? []
-            : [`Its missions (pause or start any of them under Agents → Missions):`, ...missionLines(envelope.missions), '']),
+            : [`Its missions (pause or start any of them under Agents → Missions):`, ...missionLines(envelope.missions, specs), '']),
         `Once you approve, this file is YOURS: an update from the catalogue is always offered, never written`,
         'without your approval, and a file you change is never touched.',
     ].join('\n');
 }
-export function entryView(pkg, state, timezone, defaults) {
+/**
+ * `specs` are the tools this buddi knows: a tool name in the owner-facing text (pitch, description, about,
+ * changes, examples, mission names) is rewritten in words, for listings made before the market refused them.
+ */
+export function entryView(pkg, state, timezone, defaults, specs = []) {
     const m = pkg.manifest;
+    const known = [...specs, ...m.tools.filter((name) => !specs.some((s) => s.name === name)).map((name) => ({ name }))];
+    const words = (text) => ownerText(text, known);
     return {
         name: m.name,
         version: m.version,
         handle: m.handle,
         title: m.title,
-        pitch: m.pitch,
-        description: m.description,
-        about: m.about,
+        pitch: words(m.pitch),
+        description: words(m.description),
+        about: words(m.about),
         category: m.category,
         trust: m.trust,
         author: m.author,
@@ -820,7 +1029,7 @@ export function entryView(pkg, state, timezone, defaults) {
         tools: m.tools,
         missions: m.missions.map((mission) => ({
             id: mission.id,
-            name: mission.name,
+            name: words(mission.name),
             cron: mission.cron,
             when: describeCadence(mission.cron, timezone),
             prompt: mission.prompt,
@@ -832,9 +1041,9 @@ export function entryView(pkg, state, timezone, defaults) {
             optional: fill.optional === true,
             default: defaults?.find((d) => d.id === fill.id)?.value ?? '',
         })),
-        examples: m.examples,
+        examples: m.examples.map(words),
         skills: pkg.skills.map((s) => s.name),
-        changes: m.changes,
+        changes: words(m.changes),
         replaces: m.replaces,
         avatar: pkg.avatar,
         page: pkg.page,
@@ -879,7 +1088,7 @@ export function createCatalogueTools(registry, helpers) {
                 fetchedAt: loaded.fetchedAt,
                 ...(loaded.stale ? { stale: true } : {}),
                 agents: loaded.packages.map((pkg) => {
-                    const view = entryView(pkg, packageState(pkg, state), ctx.timezone);
+                    const view = entryView(pkg, packageState(pkg, state), ctx.timezone, undefined, registry.list());
                     return {
                         name: view.name,
                         version: view.version,
@@ -1028,6 +1237,17 @@ export function createCatalogueTools(registry, helpers) {
                 refuse('would-not-load', `${envelope.mode === 'install' ? `${envelope.package.title} was not added` : `@${envelope.handle} was not updated`}, and ` +
                     `nothing was changed: the agents would not load with it (${reload.error ?? reload.message}).`);
             }
+            // Who it hands work to, and the lists it joins: each on its own, after the agent loads (never undone by a failed list).
+            const lists = envelope.delegation
+                ? applyDelegateEdits([
+                    ...(envelope.delegation.after.join(',') === envelope.delegation.before.join(',')
+                        ? []
+                        : [{ id: envelope.id, path: envelope.delegation.file, content: `${JSON.stringify(envelope.delegation.after, null, 2)}\n` }]),
+                    ...envelope.delegation.joins,
+                ])
+                : { changed: [], failed: [] };
+            if (lists.changed.length > 0)
+                helpers.reload(registry);
             const assigned = envelope.mode === 'install' ? await helpers.assignAccount(registry, envelope.id, envelope.account) : '';
             let pictured = false;
             // The package's picture is kept in the database at install, so every page draws it without asking
@@ -1051,9 +1271,18 @@ export function createCatalogueTools(registry, helpers) {
             }
             const created = [];
             if (ctx.db) {
+                // The settings the owner approved for missions the agent already has: just these two, nothing the owner controls.
+                if (envelope.mode === 'update') {
+                    for (const change of envelope.update?.missionSettings ?? []) {
+                        await setMissionExtras(ctx.db, change.id, { context: change.context, reportMax: change.reportMax });
+                    }
+                }
                 for (const mission of envelope.missions) {
-                    if (envelope.mode === 'update' && (await getMission(ctx.db, mission.id).catch(() => null)))
+                    if (envelope.mode === 'update' && (await getMission(ctx.db, mission.id).catch(() => null))) {
+                        // The owner's prompt and hour stay; what the package says it reads and how long it reports follow it.
+                        await setMissionExtras(ctx.db, mission.id, { context: mission.context ?? null, reportMax: mission.reportMax ?? null });
                         continue;
+                    }
                     await upsertMission(ctx.db, {
                         id: mission.id,
                         name: mission.name,
@@ -1061,6 +1290,8 @@ export function createCatalogueTools(registry, helpers) {
                         prompt: mission.prompt,
                         enabled: mission.enabled,
                         alwaysDeliver: mission.alwaysDeliver ?? false,
+                        ...(mission.context ? { context: mission.context } : {}),
+                        ...(mission.reportMax ? { reportMax: mission.reportMax } : {}),
                     });
                     await setSchedule(ctx.db, mission.id, {
                         cron: mission.cron,
@@ -1084,6 +1315,7 @@ export function createCatalogueTools(registry, helpers) {
                 missions: created,
                 ...(pictured ? { picture: true } : {}),
                 ...(trashed ? { previousFile: trashed } : {}),
+                ...(lists.failed.length > 0 ? { delegatesNotWritten: lists.failed } : {}),
                 live: reload.reloaded,
                 message: (envelope.mode === 'install'
                     ? `@${envelope.handle} is on the team, and the file is the owner's now. `