@withbuddi/buddi 0.1.0-pre.30 → 0.1.0-pre.32

package/packages/gateway/dist/agents/platform.js

@@ -41,7 +41,7 @@
  */
 import { existsSync, readFileSync, statSync } from 'node:fs';
 import path from 'node:path';
-import { assertApprovedEffect, DEFAULT_MAX_TURNS, HANDLE, HANDLE_MAX, HANDLE_MIN, AGENT_FILE, KEBAB, RESERVED_AGENT_IDS, reservedAgentIdMessage, PROVIDER_KINDS, accountModelProblem, modelProblem, parseAgentFile, parseSkillFile, patchAgentSource, resolveToolNames, SKILLS_DIR, listGroups as coreListGroups, createGroup as coreCreateGroup, updateGroup as coreUpdateGroup, archiveGroup as coreArchiveGroup, planGroupChange, GroupRefusal, parseCron, setSchedule, upsertMission, DELEGATE_EVERYONE, IDLE_ROLLOVERS, } from '@buddi/core';
+import { assertApprovedEffect, DEFAULT_MAX_TURNS, HANDLE, HANDLE_MAX, HANDLE_MIN, AGENT_FILE, KEBAB, RESERVED_AGENT_IDS, reservedAgentIdMessage, PROVIDER_KINDS, accountModelProblem, modelProblem, parseAgentFile, parseSkillFile, patchAgentSource, resolveToolNames, SKILLS_DIR, listGroups as coreListGroups, createGroup as coreCreateGroup, updateGroup as coreUpdateGroup, archiveGroup as coreArchiveGroup, planGroupChange, GroupRefusal, parseCron, setSchedule, upsertMission, listMissions, setMissionEnabled, DELEGATE_EVERYONE, IDLE_ROLLOVERS, } from '@buddi/core';
 import { z } from 'zod';
 import { composeProvenance, driftFor, proposalChecksum, PROVENANCE_FILE } from '../plugins/provenance.js';
 import { agentSearchPath, EXAMPLES_AGENTS_DIR } from './catalog.js';
@@ -49,8 +49,8 @@ import { DELEGATES_FILE, readDelegates } from './delegation.js';
 import { insideExamples } from './owner-tools.js';
 import { withCoreTools } from './core-tools.js';
 import { storeBundledMascot } from './mascots.js';
-import { starterMission, starterProposals } from './starter-team.js';
-import { agentMissionId, describeCadence, slugify } from '../missions/reminders.js';
+import { createCatalogueTools, planInstall, } from './platform-catalogue.js';
+import { agentMissionId, describeCadence } from '../missions/reminders.js';
 import { composeAgentFile, composeSkillFile, createAgentDirAtomic, moveAgentAside, replaceBody, skillFilePath, trashStamp, writeFilesAtomic, TRASH_DIR, } from './platform-files.js';
 import { delegateToWriterRefusal, PLATFORM_READ_TOOLS, writeToolsIn, } from './platform-names.js';
 import { diffGrant, grantBlock, grantChangeBlock, } from './platform-grant.js';
@@ -118,6 +118,7 @@ function resolved(registry, env = process.env) {
         reload: binding.reload,
         accounts: binding.accounts?.(),
         setDefaultAgent: binding.setDefaultAgent,
+        catalogue: binding.catalogue?.(),
         agentsDir,
         skillsDir: binding.skillsDir ?? search.owner.skillsDir,
         examplesDir: binding.examplesDir ?? EXAMPLES_AGENTS_DIR,
@@ -439,6 +440,18 @@ export function renderDeletePreview(envelope) {
         `To:   ${envelope.trashDirectory}/${envelope.id}-<timestamp>`,
         '',
         `It loses ${envelope.tools.length} tools and stops answering @${envelope.handle} immediately.`,
+        ...(envelope.pausesMissions === undefined || envelope.pausesMissions.length === 0
+            ? []
+            : [
+                `Its ${envelope.pausesMissions.length === 1 ? 'mission is' : `${envelope.pausesMissions.length} missions are`} paused, ` +
+                    `not deleted: ${envelope.pausesMissions.map((m) => m.name).join(', ')}.`,
+            ]),
+        ...(envelope.unusedPlugins === undefined || envelope.unusedPlugins.length === 0
+            ? []
+            : [
+                `No other agent uses ${envelope.unusedPlugins.join(', ')}; ${envelope.unusedPlugins.length === 1 ? 'it stays' : 'they stay'} ` +
+                    'installed, and Settings → Plugins removes one.',
+            ]),
         ...(envelope.delegatedToBy.length === 0
             ? []
             : [
@@ -524,7 +537,9 @@ const createInput = z
         "one of the owner's own agents."),
 })
     .strict();
-function buildCreateEnvelope(input, deps) {
+function buildCreateEnvelope(
+// `starters` is not the tool's to take: only a catalogue package brings its example asks.
+input, deps) {
     const { binding, registry } = deps;
     const id = checkId(input.id);
     const handle = checkHandle(input.handle);
@@ -582,6 +597,7 @@ function buildCreateEnvelope(input, deps) {
         ...(input.maxTurns === undefined ? {} : { maxTurns: input.maxTurns }),
         ...(input.language === undefined ? {} : { language: input.language }),
         ...(input.idleRollover === undefined ? {} : { idleRollover: input.idleRollover }),
+        ...(input.starters === undefined || input.starters.length === 0 ? {} : { starters: input.starters }),
         ...(input.avatar === undefined ? {} : { avatar: checkAvatar(input.avatar) }),
         ...(input.accent === undefined ? {} : { accent: input.accent.toLowerCase() }),
         // Replacing the example that declares `default: true` must not leave the
@@ -990,13 +1006,53 @@ function buildDeleteEnvelope(input, deps) {
         delegatedToBy,
     };
 }
+/** The plugins the record says are installed, when the catalogue service can read it. */
+function installedPluginNames(binding) {
+    try {
+        return binding.catalogue?.plugins().map((p) => p.name) ?? [];
+    }
+    catch {
+        return [];
+    }
+}
+/**
+ * What removing an agent also does, read before the approval: the missions
+ * it runs that are on (paused by the same approval), and the installed
+ * plugins nobody else is granted (named, never removed).
+ */
+async function withRemoveExtras(envelope, deps) {
+    const missions = deps.db
+        ? (await listMissions(deps.db).catch(() => []))
+            .filter((m) => m.enabled && (m.agentId === envelope.id || m.id.startsWith(`agent:${envelope.id}:`)))
+            .map((m) => ({ id: m.id, name: m.name }))
+        : [];
+    const pluginOf = new Map();
+    for (const manifest of deps.registry.manifests()) {
+        if (!deps.installed.includes(manifest.name))
+            continue;
+        for (const tool of manifest.tools)
+            pluginOf.set(tool.name, manifest.name);
+    }
+    const mine = new Set(envelope.tools.map((t) => pluginOf.get(t)).filter((p) => p !== undefined));
+    for (const other of deps.binding.catalog.list()) {
+        if (other.id === envelope.id)
+            continue;
+        for (const tool of deps.binding.catalog.get(other.id)?.tools ?? []) {
+            const plugin = pluginOf.get(tool);
+            if (plugin)
+                mine.delete(plugin);
+        }
+    }
+    return {
+        ...envelope,
+        ...(missions.length === 0 ? {} : { pausesMissions: missions }),
+        ...(mine.size === 0 ? {} : { unusedPlugins: [...mine].sort() }),
+    };
+}
 export function pluginAgentProposals(registry) {
-    return [
-        ...registry.manifests().flatMap((m) => (m.agents ?? []).map((agent) => ({ plugin: m.name, pluginVersion: m.version, agent }))),
-        // The starter team (starter-team.ts): buddi's own proposals, under the
-        // built-in source `buddi`, accepted through the very same gated tool.
-        ...starterProposals(),
-    ];
+    // buddi's own ready-made agents are no longer proposals: they are packages
+    // in the catalogue (platform-catalogue.ts), added through platform.install_agent.
+    return registry.manifests().flatMap((m) => (m.agents ?? []).map((agent) => ({ plugin: m.name, pluginVersion: m.version, agent })));
 }
 export function pluginSkillProposals(registry) {
     return registry.manifests().flatMap((m) => (m.skills ?? []).map((skill) => ({ plugin: m.name, pluginVersion: m.version, skill })));
@@ -1012,7 +1068,7 @@ function findProposal(registry, plugin, agentId) {
     }
     return match;
 }
-/** Every mission an accept creates: the starter's one, then the plugin's. */
+/** Every mission an accept creates. */
 function acceptedMissions(envelope) {
     return [...(envelope.mission ? [envelope.mission] : []), ...(envelope.missions ?? [])];
 }
@@ -1109,7 +1165,6 @@ function buildAcceptAgentEnvelope(input, deps) {
             content,
         };
     });
-    const mission = starterMission(proposal.plugin, suggestion.id);
     const missions = (suggestion.missions ?? []).map((m) => {
         const slug = m.id.trim();
         if (!KEBAB.test(slug)) {
@@ -1144,17 +1199,6 @@ function buildAcceptAgentEnvelope(input, deps) {
         proposalChecksum: proposalChecksum(suggestion),
         skills,
         inheritedFrom: base.account === null ? null : (speaks?.from ?? null),
-        ...(mission === null
-            ? {}
-            : {
-                mission: {
-                    id: agentMissionId(base.id, slugify(mission.name)),
-                    name: mission.name,
-                    cron: mission.cron,
-                    timezone: deps.timezone,
-                    prompt: mission.prompt,
-                },
-            }),
         ...(missions.length === 0 ? {} : { missions }),
     };
 }
@@ -1360,12 +1404,46 @@ export function reloadResult(binding) {
     catch (err) {
         return {
             reloaded: false,
+            error: err instanceof Error ? err.message : String(err),
             message: 'The file is written, but reloading the catalog failed, so the running surfaces still hold the ' +
                 `previous one: ${err instanceof Error ? err.message : String(err)}. Tell the owner to fix that ` +
                 'and run `buddi service restart`.',
         };
     }
 }
+/* ------------------------------------------------------------------ *
+ * The agent catalogue (platform-catalogue.ts), built from the same pieces
+ * ------------------------------------------------------------------ */
+const CATALOGUE_HELPERS = {
+    resolved: (r) => resolved(r),
+    service: (r) => resolved(r).catalogue,
+    buildCreate: (input, deps) => buildCreateEnvelope(input, {
+        binding: resolved(deps.registry),
+        registry: deps.registry,
+        proposedBy: deps.proposedBy,
+    }),
+    speakingAccount: (r, agentId) => speakingAccount(resolved(r), agentId),
+    checkTools,
+    renderCreatePreview,
+    reload: (r) => reloadResult(resolved(r)),
+    assignAccount: (r, agentId, account) => assignAccount(resolved(r), agentId, account),
+    proposals: (r) => pluginAgentProposals(r),
+};
+/**
+ * What adding (or updating) a package would do, writing nothing: the envelope
+ * and the preview `platform.install_agent` would carry. For the dashboard's
+ * install sheet and update sheet, and `buddi agents add` without `--yes`.
+ */
+export function planCatalogueInstall(registry, input, ctx) {
+    return planInstall(registry, CATALOGUE_HELPERS, input, ctx);
+}
+/** The catalogue service and the agents directory the platform tools are bound to, or undefined when unbound. */
+export function catalogueBindingOf(registry) {
+    if (!bindings.get(registry))
+        return undefined;
+    const binding = resolved(registry);
+    return { catalog: binding.catalog, agentsDir: binding.agentsDir, trashRoot: binding.trashRoot, service: binding.catalogue };
+}
 /* ------------------------------------------------------------------ *
  * The manifest
  * ------------------------------------------------------------------ */
@@ -1418,6 +1496,7 @@ export function renderGroupUpdate(envelope, nameOf = (id) => id) {
     return sentence.charAt(0).toUpperCase() + sentence.slice(1);
 }
 export function createPlatformManifest(registry) {
+    const [catalogueTool, installAgent] = createCatalogueTools(registry, CATALOGUE_HELPERS);
     /* ---- groups: a team of agents in one conversation (docs/groups.md) ---- */
     const listGroups = {
         name: 'platform.list_groups',
@@ -1989,9 +2068,8 @@ export function createPlatformManifest(registry) {
             // leaves the initials, never an unfinished approval.
             const suggestion = findProposal(registry, input.plugin, input.agent).agent;
             const pictured = ctx.db ? await storeBundledMascot(ctx.db, envelope.id, suggestion.avatar) : false;
-            // A starter agent's first mission, approved with it: run as the new
-            // agent, so it is its own (`schedule.list_mine`) and it can stop it.
-            // A plugin's declared missions (Ledger's) are created the same way.
+            // A plugin's declared missions (Ledger's), approved with it: run as the
+            // new agent, so they are its own (`schedule.list_mine`) and it can stop them.
             const missions = ctx.db ? acceptedMissions(envelope) : [];
             for (const mission of missions) {
                 await upsertMission(ctx.db, {
@@ -2005,6 +2083,8 @@ export function createPlatformManifest(registry) {
                 await setSchedule(ctx.db, mission.id, {
                     cron: mission.cron,
                     timezone: mission.timezone,
+                    // Always the owner's zone of the moment (no proposal names one): it follows the owner.
+                    timezoneExplicit: false,
                     misfirePolicy: mission.misfirePolicy ?? 'coalesce',
                 });
             }
@@ -2071,20 +2151,32 @@ export function createPlatformManifest(registry) {
             CONDUCT,
         tier: 'gated',
         input: deleteInput,
-        describe(input, ctx) {
+        async describe(input, ctx) {
             const binding = resolved(registry);
-            return describing((i) => buildDeleteEnvelope(i, { binding, proposedBy: ctx.agentId ?? 'unknown' }), renderDeletePreview)(input);
+            const envelope = await withRemoveExtras(buildDeleteEnvelope(input, { binding, proposedBy: ctx.agentId ?? 'unknown' }), {
+                binding, registry, db: ctx.db, installed: installedPluginNames(binding),
+            });
+            return { envelope, preview: renderDeletePreview(envelope) };
         },
         async execute(input, ctx) {
             const binding = resolved(registry);
-            const envelope = buildDeleteEnvelope(input, { binding, proposedBy: ctx.agentId ?? 'unknown' });
+            const envelope = await withRemoveExtras(buildDeleteEnvelope(input, { binding, proposedBy: ctx.agentId ?? 'unknown' }), {
+                binding, registry, db: ctx.db, installed: installedPluginNames(binding),
+            });
             assertApprovedEffect(ctx, envelope);
             const movedTo = moveAgentAside(envelope.directory, binding.trashRoot, trashStamp(ctx.now()));
             const reload = reloadResult(binding);
+            const paused = [];
+            for (const mission of envelope.pausesMissions ?? []) {
+                if (ctx.db && (await setMissionEnabled(ctx.db, mission.id, false).catch(() => null)))
+                    paused.push(mission.id);
+            }
             return {
                 ok: true,
                 id: envelope.id,
                 movedTo,
+                ...(paused.length === 0 ? {} : { pausedMissions: paused }),
+                ...(envelope.unusedPlugins ? { unusedPlugins: envelope.unusedPlugins } : {}),
                 live: reload.reloaded,
                 message: `@${envelope.handle} is gone from the catalog. Its files were not deleted — they are at ` +
                     `${movedTo}, and moving that directory back restores the agent. ${reload.message}`,
@@ -2115,6 +2207,8 @@ export function createPlatformManifest(registry) {
             deleteAgent,
             acceptPluginAgent,
             acceptPluginSkill,
+            catalogueTool,
+            installAgent,
         ],
     };
 }