@withbuddi/buddi 0.1.0-pre.29 → 0.1.0-pre.30

package/node_modules/@buddi/gateway/dist/web/server.js

@@ -61,11 +61,12 @@ import { mlxhBaseUrl, probeMlxh } from '../mlxh.js';
 import { OnboardingRefusal, WEB_ONBOARDING_STEPS, WEB_ONBOARDING_SURFACE, claimOpeningTurn, createFirstAgent, probeOllama, readOnboarding, rebindBrain, updateFirstAgent, withFirstRunFacts, readFirstAgentPersona } from './onboarding.js';
 import { TakeOnRefusal, readTakeOn, startTakeOn } from './take-on.js';
 import { TelegramWebError, saveTelegramToken, telegramBot, telegramDevices, telegramPairing, telegramStatus, unpairTelegramDevice, } from './telegram.js';
-import { PAGE_ROUTE, sendPageFile, actOnPage, listPageDescriptors, runPageQuery, } from './pages.js';
+import { PAGE_ROUTE, sendPageFile, actOnPage, actRateLimited, listPageDescriptors, runPageQuery, } from './pages.js';
 import { listSecrets, secretUses, secretsAct } from './secrets.js';
 import { sayRoute, transcribeRoute } from './speech.js';
 import { createServer } from 'node:http';
-import { getAction, idleRolloverMs, inRecovery, listPendingActions, isJobState, parseAgentFile, setSentinelEnabled, snoozeFinding } from '@buddi/core';
+import { getAction, idleRolloverMs, inRecovery, listMissions, listPendingActions, isJobState, parseAgentFile, setSentinelEnabled, snoozeFinding, snoozeFindings, unmuteFindings } from '@buddi/core';
+import { actOnAlerts, askPrompt, findingsForAsk, muteAlert } from './alerts.js';
 import { connectionsOf } from '@buddi/tool-mcp';
 import { CONNECTIONS_CALLBACK_PATH, connectionsRoute } from './connections.js';
 import { browserHost } from '../browser-host.js';
@@ -93,7 +94,7 @@ import { retryHref, sendSignedOut, wantsSignedOutPage } from './signed-out.js';
 import { extensionEndpoint } from './extension.js';
 import { REMOTE_HAND_SOCKET_PATH, RemoteHandEndpoint } from './remote-hand.js';
 import { csrfCookieName, CSRF_HEADER, sessionCookieName, requestPort, BodyTooLargeError, first, cookieHeader, parseCookies, parseUrl, readJsonBody, remoteKey, requestOrigin, requestScope, sendEmpty, sendJson, sendText, } from './http.js';
-import { boundedLimit, readAgents, readApprovals, readConversation, readConversations, readEventKinds, readEvents, readJobs, readMissions, readOverview, setGlanceHidden, readOffers, readReminders, readSentinels, toApprovalView, } from './read.js';
+import { boundedLimit, readAgents, readApprovals, readConversation, readConversations, readEventKinds, readEvents, readJobs, readJobFailures, readMissions, readOverview, setGlanceHidden, readOffers, readReminders, readSentinels, toApprovalView, } from './read.js';
 import { RateLimiter, SessionStore, } from './sessions.js';
 import { supervisorCall } from './service.js';
 import { backupJobRoute, createBackupRoute, discardUpload, listBackups, passphraseRoute, receiveUpload, restoreRoute, scheduleRoute, verifyBackupRoute, } from './backups.js';
@@ -111,14 +112,14 @@ import { currentVersion, upgradeJobRoute, upgradeRoute, versionCheckRoute, versi
 import { leaveRecoveryMode, readRecoveryView } from './recovery.js';
 import { readRail, setRailPageHidden } from './rail.js';
 import { BUILD_MISSING, serveAsset, serveShellAtRoot } from './static.js';
-import { StreamBudget, resumeCursor, streamConversation } from './stream.js';
+import { StreamBudget, frame, resumeCursor, streamConversation } from './stream.js';
 import { ensureWebToken, verifyTicket } from './token.js';
 import { MAX_UPLOAD_BYTES, readUpload } from './upload.js';
 import { LOCKED_BODY, LockUnavailable, allowedWhileLocked, clientOf, createLock } from './lock.js';
 import { matchApiRoute, TOKEN_REFUSALS } from './api-routes.js';
 import { apiTokensRoute, bearerOf, verifyApiToken } from './api-tokens.js';
 import { LockImageRefusal, MAX_LOCK_IMAGE_BYTES, normaliseLockImage } from './lock-image.js';
-import { cancelJobFromWeb, cancelReminderFromWeb, decideApprovalFromWeb, retryJobFromWeb, setMissionEnabledFromWeb, setPausedFromWeb, setScheduleFromWeb, dismissOfferFromWeb, dismissOffersFromWeb, takeOfferFromWeb, } from './write.js';
+import { cancelJobFromWeb, cancelReminderFromWeb, decideApprovalFromWeb, retryJobFromWeb, retryJobsFromWeb, dismissJobsFromWeb, undismissJobsFromWeb, setMissionEnabledFromWeb, setPausedFromWeb, setScheduleFromWeb, dismissOfferFromWeb, dismissOffersFromWeb, takeOfferFromWeb, } from './write.js';
 /** How often approvals past their expiry are swept, and waiting delegations told. */
 export const EXPIRY_SWEEP_MS = 60_000;
 /**
@@ -137,6 +138,16 @@ const WEB_CHATS = new WeakMap();
  * it down, and a caller that built a bare `createWebApp` is unaffected.
  */
 const PREVIEW_APPS = new WeakMap();
+/**
+ * What a dashboard says to its open pages just before it closes: one
+ * `closing` frame on every live stream, naming the restart or stop the page
+ * itself asked for when it was one (`for`), so a page another device or the
+ * CLI restarted under draws "Restarting buddi" rather than errors, and
+ * reloads once the next process answers `/_buddi/ready` with a new `boot`.
+ */
+const CLOSING_SAYS = new WeakMap();
+/** How long a closing frame may take to reach the pages before the sockets go. */
+const CLOSING_FLUSH_MS = 250;
 /** The chat surface this server is running, if any. */
 /** The most of a text file a preview shows; the download has the whole. */
 const PREVIEW_TEXT_BYTES = 100_000;
@@ -304,6 +315,14 @@ export function createWebApp(deps) {
      */
     const lock = createLock({ pool: deps.pool, sessions, now: deps.now, get timezone() { return deps.timezone; }, widgets, log });
     const openStreams = new Map();
+    /*
+     * This process's boot: answered by `/_buddi/ready`, so a page that watches a
+     * restart can tell the process that went from the one that came back.
+     * Random, and nothing else: it says which run this is, not when or where.
+     */
+    const boot = randomUUID();
+    /** Set when a page asked the supervisor to restart or stop this process: what the closing frame says. */
+    let goingAway;
     /*
      * The session a live API token acts through: minted on its first request,
      * kept in memory only, one per token (and scope), so a stream budget or a
@@ -572,6 +591,31 @@ export function createWebApp(deps) {
     if (chat)
         WEB_CHATS.set(server, chat);
     PREVIEW_APPS.set(server, previews);
+    CLOSING_SAYS.set(server, async () => {
+        const said = frame('closing', goingAway === undefined ? {} : { for: goingAway });
+        const flushed = [];
+        for (const { responses } of openStreams.values()) {
+            for (const res of responses) {
+                if (res.writableEnded || res.destroyed)
+                    continue;
+                // Ended, not just written: an ended response is flushed before its
+                // socket goes, where a frame still queued would be dropped with it.
+                flushed.push(new Promise((resolve) => {
+                    try {
+                        res.end(said, () => resolve());
+                    }
+                    catch {
+                        resolve();
+                    }
+                }));
+            }
+        }
+        if (flushed.length === 0)
+            return;
+        let timer;
+        await Promise.race([Promise.all(flushed), new Promise((resolve) => { timer = setTimeout(resolve, CLOSING_FLUSH_MS); })]);
+        clearTimeout(timer);
+    });
     // "Your browser": the only path this server ever upgrades. Attached here
     // rather than in `startWebServer` so every caller, tests included, has it.
     extension.attach(server);
@@ -594,7 +638,7 @@ export function createWebApp(deps) {
             const challenge = url.searchParams.get('challenge') ?? '';
             if (!/^[a-f0-9]{64}$/.test(challenge))
                 return sendEmpty(res, 400);
-            return sendJson(res, 200, { proof: createHmac('sha256', deps.token).update(`buddi-ready-v1:${challenge}`).digest('hex') });
+            return sendJson(res, 200, { proof: createHmac('sha256', deps.token).update(`buddi-ready-v1:${challenge}`).digest('hex'), boot }, { 'Cache-Control': 'no-store' });
         }
         // A remote socket or proxy metadata can only earn remote access. It
         // decides how long a session minted now lives, and it must keep matching
@@ -1335,8 +1379,16 @@ export function createWebApp(deps) {
                         kind: q.get('kind') ?? undefined,
                         limit: boundedLimit(q.get('limit')),
                         offset: Math.max(0, Math.min(Number(q.get('offset') ?? 0) || 0, 100_000)),
+                        failed: q.get('failed') === 'open' || q.get('failed') === 'dismissed' ? q.get('failed') : undefined,
+                        hideDismissed: q.get('dismissed') === '0',
                     }));
                 }
+                // Failed jobs grouped by what broke them: the ones still asking, and
+                // the dismissed ones (by the owner, or quiet after 14 days) apart.
+                case '/api/jobs/failures': {
+                    const names = new Map(deps.catalog.list().map((a) => [a.id, a.name]));
+                    return sendJson(res, 200, await readJobFailures(deps.pool, now, (id) => names.get(id) ?? null));
+                }
                 case '/api/approvals': {
                     const approvals = await readApprovals(deps.pool, now, boundedLimit(q.get('limit'), 50));
                     return sendJson(res, 200, { pending: approvals.pending.map(a => ({ ...a, ...permissionScopes(a.tool) })),
@@ -1368,7 +1420,7 @@ export function createWebApp(deps) {
                         reminders: await readReminders(deps.pool, boundedLimit(q.get('limit'))),
                     });
                 case '/api/sentinels':
-                    return sendJson(res, 200, await readSentinels(deps.pool, deps.registry, boundedLimit(q.get('limit'), 50)));
+                    return sendJson(res, 200, await readSentinels(deps.pool, deps.registry, deps.now()));
                 case '/api/chat/agents':
                     return sendJson(res, 200, readChatAgents(deps.catalog, await avatarVersions(deps.pool)));
                 // Which agents are waiting on the owner. One small query, and the only
@@ -2267,14 +2319,64 @@ export function createWebApp(deps) {
                 return sendJson(res, 400, { error: 'Expected agentId and conversationId.' });
             return sendJson(res, 200, { stopped: host.stop(deps.ctx.ownerId, body.agentId, body.conversationId) });
         }
+        /*
+         * Alerts (alerts.ts): the owner's verbs on what the watchers found. Snooze
+         * one ("Not now" for a week with `days`, "Not needed" without), several at
+         * once (Clear all, and its Undo), silence a subject or a kind, run what a
+         * finding declared, or ask the agent that answers for it.
+         */
         const alert = /^\/api\/alerts\/([^/]+)\/snooze$/.exec(path);
         if (alert) {
             if (typeof body.snoozed !== 'boolean')
                 return sendJson(res, 400, { error: '`snoozed` must be true or false' });
-            const finding = await snoozeFinding(deps.pool, decodeURIComponent(alert[1]), body.snoozed, deps.now());
+            const days = typeof body.days === 'number' && Number.isFinite(body.days) && body.days > 0 && body.days <= 90 ? body.days : null;
+            const until = body.snoozed && days !== null ? new Date(deps.now().getTime() + days * 86_400_000) : null;
+            const finding = await snoozeFinding(deps.pool, decodeURIComponent(alert[1]), body.snoozed, deps.now(), until);
             if (!finding)
                 return sendJson(res, 404, { error: 'No open alert has that key.' });
-            return sendJson(res, 200, { key: finding.key, snoozedAt: finding.snoozedAt ? finding.snoozedAt.toISOString() : null });
+            return sendJson(res, 200, {
+                key: finding.key,
+                snoozedAt: finding.snoozedAt ? finding.snoozedAt.toISOString() : null,
+                snoozedUntil: finding.snoozedUntil ? finding.snoozedUntil.toISOString() : null,
+            });
+        }
+        if (path === '/api/alerts/snooze') {
+            const keys = Array.isArray(body.keys) ? body.keys.filter((k) => typeof k === 'string').slice(0, 500) : null;
+            if (keys === null || typeof body.snoozed !== 'boolean')
+                return sendJson(res, 400, { error: 'Send `{ keys: string[], snoozed: boolean, days? }`.' });
+            const days = typeof body.days === 'number' && Number.isFinite(body.days) && body.days > 0 && body.days <= 90 ? body.days : null;
+            const until = body.snoozed && days !== null ? new Date(deps.now().getTime() + days * 86_400_000) : null;
+            return sendJson(res, 200, { keys: await snoozeFindings(deps.pool, keys, body.snoozed, deps.now(), until) });
+        }
+        if (path === '/api/alerts/mute')
+            return reply(res, await muteAlert(deps.pool, body, deps.now()));
+        const unmute = /^\/api\/alerts\/mutes\/([^/]+)\/remove$/.exec(path);
+        if (unmute) {
+            const removed = await unmuteFindings(deps.pool, decodeURIComponent(unmute[1]));
+            return removed ? sendJson(res, 200, { removed: true }) : sendJson(res, 404, { error: 'Nothing is silenced under that id.' });
+        }
+        if (path === '/api/alerts/act') {
+            if (actRateLimited(session.id, deps.now().getTime()))
+                return sendJson(res, 429, { error: 'Too many writes from this page. Wait a moment and try again.' });
+            return reply(res, await actOnAlerts({ pool: deps.pool, registry: deps.registry, ctx: deps.ctx, now: deps.now }, body, session));
+        }
+        if (path === '/api/alerts/ask') {
+            const keys = Array.isArray(body.keys) ? body.keys.filter((k) => typeof k === 'string') : [];
+            const findings = await findingsForAsk(deps.pool, keys);
+            if (findings.length === 0)
+                return sendJson(res, 404, { error: 'No alert has those keys.' });
+            if (!chat)
+                return sendJson(res, 503, { error: 'Chat is not running in this process.' });
+            // The agent that answers for them, else whoever runs the wake mission.
+            const wake = (await listMissions(deps.pool)).find((m) => m.id === 'sentinel-wake');
+            const agentId = findings.find((f) => f.agentId !== null && deps.catalog.get(f.agentId) !== undefined)?.agentId ?? wake?.agentId ?? null;
+            if (agentId === null)
+                return sendJson(res, 409, { error: 'No agent answers for this alert yet.' });
+            const { label, prompt } = askPrompt(findings);
+            const sent = await chat.send({ agentId, text: prompt, offer: { id: `alert:${findings[0].key}`.slice(0, 200), label, brief: true } });
+            if (!sent.ok)
+                return sendJson(res, sent.status, { error: sent.error });
+            return sendJson(res, 200, { agentId, conversationId: sent.conversationId, runId: sent.runId });
         }
         /*
          * A watcher, switched off or back on. Off means it does not run: it raises
@@ -2530,8 +2632,10 @@ export function createWebApp(deps) {
             }
             const outcome = await leaveRecoveryMode({ pool: deps.pool, env: deps.env ?? process.env, log }, deps.ctx.ownerId, { dropPending: body.dropPending !== false, keepGrants: keep }, now);
             if (socket) {
+                goingAway = 'restart';
                 res.once('finish', () => {
                     void supervisorCall(socket, '/restart', 'POST').catch((err) => {
+                        goingAway = undefined;
                         log(`web: supervisor restart after leaving recovery failed: ${err instanceof Error ? err.message : String(err)}`);
                     });
                 });
@@ -2571,8 +2675,10 @@ export function createWebApp(deps) {
                     return sendJson(res, 503, { error: 'The supervisor is not answering on its control socket. Run buddi in a terminal.' });
                 }
             }
+            goingAway = action === 'stop' ? 'stop' : 'restart';
             res.once('finish', () => {
                 void supervisorCall(socket, `/${action}`, 'POST').catch((err) => {
+                    goingAway = undefined;
                     log(`web: supervisor ${action} failed: ${err instanceof Error ? err.message : String(err)}`);
                 });
             });
@@ -3013,6 +3119,14 @@ export function createWebApp(deps) {
                 return sendJson(res, 400, { error: change });
             return finish(res, setAgentEngineFromWeb({ catalog: deps.catalog, env: deps.env ?? process.env }, decodeURIComponent(engine[1]), change));
         }
+        // Failed jobs in bulk — by ids, by cause group, or every one still asking.
+        // Dismiss keeps them on record and out of the footer's count.
+        if (path === '/api/jobs/dismiss')
+            return finish(res, await dismissJobsFromWeb(writeDeps, body));
+        if (path === '/api/jobs/undismiss')
+            return finish(res, await undismissJobsFromWeb(writeDeps, body));
+        if (path === '/api/jobs/retry')
+            return finish(res, await retryJobsFromWeb(writeDeps, body));
         const job = /^\/api\/jobs\/([^/]+)\/(retry|cancel)$/.exec(path);
         if (job) {
             const jobId = decodeURIComponent(job[1]);
@@ -3276,6 +3390,8 @@ export async function startWebServer(deps) {
         close: async () => {
             if (expirySweep)
                 clearInterval(expirySweep);
+            // Said before anything closes, while the streams can still carry it.
+            await CLOSING_SAYS.get(server)?.();
             // Both listeners, both awaited. A preview socket still open is a port
             // still held, and the next thing to want it — the next test, the
             // gateway coming back up — finds it taken.