@wistia/ui 3.0.0 → 3.0.1

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## 3.0.1
+
+### Patch Changes
+
+- [#4556](https://github.com/wistia/vhs/pull/4556) [`ae46e8f`](https://github.com/wistia/vhs/commit/ae46e8f530f67ff5a68b082d611c3da6fd295099) Thanks [@wistia-wizard](https://github.com/apps/wistia-wizard)! - Link: a link with a `beforeAction` now calls its `onClick` during the click, instead of after `beforeAction` finishes, and navigates whether or not `onClick` throws. Since 2.13.1, link items in a `Menu` with an absolute `href` and a `beforeAction` stopped navigating: the menu's click handler ran after the `await` and threw, which skipped `window.location.assign`.
+
 ## 3.0.0
 
 ### Major Changes

package/dist/index.js

@@ -1,6 +1,6 @@
 
 /*
- * @license @wistia/ui v3.0.0
+ * @license @wistia/ui v3.0.1
  *
  * Copyright (c) 2024-2026, Wistia, Inc. and its affiliates.
  *
@@ -5854,19 +5854,24 @@ const Link = ({ beforeAction, children, type, disabled = false, colorScheme = "i
 	const to = generateHref(props.href, type, disabled);
 	const shouldUseReactRouterLink = inRouterContext && type !== "external" && !to?.startsWith("http");
 	const hasIcons = isNotNil(leftIcon) || isNotNil(rightIcon);
-	const handleClick = async (event) => {
-		if (disabled) event.preventDefault();
-		else if (beforeAction) {
+	const runBeforeAction = async (action) => {
+		try {
+			await action();
+		} catch (error) {
+			console.error(error);
+		}
+		if (!shouldUseReactRouterLink && isNotNil(to)) window.location.assign(to);
+	};
+	const handleClick = (event) => {
+		if (disabled) {
+			event.preventDefault();
+			return;
+		}
+		if (beforeAction) {
 			if (!shouldUseReactRouterLink) event.preventDefault();
-			try {
-				await beforeAction();
-			} catch (error) {
-				console.error(error);
-			} finally {
-				if (isFunction(props.onClick)) props.onClick(event);
-				if (!shouldUseReactRouterLink && isNotNil(to)) window.location.assign(to);
-			}
-		} else if (isFunction(props.onClick)) props.onClick(event);
+			runBeforeAction(beforeAction);
+		}
+		if (isFunction(props.onClick)) props.onClick(event);
 	};
 	const commonProps = {
 		$colorScheme: colorScheme,