@wistia/oxlint-config 1.9.1 → 1.10.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@wistia/oxlint-config",
-  "version": "1.9.1",
+  "version": "1.10.1",
   "description": "Wistia's Oxlint configurations",
   "keywords": [
     "linter",
@@ -76,16 +76,16 @@
     "validate": "vitest run test/validate-configs.test.mjs"
   },
   "dependencies": {
-    "@eslint-react/eslint-plugin": "^5.11.3",
-    "@vitest/eslint-plugin": "^1.6.21",
+    "@eslint-react/eslint-plugin": "^5.18.0",
+    "@vitest/eslint-plugin": "^1.6.24",
     "confusing-browser-globals": "^1.0.11",
     "eslint-plugin-barrel-files": "^3.0.1",
     "eslint-plugin-import-x": "^4.17.1",
-    "eslint-plugin-jest-dom": "^5.5.0",
-    "eslint-plugin-n": "^18.2.1",
+    "eslint-plugin-jest-dom": "^5.6.0",
+    "eslint-plugin-n": "^18.2.2",
     "eslint-plugin-no-only-tests": "^3.4.0",
-    "eslint-plugin-playwright": "^2.10.5",
-    "eslint-plugin-storybook": "^10.4.6",
+    "eslint-plugin-playwright": "^2.11.0",
+    "eslint-plugin-storybook": "^10.5.5",
     "eslint-plugin-styled-components": "^0.0.0",
     "eslint-plugin-styled-components-a11y": "^2.2.1",
     "eslint-plugin-testing-library": "^7.16.2",
@@ -93,19 +93,19 @@
   },
   "devDependencies": {
     "@changesets/changelog-github": "^0.7.0",
-    "@changesets/cli": "^2.31.0",
-    "eslint": "^10.6.0",
-    "oxfmt": "^0.59.0",
-    "oxlint": "^1.74.0",
-    "oxlint-tsgolint": "^0.24.0",
-    "storybook": "^10.4.6",
+    "@changesets/cli": "^2.31.1",
+    "eslint": "^10.8.0",
+    "oxfmt": "^0.60.0",
+    "oxlint": "^1.75.0",
+    "oxlint-tsgolint": "^7.0.2001",
+    "storybook": "^10.5.5",
     "vitest": "^4.1.10"
   },
   "peerDependencies": {
-    "eslint": ">= 10.6.0",
-    "oxfmt": ">= 0.59.0",
-    "oxlint": ">= 1.74.0",
-    "oxlint-tsgolint": ">= 0.24.0"
+    "eslint": ">= 10.8.0",
+    "oxfmt": ">= 0.60.0",
+    "oxlint": ">= 1.75.0",
+    "oxlint-tsgolint": ">= 7.0.2001"
   },
   "peerDependenciesMeta": {
     "oxfmt": {

package/rules/node.mjs

@@ -44,6 +44,10 @@ export const nodeRules = {
     // Decision: too restrictive for general use
     'node/no-sync': 'off',
 
+    // Disallow top-level await
+    // https://oxc.rs/docs/guide/usage/linter/rules/node/no-top-level-await.html
+    'node/no-top-level-await': ['error', { ignoreBin: true }],
+
     //eslint-plugin-n rules via jsPlugins
 
     // Disallow deprecated APIs
@@ -80,7 +84,8 @@ export const nodeRules = {
 
     // Disallow top-level await
     // https://github.com/eslint-community/eslint-plugin-n/blob/HEAD/docs/rules/no-top-level-await.md
-    'n/no-top-level-await': ['error', { ignoreBin: true }],
+    // Decision: handled by native node/no-top-level-await
+    'n/no-top-level-await': 'off',
 
     // Require return statements after callbacks
     // https://github.com/eslint-community/eslint-plugin-n/blob/HEAD/docs/rules/callback-return.md

package/rules/playwright.mjs

@@ -196,6 +196,10 @@ export const playwrightRules = {
     // https://github.com/playwright-community/eslint-plugin-playwright/blob/main/docs/rules/no-duplicate-slow.md
     'eslint-plugin-playwright/no-duplicate-slow': 'error',
 
+    // Disallow assertions on a Locator that can never fail
+    // https://github.com/playwright-community/eslint-plugin-playwright/blob/main/docs/rules/no-unnecessary-assertions.md
+    'eslint-plugin-playwright/no-unnecessary-assertions': 'error',
+
     // Enforce blank lines between test blocks
     // https://github.com/playwright-community/eslint-plugin-playwright/blob/main/docs/rules/consistent-spacing-between-blocks.md
     // Decision: style preference, left to a formatter

package/rules/react.mjs

@@ -249,6 +249,11 @@ export const reactRules = {
     // Decision: requires project-specific configuration
     'react/forbid-elements': 'off',
 
+    // Enforce a consistent function form for function components
+    // https://oxc.rs/docs/guide/usage/linter/rules/react/function-component-definition.html
+    // Decision: style preference
+    'react/function-component-definition': 'off',
+
     // Enforce destructuring assignment of useState hook
     // https://oxc.rs/docs/guide/usage/linter/rules/react/hook-use-state.html
     // Decision: too opinionated for general use

package/rules/unicorn.mjs

@@ -65,15 +65,21 @@ export const unicornRules = {
 
     // Enforce specific import styles per module
     // https://oxc.rs/docs/guide/usage/linter/rules/unicorn/import-style.html
-    // Override built-in defaults: this rule ships preferring default imports
-    // for `chalk`, `path`, and `node:path`. We require named imports instead.
+    // Override built-in defaults. Entries merge into the built-in style per key
+    // rather than replacing it, so every key we want must be set explicitly.
+    // - `node:path` ships default-only. Of all node builtins the rule constrains
+    //   only `node:path` (default-only) and `node:util` (named-only); `fs`,
+    //   `os`, `crypto`, `url`, `events` and the rest are unconstrained. Named is
+    //   our style everywhere else, so override it.
+    // - `chalk` ships default-only, which is right for the pre-built instance
+    //   (chalk's whole main API) but wrong for `import { Chalk } from 'chalk'`,
+    //   the class you instantiate for a custom instance. Both are legitimate.
     'unicorn/import-style': [
       'error',
       {
         styles: {
           'node:path': { named: true, default: false },
-          path: { named: true, default: false },
-          chalk: { named: true, default: false },
+          chalk: { named: true, default: true },
         },
       },
     ],

package/rules/vitest.mjs

@@ -36,6 +36,10 @@ export const vitestRules = {
     // https://oxc.rs/docs/guide/usage/linter/rules/vitest/padding-around-after-all-blocks.html
     'vitest/padding-around-after-all-blocks': 'error',
 
+    // Enforce padding around test blocks
+    // https://oxc.rs/docs/guide/usage/linter/rules/vitest/padding-around-test-blocks.html
+    'vitest/padding-around-test-blocks': 'error',
+
     // Disallow conditional tests
     // https://oxc.rs/docs/guide/usage/linter/rules/vitest/no-conditional-in-test.html
     'vitest/no-conditional-in-test': 'error',
@@ -509,7 +513,8 @@ export const vitestRules = {
 
     // Enforce padding around test blocks
     // https://github.com/vitest-dev/eslint-plugin-vitest/blob/main/docs/rules/padding-around-test-blocks.md
-    'vitest-js/padding-around-test-blocks': 'error',
+    // Decision: handled by native vitest/padding-around-test-blocks
+    'vitest-js/padding-around-test-blocks': 'off',
 
     // Prefer toHaveBeenCalledOnce() over toHaveBeenCalledTimes(1)
     // https://github.com/vitest-dev/eslint-plugin-vitest/blob/main/docs/rules/prefer-called-once.md