@wistia/oxlint-config 1.7.2 → 1.8.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@wistia/oxlint-config",
-  "version": "1.7.2",
+  "version": "1.8.0",
   "description": "Wistia's Oxlint configurations",
   "packageManager": "yarn@4.17.1",
   "type": "module",
@@ -11,7 +11,8 @@
     "/index.mjs",
     "/index.d.mts",
     "/oxfmtConfig.mjs",
-    "/oxfmtConfig.d.mts"
+    "/oxfmtConfig.d.mts",
+    "/resolve-plugin.mjs"
   ],
   "exports": {
     "./package.json": "./package.json",
@@ -60,9 +61,9 @@
   },
   "peerDependencies": {
     "eslint": ">= 10.6.0",
-    "oxfmt": ">= 0.57.0",
-    "oxlint": ">= 1.72.0",
-    "oxlint-tsgolint": ">= 0.23.0"
+    "oxfmt": ">= 0.58.0",
+    "oxlint": ">= 1.73.0",
+    "oxlint-tsgolint": ">= 0.24.0"
   },
   "peerDependenciesMeta": {
     "oxfmt": {
@@ -89,9 +90,9 @@
     "@changesets/changelog-github": "^0.7.0",
     "@changesets/cli": "^2.31.0",
     "eslint": "^10.6.0",
-    "oxfmt": "^0.57.0",
-    "oxlint": "^1.72.0",
-    "oxlint-tsgolint": "^0.23.0",
+    "oxfmt": "^0.58.0",
+    "oxlint": "^1.73.0",
+    "oxlint-tsgolint": "^0.24.0",
     "storybook": "^10.4.6",
     "vitest": "^4.1.9"
   },

package/resolve-plugin.mjs

@@ -0,0 +1,10 @@
+import { fileURLToPath } from 'node:url';
+
+// Resolves a jsPlugin package to an absolute path from within this package.
+// oxlint resolves bare specifiers (e.g. 'eslint-plugin-storybook') from the
+// consumer's config location, not from this package — so when a consumer's
+// dependency tree nests this package's dependencies (e.g. its typescript
+// version differs from the consumer's root), bare specifiers fail to resolve.
+// An absolute path loads the copy this package depends on, both in this repo
+// and from a consumer's node_modules.
+export const resolvePlugin = (specifier) => fileURLToPath(import.meta.resolve(specifier));

package/rules/barrel-files.mjs

@@ -1,7 +1,9 @@
+import { resolvePlugin } from '../resolve-plugin.mjs';
+
 // All barrel-files rules loaded via jsPlugins (no native oxlint support).
 // see: https://marvinh.dev/blog/speeding-up-javascript-ecosystem-part-7/
 export const barrelFilesRules = {
-  jsPlugins: ['eslint-plugin-barrel-files'],
+  jsPlugins: [resolvePlugin('eslint-plugin-barrel-files')],
   rules: {
     // Avoid barrel files
     // https://github.com/thepassle/eslint-plugin-barrel-files/blob/main/docs/rules/avoid-barrel-files.md

package/rules/base.mjs

@@ -175,6 +175,10 @@ export const baseRules = {
     // https://oxc.rs/docs/guide/usage/linter/rules/eslint/no-unreachable.html
     'eslint/no-unreachable': 'error',
 
+    // Disallow loops whose body allows only one iteration
+    // https://oxc.rs/docs/guide/usage/linter/rules/eslint/no-unreachable-loop.html
+    'eslint/no-unreachable-loop': 'error',
+
     // Disallow control flow statements in finally blocks
     // https://oxc.rs/docs/guide/usage/linter/rules/eslint/no-unsafe-finally.html
     'eslint/no-unsafe-finally': 'error',

package/rules/import.mjs

@@ -1,8 +1,10 @@
+import { resolvePlugin } from '../resolve-plugin.mjs';
+
 // Native oxlint import rules + eslint-plugin-import-x via jsPlugins for rules
 // without native equivalents.
 export const importRules = {
   plugins: ['import'],
-  jsPlugins: [{ name: 'import-x-js', specifier: 'eslint-plugin-import-x' }],
+  jsPlugins: [{ name: 'import-x-js', specifier: resolvePlugin('eslint-plugin-import-x') }],
   rules: {
     // Ensure named imports coupled with named exports
     // https://oxc.rs/docs/guide/usage/linter/rules/import/named.html

package/rules/node.mjs

@@ -1,8 +1,10 @@
+import { resolvePlugin } from '../resolve-plugin.mjs';
+
 // Native oxlint node rules + eslint-plugin-n via jsPlugins for rules
 // without native equivalents.
 export const nodeRules = {
   plugins: ['node'],
-  jsPlugins: [{ name: 'n', specifier: 'eslint-plugin-n' }],
+  jsPlugins: [{ name: 'n', specifier: resolvePlugin('eslint-plugin-n') }],
   rules: {
     // Require return statements after callbacks
     // https://oxc.rs/docs/guide/usage/linter/rules/node/callback-return.html

package/rules/playwright.mjs

@@ -1,6 +1,8 @@
+import { resolvePlugin } from '../resolve-plugin.mjs';
+
 // All playwright rules loaded via jsPlugins (no native oxlint support).
 export const playwrightRules = {
-  jsPlugins: ['eslint-plugin-playwright'],
+  jsPlugins: [resolvePlugin('eslint-plugin-playwright')],
   rules: {
     // Disallow focused tests
     // https://github.com/playwright-community/eslint-plugin-playwright/blob/main/docs/rules/no-focused-test.md

package/rules/react.mjs

@@ -1,8 +1,10 @@
+import { resolvePlugin } from '../resolve-plugin.mjs';
+
 // Native oxlint react rules + @eslint-react/eslint-plugin via jsPlugins for rules
 // without native equivalents.
 export const reactRules = {
   plugins: ['react'],
-  jsPlugins: [{ name: '@eslint-react', specifier: '@eslint-react/eslint-plugin' }],
+  jsPlugins: [{ name: '@eslint-react', specifier: resolvePlugin('@eslint-react/eslint-plugin') }],
   rules: {
     // Enforce that button elements have an explicit type attribute
     // https://oxc.rs/docs/guide/usage/linter/rules/react/button-has-type.html

package/rules/storybook.mjs

@@ -1,6 +1,8 @@
+import { resolvePlugin } from '../resolve-plugin.mjs';
+
 // All storybook rules loaded via jsPlugins (no native oxlint support).
 export const storybookRules = {
-  jsPlugins: ['eslint-plugin-storybook'],
+  jsPlugins: [resolvePlugin('eslint-plugin-storybook')],
   rules: {
     // Interactions should be awaited
     // https://github.com/storybookjs/eslint-plugin-storybook/blob/main/docs/rules/await-interactions.md

package/rules/styled-components.mjs

@@ -1,6 +1,8 @@
+import { resolvePlugin } from '../resolve-plugin.mjs';
+
 // All styled-components-a11y rules loaded via jsPlugins (no native oxlint support).
 export const styledComponentsRules = {
-  jsPlugins: ['eslint-plugin-styled-components-a11y'],
+  jsPlugins: [resolvePlugin('eslint-plugin-styled-components-a11y')],
   rules: {
     // Enforce that all elements that require alternative text have meaningful information
     // https://github.com/brendanmorrell/eslint-plugin-styled-components-a11y/blob/master/docs/rules/alt-text.md

package/rules/testing-library.mjs

@@ -1,6 +1,11 @@
+import { resolvePlugin } from '../resolve-plugin.mjs';
+
 // All testing-library + jest-dom rules loaded via jsPlugins (no native oxlint support).
 export const testingLibraryRules = {
-  jsPlugins: ['eslint-plugin-testing-library', 'eslint-plugin-jest-dom'],
+  jsPlugins: [
+    resolvePlugin('eslint-plugin-testing-library'),
+    resolvePlugin('eslint-plugin-jest-dom'),
+  ],
   rules: {
     // Enforce async events to be awaited
     // https://github.com/testing-library/eslint-plugin-testing-library/blob/main/docs/rules/await-async-events.md

package/rules/unicorn.mjs

@@ -54,6 +54,10 @@ export const unicornRules = {
     // https://oxc.rs/docs/guide/usage/linter/rules/unicorn/explicit-length-check.html
     'unicorn/explicit-length-check': 'error',
 
+    // Enforce explicit delay argument for `setTimeout()` and `setInterval()`
+    // https://oxc.rs/docs/guide/usage/linter/rules/unicorn/explicit-timer-delay.html
+    'unicorn/explicit-timer-delay': 'error',
+
     // Enforce a case style for filenames
     // https://oxc.rs/docs/guide/usage/linter/rules/unicorn/filename-case.html
     // Decision: project-specific; consumers enforce their own filename conventions
@@ -133,6 +137,10 @@ export const unicornRules = {
     // https://oxc.rs/docs/guide/usage/linter/rules/unicorn/no-await-in-promise-methods.html
     'unicorn/no-await-in-promise-methods': 'error',
 
+    // Disallow confusing uses of `Array#with()`
+    // https://oxc.rs/docs/guide/usage/linter/rules/unicorn/no-confusing-array-with.html
+    'unicorn/no-confusing-array-with': 'error',
+
     // Do not use leading/trailing space between `console.log` parameters
     // https://oxc.rs/docs/guide/usage/linter/rules/unicorn/no-console-spaces.html
     // Decision: formatter territory

package/rules/vitest.mjs

@@ -1,9 +1,11 @@
+import { resolvePlugin } from '../resolve-plugin.mjs';
+
 // Native oxlint vitest rules + jsPlugin rules from @vitest/eslint-plugin and eslint-plugin-no-only-tests
 export const vitestRules = {
   plugins: ['vitest'],
   jsPlugins: [
-    { name: 'vitest-js', specifier: '@vitest/eslint-plugin' },
-    'eslint-plugin-no-only-tests',
+    { name: 'vitest-js', specifier: resolvePlugin('@vitest/eslint-plugin') },
+    resolvePlugin('eslint-plugin-no-only-tests'),
   ],
   rules: {
     // Require .test test file pattern