@wistia/oxlint-config 1.1.0 → 1.2.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@wistia/oxlint-config",
-  "version": "1.1.0",
+  "version": "1.2.0",
   "description": "Wistia's Oxlint configurations",
   "packageManager": "yarn@4.17.0",
   "type": "module",

package/rules/import.mjs

@@ -195,7 +195,7 @@ export const importRules = {
     'import-x-js/order': [
       'error',
       {
-        groups: [['builtin', 'external', 'internal'], 'index', ['parent', 'sibling']],
+        groups: ['type', ['builtin', 'external', 'internal'], 'index', ['parent', 'sibling']],
         'newlines-between': 'never',
       },
     ],

package/rules/node.mjs

@@ -4,6 +4,10 @@ export const nodeRules = {
   plugins: ['node'],
   jsPlugins: [{ name: 'n', specifier: 'eslint-plugin-n' }],
   rules: {
+    // Require return statements after callbacks
+    // https://oxc.rs/docs/guide/usage/linter/rules/node/callback-return.html
+    'node/callback-return': 'error',
+
     // Require error handling in callbacks
     // https://oxc.rs/docs/guide/usage/linter/rules/node/handle-callback-err.html
     'node/handle-callback-err': 'error',
@@ -22,13 +26,12 @@ export const nodeRules = {
 
     // Disallow the use of process.env
     // https://oxc.rs/docs/guide/usage/linter/rules/node/no-process-env.html
-    // Decision: too opinionated for general use
+    // Decision: too opinionated for general use; individual projects can enable this rule if desired
     'node/no-process-env': 'off',
 
     // Require require() to be called in the top-level module scope
     // https://oxc.rs/docs/guide/usage/linter/rules/node/global-require.html
-    // Decision: restricts valid language feature
-    'node/global-require': 'off',
+    'node/global-require': 'error',
 
     //eslint-plugin-n rules via jsPlugins
 
@@ -70,7 +73,8 @@ export const nodeRules = {
 
     // Require return statements after callbacks
     // https://github.com/eslint-community/eslint-plugin-n/blob/HEAD/docs/rules/callback-return.md
-    'n/callback-return': 'error',
+    // Decision: handled by native node/callback-return
+    'n/callback-return': 'off',
 
     // Enforce either module.exports or exports
     // https://github.com/eslint-community/eslint-plugin-n/blob/HEAD/docs/rules/exports-style.md
@@ -78,7 +82,8 @@ export const nodeRules = {
 
     // Require require() to be called in the top-level module scope
     // https://github.com/eslint-community/eslint-plugin-n/blob/HEAD/docs/rules/global-require.md
-    'n/global-require': 'error',
+    // Decision: handled by native node/global-require
+    'n/global-require': 'off',
 
     // Disallow require calls to be mixed with regular variable declarations
     // https://github.com/eslint-community/eslint-plugin-n/blob/HEAD/docs/rules/no-mixed-requires.md