@wistia/oxlint-config 0.9.2 → 0.9.4

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@wistia/oxlint-config",
-  "version": "0.9.2",
+  "version": "0.9.4",
   "description": "Wistia's Oxlint configurations",
   "packageManager": "yarn@4.14.1",
   "type": "module",

package/rules/barrel-files.mjs

@@ -15,8 +15,7 @@ export const barrelFilesRules = {
 
     // Avoid namespace imports from barrel files
     // https://github.com/thepassle/eslint-plugin-barrel-files/blob/main/docs/rules/avoid-namespace-import.md
-    // Decision: too opinionated for general use
-    'eslint-plugin-barrel-files/avoid-namespace-import': 'off',
+    'eslint-plugin-barrel-files/avoid-namespace-import': 'error',
 
     // Avoid re-export all from barrel files
     // https://github.com/thepassle/eslint-plugin-barrel-files/blob/main/docs/rules/avoid-re-export-all.md

package/rules/base.mjs

@@ -804,8 +804,7 @@ export const baseRules = {
 
     // Disallow assignments that are never used
     // https://oxc.rs/docs/guide/usage/linter/rules/eslint/no-useless-assignment.html
-    // Decision: handled by TypeScript noUnusedLocals
-    'eslint/no-useless-assignment': 'off',
+    'eslint/no-useless-assignment': 'error',
 
     // Disallow unnecessary calls to .call() and .apply()
     // https://oxc.rs/docs/guide/usage/linter/rules/eslint/no-useless-call.html
@@ -929,12 +928,12 @@ export const baseRules = {
 
     // Disallow barrel files (index files that re-export from other modules)
     // https://oxc.rs/docs/guide/usage/linter/rules/oxc/no-barrel-file.html
-    // Decision: handled by barrel-files plugin
+    // Decision: handled by barrel-files/avoid-re-export-all and barrel-files/avoid-namespace-import
     'oxc/no-barrel-file': 'off',
 
     // Disallow TypeScript const enums
     // https://oxc.rs/docs/guide/usage/linter/rules/oxc/no-const-enum.html
-    // Decision: too opinionated for general use
+    // Decision: const enums are TypeScript-only syntax; enabled in typescript config
     'oxc/no-const-enum': 'off',
 
     // Disallow spreading keys from a map-like object into an object literal

package/rules/import.mjs

@@ -102,7 +102,7 @@ export const importRules = {
 
     // Require exports to be placed at the end of the file
     // https://oxc.rs/docs/guide/usage/linter/rules/import/exports-last.html
-    // Decision: too opinionated for general use
+    // Decision: conflicts with `import/first`, which is enabled
     'import/exports-last': 'off',
 
     // Prefer named exports to be grouped together in a single export declaration

package/rules/node.mjs

@@ -167,12 +167,12 @@ export const nodeRules = {
 
     // Disallow import declarations which import extraneous modules
     // https://github.com/eslint-community/eslint-plugin-n/blob/HEAD/docs/rules/no-extraneous-import.md
-    // Decision: handled by import-x-js/no-extraneous-dependencies
+    // Decision: handled by knip
     'n/no-extraneous-import': 'off',
 
     // Disallow require() expressions which import extraneous modules
     // https://github.com/eslint-community/eslint-plugin-n/blob/HEAD/docs/rules/no-extraneous-require.md
-    // Decision: handled by import-x-js/no-extraneous-dependencies
+    // Decision: handled by knip
     'n/no-extraneous-require': 'off',
 
     // Disallow import declarations which import non-existent modules

package/rules/typescript.mjs

@@ -19,6 +19,11 @@ export const typescriptRules = {
     // Decision: handled by TypeScript noUnusedLocals/noUnusedParameters
     'eslint/no-unused-vars': 'off',
 
+    // Disallow assignments that are never used
+    // https://oxc.rs/docs/guide/usage/linter/rules/eslint/no-useless-assignment.html
+    // Decision: handled by TypeScript noUnusedLocals
+    'eslint/no-useless-assignment': 'off',
+
     // Recommended to be disabled for TypeScript projects
     // https://github.com/typescript-eslint/typescript-eslint/blob/main/docs/linting/TROUBLESHOOTING.md#i-get-errors-from-the-no-undef-rule-about-global-variables-not-being-defined-even-though-there-are-no-typescript-errors
     // Decision: handled by TypeScript
@@ -31,6 +36,10 @@ export const typescriptRules = {
     // Decision: handled by typescript/require-await
     'eslint/require-await': 'off',
 
+    // Const enum values can shift when keys are added/removed; prefer a type union of string literals.
+    // https://oxc.rs/docs/guide/usage/linter/rules/oxc/no-const-enum.html
+    'oxc/no-const-enum': 'error',
+
     // Require that function overload signatures be consecutive
     // https://oxc.rs/docs/guide/usage/linter/rules/typescript/adjacent-overload-signatures.html
     'typescript/adjacent-overload-signatures': 'error',

package/rules/vitest.mjs

@@ -57,8 +57,7 @@ export const vitestRules = {
 
     // Prefer vi.importActual/vi.importMock in vi.mock factories
     // https://oxc.rs/docs/guide/usage/linter/rules/vitest/prefer-import-in-mock.html
-    // Decision: potentially helpful but causes too many type errors
-    'vitest/prefer-import-in-mock': 'off',
+    'vitest/prefer-import-in-mock': 'error',
 
     // Prefer strict boolean matchers (toBe(true) over toBeTruthy())
     // https://oxc.rs/docs/guide/usage/linter/rules/vitest/prefer-strict-boolean-matchers.html
@@ -508,8 +507,7 @@ export const vitestRules = {
 
     // Enforce padding around test blocks
     // https://github.com/vitest-dev/eslint-plugin-vitest/blob/main/docs/rules/padding-around-test-blocks.md
-    // Decision: handled by native vitest/padding-around-test-blocks
-    'vitest-js/padding-around-test-blocks': 'off',
+    'vitest-js/padding-around-test-blocks': 'error',
 
     // Prefer toHaveBeenCalledOnce() over toHaveBeenCalledTimes(1)
     // https://github.com/vitest-dev/eslint-plugin-vitest/blob/main/docs/rules/prefer-called-once.md