@wistia/oxlint-config 0.7.5 → 0.8.0

package/README.md

@@ -12,9 +12,23 @@ Wistia's Oxlint configurations. This is a shared config package for [oxlint](htt
 ## How to install
 
 ```bash
-yarn add -D @wistia/oxlint-config oxlint
+yarn add -D @wistia/oxlint-config oxlint eslint
 ```
 
+> **Why `eslint`?** This package uses oxlint's [jsPlugins](https://oxc.rs/docs/guide/usage/linter/js-plugins) feature to run ESLint plugins (e.g. `eslint-plugin-import-x`, `@eslint-react/eslint-plugin`, `eslint-plugin-testing-library`, etc.) natively inside oxlint. These plugins import utilities from the `eslint` package at runtime, so it must be installed even though you won't run `eslint` directly.
+>
+> **Note:** jsPlugins do not support rules that rely on TypeScript type information. Any type-aware rules in this config use native oxlint rules instead.
+
+### Type-aware linting
+
+The `typescriptConfig` enables [type-aware linting](https://oxc.rs/docs/guide/usage/linter/type-aware), which requires the `oxlint-tsgolint` package:
+
+```bash
+yarn add -D oxlint-tsgolint
+```
+
+`oxlint-tsgolint` is a separate Go-based tool that builds your TypeScript program using `typescript-go` and runs type-aware rules (e.g. detecting unhandled promises, unsafe assignments). Without it installed, type-aware rules will not run.
+
 ## Quick start
 
 Create an `oxlint.config.ts` in your project root:

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@wistia/oxlint-config",
-  "version": "0.7.5",
+  "version": "0.8.0",
   "description": "Wistia's Oxlint configurations",
   "packageManager": "yarn@4.14.1",
   "type": "module",
@@ -55,16 +55,16 @@
     "oxlint-tsgolint": ">= 1.0.0"
   },
   "dependencies": {
-    "@eslint-react/eslint-plugin": "^5.7.6",
-    "@vitest/eslint-plugin": "^1.6.16",
+    "@eslint-react/eslint-plugin": "^5.8.3",
+    "@vitest/eslint-plugin": "^1.6.17",
     "confusing-browser-globals": "^1.0.11",
     "eslint-plugin-barrel-files": "^3.0.1",
     "eslint-plugin-import-x": "^4.16.2",
     "eslint-plugin-jest-dom": "^5.5.0",
     "eslint-plugin-n": "^18.0.1",
     "eslint-plugin-no-only-tests": "^3.4.0",
-    "eslint-plugin-playwright": "^2.10.2",
-    "eslint-plugin-storybook": "^10.3.6",
+    "eslint-plugin-playwright": "^2.10.4",
+    "eslint-plugin-storybook": "^10.4.0",
     "eslint-plugin-styled-components": "^0.0.0",
     "eslint-plugin-styled-components-a11y": "^2.2.1",
     "eslint-plugin-testing-library": "^7.16.2",
@@ -73,12 +73,12 @@
   "devDependencies": {
     "@changesets/changelog-github": "^0.7.0",
     "@changesets/cli": "^2.31.0",
-    "eslint": "^10.3.0",
-    "oxfmt": "^0.48.0",
-    "oxlint": "^1.64.0",
-    "oxlint-tsgolint": "^0.22.1",
-    "storybook": "^10.3.6",
-    "vitest": "^4.1.5"
+    "eslint": "^10.4.0",
+    "oxfmt": "^0.51.0",
+    "oxlint": "^1.66.0",
+    "oxlint-tsgolint": "^0.23.0",
+    "storybook": "^10.4.0",
+    "vitest": "^4.1.7"
   },
   "engines": {
     "node": "^20.19.0 || ^22.13.0 || >=24 || >=26"

package/rules/base.mjs

@@ -272,6 +272,11 @@ export const baseRules = {
     // https://oxc.rs/docs/guide/usage/linter/rules/eslint/grouped-accessor-pairs.html
     'eslint/grouped-accessor-pairs': 'error',
 
+    // Require identifiers to match a specified regular expression
+    // https://oxc.rs/docs/guide/usage/linter/rules/eslint/id-match.html
+    // Decision: too opinionated for general use
+    'eslint/id-match': 'off',
+
     // Enforce minimum and maximum identifier lengths
     // https://oxc.rs/docs/guide/usage/linter/rules/eslint/id-length.html
     'eslint/id-length': [
@@ -374,6 +379,14 @@ export const baseRules = {
     // https://oxc.rs/docs/guide/usage/linter/rules/eslint/no-implicit-coercion.html
     'eslint/no-implicit-coercion': 'error',
 
+    // Disallow declarations in the global scope
+    // https://oxc.rs/docs/guide/usage/linter/rules/eslint/no-implicit-globals.html
+    'eslint/no-implicit-globals': 'error',
+
+    // Disallow the use of eval()-like methods
+    // https://oxc.rs/docs/guide/usage/linter/rules/eslint/no-implied-eval.html
+    'eslint/no-implied-eval': 'error',
+
     // Disallow the use of the __iterator__ property
     // https://oxc.rs/docs/guide/usage/linter/rules/eslint/no-iterator.html
     'eslint/no-iterator': 'error',
@@ -577,6 +590,13 @@ export const baseRules = {
     // https://oxc.rs/docs/guide/usage/linter/rules/eslint/operator-assignment.html
     'eslint/operator-assignment': ['error', 'always'],
 
+    // Require using arrow functions for callbacks
+    // https://oxc.rs/docs/guide/usage/linter/rules/eslint/prefer-arrow-callback.html
+    'eslint/prefer-arrow-callback': [
+      'error',
+      { allowNamedFunctions: false, allowUnboundThis: true },
+    ],
+
     // Require const declarations for variables that are never reassigned after declared
     // https://oxc.rs/docs/guide/usage/linter/rules/eslint/prefer-const.html
     'eslint/prefer-const': ['error', { destructuring: 'any', ignoreReadBeforeAssign: true }],
@@ -608,6 +628,10 @@ export const baseRules = {
     // https://oxc.rs/docs/guide/usage/linter/rules/eslint/prefer-object-spread.html
     'eslint/prefer-object-spread': 'error',
 
+    // Disallow use of the RegExp constructor in favor of regular expression literals
+    // https://oxc.rs/docs/guide/usage/linter/rules/eslint/prefer-regex-literals.html
+    'eslint/prefer-regex-literals': ['error', { disallowRedundantWrapping: true }],
+
     // Require using Error objects as Promise rejection reasons
     // https://oxc.rs/docs/guide/usage/linter/rules/eslint/prefer-promise-reject-errors.html
     'eslint/prefer-promise-reject-errors': ['error', { allowEmptyReject: true }],

package/rules/import.mjs

@@ -115,6 +115,10 @@ export const importRules = {
     // Decision: too opinionated for general use
     'import/max-dependencies': 'off',
 
+    // Require a newline after the last import/require in a group
+    // https://oxc.rs/docs/guide/usage/linter/rules/import/newline-after-import.html
+    'import/newline-after-import': 'error',
+
     // Ensure named imports coupled with named exports
     // https://oxc.rs/docs/guide/usage/linter/rules/import/named.html
     // Decision: handled by TypeScript
@@ -175,19 +179,17 @@ export const importRules = {
       'error',
       {
         devDependencies: [
-          '**/*{.,_}{test,vitest,spec}.{js,jsx,ts,tsx}',
+          '**/*{.,_}{test,vitest,spec,stories}.{js,jsx,ts,tsx}',
+          '**/oxfmt.config.*',
+          '**/.oxfmtrc.json*',
           '**/vite.config.{ts,js,cjs,mjs,mts}',
           '**/vitest.config.{ts,js,cjs,mjs,mts}',
-          '**/jest.config.{js,cjs,mjs,mts}',
-          '**/jest.setup.{js,cjs,mjs,mts}',
           '**/eslint.config.{js,cjs,mjs,mts}',
           '**/.eslintrc.{js,cjs}',
           '**/.stylelintrc.{cjs,js,json,yaml,yml}',
           '**/stylelint.config.{cjs,mjs,mts,js}',
           '**/esbuild.config.{js,cjs,mjs,mts}',
           '**/tsup.config.{js,cjs,mjs,mts}',
-          '**/webpack.config.{js,cjs,mjs,mts}',
-          '**/webpack.config.*.{js,cjs,mjs,mts}',
           '**/rollup.config.{js,cjs,mjs,mts}',
           '**/rollup.config.*.{js,cjs,mjs,mts}',
         ],
@@ -219,7 +221,8 @@ export const importRules = {
 
     // Require a newline after the last import/require in a group
     // https://github.com/un-ts/eslint-plugin-import-x/blob/master/docs/rules/newline-after-import.md
-    'import-x-js/newline-after-import': 'error',
+    // Decision: handled by native import/newline-after-import
+    'import-x-js/newline-after-import': 'off',
 
     // Ensures that there are no useless path segments
     // https://github.com/un-ts/eslint-plugin-import-x/blob/master/docs/rules/no-useless-path-segments.md

package/rules/react-a11y.mjs

@@ -53,6 +53,30 @@ export const reactA11yRules = {
     // Decision: too opinionated for general use
     'jsx_a11y/autocomplete-valid': 'off',
 
+    // Enforce that a control (an interactive element) has a text label
+    // https://oxc.rs/docs/guide/usage/linter/rules/jsx-a11y/control-has-associated-label.html
+    'jsx_a11y/control-has-associated-label': [
+      'error',
+      {
+        labelAttributes: ['label'],
+        controlComponents: [],
+        ignoreElements: ['audio', 'canvas', 'embed', 'input', 'textarea', 'tr', 'video'],
+        ignoreRoles: [
+          'grid',
+          'listbox',
+          'menu',
+          'menubar',
+          'radiogroup',
+          'row',
+          'tablist',
+          'toolbar',
+          'tree',
+          'treegrid',
+        ],
+        depth: 5,
+      },
+    ],
+
     // Enforce a clickable non-interactive element has at least one keyboard event listener
     // https://oxc.rs/docs/guide/usage/linter/rules/jsx-a11y/click-events-have-key-events.html
     'jsx_a11y/click-events-have-key-events': 'error',
@@ -128,6 +152,33 @@ export const reactA11yRules = {
       },
     ],
 
+    // Ensure interactive elements are not assigned non-interactive roles
+    // https://oxc.rs/docs/guide/usage/linter/rules/jsx-a11y/no-interactive-element-to-noninteractive-role.html
+    'jsx_a11y/no-interactive-element-to-noninteractive-role': [
+      'error',
+      { tr: ['none', 'presentation'] },
+    ],
+
+    // Enforce that non-interactive elements do not have interaction handlers
+    // https://oxc.rs/docs/guide/usage/linter/rules/jsx-a11y/no-noninteractive-element-interactions.html
+    'jsx_a11y/no-noninteractive-element-interactions': [
+      'error',
+      { handlers: ['onClick', 'onMouseDown', 'onMouseUp', 'onKeyPress', 'onKeyDown', 'onKeyUp'] },
+    ],
+
+    // Enforce that non-interactive elements are not assigned interactive roles
+    // https://oxc.rs/docs/guide/usage/linter/rules/jsx-a11y/no-noninteractive-element-to-interactive-role.html
+    'jsx_a11y/no-noninteractive-element-to-interactive-role': [
+      'error',
+      {
+        ul: ['listbox', 'menu', 'menubar', 'radiogroup', 'tablist', 'tree', 'treegrid'],
+        ol: ['listbox', 'menu', 'menubar', 'radiogroup', 'tablist', 'tree', 'treegrid'],
+        li: ['menuitem', 'option', 'row', 'tab', 'treeitem'],
+        table: ['grid'],
+        td: ['gridcell'],
+      },
+    ],
+
     // Enforce explicit role is not redundant with implicit role of the element
     // https://oxc.rs/docs/guide/usage/linter/rules/jsx-a11y/no-redundant-roles.html
     'jsx_a11y/no-redundant-roles': 'error',

package/rules/react.mjs

@@ -105,6 +105,14 @@ export const reactRules = {
     // Decision: this is a decision best left to the implementer
     'react/no-multi-comp': 'off',
 
+    // Disallow object types as default props
+    // https://oxc.rs/docs/guide/usage/linter/rules/react/no-object-type-as-default-prop.html
+    'react/no-object-type-as-default-prop': 'error',
+
+    // Disallow creating unstable components inside components
+    // https://oxc.rs/docs/guide/usage/linter/rules/react/no-unstable-nested-components.html
+    'react/no-unstable-nested-components': 'error',
+
     // Disallow usage of the return value of ReactDOM.render
     // https://oxc.rs/docs/guide/usage/linter/rules/react/no-render-return-value.html
     'react/no-render-return-value': 'error',
@@ -430,7 +438,8 @@ export const reactRules = {
 
     // Prevent creating unstable components inside components
     // https://eslint-react.xyz/docs/rules/no-nested-component-definitions
-    '@eslint-react/no-nested-component-definitions': 'error',
+    // Decision: handled by native react/no-unstable-nested-components
+    '@eslint-react/no-nested-component-definitions': 'off',
 
     // Prevent creating lazy components inside components
     // https://eslint-react.xyz/docs/rules/no-nested-lazy-component-declarations
@@ -473,7 +482,8 @@ export const reactRules = {
 
     // Disallow referential-type variables as default props
     // https://eslint-react.xyz/docs/rules/no-unstable-default-props
-    '@eslint-react/no-unstable-default-props': 'error',
+    // Decision: handled by native react/no-object-type-as-default-prop
+    '@eslint-react/no-unstable-default-props': 'off',
 
     // Prevent declaring unused methods of component class
     // https://eslint-react.xyz/docs/rules/no-unused-class-component-members

package/rules/vitest.mjs

@@ -30,6 +30,11 @@ export const vitestRules = {
     // https://oxc.rs/docs/guide/usage/linter/rules/vitest/no-import-node-test.html
     'vitest/no-import-node-test': 'error',
 
+    // Enforce padding around afterAll blocks
+    // https://oxc.rs/docs/guide/usage/linter/rules/vitest/padding-around-after-all-blocks.html
+    // Decision: stylistic formatting rule, left to formatter
+    'vitest/padding-around-after-all-blocks': 'off',
+
     // Disallow conditional tests
     // https://oxc.rs/docs/guide/usage/linter/rules/vitest/no-conditional-in-test.html
     'vitest/no-conditional-in-test': 'error',