@wistia/oxlint-config 0.4.2 → 0.4.3

package/configs/javascript.mjs

@@ -3,6 +3,7 @@ import { baseRules } from '../rules/base.mjs';
 import { importRules } from '../rules/import.mjs';
 import { promiseRules } from '../rules/promise.mjs';
 import { barrelFilesRules } from '../rules/barrel-files.mjs';
+import { unicornRules } from '../rules/unicorn.mjs';
 
 export default defineConfig({
   plugins: [...baseRules.plugins, ...importRules.plugins, ...promiseRules.plugins],
@@ -12,5 +13,6 @@ export default defineConfig({
     ...importRules.rules,
     ...promiseRules.rules,
     ...barrelFilesRules.rules,
+    ...unicornRules.rules,
   },
 });

package/configs/typescript.mjs

@@ -4,6 +4,7 @@ import { importRules } from '../rules/import.mjs';
 import { promiseRules } from '../rules/promise.mjs';
 import { typescriptRules } from '../rules/typescript.mjs';
 import { barrelFilesRules } from '../rules/barrel-files.mjs';
+import { unicornRules } from '../rules/unicorn.mjs';
 
 export default defineConfig({
   options: {
@@ -23,5 +24,6 @@ export default defineConfig({
     ...promiseRules.rules,
     ...typescriptRules.rules,
     ...barrelFilesRules.rules,
+    ...unicornRules.rules,
   },
 });

package/index.d.mts

@@ -14,6 +14,7 @@ export declare const typescriptRules: RuleFile;
 export declare const reactRules: RuleFile;
 export declare const reactA11yRules: RuleFile;
 export declare const nodeRules: RuleFile;
+export declare const unicornRules: RuleFile;
 export declare const vitestRules: RuleFile;
 export declare const playwrightRules: RuleFile;
 export declare const storybookRules: RuleFile;

package/index.mjs

@@ -6,6 +6,7 @@ export { typescriptRules } from './rules/typescript.mjs';
 export { reactRules } from './rules/react.mjs';
 export { reactA11yRules } from './rules/react-a11y.mjs';
 export { nodeRules } from './rules/node.mjs';
+export { unicornRules } from './rules/unicorn.mjs';
 export { vitestRules } from './rules/vitest.mjs';
 export { playwrightRules } from './rules/playwright.mjs';
 export { storybookRules } from './rules/storybook.mjs';

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@wistia/oxlint-config",
-  "version": "0.4.2",
+  "version": "0.4.3",
   "description": "Wistia's Oxlint configurations",
   "packageManager": "yarn@4.14.1",
   "type": "module",

package/rules/base.mjs

@@ -1,8 +1,6 @@
 export const baseRules = {
   plugins: ['eslint', 'oxc'],
   rules: {
-    // -- Possible Problems (Correctness) --
-
     // Enforce return statements in callbacks of array methods
     // https://eslint.org/docs/rules/array-callback-return
     'eslint/array-callback-return': ['error', { allowImplicit: true }],
@@ -215,8 +213,6 @@ export const baseRules = {
     // https://eslint.org/docs/rules/valid-typeof
     'eslint/valid-typeof': ['error', { requireStringLiterals: true }],
 
-    // -- Suggestions --
-
     // Enforce getter and setter pairs in objects and classes
     // https://eslint.org/docs/rules/accessor-pairs
     'eslint/accessor-pairs': 'error',
@@ -636,8 +632,7 @@ export const baseRules = {
     // https://eslint.org/docs/rules/yoda
     'eslint/yoda': 'error',
 
-    // -- oxc rules (oxlint-specific, no eslint equivalent) --
-    // These are bug-catchers that oxlint can detect natively.
+    //oxc rules - these are bug-catchers that oxlint can detect natively.
 
     // Disallow calling array methods on arguments (it's array-like, not an array)
     // https://oxc.rs/docs/guide/usage/linter/rules/oxc/bad-array-method-on-arguments.html

package/rules/import.mjs

@@ -87,8 +87,7 @@ export const importRules = {
     // https://github.com/un-ts/eslint-plugin-import-x/blob/master/docs/rules/no-webpack-loader-syntax.md
     'import/no-webpack-loader-syntax': 'error',
 
-    // -- Rules via jsPlugins (eslint-plugin-import-x) --
-    // These rules have no native oxlint equivalent.
+    //rules via jsPlugins (eslint-plugin-import-x)
 
     // Ensure imports point to files/modules that can be resolved
     // https://github.com/un-ts/eslint-plugin-import-x/blob/master/docs/rules/no-unresolved.md

package/rules/node.mjs

@@ -4,8 +4,6 @@ export const nodeRules = {
   plugins: ['node'],
   jsPlugins: [{ name: 'n', specifier: 'eslint-plugin-n' }],
   rules: {
-    // -- Native oxlint node rules --
-
     // Require error handling in callbacks
     // https://github.com/eslint-community/eslint-plugin-n/blob/HEAD/docs/rules/handle-callback-err.md
     'node/handle-callback-err': 'error',
@@ -22,7 +20,7 @@ export const nodeRules = {
     // https://github.com/eslint-community/eslint-plugin-n/blob/HEAD/docs/rules/no-path-concat.md
     'node/no-path-concat': 'error',
 
-    // -- eslint-plugin-n rules via jsPlugins --
+    //eslint-plugin-n rules via jsPlugins
 
     // Disallow deprecated APIs
     // https://github.com/eslint-community/eslint-plugin-n/blob/HEAD/docs/rules/no-deprecated-api.md

package/rules/react.mjs

@@ -4,8 +4,6 @@ export const reactRules = {
   plugins: ['react'],
   jsPlugins: [{ name: '@eslint-react', specifier: '@eslint-react/eslint-plugin' }],
   rules: {
-    // -- React Core --
-
     // Enforce that button elements have an explicit type attribute
     // https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/button-has-type.md
     'react/button-has-type': 'error',
@@ -236,10 +234,7 @@ export const reactRules = {
     // decision: stylistic choice best left for formatter
     'react/jsx-handler-names': 'off',
 
-    // -- Rules via jsPlugins (@eslint-react/eslint-plugin) --
-    // These rules have no native oxlint equivalent.
-
-    // --- Core React rules ---
+    //rules via jsPlugins (@eslint-react/eslint-plugin)
 
     // Validates higher order functions defining nested components or hooks
     // https://eslint-react.xyz/docs/rules/component-hook-factories

package/rules/testing-library.mjs

@@ -2,8 +2,6 @@
 export const testingLibraryRules = {
   jsPlugins: ['eslint-plugin-testing-library', 'eslint-plugin-jest-dom'],
   rules: {
-    // -- testing-library rules --
-
     // Enforce async events to be awaited
     // https://github.com/testing-library/eslint-plugin-testing-library/blob/main/docs/rules/await-async-events.md
     'eslint-plugin-testing-library/await-async-events': 'error',
@@ -122,8 +120,6 @@ export const testingLibraryRules = {
     // https://github.com/testing-library/eslint-plugin-testing-library/blob/main/docs/rules/render-result-naming-convention.md
     'eslint-plugin-testing-library/render-result-naming-convention': 'error',
 
-    // -- jest-dom rules --
-
     // Prefer toBeChecked over checking attributes
     // https://github.com/testing-library/eslint-plugin-jest-dom/blob/main/docs/rules/prefer-checked.md
     'eslint-plugin-jest-dom/prefer-checked': 'error',

package/rules/typescript.mjs

@@ -1,7 +1,7 @@
 export const typescriptRules = {
   plugins: ['typescript'],
   rules: {
-    // -- Disable base eslint rules superseded by typescript equivalents --
+    //Disable base eslint rules superseded by typescript equivalents --
     'eslint/class-methods-use-this': 'off',
     'eslint/default-param-last': 'off',
     'eslint/init-declarations': 'off',
@@ -44,8 +44,6 @@ export const typescriptRules = {
       },
     ],
 
-    // -- TypeScript rules --
-
     // Require that function overload signatures be consecutive
     // https://typescript-eslint.io/rules/adjacent-overload-signatures
     'typescript/adjacent-overload-signatures': 'error',
@@ -314,6 +312,10 @@ export const typescriptRules = {
     // https://typescript-eslint.io/rules/no-unsafe-unary-minus
     'typescript/no-unsafe-unary-minus': 'error',
 
+    // Disallow useless default assignments in parameter destructuring
+    // https://typescript-eslint.io/rules/no-useless-default-assignment
+    'typescript/no-useless-default-assignment': 'error',
+
     // Disallow empty exports that don't change anything in a module file
     // https://typescript-eslint.io/rules/no-useless-empty-export
     'typescript/no-useless-empty-export': 'error',

package/rules/unicorn.mjs

@@ -0,0 +1,56 @@
+export const unicornRules = {
+  plugins: [],
+  rules: {
+    // Disallow using await in Promise.all/race/etc. array arguments
+    // https://oxc.rs/docs/guide/usage/linter/rules/unicorn/no-await-in-promise-methods.html
+    'unicorn/no-await-in-promise-methods': 'error',
+
+    // Disallow empty files
+    // https://oxc.rs/docs/guide/usage/linter/rules/unicorn/no-empty-file.html
+    'unicorn/no-empty-file': 'error',
+
+    // Disallow invalid options in fetch() calls
+    // https://oxc.rs/docs/guide/usage/linter/rules/unicorn/no-invalid-fetch-options.html
+    'unicorn/no-invalid-fetch-options': 'error',
+
+    // Disallow invalid removeEventListener arguments
+    // https://oxc.rs/docs/guide/usage/linter/rules/unicorn/no-invalid-remove-event-listener.html
+    'unicorn/no-invalid-remove-event-listener': 'error',
+
+    // Disallow new Array() (use Array.from or [...] instead)
+    // https://oxc.rs/docs/guide/usage/linter/rules/unicorn/no-new-array.html
+    'unicorn/no-new-array': 'error',
+
+    // Disallow passing single-element arrays to Promise.all/race/etc.
+    // https://oxc.rs/docs/guide/usage/linter/rules/unicorn/no-single-promise-in-promise-methods.html
+    'unicorn/no-single-promise-in-promise-methods': 'error',
+
+    // Disallow thenable objects (confuses await/Promise behavior)
+    // https://oxc.rs/docs/guide/usage/linter/rules/unicorn/no-thenable.html
+    'unicorn/no-thenable': 'error',
+
+    // Disallow unnecessary await on non-Promise values
+    // https://oxc.rs/docs/guide/usage/linter/rules/unicorn/no-unnecessary-await.html
+    'unicorn/no-unnecessary-await': 'error',
+
+    // Disallow useless fallback in spread (e.g. ...obj || {})
+    // https://oxc.rs/docs/guide/usage/linter/rules/unicorn/no-useless-fallback-in-spread.html
+    'unicorn/no-useless-fallback-in-spread': 'error',
+
+    // Disallow useless length checks before array operations
+    // https://oxc.rs/docs/guide/usage/linter/rules/unicorn/no-useless-length-check.html
+    'unicorn/no-useless-length-check': 'error',
+
+    // Disallow useless spread operators
+    // https://oxc.rs/docs/guide/usage/linter/rules/unicorn/no-useless-spread.html
+    'unicorn/no-useless-spread': 'error',
+
+    // Prefer Set#size over converting to array and checking length
+    // https://oxc.rs/docs/guide/usage/linter/rules/unicorn/prefer-set-size.html
+    'unicorn/prefer-set-size': 'error',
+
+    // Prefer String#startsWith/endsWith over regex or slice comparisons
+    // https://oxc.rs/docs/guide/usage/linter/rules/unicorn/prefer-string-starts-ends-with.html
+    'unicorn/prefer-string-starts-ends-with': 'error',
+  },
+};

package/rules/vitest.mjs

@@ -10,8 +10,6 @@ export const vitestRules = {
     'eslint-plugin-no-only-tests',
   ],
   rules: {
-    // -- vitest-specific rules (no Jest equivalent) --
-
     // Require .test test file pattern
     // https://github.com/vitest-dev/eslint-plugin-vitest/blob/main/docs/rules/consistent-test-filename.md
     'vitest/consistent-test-filename': 'error',
@@ -84,11 +82,19 @@ export const vitestRules = {
     // https://github.com/vitest-dev/eslint-plugin-vitest/blob/main/docs/rules/require-mock-type-parameters.md
     'vitest/require-mock-type-parameters': 'error',
 
+    // Require awaited expect.poll() calls
+    // https://github.com/vitest-dev/eslint-plugin-vitest/blob/main/docs/rules/require-awaited-expect-poll.md
+    'vitest/require-awaited-expect-poll': 'error',
+
     // Require local Test Context for concurrent snapshot tests
     // https://github.com/vitest-dev/eslint-plugin-vitest/blob/main/docs/rules/require-local-test-context-for-concurrent-snapshots.md
     'vitest/require-local-test-context-for-concurrent-snapshots': 'error',
 
-    // -- Shared vitest/jest rules (oxlint uses the "jest/" prefix for these) --
+    // Warn on test.todo() usage
+    // https://github.com/vitest-dev/eslint-plugin-vitest/blob/main/docs/rules/warn-todo.md
+    'vitest/warn-todo': 'error',
+
+    //oxlint uses the "jest/" prefix for these unfortunately
 
     // Prefer test or it but not both
     // https://github.com/vitest-dev/eslint-plugin-vitest/blob/main/docs/rules/consistent-test-it.md
@@ -274,7 +280,7 @@ export const vitestRules = {
     // decision: `allowArguments` avoids conflict with `prefer-describe-function-title` rule, which is enabled
     'jest/valid-title': ['error', { allowArguments: true }],
 
-    // -- Rules via jsPlugins (@vitest/eslint-plugin + no-only-tests) --
+    //rules via jsPlugins (@vitest/eslint-plugin + no-only-tests)
 
     // Disallow .only tests
     // https://github.com/levibuzolic/eslint-plugin-no-only-tests