@wistia/oxlint-config 0.3.2 → 0.3.3

package/configs/javascript.mjs

@@ -5,6 +5,7 @@ import { promiseRules } from '../rules/promise.mjs';
 
 export default defineConfig({
   plugins: [...baseRules.plugins, ...importRules.plugins, ...promiseRules.plugins],
+  jsPlugins: [...(importRules.jsPlugins || [])],
   rules: {
     ...baseRules.rules,
     ...importRules.rules,

package/configs/typescript.mjs

@@ -11,6 +11,7 @@ export default defineConfig({
     ...promiseRules.plugins,
     ...typescriptRules.plugins,
   ],
+  jsPlugins: [...(importRules.jsPlugins || [])],
   rules: {
     ...baseRules.rules,
     ...importRules.rules,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@wistia/oxlint-config",
-  "version": "0.3.2",
+  "version": "0.3.3",
   "description": "Wistia's Oxlint configurations",
   "packageManager": "yarn@4.13.0",
   "type": "module",
@@ -38,6 +38,7 @@
   },
   "dependencies": {
     "@vitest/eslint-plugin": "^1.6.14",
+    "eslint-plugin-import-x": "^4.16.2",
     "eslint-plugin-jest-dom": "^5.5.0",
     "eslint-plugin-n": "^17.24.0",
     "eslint-plugin-no-only-tests": "^3.3.0",

package/rules/base.mjs

@@ -221,10 +221,22 @@ export const baseRules = {
     // https://eslint.org/docs/rules/accessor-pairs
     'eslint/accessor-pairs': 'error',
 
+    // Require braces around arrow function bodies
+    // https://eslint.org/docs/rules/arrow-body-style
+    'eslint/arrow-body-style': 'off',
+
     // Enforce the use of variables within the scope they are defined
     // https://eslint.org/docs/rules/block-scoped-var
     'eslint/block-scoped-var': 'error',
 
+    // Enforce that class methods utilize this
+    // https://eslint.org/docs/rules/class-methods-use-this
+    'eslint/class-methods-use-this': 'error',
+
+    // Require default cases in switch statements
+    // https://eslint.org/docs/rules/default-case
+    'eslint/default-case': ['error', { commentPattern: '^no default$' }],
+
     // Enforce default clauses in switch statements to be last
     // https://eslint.org/docs/rules/default-case-last
     'eslint/default-case-last': 'error',
@@ -241,6 +253,18 @@ export const baseRules = {
     // https://eslint.org/docs/rules/guard-for-in
     'eslint/guard-for-in': 'error',
 
+    // Require or disallow named function expressions
+    // https://eslint.org/docs/rules/func-names
+    'eslint/func-names': ['error', 'always'],
+
+    // Enforce the consistent use of either function declarations or expressions
+    // https://eslint.org/docs/rules/func-style
+    'eslint/func-style': ['error', 'expression'],
+
+    // Enforce grouped accessor pairs in object literals and classes
+    // https://eslint.org/docs/rules/grouped-accessor-pairs
+    'eslint/grouped-accessor-pairs': 'error',
+
     // Enforce minimum and maximum identifier lengths
     // https://eslint.org/docs/rules/id-length
     'eslint/id-length': [
@@ -255,6 +279,18 @@ export const baseRules = {
     // https://eslint.org/docs/rules/max-classes-per-file
     'eslint/max-classes-per-file': ['error', 1],
 
+    // Require constructor names to begin with a capital letter
+    // https://eslint.org/docs/rules/new-cap
+    'eslint/new-cap': [
+      'error',
+      {
+        newIsCap: true,
+        newIsCapExceptions: [],
+        capIsNew: false,
+        capIsNewExceptions: ['Immutable.Map', 'Immutable.Set', 'Immutable.List'],
+      },
+    ],
+
     // Disallow the use of alert, confirm, and prompt
     // https://eslint.org/docs/rules/no-alert
     'eslint/no-alert': 'error',
@@ -355,6 +391,17 @@ export const baseRules = {
     // https://eslint.org/docs/rules/no-loop-func
     'eslint/no-loop-func': 'error',
 
+    // Disallow magic numbers
+    // https://eslint.org/docs/rules/no-magic-numbers
+    'eslint/no-magic-numbers': [
+      'error',
+      {
+        ignore: [-1, 0, 1, 2, 3, 4, 5, 100, 1024, 1000, 10000],
+        ignoreArrayIndexes: true,
+        ignoreDefaultValues: true,
+      },
+    ],
+
     // Disallow use of chained assignment expressions
     // https://eslint.org/docs/rules/no-multi-assign
     'eslint/no-multi-assign': 'error',
@@ -425,6 +472,10 @@ export const baseRules = {
     // https://eslint.org/docs/rules/no-regex-spaces
     'eslint/no-regex-spaces': 'error',
 
+    // Disallow specified modules when loaded by import
+    // https://eslint.org/docs/rules/no-restricted-imports
+    'eslint/no-restricted-imports': 'off',
+
     // Disallow assignment operators in return statements
     // https://eslint.org/docs/rules/no-return-assign
     'eslint/no-return-assign': ['error', 'always'],
@@ -502,6 +553,10 @@ export const baseRules = {
     // https://eslint.org/docs/rules/no-with
     'eslint/no-with': 'error',
 
+    // Require or disallow assignment operator shorthand where possible
+    // https://eslint.org/docs/rules/operator-assignment
+    'eslint/operator-assignment': ['error', 'always'],
+
     // Require const declarations for variables that are never reassigned after declared
     // https://eslint.org/docs/rules/prefer-const
     'eslint/prefer-const': ['error', { destructuring: 'any', ignoreReadBeforeAssign: true }],
@@ -569,6 +624,14 @@ export const baseRules = {
     // https://eslint.org/docs/rules/symbol-description
     'eslint/symbol-description': 'error',
 
+    // Require or disallow Unicode byte order mark (BOM)
+    // https://eslint.org/docs/rules/unicode-bom
+    'eslint/unicode-bom': ['error', 'never'],
+
+    // Require var declarations be placed at the top of their containing scope
+    // https://eslint.org/docs/rules/vars-on-top
+    'eslint/vars-on-top': 'error',
+
     // Require or disallow "Yoda" conditions
     // https://eslint.org/docs/rules/yoda
     'eslint/yoda': 'error',

package/rules/import.mjs

@@ -1,5 +1,8 @@
+// Native oxlint import rules + eslint-plugin-import-x via jsPlugins for rules
+// without native equivalents.
 export const importRules = {
   plugins: ['import'],
+  jsPlugins: [{ name: 'import-x-js', specifier: 'eslint-plugin-import-x' }],
   rules: {
     // Ensure named imports coupled with named exports
     // https://github.com/un-ts/eslint-plugin-import-x/blob/master/docs/rules/named.md
@@ -83,5 +86,86 @@ export const importRules = {
     // Forbid Webpack loader syntax in imports
     // https://github.com/un-ts/eslint-plugin-import-x/blob/master/docs/rules/no-webpack-loader-syntax.md
     'import/no-webpack-loader-syntax': 'error',
+
+    // -- Rules via jsPlugins (eslint-plugin-import-x) --
+    // These rules have no native oxlint equivalent.
+
+    // Ensure imports point to files/modules that can be resolved
+    // https://github.com/un-ts/eslint-plugin-import-x/blob/master/docs/rules/no-unresolved.md
+    'import-x-js/no-unresolved': ['error', { caseSensitive: true }],
+
+    // Disallow invalid exports, e.g. multiple defaults
+    // https://github.com/un-ts/eslint-plugin-import-x/blob/master/docs/rules/export.md
+    'import-x-js/export': 'error',
+
+    // Forbid the use of extraneous packages
+    // https://github.com/un-ts/eslint-plugin-import-x/blob/master/docs/rules/no-extraneous-dependencies.md
+    'import-x-js/no-extraneous-dependencies': [
+      'error',
+      {
+        devDependencies: [
+          '**/*{.,_}{test,vitest,spec}.{js,jsx,ts,tsx}',
+          '**/vite.config.{ts,js,cjs,mjs,mts}',
+          '**/vitest.config.{ts,js,cjs,mjs,mts}',
+          '**/jest.config.{js,cjs,mjs,mts}',
+          '**/jest.setup.{js,cjs,mjs,mts}',
+          '**/eslint.config.{js,cjs,mjs,mts}',
+          '**/.eslintrc.{js,cjs}',
+          '**/.stylelintrc.{cjs,js,json,yaml,yml}',
+          '**/stylelint.config.{cjs,mjs,mts,js}',
+          '**/esbuild.config.{js,cjs,mjs,mts}',
+          '**/tsup.config.{js,cjs,mjs,mts}',
+          '**/webpack.config.{js,cjs,mjs,mts}',
+          '**/webpack.config.*.{js,cjs,mjs,mts}',
+          '**/rollup.config.{js,cjs,mjs,mts}',
+          '**/rollup.config.*.{js,cjs,mjs,mts}',
+        ],
+        optionalDependencies: false,
+      },
+    ],
+
+    // Reports if a default export is renamed during import
+    // https://github.com/un-ts/eslint-plugin-import-x/blob/master/docs/rules/no-rename-default.md
+    'import-x-js/no-rename-default': 'error',
+
+    // Ensure consistent use of file extension within the import path
+    // https://github.com/un-ts/eslint-plugin-import-x/blob/master/docs/rules/extensions.md
+    'import-x-js/extensions': [
+      'error',
+      'ignorePackages',
+      {
+        js: 'never',
+        mjs: 'never',
+        jsx: 'never',
+        ts: 'never',
+        tsx: 'never',
+      },
+    ],
+
+    // Ensure absolute imports are above relative imports
+    // https://github.com/un-ts/eslint-plugin-import-x/blob/master/docs/rules/order.md
+    'import-x-js/order': [
+      'error',
+      {
+        groups: [['builtin', 'external', 'internal'], 'index', ['parent', 'sibling']],
+        'newlines-between': 'never',
+      },
+    ],
+
+    // Require a newline after the last import/require in a group
+    // https://github.com/un-ts/eslint-plugin-import-x/blob/master/docs/rules/newline-after-import.md
+    'import-x-js/newline-after-import': 'error',
+
+    // Ensures that there are no useless path segments
+    // https://github.com/un-ts/eslint-plugin-import-x/blob/master/docs/rules/no-useless-path-segments.md
+    'import-x-js/no-useless-path-segments': ['error', { commonjs: true }],
+
+    // Reports the use of import declarations with CommonJS exports
+    // https://github.com/un-ts/eslint-plugin-import-x/blob/master/docs/rules/no-import-module-exports.md
+    'import-x-js/no-import-module-exports': ['error', { exceptions: [] }],
+
+    // Use this rule to prevent importing packages through relative paths
+    // https://github.com/un-ts/eslint-plugin-import-x/blob/master/docs/rules/no-relative-packages.md
+    'import-x-js/no-relative-packages': 'error',
   },
 };

package/rules/vitest.mjs

@@ -36,6 +36,10 @@ export const vitestRules = {
     // https://github.com/vitest-dev/eslint-plugin-vitest/blob/main/docs/rules/no-import-node-test.md
     'vitest/no-import-node-test': 'error',
 
+    // Disallow conditional tests
+    // https://github.com/vitest-dev/eslint-plugin-vitest/blob/main/docs/rules/no-conditional-in-test.md
+    'vitest/no-conditional-in-test': 'error',
+
     // Prefer toHaveBeenCalledOnce() over toHaveBeenCalledTimes(1)
     // https://github.com/vitest-dev/eslint-plugin-vitest/blob/main/docs/rules/prefer-called-once.md
     // decision: conflicts with prefer-called-times (jest plugin), which is enabled
@@ -115,13 +119,6 @@ export const vitestRules = {
     // https://github.com/vitest-dev/eslint-plugin-vitest/blob/main/docs/rules/no-conditional-expect.md
     'jest/no-conditional-expect': 'error',
 
-    // Disallow conditional tests
-    // https://github.com/vitest-dev/eslint-plugin-vitest/blob/main/docs/rules/no-conditional-in-test.md
-    // decision: disabled in oxlint — the native jest/ prefix doesn't match existing
-    // `eslint-disable vitest/no-conditional-in-test` comments, and the jsPlugin vitest-js/
-    // alias has the same problem. Eslint still enforces this rule.
-    'jest/no-conditional-in-test': 'off',
-
     // Disallow disabled tests
     // https://github.com/vitest-dev/eslint-plugin-vitest/blob/main/docs/rules/no-disabled-tests.md
     // decision: it is often useful to be allowed to add a .skip