@wistia/eslint-config 2.7.0 → 2.9.0

package/.github/workflows/release.yml

@@ -21,11 +21,22 @@ jobs:
     runs-on: ubuntu-22.04
     timeout-minutes: 5
     steps:
+      - name: Generate GitHub App token
+        id: app-token
+        uses: actions/create-github-app-token@1b10c78c7865c340bc4f6099eb2f838309f1e8c3 # v3.1.1
+        with:
+          client-id: ${{ secrets.ACTIONS_BOT_GH_APP_CLIENT_ID }}
+          private-key: ${{ secrets.ACTIONS_BOT_GH_APP_PRIVATE_KEY }}
+          owner: ${{ github.repository_owner }}
+          repositories: eslint-config
+
       - name: Check out Git repository
         uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
         with:
+          persist-credentials: false
           # This makes Actions fetch all Git history so that Changesets can generate changelogs with the correct commits
           fetch-depth: 0
+          token: ${{ steps.app-token.outputs.token }}
 
       - name: Install Node and npm packages
         uses: ./.github/actions/setup-node-env
@@ -38,7 +49,7 @@ jobs:
           echo "NEW_PACKAGE_VERSION=$(yarn changeset status --output=release.json && jq -r '.releases[0].newVersion' release.json && rm release.json)" >> "$GITHUB_ENV"
 
       - name: Create Release Pull Request or Publish to npm
-        uses: changesets/action@6a0a831ff30acef54f2c6aa1cbbc1096b066edaf # v1.7.0
+        uses: changesets/action@63a615b9cd06ba9a3e6d13796c7fbcb080a60a0b # v1.8.0
         id: changesets
         with:
           createGithubReleases: true
@@ -46,5 +57,5 @@ jobs:
           title: "chore: release v${{env.NEW_PACKAGE_VERSION}}"
           commit: "chore: release v${{env.NEW_PACKAGE_VERSION}}"
         env:
-          GITHUB_TOKEN: ${{ secrets.WISTIA_GITHUB_BOT_TOKEN }}
+          GITHUB_TOKEN: ${{ steps.app-token.outputs.token }}
           NPM_TOKEN: ${{ secrets.NPM_AUTH_TOKEN }}

package/CHANGELOG.md

@@ -1,5 +1,17 @@
 # @wistia/eslint-config
 
+## 2.9.0
+
+### Minor Changes
+
+- [#491](https://github.com/wistia/eslint-config/pull/491) [`8a65e35`](https://github.com/wistia/eslint-config/commit/8a65e35f1fd9544f8c9367efab1b5921eee1fdc7) Thanks [@okize](https://github.com/okize)! - feat: update react rules for new `eslint-plugin-n` version
+
+## 2.8.0
+
+### Minor Changes
+
+- [#488](https://github.com/wistia/eslint-config/pull/488) [`4f64acf`](https://github.com/wistia/eslint-config/commit/4f64acfdfd01afce6e3cb28759eed217d83a5e7b) Thanks [@okize](https://github.com/okize)! - feat: update react rules for new @eslint-react/eslint-plugin version
+
 ## 2.7.0
 
 ### Minor Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@wistia/eslint-config",
-  "version": "2.7.0",
+  "version": "2.9.0",
   "description": "Wistia's ESLint configurations",
   "packageManager": "yarn@4.14.1",
   "type": "module",
@@ -38,13 +38,13 @@
     "test:export": "check-export-map"
   },
   "dependencies": {
-    "@eslint-react/eslint-plugin": "^4.2.3",
-    "@eslint/compat": "^2.0.5",
+    "@eslint-react/eslint-plugin": "^5.7.7",
+    "@eslint/compat": "^2.1.0",
     "@eslint/js": "^10.0.1",
     "@stylistic/eslint-plugin": "^5.10.0",
-    "@typescript-eslint/eslint-plugin": "^8.59.0",
-    "@typescript-eslint/parser": "^8.59.0",
-    "@vitest/eslint-plugin": "^1.6.16",
+    "@typescript-eslint/eslint-plugin": "^8.59.3",
+    "@typescript-eslint/parser": "^8.59.3",
+    "@vitest/eslint-plugin": "^1.6.17",
     "confusing-browser-globals": "^1.0.11",
     "eslint-import-resolver-typescript": "^4.4.4",
     "eslint-plugin-barrel-files": "^3.0.1",
@@ -54,30 +54,30 @@
     "eslint-plugin-jest-dom": "^5.5.0",
     "eslint-plugin-jest-formatting": "^3.1.0",
     "eslint-plugin-jsx-a11y": "^6.10.2",
-    "eslint-plugin-n": "^17.24.0",
-    "eslint-plugin-no-only-tests": "^3.3.0",
+    "eslint-plugin-n": "^18.0.1",
+    "eslint-plugin-no-only-tests": "^3.4.0",
     "eslint-plugin-playwright": "^2.10.2",
     "eslint-plugin-prettier": "^5.5.5",
-    "eslint-plugin-promise": "^7.2.1",
-    "eslint-plugin-storybook": "^10.3.5",
+    "eslint-plugin-promise": "^7.3.0",
+    "eslint-plugin-storybook": "^10.3.6",
     "eslint-plugin-styled-components-a11y": "^2.2.1",
     "eslint-plugin-testing-library": "^7.16.2",
-    "globals": "^17.5.0",
-    "globals-vitest": "^4.1.5"
+    "globals": "^17.6.0",
+    "globals-vitest": "^4.1.6"
   },
   "devDependencies": {
-    "@changesets/changelog-github": "^0.6.0",
+    "@changesets/changelog-github": "^0.7.0",
     "@changesets/cli": "^2.31.0",
-    "@commitlint/cli": "^20.5.0",
-    "@commitlint/config-conventional": "^20.5.0",
+    "@commitlint/cli": "^21.0.1",
+    "@commitlint/config-conventional": "^21.0.1",
     "check-export-map": "^1.3.1",
-    "eslint": "^10.2.1",
+    "eslint": "^10.3.0",
     "glob": "^13.0.6",
     "husky": "^9.1.7",
     "prettier": "^3.8.3",
-    "storybook": "^10.3.5",
+    "storybook": "^10.3.6",
     "typescript": "^6.0.3",
-    "vitest": "^4.1.5"
+    "vitest": "^4.1.6"
   },
   "peerDependencies": {
     "eslint": ">= 10",

package/src/rules/node.mjs

@@ -151,6 +151,10 @@ export default {
   // https://github.com/eslint-community/eslint-plugin-n/blob/master/docs/rules/prefer-global/console.md
   'n/prefer-global/console': 'error',
 
+  // enforce either crypto or require("crypto").webcrypto
+  // https://github.com/eslint-community/eslint-plugin-n/blob/HEAD/docs/rules/prefer-global/crypto.md
+  'n/prefer-global/crypto': 'error',
+
   // enforce either process or require("process")
   // https://github.com/eslint-community/eslint-plugin-n/blob/master/docs/rules/prefer-global/process.md
   'n/prefer-global/process': 'error',
@@ -163,6 +167,10 @@ export default {
   // https://github.com/eslint-community/eslint-plugin-n/blob/master/docs/rules/prefer-global/text-encoder.md
   'n/prefer-global/text-encoder': 'error',
 
+  // enforce either global timers or require("timers")
+  // https://github.com/eslint-community/eslint-plugin-n/blob/HEAD/docs/rules/prefer-global/timers.md
+  'n/prefer-global/timers': 'error',
+
   // enforce either URLSearchParams or require("url").URLSearchParams
   // https://github.com/eslint-community/eslint-plugin-n/blob/master/docs/rules/prefer-global/url-search-params.md
   'n/prefer-global/url-search-params': 'error',

package/src/rules/react.mjs

@@ -30,14 +30,14 @@ export default {
 
   // --- Core React rules ---
 
-  // Validates higher order functions defining nested components or hooks
-  // https://eslint-react.xyz/docs/rules/component-hook-factories
-  '@eslint-react/component-hook-factories': 'error',
-
   // Validates usage of Error Boundaries instead of try/catch for child errors
   // https://eslint-react.xyz/docs/rules/error-boundaries
   '@eslint-react/error-boundaries': 'error',
 
+  // Restricts usage of global variables in React components
+  // https://eslint-react.xyz/docs/rules/globals
+  '@eslint-react/globals': 'error',
+
   // Verify the list of the dependencies for Hooks like useEffect and similar
   // https://eslint-react.xyz/docs/rules/exhaustive-deps
   '@eslint-react/exhaustive-deps': 'error',
@@ -154,10 +154,6 @@ export default {
   // https://eslint-react.xyz/docs/rules/no-nested-lazy-component-declarations
   '@eslint-react/no-nested-lazy-component-declarations': 'error',
 
-  // Prevent usage of shouldComponentUpdate when extending React.PureComponent
-  // https://eslint-react.xyz/docs/rules/no-redundant-should-component-update
-  '@eslint-react/no-redundant-should-component-update': 'error',
-
   // Prevent usage of setState in componentDidMount
   // https://eslint-react.xyz/docs/rules/no-set-state-in-component-did-mount
   '@eslint-react/no-set-state-in-component-did-mount': 'error',
@@ -170,14 +166,6 @@ export default {
   // https://eslint-react.xyz/docs/rules/no-set-state-in-component-will-update
   '@eslint-react/no-set-state-in-component-will-update': 'error',
 
-  // Disallow unnecessary useCallback hooks
-  // https://eslint-react.xyz/docs/rules/no-unnecessary-use-callback
-  '@eslint-react/no-unnecessary-use-callback': 'error',
-
-  // Disallow unnecessary useMemo hooks
-  // https://eslint-react.xyz/docs/rules/no-unnecessary-use-memo
-  '@eslint-react/no-unnecessary-use-memo': 'error',
-
   // Disallow unnecessary "use" prefix on custom hooks
   // https://eslint-react.xyz/docs/rules/no-unnecessary-use-prefix
   '@eslint-react/no-unnecessary-use-prefix': 'error',
@@ -218,15 +206,6 @@ export default {
   // https://eslint-react.xyz/docs/rules/no-use-context
   '@eslint-react/no-use-context': 'error',
 
-  // Enforce consistent usage of destructuring assignment of props, state, and context
-  // https://eslint-react.xyz/docs/rules/prefer-destructuring-assignment
-  // decision: best left up to the implementer
-  '@eslint-react/prefer-destructuring-assignment': 'off',
-
-  // Enforce importing React via a namespace import
-  // https://eslint-react.xyz/docs/rules/prefer-namespace-import
-  '@eslint-react/prefer-namespace-import': 'off',
-
   // Validates that components/hooks are pure
   // https://eslint-react.xyz/docs/rules/purity
   '@eslint-react/purity': 'error',
@@ -247,6 +226,10 @@ export default {
   // https://eslint-react.xyz/docs/rules/set-state-in-render
   '@eslint-react/set-state-in-render': 'error',
 
+  // Enforces static component definitions
+  // https://eslint-react.xyz/docs/rules/static-components
+  '@eslint-react/static-components': 'error',
+
   // Validates against syntax that React does not support
   // https://eslint-react.xyz/docs/rules/unsupported-syntax
   '@eslint-react/unsupported-syntax': 'error',
@@ -359,10 +342,6 @@ export default {
   // https://eslint-react.xyz/docs/rules/dom-no-void-elements-with-children
   '@eslint-react/dom-no-void-elements-with-children': 'error',
 
-  // Enforce importing React DOM via a namespace import
-  // https://eslint-react.xyz/docs/rules/dom-prefer-namespace-import
-  '@eslint-react/dom-prefer-namespace-import': 'off',
-
   // --- RSC rules ---
 
   // Enforce correct function definition for React Server Components
@@ -400,4 +379,8 @@ export default {
   // Prevent leaked setTimeout calls
   // https://eslint-react.xyz/docs/rules/web-api-no-leaked-timeout
   '@eslint-react/web-api-no-leaked-timeout': 'error',
+
+  // Prevent leaked fetch calls in effects
+  // https://eslint-react.xyz/docs/rules/web-api-no-leaked-fetch
+  '@eslint-react/web-api-no-leaked-fetch': 'error',
 };

package/test/__snapshots__/javascript.mjs.snap

@@ -64,7 +64,7 @@
       "undefined": false,
       "unescape": false,
     },
-    "parser": "typescript-eslint/parser@8.59.0",
+    "parser": "typescript-eslint/parser@8.59.3",
     "parserOptions": {
       "requireConfigFile": false,
     },

package/test/__snapshots__/jest.mjs.snap

@@ -30,7 +30,7 @@
     "@",
     "jest:eslint-plugin-jest@29.15.2",
     "jest-formatting",
-    "no-only-tests",
+    "no-only-tests:no-only-tests",
   ],
   "rules": {
     "jest-formatting/padding-around-after-all-blocks": [

package/test/__snapshots__/node.mjs.snap

@@ -97,7 +97,7 @@
   },
   "plugins": [
     "@",
-    "n:eslint-plugin-n@17.24.0",
+    "n:eslint-plugin-n@18.0.1",
     "import-x:eslint-plugin-import-x@4.16.2",
   ],
   "rules": {
@@ -209,6 +209,9 @@
     "n/prefer-global/console": [
       2,
     ],
+    "n/prefer-global/crypto": [
+      2,
+    ],
     "n/prefer-global/process": [
       2,
     ],
@@ -218,6 +221,9 @@
     "n/prefer-global/text-encoder": [
       2,
     ],
+    "n/prefer-global/timers": [
+      2,
+    ],
     "n/prefer-global/url": [
       2,
     ],

package/test/__snapshots__/react.mjs.snap

@@ -906,8 +906,12 @@
       "XRBoundedReferenceSpace": false,
       "XRCPUDepthInformation": false,
       "XRCamera": false,
+      "XRCompositionLayer": false,
+      "XRCubeLayer": false,
+      "XRCylinderLayer": false,
       "XRDOMOverlayState": false,
       "XRDepthInformation": false,
+      "XREquirectLayer": false,
       "XRFrame": false,
       "XRHand": false,
       "XRHitTestResult": false,
@@ -919,9 +923,14 @@
       "XRJointPose": false,
       "XRJointSpace": false,
       "XRLayer": false,
+      "XRLayerEvent": false,
       "XRLightEstimate": false,
       "XRLightProbe": false,
+      "XRPlane": false,
+      "XRPlaneSet": false,
       "XRPose": false,
+      "XRProjectionLayer": false,
+      "XRQuadLayer": false,
       "XRRay": false,
       "XRReferenceSpace": false,
       "XRReferenceSpaceEvent": false,
@@ -930,6 +939,7 @@
       "XRSession": false,
       "XRSessionEvent": false,
       "XRSpace": false,
+      "XRSubImage": false,
       "XRSystem": false,
       "XRTransientInputHitTestResult": false,
       "XRTransientInputHitTestSource": false,
@@ -940,6 +950,7 @@
       "XRWebGLBinding": false,
       "XRWebGLDepthInformation": false,
       "XRWebGLLayer": false,
+      "XRWebGLSubImage": false,
       "XSLTProcessor": false,
       "addEventListener": false,
       "ai": false,
@@ -1193,13 +1204,10 @@
   },
   "plugins": [
     "@",
-    "@eslint-react:@eslint-react/eslint-plugin@4.2.3",
+    "@eslint-react:@eslint-react/eslint-plugin@5.7.7",
     "jsx-a11y:eslint-plugin-jsx-a11y@6.10.2",
   ],
   "rules": {
-    "@eslint-react/component-hook-factories": [
-      2,
-    ],
     "@eslint-react/dom-no-dangerously-set-innerhtml": [
       2,
     ],
@@ -1248,15 +1256,15 @@
     "@eslint-react/dom-no-void-elements-with-children": [
       2,
     ],
-    "@eslint-react/dom-prefer-namespace-import": [
-      0,
-    ],
     "@eslint-react/error-boundaries": [
       2,
     ],
     "@eslint-react/exhaustive-deps": [
       2,
     ],
+    "@eslint-react/globals": [
+      2,
+    ],
     "@eslint-react/immutability": [
       2,
     ],
@@ -1378,9 +1386,6 @@
     "@eslint-react/no-nested-lazy-component-declarations": [
       2,
     ],
-    "@eslint-react/no-redundant-should-component-update": [
-      2,
-    ],
     "@eslint-react/no-set-state-in-component-did-mount": [
       2,
     ],
@@ -1390,12 +1395,6 @@
     "@eslint-react/no-set-state-in-component-will-update": [
       2,
     ],
-    "@eslint-react/no-unnecessary-use-callback": [
-      2,
-    ],
-    "@eslint-react/no-unnecessary-use-memo": [
-      2,
-    ],
     "@eslint-react/no-unnecessary-use-prefix": [
       2,
     ],
@@ -1426,12 +1425,6 @@
     "@eslint-react/no-use-context": [
       2,
     ],
-    "@eslint-react/prefer-destructuring-assignment": [
-      0,
-    ],
-    "@eslint-react/prefer-namespace-import": [
-      0,
-    ],
     "@eslint-react/purity": [
       2,
     ],
@@ -1450,6 +1443,9 @@
     "@eslint-react/set-state-in-render": [
       2,
     ],
+    "@eslint-react/static-components": [
+      2,
+    ],
     "@eslint-react/unsupported-syntax": [
       2,
     ],
@@ -1462,6 +1458,9 @@
     "@eslint-react/web-api-no-leaked-event-listener": [
       2,
     ],
+    "@eslint-react/web-api-no-leaked-fetch": [
+      2,
+    ],
     "@eslint-react/web-api-no-leaked-interval": [
       2,
     ],

package/test/__snapshots__/typescript.mjs.snap

@@ -64,7 +64,7 @@
       "undefined": false,
       "unescape": false,
     },
-    "parser": "typescript-eslint/parser@8.59.0",
+    "parser": "typescript-eslint/parser@8.59.3",
     "parserOptions": {
       "ecmaVersion": 2024,
       "project": "./tsconfig.json",
@@ -78,7 +78,7 @@
   "plugins": [
     "@",
     "@stylistic:@stylistic/eslint-plugin@5.10.0",
-    "@typescript-eslint:@typescript-eslint/eslint-plugin@8.59.0",
+    "@typescript-eslint:@typescript-eslint/eslint-plugin@8.59.3",
     "barrel-files:eslint-plugin-barrel-files@3.0.1",
     "filenames",
     "import-x:eslint-plugin-import-x@4.16.2",

package/test/__snapshots__/vitest.mjs.snap

@@ -35,8 +35,8 @@
   },
   "plugins": [
     "@",
-    "vitest:vitest@1.6.16",
-    "no-only-tests",
+    "vitest:vitest@1.6.17",
+    "no-only-tests:no-only-tests",
   ],
   "rules": {
     "no-only-tests/no-only-tests": [