@wistia/eslint-config 2.7.0 → 2.8.0

package/.github/workflows/release.yml

@@ -21,11 +21,22 @@ jobs:
     runs-on: ubuntu-22.04
     timeout-minutes: 5
     steps:
+      - name: Generate GitHub App token
+        id: app-token
+        uses: actions/create-github-app-token@1b10c78c7865c340bc4f6099eb2f838309f1e8c3 # v3.1.1
+        with:
+          client-id: ${{ secrets.ACTIONS_BOT_GH_APP_CLIENT_ID }}
+          private-key: ${{ secrets.ACTIONS_BOT_GH_APP_PRIVATE_KEY }}
+          owner: ${{ github.repository_owner }}
+          repositories: eslint-config
+
       - name: Check out Git repository
         uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
         with:
+          persist-credentials: false
           # This makes Actions fetch all Git history so that Changesets can generate changelogs with the correct commits
           fetch-depth: 0
+          token: ${{ steps.app-token.outputs.token }}
 
       - name: Install Node and npm packages
         uses: ./.github/actions/setup-node-env
@@ -46,5 +57,5 @@ jobs:
           title: "chore: release v${{env.NEW_PACKAGE_VERSION}}"
           commit: "chore: release v${{env.NEW_PACKAGE_VERSION}}"
         env:
-          GITHUB_TOKEN: ${{ secrets.WISTIA_GITHUB_BOT_TOKEN }}
+          GITHUB_TOKEN: ${{ steps.app-token.outputs.token }}
           NPM_TOKEN: ${{ secrets.NPM_AUTH_TOKEN }}

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # @wistia/eslint-config
 
+## 2.8.0
+
+### Minor Changes
+
+- [#488](https://github.com/wistia/eslint-config/pull/488) [`4f64acf`](https://github.com/wistia/eslint-config/commit/4f64acfdfd01afce6e3cb28759eed217d83a5e7b) Thanks [@okize](https://github.com/okize)! - feat: update react rules for new @eslint-react/eslint-plugin version
+
 ## 2.7.0
 
 ### Minor Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@wistia/eslint-config",
-  "version": "2.7.0",
+  "version": "2.8.0",
   "description": "Wistia's ESLint configurations",
   "packageManager": "yarn@4.14.1",
   "type": "module",
@@ -38,7 +38,7 @@
     "test:export": "check-export-map"
   },
   "dependencies": {
-    "@eslint-react/eslint-plugin": "^4.2.3",
+    "@eslint-react/eslint-plugin": "^5.7.3",
     "@eslint/compat": "^2.0.5",
     "@eslint/js": "^10.0.1",
     "@stylistic/eslint-plugin": "^5.10.0",
@@ -68,8 +68,8 @@
   "devDependencies": {
     "@changesets/changelog-github": "^0.6.0",
     "@changesets/cli": "^2.31.0",
-    "@commitlint/cli": "^20.5.0",
-    "@commitlint/config-conventional": "^20.5.0",
+    "@commitlint/cli": "^21.0.1",
+    "@commitlint/config-conventional": "^21.0.1",
     "check-export-map": "^1.3.1",
     "eslint": "^10.2.1",
     "glob": "^13.0.6",

package/src/rules/react.mjs

@@ -30,14 +30,14 @@ export default {
 
   // --- Core React rules ---
 
-  // Validates higher order functions defining nested components or hooks
-  // https://eslint-react.xyz/docs/rules/component-hook-factories
-  '@eslint-react/component-hook-factories': 'error',
-
   // Validates usage of Error Boundaries instead of try/catch for child errors
   // https://eslint-react.xyz/docs/rules/error-boundaries
   '@eslint-react/error-boundaries': 'error',
 
+  // Restricts usage of global variables in React components
+  // https://eslint-react.xyz/docs/rules/globals
+  '@eslint-react/globals': 'error',
+
   // Verify the list of the dependencies for Hooks like useEffect and similar
   // https://eslint-react.xyz/docs/rules/exhaustive-deps
   '@eslint-react/exhaustive-deps': 'error',
@@ -154,10 +154,6 @@ export default {
   // https://eslint-react.xyz/docs/rules/no-nested-lazy-component-declarations
   '@eslint-react/no-nested-lazy-component-declarations': 'error',
 
-  // Prevent usage of shouldComponentUpdate when extending React.PureComponent
-  // https://eslint-react.xyz/docs/rules/no-redundant-should-component-update
-  '@eslint-react/no-redundant-should-component-update': 'error',
-
   // Prevent usage of setState in componentDidMount
   // https://eslint-react.xyz/docs/rules/no-set-state-in-component-did-mount
   '@eslint-react/no-set-state-in-component-did-mount': 'error',
@@ -170,14 +166,6 @@ export default {
   // https://eslint-react.xyz/docs/rules/no-set-state-in-component-will-update
   '@eslint-react/no-set-state-in-component-will-update': 'error',
 
-  // Disallow unnecessary useCallback hooks
-  // https://eslint-react.xyz/docs/rules/no-unnecessary-use-callback
-  '@eslint-react/no-unnecessary-use-callback': 'error',
-
-  // Disallow unnecessary useMemo hooks
-  // https://eslint-react.xyz/docs/rules/no-unnecessary-use-memo
-  '@eslint-react/no-unnecessary-use-memo': 'error',
-
   // Disallow unnecessary "use" prefix on custom hooks
   // https://eslint-react.xyz/docs/rules/no-unnecessary-use-prefix
   '@eslint-react/no-unnecessary-use-prefix': 'error',
@@ -218,15 +206,6 @@ export default {
   // https://eslint-react.xyz/docs/rules/no-use-context
   '@eslint-react/no-use-context': 'error',
 
-  // Enforce consistent usage of destructuring assignment of props, state, and context
-  // https://eslint-react.xyz/docs/rules/prefer-destructuring-assignment
-  // decision: best left up to the implementer
-  '@eslint-react/prefer-destructuring-assignment': 'off',
-
-  // Enforce importing React via a namespace import
-  // https://eslint-react.xyz/docs/rules/prefer-namespace-import
-  '@eslint-react/prefer-namespace-import': 'off',
-
   // Validates that components/hooks are pure
   // https://eslint-react.xyz/docs/rules/purity
   '@eslint-react/purity': 'error',
@@ -247,6 +226,10 @@ export default {
   // https://eslint-react.xyz/docs/rules/set-state-in-render
   '@eslint-react/set-state-in-render': 'error',
 
+  // Enforces static component definitions
+  // https://eslint-react.xyz/docs/rules/static-components
+  '@eslint-react/static-components': 'error',
+
   // Validates against syntax that React does not support
   // https://eslint-react.xyz/docs/rules/unsupported-syntax
   '@eslint-react/unsupported-syntax': 'error',
@@ -359,10 +342,6 @@ export default {
   // https://eslint-react.xyz/docs/rules/dom-no-void-elements-with-children
   '@eslint-react/dom-no-void-elements-with-children': 'error',
 
-  // Enforce importing React DOM via a namespace import
-  // https://eslint-react.xyz/docs/rules/dom-prefer-namespace-import
-  '@eslint-react/dom-prefer-namespace-import': 'off',
-
   // --- RSC rules ---
 
   // Enforce correct function definition for React Server Components
@@ -400,4 +379,8 @@ export default {
   // Prevent leaked setTimeout calls
   // https://eslint-react.xyz/docs/rules/web-api-no-leaked-timeout
   '@eslint-react/web-api-no-leaked-timeout': 'error',
+
+  // Prevent leaked fetch calls in effects
+  // https://eslint-react.xyz/docs/rules/web-api-no-leaked-fetch
+  '@eslint-react/web-api-no-leaked-fetch': 'error',
 };

package/test/__snapshots__/react.mjs.snap

@@ -1193,13 +1193,10 @@
   },
   "plugins": [
     "@",
-    "@eslint-react:@eslint-react/eslint-plugin@4.2.3",
+    "@eslint-react:@eslint-react/eslint-plugin@5.7.3",
     "jsx-a11y:eslint-plugin-jsx-a11y@6.10.2",
   ],
   "rules": {
-    "@eslint-react/component-hook-factories": [
-      2,
-    ],
     "@eslint-react/dom-no-dangerously-set-innerhtml": [
       2,
     ],
@@ -1248,15 +1245,15 @@
     "@eslint-react/dom-no-void-elements-with-children": [
       2,
     ],
-    "@eslint-react/dom-prefer-namespace-import": [
-      0,
-    ],
     "@eslint-react/error-boundaries": [
       2,
     ],
     "@eslint-react/exhaustive-deps": [
       2,
     ],
+    "@eslint-react/globals": [
+      2,
+    ],
     "@eslint-react/immutability": [
       2,
     ],
@@ -1378,9 +1375,6 @@
     "@eslint-react/no-nested-lazy-component-declarations": [
       2,
     ],
-    "@eslint-react/no-redundant-should-component-update": [
-      2,
-    ],
     "@eslint-react/no-set-state-in-component-did-mount": [
       2,
     ],
@@ -1390,12 +1384,6 @@
     "@eslint-react/no-set-state-in-component-will-update": [
       2,
     ],
-    "@eslint-react/no-unnecessary-use-callback": [
-      2,
-    ],
-    "@eslint-react/no-unnecessary-use-memo": [
-      2,
-    ],
     "@eslint-react/no-unnecessary-use-prefix": [
       2,
     ],
@@ -1426,12 +1414,6 @@
     "@eslint-react/no-use-context": [
       2,
     ],
-    "@eslint-react/prefer-destructuring-assignment": [
-      0,
-    ],
-    "@eslint-react/prefer-namespace-import": [
-      0,
-    ],
     "@eslint-react/purity": [
       2,
     ],
@@ -1450,6 +1432,9 @@
     "@eslint-react/set-state-in-render": [
       2,
     ],
+    "@eslint-react/static-components": [
+      2,
+    ],
     "@eslint-react/unsupported-syntax": [
       2,
     ],
@@ -1462,6 +1447,9 @@
     "@eslint-react/web-api-no-leaked-event-listener": [
       2,
     ],
+    "@eslint-react/web-api-no-leaked-fetch": [
+      2,
+    ],
     "@eslint-react/web-api-no-leaked-interval": [
       2,
     ],