@wistia/eslint-config 2.6.0 → 2.8.0

package/.yarnrc.yml

@@ -1,7 +1,12 @@
+approvedGitRepositories:
+  - "**"
+
 enableGlobalCache: false
 
+enableScripts: true
+
 nodeLinker: node-modules
 
-yarnPath: .yarn/releases/yarn-4.13.0.cjs
+npmMinimalAgeGate: 7d
 
-npmMinimalAgeGate: '7d'
+yarnPath: .yarn/releases/yarn-4.14.1.cjs

package/CHANGELOG.md

@@ -1,5 +1,17 @@
 # @wistia/eslint-config
 
+## 2.8.0
+
+### Minor Changes
+
+- [#488](https://github.com/wistia/eslint-config/pull/488) [`4f64acf`](https://github.com/wistia/eslint-config/commit/4f64acfdfd01afce6e3cb28759eed217d83a5e7b) Thanks [@okize](https://github.com/okize)! - feat: update react rules for new @eslint-react/eslint-plugin version
+
+## 2.7.0
+
+### Minor Changes
+
+- [#468](https://github.com/wistia/eslint-config/pull/468) [`9d23cc3`](https://github.com/wistia/eslint-config/commit/9d23cc3dbcdeea1454e5a13d851313f1106dc11c) Thanks [@okize](https://github.com/okize)! - feat: remove `react-ssr-compatibility` config & rules
+
 ## 2.6.0
 
 ### Minor Changes

package/package.json

@@ -1,8 +1,8 @@
 {
   "name": "@wistia/eslint-config",
-  "version": "2.6.0",
+  "version": "2.8.0",
   "description": "Wistia's ESLint configurations",
-  "packageManager": "yarn@4.13.0",
+  "packageManager": "yarn@4.14.1",
   "type": "module",
   "main": "index.mjs",
   "engines": {
@@ -16,7 +16,6 @@
     "./node": "./src/configs/node.mjs",
     "./playwright": "./src/configs/playwright.mjs",
     "./react": "./src/configs/react.mjs",
-    "./react-ssr-compatibility": "./src/configs/react-ssr-compatibility.mjs",
     "./storybook": "./src/configs/storybook.mjs",
     "./styled-components": "./src/configs/styled-components.mjs",
     "./testing-library": "./src/configs/testing-library.mjs",
@@ -39,13 +38,13 @@
     "test:export": "check-export-map"
   },
   "dependencies": {
-    "@eslint-react/eslint-plugin": "^4.2.3",
+    "@eslint-react/eslint-plugin": "^5.7.3",
     "@eslint/compat": "^2.0.5",
     "@eslint/js": "^10.0.1",
     "@stylistic/eslint-plugin": "^5.10.0",
-    "@typescript-eslint/eslint-plugin": "^8.58.2",
-    "@typescript-eslint/parser": "^8.58.2",
-    "@vitest/eslint-plugin": "^1.6.15",
+    "@typescript-eslint/eslint-plugin": "^8.59.0",
+    "@typescript-eslint/parser": "^8.59.0",
+    "@vitest/eslint-plugin": "^1.6.16",
     "confusing-browser-globals": "^1.0.11",
     "eslint-import-resolver-typescript": "^4.4.4",
     "eslint-plugin-barrel-files": "^3.0.1",
@@ -57,31 +56,28 @@
     "eslint-plugin-jsx-a11y": "^6.10.2",
     "eslint-plugin-n": "^17.24.0",
     "eslint-plugin-no-only-tests": "^3.3.0",
-    "eslint-plugin-no-typeof-window-undefined": "^0.0.2",
-    "eslint-plugin-playwright": "^2.10.1",
+    "eslint-plugin-playwright": "^2.10.2",
     "eslint-plugin-prettier": "^5.5.5",
     "eslint-plugin-promise": "^7.2.1",
-    "eslint-plugin-react-hooks-ssr": "^0.1.5",
-    "eslint-plugin-ssr-friendly": "^1.3.0",
     "eslint-plugin-storybook": "^10.3.5",
     "eslint-plugin-styled-components-a11y": "^2.2.1",
     "eslint-plugin-testing-library": "^7.16.2",
     "globals": "^17.5.0",
-    "globals-vitest": "^4.1.4"
+    "globals-vitest": "^4.1.5"
   },
   "devDependencies": {
     "@changesets/changelog-github": "^0.6.0",
-    "@changesets/cli": "^2.30.0",
-    "@commitlint/cli": "^20.5.0",
-    "@commitlint/config-conventional": "^20.5.0",
+    "@changesets/cli": "^2.31.0",
+    "@commitlint/cli": "^21.0.1",
+    "@commitlint/config-conventional": "^21.0.1",
     "check-export-map": "^1.3.1",
-    "eslint": "^10.2.0",
+    "eslint": "^10.2.1",
     "glob": "^13.0.6",
     "husky": "^9.1.7",
-    "prettier": "^3.8.2",
+    "prettier": "^3.8.3",
     "storybook": "^10.3.5",
-    "typescript": "^6.0.2",
-    "vitest": "^4.1.4"
+    "typescript": "^6.0.3",
+    "vitest": "^4.1.5"
   },
   "peerDependencies": {
     "eslint": ">= 10",

package/src/rules/react.mjs

@@ -30,14 +30,14 @@ export default {
 
   // --- Core React rules ---
 
-  // Validates higher order functions defining nested components or hooks
-  // https://eslint-react.xyz/docs/rules/component-hook-factories
-  '@eslint-react/component-hook-factories': 'error',
-
   // Validates usage of Error Boundaries instead of try/catch for child errors
   // https://eslint-react.xyz/docs/rules/error-boundaries
   '@eslint-react/error-boundaries': 'error',
 
+  // Restricts usage of global variables in React components
+  // https://eslint-react.xyz/docs/rules/globals
+  '@eslint-react/globals': 'error',
+
   // Verify the list of the dependencies for Hooks like useEffect and similar
   // https://eslint-react.xyz/docs/rules/exhaustive-deps
   '@eslint-react/exhaustive-deps': 'error',
@@ -154,10 +154,6 @@ export default {
   // https://eslint-react.xyz/docs/rules/no-nested-lazy-component-declarations
   '@eslint-react/no-nested-lazy-component-declarations': 'error',
 
-  // Prevent usage of shouldComponentUpdate when extending React.PureComponent
-  // https://eslint-react.xyz/docs/rules/no-redundant-should-component-update
-  '@eslint-react/no-redundant-should-component-update': 'error',
-
   // Prevent usage of setState in componentDidMount
   // https://eslint-react.xyz/docs/rules/no-set-state-in-component-did-mount
   '@eslint-react/no-set-state-in-component-did-mount': 'error',
@@ -170,14 +166,6 @@ export default {
   // https://eslint-react.xyz/docs/rules/no-set-state-in-component-will-update
   '@eslint-react/no-set-state-in-component-will-update': 'error',
 
-  // Disallow unnecessary useCallback hooks
-  // https://eslint-react.xyz/docs/rules/no-unnecessary-use-callback
-  '@eslint-react/no-unnecessary-use-callback': 'error',
-
-  // Disallow unnecessary useMemo hooks
-  // https://eslint-react.xyz/docs/rules/no-unnecessary-use-memo
-  '@eslint-react/no-unnecessary-use-memo': 'error',
-
   // Disallow unnecessary "use" prefix on custom hooks
   // https://eslint-react.xyz/docs/rules/no-unnecessary-use-prefix
   '@eslint-react/no-unnecessary-use-prefix': 'error',
@@ -218,15 +206,6 @@ export default {
   // https://eslint-react.xyz/docs/rules/no-use-context
   '@eslint-react/no-use-context': 'error',
 
-  // Enforce consistent usage of destructuring assignment of props, state, and context
-  // https://eslint-react.xyz/docs/rules/prefer-destructuring-assignment
-  // decision: best left up to the implementer
-  '@eslint-react/prefer-destructuring-assignment': 'off',
-
-  // Enforce importing React via a namespace import
-  // https://eslint-react.xyz/docs/rules/prefer-namespace-import
-  '@eslint-react/prefer-namespace-import': 'off',
-
   // Validates that components/hooks are pure
   // https://eslint-react.xyz/docs/rules/purity
   '@eslint-react/purity': 'error',
@@ -247,6 +226,10 @@ export default {
   // https://eslint-react.xyz/docs/rules/set-state-in-render
   '@eslint-react/set-state-in-render': 'error',
 
+  // Enforces static component definitions
+  // https://eslint-react.xyz/docs/rules/static-components
+  '@eslint-react/static-components': 'error',
+
   // Validates against syntax that React does not support
   // https://eslint-react.xyz/docs/rules/unsupported-syntax
   '@eslint-react/unsupported-syntax': 'error',
@@ -359,10 +342,6 @@ export default {
   // https://eslint-react.xyz/docs/rules/dom-no-void-elements-with-children
   '@eslint-react/dom-no-void-elements-with-children': 'error',
 
-  // Enforce importing React DOM via a namespace import
-  // https://eslint-react.xyz/docs/rules/dom-prefer-namespace-import
-  '@eslint-react/dom-prefer-namespace-import': 'off',
-
   // --- RSC rules ---
 
   // Enforce correct function definition for React Server Components
@@ -400,4 +379,8 @@ export default {
   // Prevent leaked setTimeout calls
   // https://eslint-react.xyz/docs/rules/web-api-no-leaked-timeout
   '@eslint-react/web-api-no-leaked-timeout': 'error',
+
+  // Prevent leaked fetch calls in effects
+  // https://eslint-react.xyz/docs/rules/web-api-no-leaked-fetch
+  '@eslint-react/web-api-no-leaked-fetch': 'error',
 };

package/test/__snapshots__/javascript.mjs.snap

@@ -64,7 +64,7 @@
       "undefined": false,
       "unescape": false,
     },
-    "parser": "typescript-eslint/parser@8.58.2",
+    "parser": "typescript-eslint/parser@8.59.0",
     "parserOptions": {
       "requireConfigFile": false,
     },

package/test/__snapshots__/react.mjs.snap

@@ -1193,13 +1193,10 @@
   },
   "plugins": [
     "@",
-    "@eslint-react:@eslint-react/eslint-plugin@4.2.3",
+    "@eslint-react:@eslint-react/eslint-plugin@5.7.3",
     "jsx-a11y:eslint-plugin-jsx-a11y@6.10.2",
   ],
   "rules": {
-    "@eslint-react/component-hook-factories": [
-      2,
-    ],
     "@eslint-react/dom-no-dangerously-set-innerhtml": [
       2,
     ],
@@ -1248,15 +1245,15 @@
     "@eslint-react/dom-no-void-elements-with-children": [
       2,
     ],
-    "@eslint-react/dom-prefer-namespace-import": [
-      0,
-    ],
     "@eslint-react/error-boundaries": [
       2,
     ],
     "@eslint-react/exhaustive-deps": [
       2,
     ],
+    "@eslint-react/globals": [
+      2,
+    ],
     "@eslint-react/immutability": [
       2,
     ],
@@ -1378,9 +1375,6 @@
     "@eslint-react/no-nested-lazy-component-declarations": [
       2,
     ],
-    "@eslint-react/no-redundant-should-component-update": [
-      2,
-    ],
     "@eslint-react/no-set-state-in-component-did-mount": [
       2,
     ],
@@ -1390,12 +1384,6 @@
     "@eslint-react/no-set-state-in-component-will-update": [
       2,
     ],
-    "@eslint-react/no-unnecessary-use-callback": [
-      2,
-    ],
-    "@eslint-react/no-unnecessary-use-memo": [
-      2,
-    ],
     "@eslint-react/no-unnecessary-use-prefix": [
       2,
     ],
@@ -1426,12 +1414,6 @@
     "@eslint-react/no-use-context": [
       2,
     ],
-    "@eslint-react/prefer-destructuring-assignment": [
-      0,
-    ],
-    "@eslint-react/prefer-namespace-import": [
-      0,
-    ],
     "@eslint-react/purity": [
       2,
     ],
@@ -1450,6 +1432,9 @@
     "@eslint-react/set-state-in-render": [
       2,
     ],
+    "@eslint-react/static-components": [
+      2,
+    ],
     "@eslint-react/unsupported-syntax": [
       2,
     ],
@@ -1462,6 +1447,9 @@
     "@eslint-react/web-api-no-leaked-event-listener": [
       2,
     ],
+    "@eslint-react/web-api-no-leaked-fetch": [
+      2,
+    ],
     "@eslint-react/web-api-no-leaked-interval": [
       2,
     ],

package/test/__snapshots__/typescript.mjs.snap

@@ -64,7 +64,7 @@
       "undefined": false,
       "unescape": false,
     },
-    "parser": "typescript-eslint/parser@8.58.2",
+    "parser": "typescript-eslint/parser@8.59.0",
     "parserOptions": {
       "ecmaVersion": 2024,
       "project": "./tsconfig.json",
@@ -78,7 +78,7 @@
   "plugins": [
     "@",
     "@stylistic:@stylistic/eslint-plugin@5.10.0",
-    "@typescript-eslint:@typescript-eslint/eslint-plugin@8.58.2",
+    "@typescript-eslint:@typescript-eslint/eslint-plugin@8.59.0",
     "barrel-files:eslint-plugin-barrel-files@3.0.1",
     "filenames",
     "import-x:eslint-plugin-import-x@4.16.2",

package/test/__snapshots__/vitest.mjs.snap

@@ -35,7 +35,7 @@
   },
   "plugins": [
     "@",
-    "vitest:vitest@1.6.15",
+    "vitest:vitest@1.6.16",
     "no-only-tests",
   ],
   "rules": {

package/src/configs/react-ssr-compatibility.mjs

@@ -1,18 +0,0 @@
-import { fixupPluginRules } from '@eslint/compat';
-import ssrFriendlyPlugin from 'eslint-plugin-ssr-friendly';
-import reactHooksSSRPlugin from 'eslint-plugin-react-hooks-ssr';
-import noTypeofWindowUndefinedPlugin from 'eslint-plugin-no-typeof-window-undefined';
-import reactSSRCompatibilityRules from '../rules/react-ssr-compatibility.mjs';
-
-export default [
-  {
-    plugins: {
-      'ssr-friendly': fixupPluginRules(ssrFriendlyPlugin),
-      'react-hooks-ssr': fixupPluginRules(reactHooksSSRPlugin),
-      'no-typeof-window-undefined': fixupPluginRules(noTypeofWindowUndefinedPlugin),
-    },
-    rules: {
-      ...reactSSRCompatibilityRules,
-    },
-  },
-];

package/src/rules/react-ssr-compatibility.mjs

@@ -1,35 +0,0 @@
-// only add rules related to maintaining SSR compatibility
-// see:
-// - https://github.com/kopiro/eslint-plugin-ssr-friendly
-// - https://github.com/correttojs/eslint-plugin-react-hooks-ssr
-// - https://github.com/nirtamir2/eslint-plugin-no-typeof-window-undefined
-
-export default {
-  // Disallow use of DOM globals in module and global scope, as this will break any import/require in a NodeJS environment.
-  // https://github.com/kopiro/eslint-plugin-ssr-friendly#no-dom-globals-in-module-scope
-  'ssr-friendly/no-dom-globals-in-module-scope': 'error',
-
-  // Disallow use of DOM globals in class constructors, as this will break SSR if you're instantiating this class as singleton or you're rendering this component.
-  // https://github.com/kopiro/eslint-plugin-ssr-friendly#no-dom-globals-in-constructor
-  'ssr-friendly/no-dom-globals-in-constructor': 'error',
-
-  // Disallow use of DOM globals in render() method of a React class-component, as this will break SSR if you're rendering this component.
-  // https://github.com/kopiro/eslint-plugin-ssr-friendly#no-dom-globals-in-react-cc-render
-  'ssr-friendly/no-dom-globals-in-react-cc-render': 'error',
-
-  // Disallow use of DOM globals in the render-cycle of a React FC, as this will break SSR if you're rendering this component.
-  // https://github.com/kopiro/eslint-plugin-ssr-friendly#no-dom-globals-in-react-fc
-  'ssr-friendly/no-dom-globals-in-react-fc': 'error',
-
-  // forbid DOM globals within react server side rendering
-  // a global within `useEffect` or custom hook is allowed
-  // a global within a function prefixed by `async` (eg. `asyncMyFunc`) is allowed
-  // a global within a `useState`, `useReducer` and `useMemo` callback is forbidden
-  // a global within a React `Component` is forbidden
-  'react-hooks-ssr/react-hooks-global-ssr': 'error',
-
-  // avoid checking for window since it is supported by Deno
-  // prefer `typeof document === "undefined"` instead
-  // https://github.com/nirtamir2/eslint-plugin-no-typeof-window-undefined#no-typeof-window-undefined
-  'no-typeof-window-undefined/no-typeof-window-undefined': 'error',
-};