@wistia/eslint-config 2.5.0 → 2.5.2

package/CHANGELOG.md

@@ -1,5 +1,17 @@
 # @wistia/eslint-config
 
+## 2.5.2
+
+### Patch Changes
+
+- [#473](https://github.com/wistia/eslint-config/pull/473) [`3cc15e5`](https://github.com/wistia/eslint-config/commit/3cc15e5b1baa827788023feac6c96dc9e08a5a86) Thanks [@okize](https://github.com/okize)! - fix: turn off `@typescript-eslint/no-unused-vars` as `noUnusedLocals` in tsconfig is preferred
+
+## 2.5.1
+
+### Patch Changes
+
+- [#472](https://github.com/wistia/eslint-config/pull/472) [`1afe645`](https://github.com/wistia/eslint-config/commit/1afe6453b02ff4d480f0e1da118085f13a21104f) Thanks [@okize](https://github.com/okize)! - fix: turn off `@typescript-eslint/no-invalid-this` as `noImplicitThis` in tsconfig is preferred
+
 ## 2.5.0
 
 ### Minor Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@wistia/eslint-config",
-  "version": "2.5.0",
+  "version": "2.5.2",
   "description": "Wistia's ESLint configurations",
   "packageManager": "yarn@4.13.0",
   "type": "module",

package/src/rules/typescript.mjs

@@ -32,9 +32,7 @@ export default {
   // decision: prefer @typescript-eslint/no-implied-eval
   'no-implied-eval': 'off',
 
-  // Disallow this keywords outside of classes or class-like objects
-  // https://typescript-eslint.io/rules/no-invalid-this
-  // decision: superceded by noImplicitThis in tsconfig
+  // decision: prefer @typescript-eslint/no-invalid-this
   'no-invalid-this': 'off',
 
   // decision: prefer @typescript-eslint/no-loop-func
@@ -315,7 +313,8 @@ export default {
 
   // Disallow this keywords outside of classes or class-like objects
   // https://typescript-eslint.io/rules/no-invalid-this
-  '@typescript-eslint/no-invalid-this': 'error',
+  // decision: preference is to set `"noImplicitThis": true` in tsconfig
+  '@typescript-eslint/no-invalid-this': 'off',
 
   // Disallow void type outside of generic or return types
   // https://typescript-eslint.io/rules/no-invalid-void-type
@@ -489,18 +488,8 @@ export default {
   // Disallow unused variables
   // https://typescript-eslint.io/rules/no-unused-vars
   // decision: emulate the TypeScript style of exempting names starting with _
-  '@typescript-eslint/no-unused-vars': [
-    'error',
-    {
-      args: 'all',
-      argsIgnorePattern: '^_',
-      caughtErrors: 'all',
-      caughtErrorsIgnorePattern: '^_',
-      destructuredArrayIgnorePattern: '^_',
-      varsIgnorePattern: '^_',
-      ignoreRestSiblings: true,
-    },
-  ],
+  // decision: preference is to set `"noUnusedLocals": true` in tsconfig
+  '@typescript-eslint/no-unused-vars': 'off',
 
   // Disallow the use of variables before they are defined
   // https://typescript-eslint.io/rules/no-use-before-define

package/test/__snapshots__/typescript.mjs.snap

@@ -819,7 +819,7 @@
       2,
     ],
     "@typescript-eslint/no-invalid-this": [
-      2,
+      0,
       {
         "capIsConstructor": true,
       },
@@ -977,16 +977,7 @@
       2,
     ],
     "@typescript-eslint/no-unused-vars": [
-      2,
-      {
-        "args": "all",
-        "argsIgnorePattern": "^_",
-        "caughtErrors": "all",
-        "caughtErrorsIgnorePattern": "^_",
-        "destructuredArrayIgnorePattern": "^_",
-        "ignoreRestSiblings": true,
-        "varsIgnorePattern": "^_",
-      },
+      0,
     ],
     "@typescript-eslint/no-use-before-define": [
       2,