@wistia/eslint-config 2.4.7 → 2.5.1

package/.yarnrc.yml

@@ -1,7 +1,7 @@
-compressionLevel: mixed
-
 enableGlobalCache: false
 
 nodeLinker: node-modules
 
-yarnPath: .yarn/releases/yarn-4.12.0.cjs
+yarnPath: .yarn/releases/yarn-4.13.0.cjs
+
+npmMinimalAgeGate: '7d'

package/CHANGELOG.md

@@ -1,5 +1,19 @@
 # @wistia/eslint-config
 
+## 2.5.1
+
+### Patch Changes
+
+- [#472](https://github.com/wistia/eslint-config/pull/472) [`1afe645`](https://github.com/wistia/eslint-config/commit/1afe6453b02ff4d480f0e1da118085f13a21104f) Thanks [@okize](https://github.com/okize)! - fix: turn off `@typescript-eslint/no-invalid-this` as `noImplicitThis` in tsconfig is preferred
+
+## 2.5.0
+
+### Minor Changes
+
+- [#469](https://github.com/wistia/eslint-config/pull/469) [`a0498f9`](https://github.com/wistia/eslint-config/commit/a0498f9fc88d5039a943cce54f2660df4e006cfe) Thanks [@jetpackjarrett](https://github.com/jetpackjarrett)! - feat: turn off deprecated rules
+
+- [#469](https://github.com/wistia/eslint-config/pull/471) [`a0498f9`](https://github.com/wistia/eslint-config/commit/d6dd3e3644ef00115b4c703a133f70cd8ad64e79) Thanks [@okize](https://github.com/okize)! - feat: update `react` rules
+
 ## 2.4.7
 
 ### Patch Changes

package/README.md

@@ -17,3 +17,10 @@ Wistia's ESLint configuration. This repo is "pseudo-public" - private on our org
 ## Configs
 
 configs are additive, so start with a base config, either `@wistia/eslint-config` or `@wistia/eslint-config/typescript` and then apply further configs as desired.
+
+## Philosophy & Principles
+
+- **Always Error, Never Warn:** Warnings become background noise that developers tune out. A rule should either flag a real problem or stay silent.
+- **Strict, Consistent Code Style:** Where there's more than one way to do something, this configuration picks the strictest and most uniform option, favoring modern syntax and established best practices.
+- **Fast:** Known performance-heavy rules are skipped.
+- **Don't get in the way:** Rules that involve style preferences are intentionally disabled as this is best left to a formatter like `prettier`. Whenever possible, rules that can auto-fix are chosen to minimize friction and save developer time.

package/package.json

@@ -1,8 +1,8 @@
 {
   "name": "@wistia/eslint-config",
-  "version": "2.4.7",
+  "version": "2.5.1",
   "description": "Wistia's ESLint configurations",
-  "packageManager": "yarn@4.12.0",
+  "packageManager": "yarn@4.13.0",
   "type": "module",
   "main": "index.mjs",
   "engines": {
@@ -38,7 +38,7 @@
     "test:export": "check-export-map"
   },
   "dependencies": {
-    "@eslint-react/eslint-plugin": "^3.0.0",
+    "@eslint-react/eslint-plugin": "^4.2.3",
     "@eslint/compat": "^2.0.3",
     "@eslint/js": "^10.0.1",
     "@stylistic/eslint-plugin": "^5.10.0",

package/src/rules/base.mjs

@@ -65,7 +65,8 @@ export default {
 
   // Disallow duplicate arguments in function definitions
   // https://eslint.org/docs/rules/no-dupe-args
-  'no-dupe-args': 'error',
+  // decision: superseded by strict mode
+  'no-dupe-args': 'off',
 
   // Disallow duplicate class members
   // https://eslint.org/docs/rules/no-dupe-class-members
@@ -611,11 +612,13 @@ export default {
 
   // Disallow octal literals
   // https://eslint.org/docs/rules/no-octal
-  'no-octal': 'error',
+  // decision: superseded by strict mode
+  'no-octal': 'off',
 
   // Disallow octal escape sequences in string literals
   // https://eslint.org/docs/rules/no-octal-escape
-  'no-octal-escape': 'error',
+  // decision: superseded by strict mode
+  'no-octal-escape': 'off',
 
   // Disallow reassigning function parameters
   // https://eslint.org/docs/rules/no-param-reassign

package/src/rules/react.mjs

@@ -1,5 +1,5 @@
 // @eslint-react rules
-// see: https://beta.eslint-react.xyz/docs/rules
+// see: https://eslint-react.xyz/docs/rules
 
 export default {
   // Enforce that class methods utilize this
@@ -31,289 +31,373 @@ export default {
   // --- Core React rules ---
 
   // Validates higher order functions defining nested components or hooks
+  // https://eslint-react.xyz/docs/rules/component-hook-factories
   '@eslint-react/component-hook-factories': 'error',
 
   // Validates usage of Error Boundaries instead of try/catch for child errors
+  // https://eslint-react.xyz/docs/rules/error-boundaries
   '@eslint-react/error-boundaries': 'error',
 
   // Verify the list of the dependencies for Hooks like useEffect and similar
+  // https://eslint-react.xyz/docs/rules/exhaustive-deps
   '@eslint-react/exhaustive-deps': 'error',
 
   // Validates against mutating props, state, and other immutable values
+  // https://eslint-react.xyz/docs/rules/immutability
   '@eslint-react/immutability': 'error',
 
-  // Prevents unintentional '$' sign before expression in JSX
-  '@eslint-react/jsx-dollar': 'error',
-
-  // Enforce key prop comes before spread to avoid overriding
-  '@eslint-react/jsx-key-before-spread': 'error',
-
-  // Prevent accidental JS comments from being injected into JSX as text
-  '@eslint-react/jsx-no-comment-textnodes': 'error',
-
-  // Enforce explicit boolean prop syntax (e.g. disabled={true} instead of disabled)
-  // note: -1 means "never use shorthand" (equivalent to react/jsx-boolean-value: ['error', 'always'])
-  '@eslint-react/jsx-shorthand-boolean': ['error', -1],
-
-  // Enforce shorthand fragment syntax (<> instead of <React.Fragment>)
-  // note: 1 means "always use shorthand" (equivalent to react/jsx-fragments: ['error', 'syntax'])
-  '@eslint-react/jsx-shorthand-fragment': ['error', 1],
-
   // Prevent using this.state within a this.setState
+  // https://eslint-react.xyz/docs/rules/no-access-state-in-setstate
   '@eslint-react/no-access-state-in-setstate': 'error',
 
   // Prevent usage of Array index in keys
+  // https://eslint-react.xyz/docs/rules/no-array-index-key
   '@eslint-react/no-array-index-key': 'error',
 
   // Disallow usage of Children.count
+  // https://eslint-react.xyz/docs/rules/no-children-count
   '@eslint-react/no-children-count': 'error',
 
   // Disallow usage of Children.forEach
+  // https://eslint-react.xyz/docs/rules/no-children-for-each
   '@eslint-react/no-children-for-each': 'error',
 
   // Disallow usage of Children.map
+  // https://eslint-react.xyz/docs/rules/no-children-map
   '@eslint-react/no-children-map': 'error',
 
   // Disallow usage of Children.only
+  // https://eslint-react.xyz/docs/rules/no-children-only
   '@eslint-react/no-children-only': 'error',
 
-  // Prevent passing of children as props
-  '@eslint-react/no-children-prop': 'error',
-
   // Disallow usage of Children.toArray
+  // https://eslint-react.xyz/docs/rules/no-children-to-array
   '@eslint-react/no-children-to-array': 'error',
 
   // Disallow class components (except for error boundaries)
+  // https://eslint-react.xyz/docs/rules/no-class-component
   '@eslint-react/no-class-component': 'error',
 
   // Disallow usage of cloneElement
+  // https://eslint-react.xyz/docs/rules/no-clone-element
   '@eslint-react/no-clone-element': 'error',
 
   // Disallow usage of componentWillMount
+  // https://eslint-react.xyz/docs/rules/no-component-will-mount
   '@eslint-react/no-component-will-mount': 'error',
 
   // Disallow usage of componentWillReceiveProps
+  // https://eslint-react.xyz/docs/rules/no-component-will-receive-props
   '@eslint-react/no-component-will-receive-props': 'error',
 
   // Disallow usage of componentWillUpdate
+  // https://eslint-react.xyz/docs/rules/no-component-will-update
   '@eslint-react/no-component-will-update': 'error',
 
   // Disallow usage of legacy Context.Provider (React 19+)
+  // https://eslint-react.xyz/docs/rules/no-context-provider
   '@eslint-react/no-context-provider': 'error',
 
   // Disallow usage of createRef (prefer useRef)
+  // https://eslint-react.xyz/docs/rules/no-create-ref
   '@eslint-react/no-create-ref': 'error',
 
   // Prevent direct mutation of this.state
+  // https://eslint-react.xyz/docs/rules/no-direct-mutation-state
   '@eslint-react/no-direct-mutation-state': 'error',
 
   // Disallow duplicate keys in JSX arrays
+  // https://eslint-react.xyz/docs/rules/no-duplicate-key
   '@eslint-react/no-duplicate-key': 'error',
 
   // Disallow usage of forwardRef (React 19+ passes ref as prop)
+  // https://eslint-react.xyz/docs/rules/no-forward-ref
   '@eslint-react/no-forward-ref': 'error',
 
   // Prevent implicitly passing the children prop
+  // https://eslint-react.xyz/docs/rules/no-implicit-children
   '@eslint-react/no-implicit-children': 'error',
 
   // Prevent implicitly passing the key prop
+  // https://eslint-react.xyz/docs/rules/no-implicit-key
   '@eslint-react/no-implicit-key': 'error',
 
   // Prevent implicitly passing the ref prop
+  // https://eslint-react.xyz/docs/rules/no-implicit-ref
   '@eslint-react/no-implicit-ref': 'error',
 
   // Prevent problematic leaked values from being rendered
+  // https://eslint-react.xyz/docs/rules/no-leaked-conditional-rendering
   '@eslint-react/no-leaked-conditional-rendering': 'error',
 
   // Enforce that components have a displayName for DevTools
+  // https://eslint-react.xyz/docs/rules/no-missing-component-display-name
   '@eslint-react/no-missing-component-display-name': 'off',
 
   // Enforce that contexts have a displayName for DevTools
+  // https://eslint-react.xyz/docs/rules/no-missing-context-display-name
   '@eslint-react/no-missing-context-display-name': 'off',
 
   // Enforce that every JSX element in a list has a key prop
+  // https://eslint-react.xyz/docs/rules/no-missing-key
   '@eslint-react/no-missing-key': 'error',
 
   // Disallow misusing captureOwnerStack
+  // https://eslint-react.xyz/docs/rules/no-misused-capture-owner-stack
   '@eslint-react/no-misused-capture-owner-stack': 'error',
 
   // Prevent creating unstable components inside components
+  // https://eslint-react.xyz/docs/rules/no-nested-component-definitions
   '@eslint-react/no-nested-component-definitions': 'error',
 
   // Prevent creating lazy components inside components
+  // https://eslint-react.xyz/docs/rules/no-nested-lazy-component-declarations
   '@eslint-react/no-nested-lazy-component-declarations': 'error',
 
   // Prevent usage of shouldComponentUpdate when extending React.PureComponent
+  // https://eslint-react.xyz/docs/rules/no-redundant-should-component-update
   '@eslint-react/no-redundant-should-component-update': 'error',
 
   // Prevent usage of setState in componentDidMount
+  // https://eslint-react.xyz/docs/rules/no-set-state-in-component-did-mount
   '@eslint-react/no-set-state-in-component-did-mount': 'error',
 
   // Prevent usage of setState in componentDidUpdate
+  // https://eslint-react.xyz/docs/rules/no-set-state-in-component-did-update
   '@eslint-react/no-set-state-in-component-did-update': 'error',
 
   // Prevent usage of setState in componentWillUpdate
+  // https://eslint-react.xyz/docs/rules/no-set-state-in-component-will-update
   '@eslint-react/no-set-state-in-component-will-update': 'error',
 
   // Disallow unnecessary useCallback hooks
+  // https://eslint-react.xyz/docs/rules/no-unnecessary-use-callback
   '@eslint-react/no-unnecessary-use-callback': 'error',
 
   // Disallow unnecessary useMemo hooks
+  // https://eslint-react.xyz/docs/rules/no-unnecessary-use-memo
   '@eslint-react/no-unnecessary-use-memo': 'error',
 
   // Disallow unnecessary "use" prefix on custom hooks
+  // https://eslint-react.xyz/docs/rules/no-unnecessary-use-prefix
   '@eslint-react/no-unnecessary-use-prefix': 'error',
 
   // Disallow usage of UNSAFE_componentWillMount
+  // https://eslint-react.xyz/docs/rules/no-unsafe-component-will-mount
   '@eslint-react/no-unsafe-component-will-mount': 'error',
 
   // Disallow usage of UNSAFE_componentWillReceiveProps
+  // https://eslint-react.xyz/docs/rules/no-unsafe-component-will-receive-props
   '@eslint-react/no-unsafe-component-will-receive-props': 'error',
 
   // Disallow usage of UNSAFE_componentWillUpdate
+  // https://eslint-react.xyz/docs/rules/no-unsafe-component-will-update
   '@eslint-react/no-unsafe-component-will-update': 'error',
 
   // Prevent non-stable values used as context values
+  // https://eslint-react.xyz/docs/rules/no-unstable-context-value
   '@eslint-react/no-unstable-context-value': 'error',
 
   // Disallow referential-type variables as default props
+  // https://eslint-react.xyz/docs/rules/no-unstable-default-props
   '@eslint-react/no-unstable-default-props': 'error',
 
   // Prevent declaring unused methods of component class
+  // https://eslint-react.xyz/docs/rules/no-unused-class-component-members
   '@eslint-react/no-unused-class-component-members': 'error',
 
   // Warn about component props that are defined but never used
+  // https://eslint-react.xyz/docs/rules/no-unused-props
   '@eslint-react/no-unused-props': 'error',
 
   // Prevent unused state values
+  // https://eslint-react.xyz/docs/rules/no-unused-state
   '@eslint-react/no-unused-state': 'error',
 
   // Prefer using use() over useContext() (React 19+)
+  // https://eslint-react.xyz/docs/rules/no-use-context
   '@eslint-react/no-use-context': 'error',
 
-  // Disallow unnecessary fragments
-  '@eslint-react/no-useless-fragment': 'error',
-
   // Enforce consistent usage of destructuring assignment of props, state, and context
+  // https://eslint-react.xyz/docs/rules/prefer-destructuring-assignment
   // decision: best left up to the implementer
   '@eslint-react/prefer-destructuring-assignment': 'off',
 
   // Enforce importing React via a namespace import
+  // https://eslint-react.xyz/docs/rules/prefer-namespace-import
   '@eslint-react/prefer-namespace-import': 'off',
 
   // Validates that components/hooks are pure
+  // https://eslint-react.xyz/docs/rules/purity
   '@eslint-react/purity': 'error',
 
   // Validates correct usage of refs, not reading/writing during render
+  // https://eslint-react.xyz/docs/rules/refs
   '@eslint-react/refs': 'error',
 
   // Enforce Rules of Hooks
+  // https://eslint-react.xyz/docs/rules/rules-of-hooks
   '@eslint-react/rules-of-hooks': 'error',
 
   // Validates against calling setState synchronously in an effect
+  // https://eslint-react.xyz/docs/rules/set-state-in-effect
   '@eslint-react/set-state-in-effect': 'error',
 
   // Validates against setting state during render
+  // https://eslint-react.xyz/docs/rules/set-state-in-render
   '@eslint-react/set-state-in-render': 'error',
 
-  // Enforces the Rules of Props (unstable)
-  '@eslint-react/unstable-rules-of-props': 'error',
-
-  // Enforces the Rules of State (unstable)
-  '@eslint-react/unstable-rules-of-state': 'error',
-
   // Validates against syntax that React does not support
+  // https://eslint-react.xyz/docs/rules/unsupported-syntax
   '@eslint-react/unsupported-syntax': 'error',
 
   // Validates usage of useMemo with a return value
+  // https://eslint-react.xyz/docs/rules/use-memo
   '@eslint-react/use-memo': 'error',
 
   // Ensure destructuring and symmetric naming of useState hook value and setter
+  // https://eslint-react.xyz/docs/rules/use-state
   '@eslint-react/use-state': 'error',
 
+  // --- JSX rules ---
+
+  // Prevent passing of children as props
+  // https://eslint-react.xyz/docs/rules/jsx-no-children-prop
+  '@eslint-react/jsx-no-children-prop': 'error',
+
+  // Prevent passing both children prop and JSX children simultaneously
+  // https://eslint-react.xyz/docs/rules/jsx-no-children-prop-with-children
+  '@eslint-react/jsx-no-children-prop-with-children': 'error',
+
+  // Prevent accidental JS comments from being injected into JSX as text
+  // https://eslint-react.xyz/docs/rules/jsx-no-comment-textnodes
+  '@eslint-react/jsx-no-comment-textnodes': 'error',
+
+  // Enforce key prop comes before spread to avoid overriding
+  // https://eslint-react.xyz/docs/rules/jsx-no-key-after-spread
+  '@eslint-react/jsx-no-key-after-spread': 'error',
+
+  // Prevents unintentional leaked '$' sign before expression in JSX
+  // https://eslint-react.xyz/docs/rules/jsx-no-leaked-dollar
+  '@eslint-react/jsx-no-leaked-dollar': 'error',
+
+  // Prevents unintentional leaked ';' in JSX
+  // https://eslint-react.xyz/docs/rules/jsx-no-leaked-semicolon
+  '@eslint-react/jsx-no-leaked-semicolon': 'error',
+
+  // Enforce that namespaces are not used in JSX elements
+  // https://eslint-react.xyz/docs/rules/jsx-no-namespace
+  '@eslint-react/jsx-no-namespace': 'error',
+
+  // Disallow unnecessary fragments
+  // https://eslint-react.xyz/docs/rules/jsx-no-useless-fragment
+  '@eslint-react/jsx-no-useless-fragment': 'error',
+
   // --- React DOM rules ---
 
   // Warn on usage of dangerouslySetInnerHTML
-  '@eslint-react/dom/no-dangerously-set-innerhtml': 'error',
+  // https://eslint-react.xyz/docs/rules/dom-no-dangerously-set-innerhtml
+  '@eslint-react/dom-no-dangerously-set-innerhtml': 'error',
 
   // Prevent problem with children and dangerouslySetInnerHTML
-  '@eslint-react/dom/no-dangerously-set-innerhtml-with-children': 'error',
+  // https://eslint-react.xyz/docs/rules/dom-no-dangerously-set-innerhtml-with-children
+  '@eslint-react/dom-no-dangerously-set-innerhtml-with-children': 'error',
 
   // Warn against using findDOMNode()
-  '@eslint-react/dom/no-find-dom-node': 'error',
+  // https://eslint-react.xyz/docs/rules/dom-no-find-dom-node
+  '@eslint-react/dom-no-find-dom-node': 'error',
 
   // Disallow usage of flushSync
-  '@eslint-react/dom/no-flush-sync': 'error',
+  // https://eslint-react.xyz/docs/rules/dom-no-flush-sync
+  '@eslint-react/dom-no-flush-sync': 'error',
 
   // Disallow usage of ReactDOM.hydrate (use hydrateRoot instead)
-  '@eslint-react/dom/no-hydrate': 'error',
+  // https://eslint-react.xyz/docs/rules/dom-no-hydrate
+  '@eslint-react/dom-no-hydrate': 'error',
 
   // Enforce that buttons have an explicit type attribute
-  '@eslint-react/dom/no-missing-button-type': 'error',
+  // https://eslint-react.xyz/docs/rules/dom-no-missing-button-type
+  '@eslint-react/dom-no-missing-button-type': 'error',
 
   // Enforce sandbox attribute on iframe elements
-  '@eslint-react/dom/no-missing-iframe-sandbox': 'error',
-
-  // Enforce that namespaces are not used in React elements
-  '@eslint-react/dom/no-namespace': 'error',
+  // https://eslint-react.xyz/docs/rules/dom-no-missing-iframe-sandbox
+  '@eslint-react/dom-no-missing-iframe-sandbox': 'error',
 
   // Disallow usage of ReactDOM.render (use createRoot instead)
-  '@eslint-react/dom/no-render': 'error',
+  // https://eslint-react.xyz/docs/rules/dom-no-render
+  '@eslint-react/dom-no-render': 'error',
 
   // Disallow using ReactDOM.render return value
-  '@eslint-react/dom/no-render-return-value': 'error',
+  // https://eslint-react.xyz/docs/rules/dom-no-render-return-value
+  '@eslint-react/dom-no-render-return-value': 'error',
 
   // Prevent usage of javascript: URLs
-  '@eslint-react/dom/no-script-url': 'error',
+  // https://eslint-react.xyz/docs/rules/dom-no-script-url
+  '@eslint-react/dom-no-script-url': 'error',
 
   // Require style prop value be an object
-  '@eslint-react/dom/no-string-style-prop': 'error',
+  // https://eslint-react.xyz/docs/rules/dom-no-string-style-prop
+  '@eslint-react/dom-no-string-style-prop': 'error',
 
   // Prevent usage of unknown DOM property
-  '@eslint-react/dom/no-unknown-property': 'error',
+  // https://eslint-react.xyz/docs/rules/dom-no-unknown-property
+  '@eslint-react/dom-no-unknown-property': 'error',
 
   // Enforce safe iframe sandbox attribute values
-  '@eslint-react/dom/no-unsafe-iframe-sandbox': 'error',
+  // https://eslint-react.xyz/docs/rules/dom-no-unsafe-iframe-sandbox
+  '@eslint-react/dom-no-unsafe-iframe-sandbox': 'error',
 
   // Disallow target="_blank" without rel="noreferrer"
-  '@eslint-react/dom/no-unsafe-target-blank': 'error',
+  // https://eslint-react.xyz/docs/rules/dom-no-unsafe-target-blank
+  '@eslint-react/dom-no-unsafe-target-blank': 'error',
 
   // Disallow usage of deprecated useFormState (use useActionState instead)
-  '@eslint-react/dom/no-use-form-state': 'error',
+  // https://eslint-react.xyz/docs/rules/dom-no-use-form-state
+  '@eslint-react/dom-no-use-form-state': 'error',
 
   // Prevent void DOM elements from receiving children
-  '@eslint-react/dom/no-void-elements-with-children': 'error',
+  // https://eslint-react.xyz/docs/rules/dom-no-void-elements-with-children
+  '@eslint-react/dom-no-void-elements-with-children': 'error',
 
   // Enforce importing React DOM via a namespace import
-  '@eslint-react/dom/prefer-namespace-import': 'off',
+  // https://eslint-react.xyz/docs/rules/dom-prefer-namespace-import
+  '@eslint-react/dom-prefer-namespace-import': 'off',
 
   // --- RSC rules ---
 
   // Enforce correct function definition for React Server Components
-  '@eslint-react/rsc/function-definition': 'error',
+  // https://eslint-react.xyz/docs/rules/rsc-function-definition
+  '@eslint-react/rsc-function-definition': 'error',
 
   // --- Naming convention rules ---
 
   // Enforce consistent naming for React context
-  '@eslint-react/naming-convention/context-name': 'error',
+  // https://eslint-react.xyz/docs/rules/naming-convention-context-name
+  '@eslint-react/naming-convention-context-name': 'error',
 
   // Enforce consistent naming for React component identifiers
-  '@eslint-react/naming-convention/id-name': 'error',
+  // https://eslint-react.xyz/docs/rules/naming-convention-id-name
+  '@eslint-react/naming-convention-id-name': 'error',
 
   // Enforce consistent naming for refs
-  '@eslint-react/naming-convention/ref-name': 'error',
+  // https://eslint-react.xyz/docs/rules/naming-convention-ref-name
+  '@eslint-react/naming-convention-ref-name': 'error',
 
   // --- Web API rules ---
 
   // Prevent leaked event listeners
-  '@eslint-react/web-api/no-leaked-event-listener': 'error',
+  // https://eslint-react.xyz/docs/rules/web-api-no-leaked-event-listener
+  '@eslint-react/web-api-no-leaked-event-listener': 'error',
 
   // Prevent leaked setInterval calls
-  '@eslint-react/web-api/no-leaked-interval': 'error',
+  // https://eslint-react.xyz/docs/rules/web-api-no-leaked-interval
+  '@eslint-react/web-api-no-leaked-interval': 'error',
 
   // Prevent leaked ResizeObserver instances
-  '@eslint-react/web-api/no-leaked-resize-observer': 'error',
+  // https://eslint-react.xyz/docs/rules/web-api-no-leaked-resize-observer
+  '@eslint-react/web-api-no-leaked-resize-observer': 'error',
 
   // Prevent leaked setTimeout calls
-  '@eslint-react/web-api/no-leaked-timeout': 'error',
+  // https://eslint-react.xyz/docs/rules/web-api-no-leaked-timeout
+  '@eslint-react/web-api-no-leaked-timeout': 'error',
 };

package/src/rules/typescript.mjs

@@ -313,7 +313,8 @@ export default {
 
   // Disallow this keywords outside of classes or class-like objects
   // https://typescript-eslint.io/rules/no-invalid-this
-  '@typescript-eslint/no-invalid-this': 'error',
+  // decision: superceded by `noImplicitThis` in tsconfig
+  '@typescript-eslint/no-invalid-this': 'off',
 
   // Disallow void type outside of generic or return types
   // https://typescript-eslint.io/rules/no-invalid-void-type

package/test/__snapshots__/javascript.mjs.snap

@@ -1177,7 +1177,7 @@
       0,
     ],
     "no-dupe-args": [
-      2,
+      0,
     ],
     "no-dupe-class-members": [
       2,
@@ -1400,10 +1400,10 @@
       2,
     ],
     "no-octal": [
-      2,
+      0,
     ],
     "no-octal-escape": [
-      2,
+      0,
     ],
     "no-param-reassign": [
       2,